- 08 May, 2018 23 commits
-
-
Leszek Swirski authored
Fixes the MaybeObject->Object conversion in ObjectStats to allow Smis, rather than just HeapObjects. Change-Id: I845613c47bb6ca696d444a025100b471fb385980 Reviewed-on: https://chromium-review.googlesource.com/1049925Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53070}
-
Tobias Tebbi authored
Change-Id: Ibb6e10caaa4fcdb29c35baef71cf1b4faef45bc4 Reviewed-on: https://chromium-review.googlesource.com/1042389Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53069}
-
Michael Achenbach authored
When a custom workdir is used for the checkout, it differs from the workdir for temporary state files. In this case, code ensuring the existing of the parent dir wasn't executed. NOTRY=true Bug: v8:7735 Change-Id: Idc81b50bb8f880dea45fde08ba4d437c91e96a37 Reviewed-on: https://chromium-review.googlesource.com/1049552Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53068}
-
Camillo Bruni authored
Loading the length from a PropertyArray is currently broken. Bug: v8:7732 Change-Id: Ia05f314f2f4822a8821801889b7a58f75b3f198c Reviewed-on: https://chromium-review.googlesource.com/1049610Reviewed-by:
-
Simon Zünd authored
To stay compatible with JSC, Array.p.sort did a post-processing step that shadowed elements from the prototype chain. Some time ago, JSC changed and no longer exhibits this behavior. To preserve comptibility and stay consistent with RemoveArrayHoles, this CL removes this post-processing step altogether and adjusts tests to expect the new behavior. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7382 Change-Id: Iecedc37cea25001d3768b99a3a9de3a2db90ba82 Reviewed-on: https://chromium-review.googlesource.com/1047286 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53066}
-
Choongwoo Han authored
Remove InitialArrayPrototypeHasInitialArrayPrototypeMap and HasInitialFastElementsKindMap introduced by http://crrev.com/55efb6cc5dd0ae28b9cc41da31fe86069487c113, but not used after http://crrev.com/1525374ff5a564b55b748ad33e6cd0d0ea684006. Change-Id: I1182221a95d5fc1ac953139e400533efe420bd19 Reviewed-on: https://chromium-review.googlesource.com/1045951Reviewed-by:
-
Clemens Hammacher authored
Code comments help a lot to understand the generated code. Add a comment before each instruction, and some special comments for longer instructions. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ic18974e5cc89e23533e3abc54b0389723b77ff73 Reviewed-on: https://chromium-review.googlesource.com/1049626 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53064}
-
Choongwoo Han authored
Bug: v8:7103 Change-Id: I86e208de38aad1d41c65d39b94996012efa1346b Reviewed-on: https://chromium-review.googlesource.com/1045949 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
jgruber authored
Embedded builtins have been regressing benchmarks incrementally as more and more builtins were moved to the embedded blob. This has made recognition and analysis of other possible performance issues more difficult. Let's disable embedded builtins until their performance is at an acceptable level. Bug: v8:6666 Change-Id: I21a1274f3d5a65063127b0a8604df6dd0d3c0c95 Reviewed-on: https://chromium-review.googlesource.com/1049550 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL re-implements CopyFromPrototype, that is used during sorting, as a runtime function, in preparation to move Array.p.sort to CSA. CopyFromPrototype is called for sparse non-arrays, where elements might be available on the prototype chain. For compatibility with JSC, we copy them to the object itself and sort only own properties. Bug: v8:7382 Change-Id: I4f5c14995cf9769c4f9f1d62b3a5bfde6d386556 Reviewed-on: https://chromium-review.googlesource.com/1044205 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53061}
-
Simon Zünd authored
This CL implements the functionality of SafeRemoveArrayHoles (JS), which is used as a pre-processing step for sorting, in a runtime function. SafeRemoveArrayHoles is a generic fallback, when an existing runtime function fails to remove holes/move undefineds to the end of an array. This CL extends the existing runtime function to also support JSProxy objects, and objects where indices have accessors. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7382 Change-Id: I4881539cf2171caba08ff6e3e50320291f49839c Reviewed-on: https://chromium-review.googlesource.com/1041950 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
On system which required a contiguous code range, we currently limit the committed wasm code space to the heap code space. Since https://crrev.com/c/1044195, this was only 128MB, making bigger benchmarks fail. There is no need to link the two limits, thus just remove that logic. R=titzer@chromium.org Change-Id: Id61f5dd28c96c3d2b7fcd730751285c6fc144bc5 Reviewed-on: https://chromium-review.googlesource.com/1049648Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53059}
-
Michael Starzinger authored
This shares JS-to-Wasm wrapper code across instances belonging to the same module object. We no longer need to copy the wrappers since they are by now independent of the concrete instance. R=titzer@chromium.org BUG=v8:7424 Change-Id: I54188eae6378e53cc274cd19f8e652ffdba72ee5 Reviewed-on: https://chromium-review.googlesource.com/1049607 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This changes JS-to-Wasm wrappers to no longer embed a WeakCell with the associated instance into the code, but load the instance object from the passed {WasmExportedFunction} object instead. R=titzer@chromium.org BUG=v8:7424 Change-Id: I5403f882912eb23e760fabe70207440648754a69 Reviewed-on: https://chromium-review.googlesource.com/1028053 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Dan Elphick authored
This reverts commit b19d123f. Reason for revert: It breaks the more important change: https://chromium-review.googlesource.com/c/v8/v8/+/1042145 (Because it adds mutable objects to RO_SPACE). Original change's description: > [heap] Move even more objects into RO_SPACE > > Moves all Oddballs, empty_feedback_metadata, lots of symbols and > immortal heap numbers and several other empty collection objects. > > RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE > old 31592 0 221160 33280 176 0 > new 35016 0 217736 33280 176 0 > diff +3424 -3424 > > Bug: v8:7464 > Change-Id: Ic99411bcbcb9c9a48b33c59dddb68359278fb0b3 > Reviewed-on: https://chromium-review.googlesource.com/1025996 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53053} TBR=hpayer@chromium.org,mlippautz@chromium.org,delphick@chromium.org Change-Id: Ieb81f88fe348fcffb67c153c0b116670318814f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/1049555Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53056}
-
Ivo Markovic authored
at register is used a lot in macro-assembler-mips[64].cc and we should not use it as temporary register in other parts of code Change-Id: I7ef038cdf4f8c57aa76823e7ee0ffb40b62731cd Reviewed-on: https://chromium-review.googlesource.com/1027816 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53055}
-
Ben L. Titzer authored
R=mvstanton@chromium.org CC=mstarzinger@chromium.org Bug: v8:7721 Change-Id: I8baf4c8d52d0a5bd4a3b8d832624438f465f9390 Reviewed-on: https://chromium-review.googlesource.com/1047609Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53054}
-
Dan Elphick authored
Moves all Oddballs, empty_feedback_metadata, lots of symbols and immortal heap numbers and several other empty collection objects. RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE old 31592 0 221160 33280 176 0 new 35016 0 217736 33280 176 0 diff +3424 -3424 Bug: v8:7464 Change-Id: Ic99411bcbcb9c9a48b33c59dddb68359278fb0b3 Reviewed-on: https://chromium-review.googlesource.com/1025996 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: -
jgruber authored
Bug: v8:6890 Change-Id: I4002326cb79165ce6edb79a943d66de156b90116 Reviewed-on: https://chromium-review.googlesource.com/1046053Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53052}
-
Marja Hölttä authored
- Make FeedbackVector backing store a WeakFixedArray. - "feedback" is always strong but "extra" might be weak. - Whenever the handler stored in FeedbackVector is a WeakCell to a transition Map, replace it with an in-place weak reference. For a more detailed description of the changes, see the design doc https://docs.google.com/document/d/1P8cIme2wKszdYt64ObAiuh6pXgLnrrn80Hpl1ejJbOU/edit#heading=h.ijx1oculrikp BUG=v8:7308 Change-Id: I72c5cf6597ef24d4c22a1fe8e25b67ca196d4ec8 Reviewed-on: https://chromium-review.googlesource.com/1027855 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53051}
-
Tobias Tebbi authored
Change-Id: I61a594e194082577135dbc82b2673bf477105ef3 Reviewed-on: https://chromium-review.googlesource.com/1046949 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:7733 Change-Id: Ib3133e882c0a798f76478492a6663356267a1578 Reviewed-on: https://chromium-review.googlesource.com/1049546 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53049}
-
Jaroslav Sevcik authored
This CL introduces type narrowing and constant folding reducers to constant fold code that comes out of inlined destructuring of arrays. In particular, array iterator introduces code that contains a phi of a temporary array that blocks escape analysis. The phi comes from conditional that can be evaluated statically (i.e., constant folded), so with better constant folding we allow escape analysis to get rid of the temporary array. On a quick micro-benchmark below, we see more than 6x improvement. This is close to the hand-optimized version - if we replace body of f with 'return b + a', we get 220ms (versus 218ms with destructuring). function f(a, b) { [b, a] = [a, b]; return a + b; } function sum(count) { let s = 0; for (let i = 0; i < count; i++) { s += f(1, 2); } return s; } // Warm up sum(1e5); sum(1e5); console.time("destructure array"); sum(1e8); console.timeEnd("destructure array"); console.timeEnd: destructure array, 213.526000 console.timeEnd: destructure array, 1503.537000 Bug: v8:7728 Change-Id: Ib7aec1d5897989e6adb1af1eddd516d8b3866db5 Reviewed-on: https://chromium-review.googlesource.com/1047672Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53048}
-
- 07 May, 2018 17 commits
-
-
Hidy Han authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6390806935ada277db965718a804ab090b3be5dd Reviewed-on: https://chromium-review.googlesource.com/1041157Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Hidy Han <hidyhan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53047}
-
Clemens Hammacher authored
We had four files in git which used CRLF. After adding a .gitattributes file with "* text=auto", we should not get any new ones. This CL converts the four existing files to LF. R=mathias@chromium.org Bug: v8:7570 Change-Id: Ia9c92f4bed14c6669de7d60390627a11de6450b8 Reviewed-on: https://chromium-review.googlesource.com/1047611 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#53046}
-
Georg Neis authored
Bug: v8:7716 Change-Id: I9cf71c1e9431ee751db595b6c94c09dab5f1610b Reviewed-on: https://chromium-review.googlesource.com/1047612Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53045}
-
Clemens Hammacher authored
This attribute will apply to newly added file only. If they contain CRLF, this will be converted to LF automatically. R=mathias@chromium.org Bug: v8:7570 Change-Id: Idbf1f15d55dda18f623f9b3c7be8bba686569af0 Reviewed-on: https://chromium-review.googlesource.com/1047608 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
If trap handlers cannot be installed, we printed two lines to stdout and stderr, both not terminated by a newline. This CL adds a newline to one output and uses the FATAL macro for the other, highlighting the error better and showing the location where it happens. R=eholk@chromium.org Bug: v8:7570 Change-Id: Ic24f48f92b87528e0fd5889badf2c90d765e451a Reviewed-on: https://chromium-review.googlesource.com/1047606Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Bug: v8:7721 Change-Id: I8fd2c532c36bfd5faec2947d3154a2984c13ed46 Reviewed-on: https://chromium-review.googlesource.com/1047668Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53042}
-
Eugene Ostroukhov authored
This API will be used by Node.js to provide output compatible with Chrome devtools. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I265495f8af39bfc78d7fdbe43ac308f0920e817d Reviewed-on: https://chromium-review.googlesource.com/1044491Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Cr-Commit-Position: refs/heads/master@{#53041}
-
Michael Starzinger authored
This moves the internal fields on {WasmExportedFunction} objects from being properties with private symbols to a separate structure instead. The new {WasmExportedFunctionData} structure can hang off the underlying shared function info which is created for each exported function. This reduces the number of transitions, speeds up instantiation, and makes it easier to reach them from generated code (in the future). R=titzer@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iaa733b6c9f7bea96246d6680756aa7101669a1a9 Reviewed-on: https://chromium-review.googlesource.com/1047025 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Alexei Filippov authored
The RareData objects contain fields that often absent in CodeEntry'es. They are created as needed when a corresponding field is added. This reduces CodeEntry size on x64 by 40% from 136 to 80 bytes. BUG=v8:7719 Change-Id: I1f3c6255aa2f228895e835b536c743396131db31 Reviewed-on: https://chromium-review.googlesource.com/1045885Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53039}
-
Sigurd Schneider authored
We lost the print functionality for stub schedules somewhere on the way. This re-adds the appropriate call to TraceSchedule to get it going again. Bug: v8:7327 Change-Id: I245823b440542708410d2253f9f4e78b2e22f3c9 Reviewed-on: https://chromium-review.googlesource.com/1047270Reviewed-by:
-
Ben L. Titzer authored
In preparation for cleaning up PipelineData to use a MachineGraph where appropriate, move the dead node up to MachineGraph. R=ahaas@chromium.org Bug: v8:7721 Change-Id: I3f9d456aef7cf4d80adbc93ae938636ffcc3712d Reviewed-on: https://chromium-review.googlesource.com/1046828 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Retpolines were never used for off-heap wasm code. This CL adds them. R=titzer@chromium.org Bug: chromium:840376, chromium:798964 Change-Id: I9f1b2150cce484f831a83663d1fb06555e7eac82 Reviewed-on: https://chromium-review.googlesource.com/1047385 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=clemensh@chromium.org Change-Id: Ib1a0105e3347a5ccafdb72dadd9aa144ab77732c Reviewed-on: https://chromium-review.googlesource.com/1046970Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53035}
-
Sathya Gunasekaran authored
Bug: v8:4247 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibf5e7dd39cb81ac47af871edbe079d73839f9c1c Reviewed-on: https://chromium-review.googlesource.com/1045184Reviewed-by:
-
Peter Marshall authored
Trying to reduce use of our self-baked data structures. Bug: v8:7570 Change-Id: I419a932b6b8904810844d40a5636e423df832197 Reviewed-on: https://chromium-review.googlesource.com/1032739 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Marja Hölttä authored
The hard-coded timeout in the test is so near, that e.g., adding DCHECKs pushes the test over the limit. The test is ran with dcheck_always_on=true. We shouldn't do any performance testing with dcheck_always_on=true; this creates the wrong incentive to not add DCHECKs (or in this case, CLs which add more DCHECKs or cause more DCHECKs to be hit cannot land at all). Change-Id: Ia4d1b2b17ce5a5330b929f984253c89ba273f661 Reviewed-on: https://chromium-review.googlesource.com/1046548Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ic69665c8a2606ec40ab06881e0501e33ee0621a0 Reviewed-on: https://chromium-review.googlesource.com/1046653Reviewed-by:
-
