1. 22 Aug, 2017 2 commits
  2. 21 Aug, 2017 31 commits
  3. 20 Aug, 2017 2 commits
  4. 19 Aug, 2017 5 commits
    • Mircea Trofin's avatar
      Revert "Revert "[wasm] Reference indirect tables as addresses of global handles"" · b22fb03a
      Mircea Trofin authored
      This reverts commit af37f6b9.
      
      Reason for revert: Reverted dependency fixed.
      
      Original change's description:
      > Revert "[wasm] Reference indirect tables as addresses of global handles"
      > 
      > This reverts commit 186099d4.
      > 
      > Reason for revert: Need to revert:
      > https://chromium-review.googlesource.com/c/613880
      > 
      > Original change's description:
      > > [wasm] Reference indirect tables as addresses of global handles
      > > 
      > > This sets us up for getting the wasm code generation off the GC heap.
      > > We reference tables as global handles, which have a stable address. This
      > > requires an extra instruction when attempting to make an indirect call,
      > > per table (i.e. one for the signature table and one for the function
      > > table).
      > > 
      > > Bug: 
      > > Change-Id: I83743ba0f1dfdeba9aee5d27232f8823981288f8
      > > Reviewed-on: https://chromium-review.googlesource.com/612322
      > > Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      > > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#47444}
      > 
      > TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org
      > 
      > Change-Id: Ic3dff87410a51a2072ddc16cfc83a230526d4c56
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Reviewed-on: https://chromium-review.googlesource.com/622568
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#47450}
      
      TBR=bradnelson@chromium.org,machenbach@chromium.org,titzer@chromium.org,mtrofin@chromium.org
      
      Change-Id: I3dc5dc8be26b5462703edac954cbedbb8f504c1e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/622035Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
      Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47455}
      b22fb03a
    • Mircea Trofin's avatar
      Revert "Revert "[wasm] Rename TestingModule to TestingModuleBuilder."" · 5eb1aa48
      Mircea Trofin authored
      This reverts commit 3913bde1.
      
      Reason for revert: Reason for revert fixed.
      
      Original change's description:
      > Revert "[wasm] Rename TestingModule to TestingModuleBuilder."
      > 
      > This reverts commit ed06fc91.
      > 
      > Reason for revert: Need to revert previous CL
      > 
      > Original change's description:
      > > [wasm] Rename TestingModule to TestingModuleBuilder.
      > > 
      > > This is a followup to moving the ModuleEnv to the compiler directory and
      > > making it immutable.
      > > 
      > > R=​mtrofin@chromium.org, ahaas@chromium.org
      > > 
      > > Bug: 
      > > Change-Id: I0f5ec1b697bdcfad0b4dc2bca577cc0f40de8dc0
      > > Reviewed-on: https://chromium-review.googlesource.com/616762
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
      > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#47419}
      > 
      > TBR=titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      > 
      > Change-Id: I9b3b379e89f523c2fcf205a1d268aa294bbc44ff
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Reviewed-on: https://chromium-review.googlesource.com/622567
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#47448}
      
      TBR=machenbach@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      
      Change-Id: Idce6f1ca8ed0ea80edb50292e9b6e2d7712f29cf
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/622034Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
      Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47454}
      5eb1aa48
    • Mircea Trofin's avatar
      Revert "Revert "[wasm] Move the ModuleEnv to compiler and make it immutable."" · 72dd5738
      Mircea Trofin authored
      This reverts commit e79d4f06.
      
      Reason for revert: Fixed compile error
      
      Original change's description:
      > Revert "[wasm] Move the ModuleEnv to compiler and make it immutable."
      > 
      > This reverts commit d04660db.
      > 
      > Reason for revert: Suspect for blocking the roll:
      > https://chromium-review.googlesource.com/c/621191
      > 
      > See:
      > https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/13583
      > 
      > Original change's description:
      > > [wasm] Move the ModuleEnv to compiler and make it immutable.
      > > 
      > > This CL (finally) makes the contract between the compiler and the module
      > > environment clear. In order to compile a function, the caller must provide
      > > an instance of the compiler::ModuleEnv struct, which contains references
      > > to code, function and signature tables, memory start, etc.
      > > 
      > > R=​mtrofin@chromium.org,ahaas@chromium.org
      > > 
      > > Bug: 
      > > Change-Id: I68e44d5da2c5ad44dad402029c2e57f2d5d25b4f
      > > Reviewed-on: https://chromium-review.googlesource.com/613880
      > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
      > > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#47418}
      > 
      > TBR=titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      > 
      > Change-Id: I60a369a43121720fbb13ea6c2ec6ca948d60a20b
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Reviewed-on: https://chromium-review.googlesource.com/622547
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#47451}
      
      TBR=machenbach@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      
      Change-Id: Ie0efa6204c41b2cb672586a7ac0a622ca13ce5fe
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/622033
      Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
      Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47453}
      72dd5738
    • Enrico Bacis's avatar
      [wasm] Add tests for grow_memory in conditional branches · fe4d0686
      Enrico Bacis authored
      This CL introduces 8 tests that verify that the effects of a grow_memory
      instruction executed inside a conditional branch are visible also when
      the branch is merged.
      
      The tests verify the output of the current_memory instruction and the
      result of loading a variable stored in the grown memory inside the
      branch in the following cases:
      
       * the memory is grown inside the if branch (with no else branch);
      
       * the memory is grown inside the if branch (when an else branch exists);
      
       * the memory is grown inside the else branch;
      
       * the memory is grown by different amount of pages inside both the if
       and else branches.
      
      R=ahaas@chromium.org,clemensh@chromium.org,gdeepti@chromium.org
      
      Change-Id: I8127ebdf959eed5b7b5ca5aa6033a7ea41465f32
      Reviewed-on: https://chromium-review.googlesource.com/617222Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Enrico Bacis <enricobacis@google.com>
      Cr-Commit-Position: refs/heads/master@{#47452}
      fe4d0686
    • Michael Achenbach's avatar
      Revert "[wasm] Move the ModuleEnv to compiler and make it immutable." · e79d4f06
      Michael Achenbach authored
      This reverts commit d04660db.
      
      Reason for revert: Suspect for blocking the roll:
      https://chromium-review.googlesource.com/c/621191
      
      See:
      https://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/13583
      
      Original change's description:
      > [wasm] Move the ModuleEnv to compiler and make it immutable.
      > 
      > This CL (finally) makes the contract between the compiler and the module
      > environment clear. In order to compile a function, the caller must provide
      > an instance of the compiler::ModuleEnv struct, which contains references
      > to code, function and signature tables, memory start, etc.
      > 
      > R=​mtrofin@chromium.org,ahaas@chromium.org
      > 
      > Bug: 
      > Change-Id: I68e44d5da2c5ad44dad402029c2e57f2d5d25b4f
      > Reviewed-on: https://chromium-review.googlesource.com/613880
      > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Ben Titzer <titzer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#47418}
      
      TBR=titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
      
      Change-Id: I60a369a43121720fbb13ea6c2ec6ca948d60a20b
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/622547
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47451}
      e79d4f06