- 14 Sep, 2021 22 commits
-
-
Ng Zhi An authored
We need to support pre-SSE4.1 for Pinsrd. Share the AVX and SSE4_1 code, but delegate to base class for the pre-SSE4.1 code (via CRTP). Bug: v8:11589 Change-Id: I7563670174e44d8061182aefc311593d9578b0e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3159183Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76827}
-
Ng Zhi An authored
The idea of effect level was introduced in https://codereview.chromium.org/1706763002. This change was trying to optimize sequences like: x = load o, i cmp 1, x to use a memory operand: cmp 1, [o+i] However, the load can be invalidated, like so: x = load o, i store o, i, v cmp 1, x Then, selecting a memory operand for cmp would be incorrect (it should be using the loaded value x, not the store valued v: store o, i, v cmp 1, [o+i] # uses v, which is wrong, should use x Effect levels were introduced to mark where levels of potentially invalidating instructions: effect level x = load o, i 0 store o, i, v 1 cmp 1, x 1 Then when selecting instructions, CanCover will check to ensure that cmp and load are on the same level. ProtectedLoad, and LoadTransforms should not affect the effect levels in this case, because they don't invalidate any prior loads: x = load o, i y = protected load o, i cmp 1, x Becomes: y = protected load o, i cmp 1, [o+i] Bug: v8:12189 Change-Id: I585b94320def4ba554ae955fa5f8fcc9efd6dafe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158551Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76826}
-
Ng Zhi An authored
Change them to use macro-assembler functions so they will emit AVX if supported. Rename the opcodes since they are no longer SSE specific. Bug: v8:12148 Change-Id: Iaa2aa54dde9f9b41304394f98b8ed18dbb65715b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158679Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76825}
-
Frank Tang authored
Refactor generic option reading facility also used by Temporal from intl-objects.* to option-util.* See https://tc39.es/proposal-temporal/#sec-getoptionsobject https://tc39.es/proposal-temporal/#sec-getoptionsobject-deleted https://tc39.es/ecma402/#sec-getoptionsobject Bug: v8:11544 Change-Id: I8b27e8fa3515c1287217c2fbe225172fb8f69210 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122501Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76824}
-
Andreas Haas authored
WPT and WebAssembly spec tests are not 100% in sync, which means that there are aspects of the WebAssembly spec that get only tested by WPT. Up until now WPT was only executed on the blink side, and failing tests were just ignored. With this CL we add WPT to the existing wasm spec test setup, so that we run both the spec tests, and WPT. Bug: v8:12227 Change-Id: Iccbe696a6d9dd01f8bab1990736f1ed16e0cdf7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160347Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#76823}
-
Clemens Backes authored
Avoid the usage of ASSERT_DEATH_IF_SUPPORTED with a matcher, as that's not supported if death tests are not supported (e.g. on iOS). R=jkummerow@chromium.org Bug: v8:11974 Change-Id: Ieb33ac8605e82fde67bfcd0e81e85ac2d18e9b27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160341Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76822}
-
Deepti Gandluri authored
This reverts commit 0adc1410. Reason for revert: Reverting due to fail on V8 Linux - noi18n - debug https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8836095186331011153/+/u/Check_-_default/function-exist Original change's description: > [Temporal] Part 1 - Skeleton > > 1. Expose all the functions to empty buildins. > 2. Wire up basic structure of classes and internal slots. > > Design Doc: https://docs.google.com/document/d/1Huu2OUlmveBh4wjgx0D7ouC9O9vSdiZWaRK3OwkQZU0/ > > This is just a CL to establish a skeleton for Temporal. > The Temporal is very big. The prototype CL is in > https://chromium-review.googlesource.com/c/v8/v8/+/2967755 > but too big to be reviewed so I break up the basic structure here first. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel > Bug: v8:11544 > Change-Id: I10d09e3c2530e5b1a6ba60014a2294e138879ff3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092561 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76819} Bug: v8:11544 Change-Id: I358f671452a986c8e87d1f831ab5eb1550a38441 Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160467 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Deepti Gandluri <gdeepti@chromium.org> Owners-Override: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76821}
-
Ng Zhi An authored
Pinsrb, Pinsrw was separately defined in ia32 and x64 macro assembler, move them into shared-macro-assembler. Pinsrd can be moved also, but is not as straightforward, move that in a future patch. Bug: v8:11589 Change-Id: Ib5c7517236e0c3fb7b9a4643f0a3ee8237ee6545 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158681Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76820}
-
Frank Tang authored
1. Expose all the functions to empty buildins. 2. Wire up basic structure of classes and internal slots. Design Doc: https://docs.google.com/document/d/1Huu2OUlmveBh4wjgx0D7ouC9O9vSdiZWaRK3OwkQZU0/ This is just a CL to establish a skeleton for Temporal. The Temporal is very big. The prototype CL is in https://chromium-review.googlesource.com/c/v8/v8/+/2967755 but too big to be reviewed so I break up the basic structure here first. Cq-Include-Trybots: luci.v8.try:v8_linux64_bazel Bug: v8:11544 Change-Id: I10d09e3c2530e5b1a6ba60014a2294e138879ff3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092561Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76819}
-
legendecas authored
DataView constructor, DataView.prototype.byteLength and DataView.prototype.byteOffset should throw TypeError when the buffer was detached. Both SpiderMonkey and JSC passed the test262 suites. Bug: v8:12162 Change-Id: I126d24213c00e4d26540519bce9b5388862eb32c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140015Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#76818}
-
Francis McCabe authored
s/&/,/ Bug: v8:12191 Change-Id: Ib933470455c4a0f6e133bd1277cc2bba6aa83e12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158549Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76817}
-
Manos Koukoutos authored
We introduce the WasmInliningHeuristics virtual class and implement it with a trivial heuristics that inlines direct calls based on callee index only. Other, more meaningful heuristics will be introduced later. Bug: v8:12166 Change-Id: I74fd8f61e0c97b975827fa062629e9ff7463e058 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157952 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76816}
-
Georg Neis authored
1) Code in JSCallReducer read a FeedbackCell twice and expected the result to be the same. 2) JSInliningHeuristics, in the CheckClosure case, assumed that the FeedbackCell contains a FeedbackVector. Bug: chromium:1248743, v8:7790 Change-Id: I66d6dd5f7a879c2479572e1896dd78aeedd2fa27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160200Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76815}
-
Clemens Backes authored
The previous setup of the test was suboptimal and could easily hide bugs. Since the whole test body was wrapped in an ASSERT_DEATH call (without checking any message of the crash), any CHECK failure inside the test body would make the test pass. This CL leverages the fact that in our setup the "death test style" is set to "threadsafe" anyway, so the process that is forked for the death test just runs the whole test body including the single death test of interest, and the parent checks that it indeed crashes. This allows us to undo our previous setup and just include death test assertions regularly in the test body. By checking that the child process fails exactly between two print statements (around the write access) we ensure that we observe the crash we intend to observe. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Change-Id: I293079ae2dbcbe154bef91314ed08cab567f4d18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151965Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76814}
-
Leszek Swirski authored
CopyChars takes a count parameter, not an end parameter, so we can save some subtractions by passing in the count to WriteToFlat. Most of the time the start,end arguments into WriteToFlat are 0,length anyway, so this doesn't change a lot of places. Change-Id: I9587c7afce529218a16b728c0477b87569df8e21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157947Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76813}
-
Thibaud Michaud authored
This is a reland of deb66c84 Added missing cctest.status entries to disable the tests on non-simd hardware. Original change's description: > [wasm] Add tests for NaN detection in Liftoff > > Check that the flag is also set if only one of the lanes is NaN for SIMD > operations. > > R=clemensb@chromium.org > > Bug: v8:11856 > Change-Id: I3860ed1beac4faee1ade7180b67ca06762ca9b95 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158322 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76801} Bug: v8:11856 Change-Id: If45451703d80fe217eac8c610dac022dc778436f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158329Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76812}
-
Michael Lippautz authored
The struct is reused across various GC cycles and std::move() may leave the vector in valid but unspecified state. Change-Id: I3c40795be7397d015b96116d3549953024b98808 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160197 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#76811}
-
Manos Koukoutos authored
Bug: v8:12166 Change-Id: Ic15170b6e2dbaf5c9218c8fd951f4f7462b1d37a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157951 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76810}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/400ed3f..713b917 Fix mention of --benchmarks in comment (#1229) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/713b917 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Idb2eccc9daf197d26f37d765a81623a1297bbd26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3159606Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76809}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/38820a5..f16814b Rolling v8/third_party/aemu-linux-x64: _MqlabIiZ-51x79A36MyMSHmpsXJ6kjMY-4BqteuKPoC..FqiWusPGPs0zkuCyCSj2axBNOhCaD117fjIbnnj6h8kC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7a4741c..53aef64 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8f09549..984ce94 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/20795c9..cb29f9c Rolling v8/tools/luci-go: git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7..git_revision:4a0f3da2840eaa5341470174b57047313e074ecd Rolling v8/tools/luci-go: git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7..git_revision:4a0f3da2840eaa5341470174b57047313e074ecd Rolling v8/tools/luci-go: git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7..git_revision:4a0f3da2840eaa5341470174b57047313e074ecd TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Idfa651e9a56ed67f7d95647903f1b29f4e4e7c97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3159602Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76808}
-
Lu Yahan authored
If load imm32 using auipc/lui, for example load 0x7FFFFBF9, we should ensure imm32 + 0x800 is int32 Bug: v8:12171 Change-Id: I605ae9cad0b67cfd68d727ebdb3bcefea21904fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141264Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76807}
-
Lu Yahan authored
Change-Id: I9b65bdc772b00177e48547823c3a3bea79f8b875 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3156589 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76806}
-
- 13 Sep, 2021 18 commits
-
-
Ng Zhi An authored
We move the implementation in Liftoff (which is the most general and handles AVX/SSE and also register aliasing) into shared-macro-assembler. Also consolidate SSE/AVX for ia32. No functionality change is expected. Bug: v8:11589 Bug: v8:11217 Change-Id: I64cc71791f04332dd3505055f4672430c2daf5ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131373Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76805}
-
Ng Zhi An authored
Bug introduced In crrev.com/c/3150138. Fixed: v8:12220 Change-Id: I5cae11fdd43dc47dad0c8bf55daa6b925b629da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158543Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76804}
-
Ng Zhi An authored
Move this from macro-assembler-x64 to shared-macro-assembler, and use this implementation for ia32 (TurboFan and Liftoff). Bug: v8:11589 Change-Id: If851560c8db1293924ca024725609c399c553a4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124099 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76803}
-
Clemens Backes authored
This reverts commit deb66c84. Reason for revert: Fails in no-sse config: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/36712 Original change's description: > [wasm] Add tests for NaN detection in Liftoff > > Check that the flag is also set if only one of the lanes is NaN for SIMD > operations. > > R=clemensb@chromium.org > > Bug: v8:11856 > Change-Id: I3860ed1beac4faee1ade7180b67ca06762ca9b95 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158322 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76801} Bug: v8:11856 Change-Id: I16c50b3d0c1831a6d61159bdcf29610fd5aed8a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158328 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76802}
-
Thibaud Michaud authored
Check that the flag is also set if only one of the lanes is NaN for SIMD operations. R=clemensb@chromium.org Bug: v8:11856 Change-Id: I3860ed1beac4faee1ade7180b67ca06762ca9b95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158322Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76801}
-
Brice Dobry authored
Lu Yahan is a key contributor to the RISC-V target and I would like to add him to the owners list so that he can approve changes in Gerrit. Change-Id: I017fb2ef20320887959e9830fb63e05df121c7b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145370Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/main@{#76800}
-
Leszek Swirski authored
Also a couple of microoptimizations and consistent formatting in WriteToFlat. Change-Id: Ie642a4b8e0819b04603ee5c5d12eebccf6a2d59c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151963 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#76799}
-
Clemens Backes authored
This fixes the order of declaring class members for LiftoffCompiler, LiftoffAssembler, LiftoffRegister, and LiftoffRegList. The recommended order according to the style guide is: types, constants, constructors, other members, data members. R=thibaudm@chromium.org Bug: v8:11879 Change-Id: I5c550ed11ed0169f07477b6a1723053316374707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157960 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76798}
-
Junliang Yan authored
Change-Id: Icdef3916993e14e39ef9da70af128b9fde2d3b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158323Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76797}
-
Benedikt Meurer authored
This unblocks https://crrev.com/c/3099011 by speeding up the case for the DebugPropertyIterator where only non-indexed properties (for large arrays or typed arrays) are requested. Previously we'd walk through all properties - including all indexed properties - and only filter out the indexed properties in the end in `ValueMirror::getProperties()`. Bug: chromium:1199701, chromium:1162229 Change-Id: I2555e3129fef29da347314eee400ea97ebf5e5b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114135 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#76796}
-
Michael Lippautz authored
The refactoring is triggered by https://crrev.com/c/3121905 where we noticed that a bunch of tricky counter paths could be simplified, making reasoning about corectness easier. In this CL: 1. Use uniqe_ptr instead of Optional to allow moving SweepingJob away from the header file. 2. sweeping_in_progress_ is replaced with simply checking for a job. 3. freed_bytes_ are moved to the job and the dependency is reversed, avoiding the inside-out (Job->Sweeper) dependency completely. 4. Merge() and counter updates are merged into a Finalize() method. 5. FinishIfDone() allows for conditional finization. 6. young_bytes_ and old_bytes_ are removed as they were always updated when the corresponding bytes in the ArrayBufferList was updated. Change-Id: I56e5b04087166ce03d3a9195ac48359122a84c73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124776Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#76795}
-
Lu Yahan authored
In riscv64, pc-relatice call need meet IsInt32(offset + 0x800), so max pcrelatice code range is 4094MB. Change-Id: Id3481483eb3131b5c08f22bde08206ee30cc25db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3156585 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76794}
-
Jakob Kummerow authored
No asymptotic improvements, and none are planned either. Minor speedups (25-50%) through reduced overhead: accessing Digits is faster than working with Handle<BigInt>, and this implementation avoids allocating intermediate results. Bug: v8:11515 Change-Id: I2aab2b1c5c9cbb910800161b8514c497daf2b587 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149453Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76793}
-
Manos Koukoutos authored
Bug: v8:12166 Change-Id: I4e9322ff5289cc76b4434b200f9369d9231e5bc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145416 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76792}
-
Thibaud Michaud authored
The "unreachable" state is usually reset in the first catch block. Ensure that this is done for catchless tries too. R=clemensb@chromium.org Bug: chromium:1246712 Change-Id: If746a3fe3158b0bac4b9b02e4978ca444f8ce427 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157949Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76791}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:12108 Change-Id: Iad128d108df64a5a0c205f7ed69a06cdffb40c31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148133Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76790}
-
Marja Hölttä authored
The bug was introduced in https://chromium-review.googlesource.com/c/v8/v8/+/3147910 : We only want the fast path when "start" is either missing or the number 0, not when it's something which converts to 0. Bug: chromium:1248704 Change-Id: I72bb8fa8a9b90a13aae216c6a8e16e7be54285fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157948 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76789}
-
Darshan Sen authored
Signed-off-by: Darshan Sen <raisinten@gmail.com> Change-Id: I51650e87261c817d6a58a34d56920b6fb8c1e281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3112985Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76788}
-