- 28 Sep, 2018 10 commits
-
-
Clemens Hammacher authored
Pending phantom handle callbacks are not reliably executed if the heap shuts down. This can cause to memory leaks or other unwanted behaviour, like in wasm where the NativeModules (held in Managed objects implemented via phantom handles) unregister from the WasmEngine in the second-pass callback. This must be executed before tearing down the WasmEngine. This CL fixes this by running pending callback synchronously on heap tear down. R=ulan@chromium.org, mlippautz@chromium.org Bug: v8:8208 Change-Id: I27b630c4d8f1fb12309040ea2179b64eed38710a Reviewed-on: https://chromium-review.googlesource.com/1249101 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56286}
-
Clemens Hammacher authored
Minor refactoring, for readability and performance. R=ahaas@chromium.org Bug: v8:8015 Change-Id: I30c4a76998c8867aea0e08fd982b4425d4ae8fef Reviewed-on: https://chromium-review.googlesource.com/1251163Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56285}
-
Igor Sheludko authored
Trimming may free up some allocatable pages that can be reused by subsequent allocations. This CL also fixes base::AddressRegion::contains(Address, size_t). Bug: v8:8096 Change-Id: I3b7381fd32f7dbf186dffc1a26d5a88cd8a30d2f Reviewed-on: https://chromium-review.googlesource.com/1249127Reviewed-by:
-
Toon Verwaest authored
|this| cannot be an ambiguous declaration. Actual declarations are inserted upon function scope creation, so we can simply parse as reference and it will resolve correctly. Change-Id: I3aaa1a2666b4caffbf8524caec7068125e10240b Reviewed-on: https://chromium-review.googlesource.com/1251162Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56283}
-
Clemens Hammacher authored
This reverts commit e4c650ad. Reason for revert: Break Linux nosnap: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20786 Original change's description: > [heap] Free dead young generation large objects. > > Bug: chromium:852420 > Change-Id: I77479c3a96bcae6041ddce316c5062f129447edd > Reviewed-on: https://chromium-review.googlesource.com/1249124 > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56280} TBR=hpayer@chromium.org,mlippautz@chromium.org Change-Id: If35a09497e09f5cc7ceef8ec33a7c86761f2a336 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1251124Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56282}
-
Florian Sattler authored
PreParser now does not longer track which kind of error occurred. If we see an error we reparse with the parser and report the error. Furthermore, this fixes tests in test-parsing. Change-Id: I1860949fab4d65ff4a5a1b63796c7574494f9d50 Reviewed-on: https://chromium-review.googlesource.com/1231173 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I77479c3a96bcae6041ddce316c5062f129447edd Reviewed-on: https://chromium-review.googlesource.com/1249124 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:890057 Change-Id: I98bc278ebc202c3d8f6417367bd1c592e4824011 Reviewed-on: https://chromium-review.googlesource.com/1250481 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56279}
-
Alexey Kozyatinskiy authored
We might have empty frame_inspector_ here, let's fast return in this case. R=yangguo@chromium.org Bug: chromium:864920 Change-Id: Ia8012251877bb4e04b7f756db72a3039bca6fa9c Reviewed-on: https://chromium-review.googlesource.com/1250408Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56278}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/343caac..eb7ca76 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3cf15a9..7453eba Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f221bac..95d4c85 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/ce131de..ff74025 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/86c7e6d..c5434e9 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7aa1be4f55e02ae0c4df27ccabb77940fbf8f4d3 Reviewed-on: https://chromium-review.googlesource.com/1249960Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56277}
-
- 27 Sep, 2018 26 commits
-
-
Benedikt Meurer authored
The Parser inserts a temporary .promise variable to hold the outer promise for async functions, but doesn't assign an actually visible name to it. This change puts the name ".promise" on it (similar to what we do for other special variables like .result), which makes it easier to debug this (for V8 developers). It's not observable to regular developers. Bug: v8:7522, v8:8015 Change-Id: I388352ad931a49102cb5afe350314337a505a150 Reviewed-on: https://chromium-review.googlesource.com/1249106Reviewed-by:
-
Vasili Skurydzin authored
Bug: v8:8193 GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 Change-Id: I0d4efca4da03ef82651325e15ddf2160022bc8de Reviewed-on: https://chromium-review.googlesource.com/1228633Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56275}
-
Vasili Skurydzin authored
test/cctest/compiler/value-helper.h: fix due to a GCC bug affecting padding of aggregate data types on Aix. GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976 Change-Id: I303b09a9a84b372033c16cbf157d5fc2bf25f93a Reviewed-on: https://chromium-review.googlesource.com/1244616Reviewed-by:
-
Junliang Yan authored
on ppc64/s390x, gcc 6.3 complains "error: unknown option after '#pragma GCC diagnostic' kind". This is to avoid using the option on these platforms. R=jkummerow@chromium.org Bug: v8:8100 Change-Id: I61e5b70038c41cb62889a36694ffcc36fa6deee9 Reviewed-on: https://chromium-review.googlesource.com/1246803Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56273}
-
Toon Verwaest authored
For statementlists we only need to track whether they are null or not. We especially do not need to track possible variable declarations. Change-Id: I66377521c924931a1871e5df0e55a7b45f169155 Reviewed-on: https://chromium-review.googlesource.com/1249267Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56272}
-
Yang Guo authored
R=petermarshall@chromium.org Bug: chromium:680662 Change-Id: If48d1043dbe1e1bb695ec890c23e103a6cacf2d4 Reviewed-on: https://chromium-review.googlesource.com/1244220 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56271}
-
Ivica Bogosavljevic authored
Port c2088790 Change-Id: Ia57a3a47bbc6f99fdf40ea58d01cbb007b4409e3 Reviewed-on: https://chromium-review.googlesource.com/1245773Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#56270}
-
Hannes Payer authored
Bug: v8:8228 Change-Id: I5a666d3bfebe4bce9e06cc6a7fd82aac1fbf2a61 Reviewed-on: https://chromium-review.googlesource.com/1249144Reviewed-by:
-
Michael Achenbach authored
TBR=santa Change-Id: Id26ecc661066d8ec11df5375f5cf40bc89e0cc62 Reviewed-on: https://chromium-review.googlesource.com/1249266Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56268}
-
Florian Sattler authored
Change-Id: I49a4e9740f6a3715ca5cdafd121b3b99fed8dc6b Reviewed-on: https://chromium-review.googlesource.com/1245428Reviewed-by:
-
Creddy authored
This is a reland of eccf1867 Original change's description: > [interpreter] Separate bytecodes for one-shot property loads and stores > > Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback > for one-shot property loads and stores. This CL replaces the runtime > calls with new bytecodes for named property load stores in one-shot code. > the runtime calls needed extra set of consecutive registers and > additional move instructions. This increased the size of > bytecode-array and possibly extended the life time of objects. > By replacing them with NoFeedback bytecodes we avoid these issues. > > Bug: v8:8072 > Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f > Reviewed-on: https://chromium-review.googlesource.com/1196725 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Cr-Commit-Position: refs/heads/master@{#56211} Bug: v8:8072 Change-Id: Ie8e52b37daf35c7bc08bb910d7b15a9b783354e4 Reviewed-on: https://chromium-review.googlesource.com/1245742 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ia5f8ff6279860db83e5bb95206d3e740a13fcc3c Reviewed-on: https://chromium-review.googlesource.com/1248621Reviewed-by:
-
Peter Marshall authored
This reverts commit 5fb55097. Reason for revert: This does not make sense for the chromium use-case Original change's description: > [API] Change GetCodeRange to match the style of GetEmbeddedCodeRange > > Deprecate GetCodeRange(void** start, size_t* length_in_bytes) in favor > of a new signature MemoryRange GetCodeRange() which is consistent with > that of GetEmbeddedCodeRange. > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic5e244981422a2c75485c851ca768e54914cc539 > Reviewed-on: https://chromium-review.googlesource.com/1245741 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56241} TBR=yangguo@chromium.org,petermarshall@chromium.org Change-Id: I51e8bedcb099d3f153ead1451284bf97017bedcf No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1249126Reviewed-by:
-
Clemens Hammacher authored
This code is rarely used, but it makes invalid assumptions. The reversations in {owned_code_space_} might not actually be sorted, so we cannot assume that whenever there is an overlap this will be at the end of the to-be-committed range. Minor drive-by improvements: Use iterator, remove redundant DCHECK. R=mstarzinger@chromium.org Change-Id: I56bca4298c89e97395de71f9d9be404a7b2bf621 Reviewed-on: https://chromium-review.googlesource.com/1245770Reviewed-by: -
Jaroslav Sevcik authored
Instead attribute them properly as Bultin or BytecodeHandler. Bug: v8:6240 Change-Id: I773a533b318afe52d63152edf5b16463801db8e9 Reviewed-on: https://chromium-review.googlesource.com/1249202Reviewed-by:
-
Stephan Herhut authored
This adds a stress test for the I64 variants of the AtomicCompareExchange opcodes. Bug: v8:6532 Change-Id: Iaba4f31f944a71393e5c3222d364d214ff482b9e Reviewed-on: https://chromium-review.googlesource.com/1235913 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Georg Neis authored
- Add a new broker mode kRetired, in which the heap can again be accessed. - Change the way modes work. We now always start in kDisabled. If FLAG_concurrent_compiler_frontend is on, we eventually move to kSerializing, then to kSerialized, then to kRetired. - Add an ObjectDataKind to ObjectData that indicates whether the data is just a dummy (i.e. created while broker was in kDisabled mode). This also happens to fix a bug found by clusterfuzz. Bug: v8:7790, chromium:889722 Change-Id: I38833fe7ad26d2d3efb15ba560576defb82f673a Reviewed-on: https://chromium-review.googlesource.com/1245425 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56260}
-
Michael Achenbach authored
NOTRY=true Bug: v8:8198 Change-Id: I04fd0344f3ce9951c246876fbe1c58fa4306d16c Reviewed-on: https://chromium-review.googlesource.com/1248981Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56259}
-
Clemens Hammacher authored
Make {AllocateForCode} return an actual buffer, and move the OOM check into that method. This allows us to generate more precise OOM messages. R=mstarzinger@chromium.org Change-Id: Ie9ed81248fe8068c92eec29a4911ffef43032de2 Reviewed-on: https://chromium-review.googlesource.com/1245769 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Tobias Tebbi authored
This fixes a bug that the variables used to implement labels with parameters in CSA leak into the user-accessible scope. Example: macro Foo() labels Bar(Smi) { Bar0 = 5; } Bug: v8:7793 Change-Id: I33bf5a207c7e9e7337fa79fc7591c05901b2fa5b Reviewed-on: https://chromium-review.googlesource.com/1246183Reviewed-by: -
Clemens Hammacher authored
There is a data race if several background threads check for a tracing flag concurrently. Both will call {GetCategoryGroupEnabledInternal}. The first one not find the category in the {g_category_group_enabled} array, and hence will add it and call {UpdateCategoryGroupEnabledFlag} to initialize the flag. The second thread then finds the entry in the array and reads it without any synchronization, which is a data race. Since we do not really care about this race, we just use a {Relaxed_Load} to read the field. TSan is fine with that. R=yangguo@chromium.org CC=ofrobots@google.com Bug: v8:8221 Change-Id: Ie09141e3d845956d3c487a463f00b7d6cd413513 Reviewed-on: https://chromium-review.googlesource.com/1245424Reviewed-by: -
Maya Lekova authored
NOTRY=true Bug: v8:8220 Change-Id: I4f6dc81321adc5efceaf64be04fc23627e90b0fe Reviewed-on: https://chromium-review.googlesource.com/1245772 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I1cf8d697b5a4408fb75332dc39be12c0a2ee0e5a Bug: v8:8202, v8:6532 Reviewed-on: https://chromium-review.googlesource.com/1240907 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:8015 Change-Id: I19440f77601317d99d912f5d7248a5275c980993 Reviewed-on: https://chromium-review.googlesource.com/1245761Reviewed-by:
-
Alexei Filippov authored
This reverts commit 181bbd5c. Reason for revert: Still break Win tests https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20debug/25096 Original change's description: > Reland "[heap profiler] Refactor: Replace indices with HeapEntry*" > > This is a reland of 69a502ce > > TBR=ulan@chromium.org > > Original change's description: > > [heap profiler] Refactor: Replace indices with HeapEntry* > > > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > > Reviewed-on: https://chromium-review.googlesource.com/1229613 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#56245} > > Change-Id: I416da19eb38a1a55f5e2f5897062bc1ca454ac34 > Reviewed-on: https://chromium-review.googlesource.com/1246802 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56250} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: I0d027d192a9354eb6157405566420e6aa38738c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1248131Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#56252}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6f889c3..343caac Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/846ae9b..3cf15a9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c4a7356..f221bac Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/9b435fc..ce131de Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9ad74fa..86c7e6d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaf0d368c44cd99d570d47782c2121d625fb9a551 Reviewed-on: https://chromium-review.googlesource.com/1248122Reviewed-by:
-
- 26 Sep, 2018 4 commits
-
-
Alexei Filippov authored
This is a reland of 69a502ce TBR=ulan@chromium.org Original change's description: > [heap profiler] Refactor: Replace indices with HeapEntry* > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > Reviewed-on: https://chromium-review.googlesource.com/1229613 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56245} Change-Id: I416da19eb38a1a55f5e2f5897062bc1ca454ac34 Reviewed-on: https://chromium-review.googlesource.com/1246802 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Frank Tang authored
Add tests for 'quarter' unit in Intl.RelativeTimeFormat#format Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I03077d5d89e1b9e459af0c31b5bf7378d9c4a1f0 Reviewed-on: https://chromium-review.googlesource.com/1244758 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56249}
-
Alexei Filippov authored
This reverts commit 69a502ce. Reason for revert: Broke the build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20gcc%204.8/22123 Original change's description: > [heap profiler] Refactor: Replace indices with HeapEntry* > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > Reviewed-on: https://chromium-review.googlesource.com/1229613 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56245} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: Ib4495f17a653a95f8d5af634da74905c63048f8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246235Reviewed-by:
-
Alexei Filippov authored
This reverts commit 0352ea97. Reason for revert: A dependent patch broke the build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20gcc%204.8/22123 Original change's description: > [heap profiler] Refactor: remove SnapshotFiller proxy > > Long time ago there were two passes over heap. One was counting > objects and edge and another was filling them. Since then we have > just a single pass, but the filler object is still there. > > Remove it for the sake of layering simplicity. > > Change-Id: Ic873eb5ca616b9dcae17fe388197dde8f539026f > Reviewed-on: https://chromium-review.googlesource.com/1244380 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56246} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: If71ddcc0008d138054074fc4cca3f38e032763e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246234Reviewed-by:
-
