1. 04 Feb, 2019 1 commit
    • Clemens Hammacher's avatar
      Reland "[test] Check for illegal uses of mjsunit methods" · ac73e1d5
      Clemens Hammacher authored
      This is a reland of a9e93572
      
      Original change's description:
      > [test] Check for illegal uses of mjsunit methods
      > 
      > The assertThrows and assertDoesNotThrow methods expect either a
      > function to execute, or a string to eval. In several tests however we
      > accidentally passed the *result* of the statement to be tested instead
      > of the code.
      > This CL adds check to catch such error early, and removes wrong uses.
      > In most places, we do not need to use assertDoesNotThrow anyway,
      > because exceptions are handled as test failures.
      > 
      > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
      > MjsUnitAssertionErrors correctly.
      > 
      > R=mathias@chromium.org
      > 
      > Bug: v8:8562
      > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
      > Reviewed-on: https://chromium-review.googlesource.com/c/1439238
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59277}
      
      Bug: v8:8562
      Change-Id: I3b26935f7b35302d499266155273ea271bf8151d
      Reviewed-on: https://chromium-review.googlesource.com/c/1449792Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59328}
      ac73e1d5
  2. 01 Feb, 2019 2 commits
    • Michael Achenbach's avatar
      Revert "[test] Check for illegal uses of mjsunit methods" · 14c06a34
      Michael Achenbach authored
      This reverts commit a9e93572.
      
      Reason for revert:
      https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23956
      Happened already 2 builds earlier, but the output is corrupted due to
      an outage.
      
      Original change's description:
      > [test] Check for illegal uses of mjsunit methods
      > 
      > The assertThrows and assertDoesNotThrow methods expect either a
      > function to execute, or a string to eval. In several tests however we
      > accidentally passed the *result* of the statement to be tested instead
      > of the code.
      > This CL adds check to catch such error early, and removes wrong uses.
      > In most places, we do not need to use assertDoesNotThrow anyway,
      > because exceptions are handled as test failures.
      > 
      > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
      > MjsUnitAssertionErrors correctly.
      > 
      > R=​mathias@chromium.org
      > 
      > Bug: v8:8562
      > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
      > Reviewed-on: https://chromium-review.googlesource.com/c/1439238
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59277}
      
      TBR=ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org
      
      Change-Id: Iec06c95dd3223f27297e5c6e02835d26b5e753e7
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8562
      Reviewed-on: https://chromium-review.googlesource.com/c/1449634Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59284}
      14c06a34
    • Clemens Hammacher's avatar
      [test] Check for illegal uses of mjsunit methods · a9e93572
      Clemens Hammacher authored
      The assertThrows and assertDoesNotThrow methods expect either a
      function to execute, or a string to eval. In several tests however we
      accidentally passed the *result* of the statement to be tested instead
      of the code.
      This CL adds check to catch such error early, and removes wrong uses.
      In most places, we do not need to use assertDoesNotThrow anyway,
      because exceptions are handled as test failures.
      
      Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
      MjsUnitAssertionErrors correctly.
      
      R=mathias@chromium.org
      
      Bug: v8:8562
      Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
      Reviewed-on: https://chromium-review.googlesource.com/c/1439238Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59277}
      a9e93572
  3. 16 Dec, 2010 1 commit
  4. 18 Jan, 2010 1 commit
    • mikhail.naganov@gmail.com's avatar
      Fix issue 571: display descriptive names for code objects from snapshot. · 37d39724
      mikhail.naganov@gmail.com authored
      As this is only needed for internal profiling (not for DevTools),
      the following approach had been chosen:
      
       - during snapshot creation, positions of serialized objects inside
         a snapshot are logged;
      
       - then during V8 initialization, positions of deserealized objects
         are logged;
      
       - those positions are used for retrieving code objects names from
         snapshot creation log, which needs to be supplied to tick processor
         script.
      
      Positions logging is controlled with the new flag: --log_snapshot_positions.
      This flag is turned off by default, and this adds no startup penalty.
      
      To plug this fix to Golem, the following actions are needed:
      
       - logs created using 'mksnapshot' need to be stored along with VM images;
      
       - tick processor script needs to be run with '--snapshot-log=...' cmdline
         argument.
      
      BUG=571
      
      Review URL: http://codereview.chromium.org/551062
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      37d39724
  5. 14 Jul, 2009 1 commit
  6. 09 Jul, 2009 1 commit
  7. 27 Feb, 2009 1 commit
  8. 16 Jan, 2009 1 commit
  9. 14 Jan, 2009 1 commit
  10. 26 Sep, 2008 1 commit
  11. 09 Sep, 2008 1 commit
  12. 22 Aug, 2008 1 commit
    • christian.plesner.hansen's avatar
      Included mjsunit JavaScript test suite and C++ unit tests. · c42f5829
      christian.plesner.hansen authored
      In the shell sample don't print the result of executing a script, only
      evaluating expressions.
      
      Fixed issue when building samples on Windows using a shared V8
      library.  Added visibility option on Linux build which makes the
      generated library 18% smaller.
      
      Changed build system to accept multiple build modes in one build and
      generate seperate objects, libraries and executables for each mode.
      
      Removed deferred negation optimization (a * -b => -(a * b)) since this
      visibly changes operand conversion order.
      
      Improved parsing performance by introducing stack guard in preparsing.
      Without a stack guard preparsing always bails out with stack overflow.
      
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      c42f5829
  13. 03 Jul, 2008 1 commit