- 04 Feb, 2019 1 commit
-
-
Clemens Hammacher authored
This is a reland of a9e93572 Original change's description: > [test] Check for illegal uses of mjsunit methods > > The assertThrows and assertDoesNotThrow methods expect either a > function to execute, or a string to eval. In several tests however we > accidentally passed the *result* of the statement to be tested instead > of the code. > This CL adds check to catch such error early, and removes wrong uses. > In most places, we do not need to use assertDoesNotThrow anyway, > because exceptions are handled as test failures. > > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate > MjsUnitAssertionErrors correctly. > > R=mathias@chromium.org > > Bug: v8:8562 > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 > Reviewed-on: https://chromium-review.googlesource.com/c/1439238 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59277} Bug: v8:8562 Change-Id: I3b26935f7b35302d499266155273ea271bf8151d Reviewed-on: https://chromium-review.googlesource.com/c/1449792Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59328}
-
- 01 Feb, 2019 2 commits
-
-
Michael Achenbach authored
This reverts commit a9e93572. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23956 Happened already 2 builds earlier, but the output is corrupted due to an outage. Original change's description: > [test] Check for illegal uses of mjsunit methods > > The assertThrows and assertDoesNotThrow methods expect either a > function to execute, or a string to eval. In several tests however we > accidentally passed the *result* of the statement to be tested instead > of the code. > This CL adds check to catch such error early, and removes wrong uses. > In most places, we do not need to use assertDoesNotThrow anyway, > because exceptions are handled as test failures. > > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate > MjsUnitAssertionErrors correctly. > > R=mathias@chromium.org > > Bug: v8:8562 > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 > Reviewed-on: https://chromium-review.googlesource.com/c/1439238 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59277} TBR=ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org Change-Id: Iec06c95dd3223f27297e5c6e02835d26b5e753e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8562 Reviewed-on: https://chromium-review.googlesource.com/c/1449634Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59284}
-
Clemens Hammacher authored
The assertThrows and assertDoesNotThrow methods expect either a function to execute, or a string to eval. In several tests however we accidentally passed the *result* of the statement to be tested instead of the code. This CL adds check to catch such error early, and removes wrong uses. In most places, we do not need to use assertDoesNotThrow anyway, because exceptions are handled as test failures. Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate MjsUnitAssertionErrors correctly. R=mathias@chromium.org Bug: v8:8562 Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 Reviewed-on: https://chromium-review.googlesource.com/c/1439238Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59277}
-
- 16 Dec, 2010 1 commit
-
-
ricow@chromium.org authored
Change Object.defineProperty to accept undefined as getters and setters and to correctly accept overriding an accessor with a data property. In the past we only accepted functions as argument for setting an accessor. Since one should be able to set an accessor to undefined this had to be changed to take either. In addition, we did not lookup properties in the prototype chain, causing us to call the setter of an existing accessor up the prototype chain when trying to replace an existing accessor (that was not local) with a data property. Review URL: http://codereview.chromium.org/5861006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6045 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Jan, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
As this is only needed for internal profiling (not for DevTools), the following approach had been chosen: - during snapshot creation, positions of serialized objects inside a snapshot are logged; - then during V8 initialization, positions of deserealized objects are logged; - those positions are used for retrieving code objects names from snapshot creation log, which needs to be supplied to tick processor script. Positions logging is controlled with the new flag: --log_snapshot_positions. This flag is turned off by default, and this adds no startup penalty. To plug this fix to Golem, the following actions are needed: - logs created using 'mksnapshot' need to be stored along with VM images; - tick processor script needs to be run with '--snapshot-log=...' cmdline argument. BUG=571 Review URL: http://codereview.chromium.org/551062 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/155437 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Jul, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Now tests can be run from any directory. Location of test data is now determined using test file location provided by 'testcfg.py' script. Tested under Linux, Mac, and Windows. Review URL: http://codereview.chromium.org/155161 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Feb, 2009 1 commit
-
-
kmillikin@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jan, 2009 1 commit
-
-
ager@chromium.org authored
instead of normal JSObjects. This ensures that __proto__ and accessors on the Object prototype do not interfere with catch scopes. Also, it fixes the bug that catch variables were not DontDelete (issue 74). Next step is to create special lookup routines for context extension objects and remove the special handling of context extension objects from the general javascript object lookup routines. Review URL: http://codereview.chromium.org/18143 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jan, 2009 1 commit
-
-
christian.plesner.hansen@gmail.com authored
also revealed a bug or two that had to be fixed. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1070 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2008 1 commit
-
-
christian.plesner.hansen authored
In the shell sample don't print the result of executing a script, only evaluating expressions. Fixed issue when building samples on Windows using a shared V8 library. Added visibility option on Linux build which makes the generated library 18% smaller. Changed build system to accept multiple build modes in one build and generate seperate objects, libraries and executables for each mode. Removed deferred negation optimization (a * -b => -(a * b)) since this visibly changes operand conversion order. Improved parsing performance by introducing stack guard in preparsing. Without a stack guard preparsing always bails out with stack overflow. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-