- 16 Nov, 2020 16 commits
-
-
Tobias Tebbi authored
... to fix GCC compile failures. Change-Id: I836fb6883354b26aa33085d9a96c5d957af5c5bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537707Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#71209}
-
Jakob Kummerow authored
- allow arrays to be allocated in LargeObjectSpace - check requested array allocation length against maximum - fix array element offsets for pointer-typed elements - fix GC handling of arrays when there are forwarding pointers - module builder: fix rtt.sub global initializer expressions - debug printing: print "UNIMPLEMENTED" instead of crashing - WasmGCTester: make some exceptions easier to diagnose Bug: v8:7748, chromium:1141376 Change-Id: Ie0281658748f3dd5e5d90d85bab78f0ea2fc3865 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534815Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71208}
-
Camillo Bruni authored
- Reuse DOM nodes if possible - Delay slow DOM node removal to not block the UI - Fix global time range syncing when adding timelines to the state - Use a Proxy to cache CSS colors instead of querying CSS properties on every access - Set className on newly create DOM nodes instead of adding to the classList - Use bound functions for event handlers that are added multiple times - Speed up Chunk.getBreackdown - Use CSS gradient for timeline-track chunk backgrounds, which is an order of magnitude faster than the serialised canvas approach Bug: v8:10644 Change-Id: Ie2d6d5b404f18e920c10c0a6460669fd4d0b20e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539947 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71207}
-
Jakob Kummerow authored
Constant-time subtype checks are only valid for struct/array objects. Previously, the code checked for JS_FUNCTION_TYPE to specifically catch funcrefs. With this patch, anything except struct/array objects is excluded, in preparation for anyref support. Additionally, this dynamic check is now only emitted when static type information is not enough. Bug: v8:7748 Change-Id: Ia2920902ee1d9e9714a4b8297a963ba3d6d3312a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536290 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Frank Emrich authored
This CL adds partial support for objects whose slow mode dictionaries are OrderedNameDictionaries. This is the case for all slow mode objects if V8_DICT_MODE_PROTOTYPES is enabled. In particular, this part deals with those runtime functions called by the DefineClass builtin, located in literal-objects.cc and runtime-classes.cc. Bug: v8:7569 Change-Id: Ie4c479fd6f8872eea9f190590408a4aafd1c77e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523321 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71205}
-
Leszek Swirski authored
This resolves issues building gcmole under LLVM 8.0.0 with gcc 10 (see https://bugs.gentoo.org/708730). Change-Id: I932def25fb3cc841cf21414a513fbe2a2fa8a8dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539946Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#71204}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1142437 Change-Id: Icba7a00ac996c0f81a67e0141496829e657a9a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539917 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71203}
-
Omer Katz authored
Ports updates to weak container handling in blink performed in [1]. These changes were needed to resolve timeouts for android. See [1] for more details. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2516363 Bug: chromium:1056170 Change-Id: I2b2c451d494438a37886a3c2bc73481bc9228664 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2538211 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71202}
-
Jakob Kummerow authored
As Wasm code increasingly needs to deal with various HeapObject subtypes, the WasmGraphAssembler is a good place to consolidate common helper methods like LoadMap or LoadFixedArrayElement. This is clearly inspired by the CodeStubAssembler, and there is clearly room for much more refactoring in this direction. This CL does not intend to change any functionality. Bug: v8:11074 Change-Id: I1b768c5791bde7041bc9f41a3069afb1844cdb46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2532083Reviewed-by:
-
Igor Sheludko authored
... and use Name::hash() where the hash is expected to be computed. In particular, when we are dealing with internalized strings or symbols. Bug: v8:11074 Change-Id: Ida22f134fee0ddf2c9b962d1bcca6aa0b632af5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529451Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71200}
-
Georg Neis authored
Split globals.js into two parts, one being skipped on NCI due to assertions about optimization status. Change-Id: Ifc572526d9c6aed369802a65d12c4456cde65ce0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539909 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Main changes: - Remove the kUninitialized and kInvalidated cell type aliases. They were confusing because their meaning depended on the current value in the cell. I think kUninitialized was obsolete anyways. - Remove a DCHECK from the compiler. The property that was asserted, while true, is irrelevant. - Remove the obsolete function GetConstantType. The only left use was in the object printer, but it's pointless there because we already print the value anyways. Change-Id: Ic718c8ba39aeb5bf18f588535dfb755a023cb144 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536647Reviewed-by:
-
Leszek Swirski authored
Add a requirement to String::GetChars that we either have a string access lock, or a string access lock is not needed. This prevents us from reading strings during internalization that may be in the middle of being made external. To avoid taking the lock too often when known to be unnecessary (e.g. for strings that were only just created), there's now a static SharedStringAccessGuardIfNeeded::NotNeeded(). This is hopefully ugly enough that it's used sparingly. One fix required for this is to enter the Isolate when tearing down IsolateData in inspector tests -- this is so that the V8Inspector instance being torn down will see the current Isolate and be able to verify its thread id against the current thread. Bug: chromium:1011762, chromium:1148680 Change-Id: Ic5d29c1b066ebae5a351c7b4bb116b9b1bf61889 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536465 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71197}
-
Marja Hölttä authored
- Add tests comparing super property access to normal property access - Shift the work so that the framework takes less time and the thing we're trying to measure takes more time. - Optimize / disable the optimization for the target function, not the whole test framework. - Reduce the amount of boilerplate code in the tests. Bug: v8:9237 Change-Id: Idde133298c9b8ffb3d49945ef9c67f5039634598 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536635Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71196}
-
Almothana Athamneh authored
Bug: chromium:1148779 Change-Id: Ied690b7b2cf6286d497179cab36dce90b6941d12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536645Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#71195}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0616471..944fd70 Rolling v8/third_party/aemu-linux-x64: NZcWyIyONpZ4Tdm_zmWgSBEWd15zhCNYWLuyJj8_IUcC..2_kHlztQ5lFU-IhCP021uv4v5Ms-aBhhsqtZ1V02tbIC TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id7245e53a0f1a5885b32fb5f2cff65d243593523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2538721Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71194}
-
- 15 Nov, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c604b39..0616471 Rolling v8/third_party/aemu-linux-x64: BisfFk67ojvPEsXt398o1XuIEAeGMM6KsrXCD1gY2RIC..NZcWyIyONpZ4Tdm_zmWgSBEWd15zhCNYWLuyJj8_IUcC TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8b192881a45ab460d1f56b8403b0cd4b4192d01c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539007Reviewed-by:
-
- 14 Nov, 2020 3 commits
-
-
Frank Tang authored
Fix the ASAN crahs when there are 9 or more items to be formatted by ListFormat. chromium DEPS rolled in https://chromium-review.googlesource.com/c/chromium/src/+/2536432 This CL is mainly to add unit test to ensure it fix. Cq-Include-Trybots: luci.v8.try:v8_linux64_asan_rel_ng,v8_mac64_asan_rel_ng,v8_win64_asan_rel_ng;luci.chromium.try:android-asan,win-asan,win-libfuzzer-asan-relBug: chromium:1146068 Change-Id: I4dfbd6ea0efe5b398196f95abc520bb93e16a7cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528476Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1053f48..c604b39 Rolling v8/third_party/aemu-linux-x64: F0EKpWdiLAqJzq0dh6psRmgvyNI65ezZmuUTuiyMIDkC..BisfFk67ojvPEsXt398o1XuIEAeGMM6KsrXCD1gY2RIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/420f736..f92a763 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5157fbf..fd5c198 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/c2a4cae..7db579a TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7be99d0ec677cf79631989b515e62ddce997a2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2538484Reviewed-by:
-
Frank Tang authored
chromium DEPS rolled in https://chromium-review.googlesource.com/c/chromium/src/+/2536432 This CL is mainly to add unit test to ensure it fix. Bug: chromium:1146468 Change-Id: I30505d9133136122023d80ff85edbf0abe49c07e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2535790Reviewed-by:
-
- 13 Nov, 2020 20 commits
-
-
Nico Hartmann authored
This is the 2nd step in series of CLs to move the SharedFunctionInfo class to kNeverSerialized and make it concurrently accessible from the background thread. This CL: * Changes optimization of GetTemplateObject in JSCreateLowering to only perform the optimization of a template object exists in the SharedFunctionInfo[Ref], but skips the optimization if one is missing instead of allocating a new one on demand. Bug: v8:7790 Change-Id: Ic37d8333676e54b3f8d69416480df12bd90723ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2463229 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Instead of caching only the default formatter, cache the last used formatter if possible. This is better because it's a common use case to create a formatter in a different language and reuse it a lot, rather than create several formatters in various languages. Running the following benchmark: ``` let i = 0; function toLocaleString() { i++; return i.toLocaleString(); } i = 0; function toLocaleStringWithLocale() { i++; return i.toLocaleString('en-US'); } const functions = [toLocaleString, toLocaleStringWithLocale]; for (const f of functions) { let start = performance.now(); for (let i = 0; i < 10e5; i++) { f(); } let end = performance.now(); print(`${f.name}: ${end - start}`); } ``` sees the following improvements: With this patch: toLocaleString: 384.292 toLocaleStringWithLocale: 450.48900000000003 Without this patch: toLocaleString: 341.952 toLocaleStringWithLocale: 23439.694 This a little over 50x improvement. Bug: chromium:926075 Change-Id: I0e316e959c90243e175df985854832a7abddbf54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536461 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: -
Ulan Degenbaev authored
The new platform can be used in combination with --single-threaded. It disables background threads and thus avoids waiting on mutexes and condition variables completely, which is useful for V8 embedders that fork the V8 process after initialization. As a bonus the new platform allows use to test --single-threaded and has already uncovered an existing bug in parallel pointer updating code. Change-Id: I3446fa027d2a077641cdaac0cd08062a1acae176 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416501 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
It is only used during initialization. Bug: v8:7790 Change-Id: I2105ad01413e3b398b3252d14e83c930c0dd3e74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536637Reviewed-by:
-
Igor Sheludko authored
... by adding ChangeAlertMechanism enum instead of two bool values and removing code duplication in tests. Bug: v8:11074 Change-Id: I90f63bd1c9e858dc3b0a4f190c19f092437257cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536458Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#71185}
-
Georg Neis authored
Don't deopt when a PropertyCell changes from readonly to writable. Turbofan doesn't depend on readonly-ness unless the property is also non-configurable, in which case such a change can't happen. Change-Id: I3d1078a8adf1ec1b16d973dd71c4295d71003a8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531791 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I4b6ef907c66bdc0a327d211db2f86ebb75f969a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536638Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#71183}
-
Clemens Backes authored
This will allow us to target the new executable from existing JS fuzzers (like the ochang fuzzer). Let's see if this gives more interesting JS input files. R=machenbach@chromium.org CC=szuend@chromium.org Bug: chromium:1142437 Change-Id: Id5bcfe660a487fbb9d6b80d167f43324cc284e1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536632 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: I2c9f3ac81710b89543b392819a6cce03eaba6cae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536639 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This is a reland of 04cdcd5a Got reverted in https://crrev.com/c/v8/v8/+/2534294 due to TSAN issues. Those are solved in https://crrev.com/c/v8/v8/+/2537693. Original change's description: > [compiler] Move InternalizedString to kNeverSerialized > > Bug: v8:7790 > Change-Id: I8311b1f4b8239d0688a4b9b9057d6082942bbc00 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534471 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71159} Bug: v8:7790 Change-Id: I95d68e23e4bc81399bcdcf7ce2fdcf49ddfb66c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536641 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I7a34efcd4841a67d1e663f9e9b5f0c8fda09a8e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2532307Reviewed-by:
-
Georg Neis authored
Change-Id: I6f0f003b09fea49718eadc59cf35bdb346c585d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536636 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Isolate::thread_id() may be invoked on a background thread to perform a check if the thread is the main thread. This also removes the copy constructor of ThreadLocalTop and clears its fields explicitly. Change-Id: I2207bf1ebd655805841fce9f23d23cff7be8f13b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537693Reviewed-by:
-
Ulan Degenbaev authored
Change-Id: Ifc754fb81089aed4cb79b1f6c4aab0cb73a2a5d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537690Reviewed-by:
-
Frank Emrich authored
Previously, CodeStubAssembler::AllocateOrderedHashTable() would allocate hash tables of the (statically known) minimum capacity in- dicated by the concrete table type. This CL adds AllocateOrderedHashTableWithCapacity, which is inspired by AllocateNameDictionary. It takes a Node<IntPtrT> indicating the desired capacity. Bug: v8:7569 Change-Id: I4bf28f69286e52773319a1ae37d33b2f55175a84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2503950 Commit-Queue: Frank Emrich <emrich@google.com> Reviewed-by:
-
Santiago Aboy Solanes authored
We now cast it into a DescriptorArrayData where appropiate, as we do with all the other Data members. Bug: v8:7790 Change-Id: I5be0aab9c4e80ae246c58a8df719308a0d475e6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534816 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Alfonso Castaño authored
In a previous CL the logic for generating the description for Trusted Types was added to Blink. Therefore, the corresponding logic remaining in V8 can be deleted safely. Previous CL: https://chromium-review.googlesource.com/c/v8/v8/+/2502342 Bug: chromium:1048143 Change-Id: I1693fa1d213066cbc1fe822f890d2d7aaf7ce0f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2502869Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Alfonso Castaño <alcastano@google.com> Cr-Commit-Position: refs/heads/master@{#71173}
-
Alfonso Castaño authored
This CL adds the CSPViolation pause reason. Such an enum will be used to enable breakpoints on Trusted Type violations. Design doc: https://docs.google.com/document/d/1rlRtq_Ai0leS9sqlRvoOL5RNc1BR6Q1yAVvLLJFasMA/ Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2520827 Follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/2517519 Bug: chromium:1142804 Change-Id: Iefdbb52115d0ba1810527773a8a2828e795fe533 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519513Reviewed-by:
-
Ross McIlroy authored
Makes ExternalReference count as a subclass of RawPtrT to enable either to be passed to these functions as base argument. BUG=v8:6949,v8:11074 Change-Id: I126856815ff7cdc0612e3c3fcdfdd4938cc19bfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534820 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Georg Neis authored
Change-Id: I0aede0a2a188fc17492c10c0c13568c052282548 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534822 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
