- 06 Nov, 2014 13 commits
-
-
mstarzinger@chromium.org authored
R=titzer@chromium.org TEST=cctest/test-scheduler/RPOLoop Review URL: https://codereview.chromium.org/708763002 Cr-Commit-Position: refs/heads/master@{#25188} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
The HydrogenCodeStub is too expensive and there's no easy way to reduce this cost, so turning it into a PlatformCodeStub solves that problem until we can use TurboFan for code stubs. TEST=mjsunit R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/683913008 Cr-Commit-Position: refs/heads/master@{#25187} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG=3681 LOG=n TBR=mvstanton@chromium.org Review URL: https://codereview.chromium.org/701353003 Cr-Commit-Position: refs/heads/master@{#25186} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
BUG=chromium:430846 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/704183002 Cr-Commit-Position: refs/heads/master@{#25185} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/695303003 Cr-Commit-Position: refs/heads/master@{#25184} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/709443002 Cr-Commit-Position: refs/heads/master@{#25183} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
The idea behind of this solution is to use the existing "relocation info" instead of consumption the CodeLinePosition events emitted by the V8 compilers. During generation code and relocation info are generated simultaneously. When code generation is done you each code object has associated "relocation info". Relocation information lets V8 to mark interesting places in the generated code: the pointers that might need to be relocated (after garbage collection), correspondences between the machine program counter and source locations for stack walking. This patch: 1. Add more source positions info in reloc info to make it suitable for source level mapping. The amount of data should not be increased dramatically because (1) V8 already marks interesting places in the generated code and (2) V8 does not write redundant information (it writes a pair (pc_offset, pos) only if pos is changed and skips other). I measured it on Octane benchmark - for unoptimized code the number of source positions may achieve 2x ('lin_solve' from NavierStokes benchmark). 2. When a sample happens, CPU profiler finds a code object by pc, then use its reloc info to match the sample to a source line. If a source line is found that hit counter is increased by one for this line. 3. Add a new public V8 API to get the hit source lines by CDT CPU profiler. Note that it's expected a minor patch in Blink to pack the source level info in JSON to be shown. 4.Add a test that checks how the samples are distributed through source lines. It tests two cases: (1) relocation info created during code generation and (2) relocation info associated with precompiled function's version. Patch from Denis Pravdin <denis.pravdin@intel.com>; R=svenpanne@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/682143003 Patch from Weiliang <weiliang.lin@intel.com>. Cr-Commit-Position: refs/heads/master@{#25182} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=jarin@chromium.org TEST=cctest/test-scheduler/LoopedFloatingDiamond2 Review URL: https://codereview.chromium.org/702683002 Cr-Commit-Position: refs/heads/master@{#25181} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TEST=cctest/test-changes-lowering,mjsunit/asm,unittests R=jarin@chromium.org Review URL: https://codereview.chromium.org/704463004 Cr-Commit-Position: refs/heads/master@{#25180} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
The bug has always been there: when the parser is operating in the "immediately internalize" mode and calls GetString, we get FlatContent of a string and then do heap allocation. The bug was uncovered by https://codereview.chromium.org/693803004/ (which put the parser to the "immediately internalize" mode more often), but looking at the code, it's possible that it can happen in other cases too. This CL makes AstValueFactory handle this situation gracefully: it won't try to internalize inside GetString(Handle<String>); it's unnecessary anyway since we have the Handle<String> already. BUG= R=rossberg@chromium.org Review URL: https://codereview.chromium.org/706533005 Cr-Commit-Position: refs/heads/master@{#25179} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=bmeurer@chromium.org, jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/699083003 Cr-Commit-Position: refs/heads/master@{#25178} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Emscripten requires little-endian arch. It has assertion for endianness: assert(HEAPU8[0] === 255 && HEAPU8[3] === 0, 'Typed arrays 2 must be run on a little-endian system'); TEST=mjsunit/asm/embenchen/* BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/708663003 Patch from Paul Lind <paul.lind@imgtec.com>. Cr-Commit-Position: refs/heads/master@{#25177} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TEST=msjunit/asm,unittests R=jarin@chromium.org Review URL: https://codereview.chromium.org/683753004 Cr-Commit-Position: refs/heads/master@{#25176} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Nov, 2014 27 commits
-
-
paul.lind@imgtec.com authored
The div and mod instructions on MIPS are not safe for rhs 0. TEST=test/mjsunit/asm/uint32div.js BUG= R=akos.palfi@imgtec.com Review URL: https://codereview.chromium.org/704013002 Cr-Commit-Position: refs/heads/master@{#25174} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#25173} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#25172} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#25171} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#25170} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Cr-Commit-Position: refs/heads/master@{#25169} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dusan.milosavljevic@imgtec.com authored
TEST=unittests/InstructionSelectorCmpTest.Parameter, InstructionSelectorTest.Word32EqualWithZero BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/706633003 Cr-Commit-Position: refs/heads/master@{#25167} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
TBR=machenbach@chromium.org, bmeurer@chromium.org Review URL: https://codereview.chromium.org/702163002 Cr-Commit-Position: refs/heads/master@{#25166} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/700153002 Cr-Commit-Position: refs/heads/master@{#25165} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
titzer@chromium.org authored
This reverts commit 482586747ca6bc0c94cc23f916fd190931d3a836. TBR=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/702893002 Cr-Commit-Position: refs/heads/master@{#25164} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
BUG= R=ulan@chromium.org Review URL: https://codereview.chromium.org/708473002 Cr-Commit-Position: refs/heads/master@{#25163} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
titzer@chromium.org authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/689133003 Cr-Commit-Position: refs/heads/master@{#25162} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
TBR=bmeurer@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/701013006 Cr-Commit-Position: refs/heads/master@{#25161} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
TBR=bmeurer@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/701023003 Cr-Commit-Position: refs/heads/master@{#25160} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
This reverts r25155. Reason: breaks webkit unit tests. BUG= TBR=marja@chromium.org Review URL: https://codereview.chromium.org/707483002 Cr-Commit-Position: refs/heads/master@{#25159} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
The bug has always been there: when the parser is operating in the "immediately internalize" mode and calls GetString, we get FlatContent of a string and then do heap allocation. The bug was uncovered by https://codereview.chromium.org/693803004/ (which put the parser to the "immediately internalize" mode more often), but looking at the code, it's possible that it can happen in other cases too. This CL makes AstValueFactory handle this situation gracefully: it won't try to internalize inside GetString(Handle<String>); it's unnecessary anyway since we have the Handle<String> already. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/699343004 Cr-Commit-Position: refs/heads/master@{#25155} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG=410721 LOG=n TEST=script_test.py R=tandrii@chromium.org TBR=tandrii@chromium.org Review URL: https://codereview.chromium.org/702843002 Cr-Commit-Position: refs/heads/master@{#25154} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
BUG=v8:3670 LOG=n R=verwaest@chromium.org Review URL: https://codereview.chromium.org/702053002 Cr-Commit-Position: refs/heads/master@{#25153} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
TBR=bmeurer@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/696213003 Cr-Commit-Position: refs/heads/master@{#25152} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25152 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/701853002 Cr-Commit-Position: refs/heads/master@{#25151} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/701933003 Cr-Commit-Position: refs/heads/master@{#25150} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/694473002 Cr-Commit-Position: refs/heads/master@{#25149} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
Shave this yak from orbit, it's the only way to be sure. BUG=chromium:427616 LOG=n R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/700963002 Cr-Commit-Position: refs/heads/master@{#25148} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
hpayer@chromium.org authored
BUG= R=jarin@chromium.org Review URL: https://codereview.chromium.org/694703003 Cr-Commit-Position: refs/heads/master@{#25147} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
Jacob.Bramley@arm.com authored
Use 'vmov Dn[x], ip' instead of 'vmov Sn, ip' to load double immediates. This patch is only useful for Turbofan as Crankshaft loads double immediates from the constant pool. This give a little improvement on asm.js benchmarks R=bmeurer@chromium.org, ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/704543002 Cr-Commit-Position: refs/heads/master@{#25146} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25146 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts commit r25142. TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/702853002 Cr-Commit-Position: refs/heads/master@{#25145} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25145 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
baptiste.afsa@arm.com authored
Since r25024 load/store indexes are 64-bit value but arm64 backend was still treating them as 32-bit value. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/698383003 Cr-Commit-Position: refs/heads/master@{#25144} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25144 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-