- 10 Apr, 2019 7 commits
-
-
Jakob Gruber authored
@@replace should only call ToString(replaceValue) once. Prior to this CL this was not the case when 1. the given regexp is fast 2. the replacement is not callable 3. and its string representation contains a '$'. In such a situation we'd call ToString both in the RegExpReplace builtin, and after bailing out again in the RegExpReplaceRT runtime function. The fix is to pass the result of ToString(replaceValue) to the runtime function. ToString in RegExpReplaceRT will be a no-op since the value is already guaranteed to be a string. Bug: chromium:947822 Change-Id: I14b4932a5ee29e49de4c2131dc2e98b50d93da49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559739 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60733}
-
Sathya Gunasekaran authored
The resolve/reject callbacks to PerformPromiseAll is refactored out so that we can just pass different closures for PerformPromiseAllSettled. Similarly, a closure to update the value is passed to Generate_PromiseAllResolveElementClosure so that we can create a diferrent value in case of Promise.allSettled. Bug: v8:9060 Change-Id: I4e1bebe6da4ea0965a67cccc8365ed91cf4683c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559216 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60732}
-
Frank Tang authored
Bug: v8:9109 Change-Id: I5a79192c8168c81d8f35711f8983fb1acb260a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559214Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60731}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e7cb8dd..6f0224b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/072a6f1..f8d4d2d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I281966c8ecbc8cc625202b63493692a41cf99c08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560652Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60730}
-
John Budorick authored
Example failure caused by this race: https://ci.chromium.org/p/chromium/builders/ci/linux-dbg/7157 Introduced in crrev.com/c/1557152 Tbr: sigurds@chromium.org,tebbi@chromium.org Bug: v8:7793 Change-Id: I06f4c95e97577b7ba51e55faa50b844d773e976b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559215 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60729}
-
Simon Zünd authored
This reverts commit 8b917cd9. Reason for revert: Breaks the noi18n build. The header js-date-time-format.h expects i18n to be enabled. Original change's description: > [torque] Convert few class layout definitions to torque. > > Converted JSGlobalObject, JSIteratorResult, JSLocale, JSDateTimeFormat, > JSListFormat, JSNumberFormat, JSPluralRules, JSRelativeTimeFormat, > JSSegmenter, JSAsyncFromSyncIterator to torque. > > Bug: v8:8952 > Change-Id: I760a658c5bef7e12bc8f07b741245e9d1933164e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529262 > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60727} TBR=jgruber@chromium.org,tebbi@chromium.org,surshar@microsoft.com Change-Id: Ibbcb3667be1042b3b0290d68369da597ea07102d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559866Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60728}
-
Suraj Sharma authored
Converted JSGlobalObject, JSIteratorResult, JSLocale, JSDateTimeFormat, JSListFormat, JSNumberFormat, JSPluralRules, JSRelativeTimeFormat, JSSegmenter, JSAsyncFromSyncIterator to torque. Bug: v8:8952 Change-Id: I760a658c5bef7e12bc8f07b741245e9d1933164e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529262 Commit-Queue: Suraj Sharma <surshar@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60727}
-
- 09 Apr, 2019 33 commits
-
-
Joyee Cheung authored
- Add a new ClassScope for block scopes created for classes. - Add a VariableMap in the class scope for private name resolution, and a separate UnresolvedList for private names that will be resolved only using ClassScopes. These are stored in RareData and will only be allocated when there are private name declaration or access in the class. Design: https://docs.google.com/document/d/1l-D70uaHzXU8QVgQZ3ACikb3FLO6LTAfQVdGDXsh5mw/edit?usp=sharing TBR: hpayer@chromium.org Bug: v8:8330 Bug: v8:7468 Change-Id: I78191fc075f7f195f6c56c959773c382346cce8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1488271 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Frank Tang authored
While dateStyle or timeStye is specified, we should not add property listed in "Table Components of date and time formats" per https://tc39.github.io/proposal-intl-datetime-style/#sec-initializedatetimeformat Bug: v8:9107 Change-Id: I3e39112ed5f99b05f30b2f50f3cd3102d094f98e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559213Reviewed-by:
-
Benedikt Meurer authored
Avoid divide by zero for empty elements backing stores, and generally don't account for empty_property_array / empty_fixed_array. Bug: v8:7266 Change-Id: I5d1c5f43165810f7ec3bcebf3caf1bc737b46e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559865 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60724}
-
Z Duong Nguyen-Huu authored
Design docs: bit.ly/fast-frozen-sealed-elements-in-v8 This change is only support the transition from packed elements to packed sealed elements (via object.seal) or to packed frozen elements (via object.freeze). Added tests for non-extensible, sealed, frozen packed elements in https://chromium-review.googlesource.com/c/v8/v8/+/1474559 Added tests for non-extensible array in optimized code in https://chromium-review.googlesource.com/c/v8/v8/+/1531030 and https://chromium-review.googlesource.com/c/v8/v8/+/1544274 Using JSTests/ObjectFreeze micro-benchmarks for release build Before: TaggedTemplate-Numbers(Score): 0.967 TaggedTemplateLoose-Numbers(Score): 8.82 After: TaggedTemplate-Numbers(Score): 1.51 TaggedTemplateLoose-Numbers(Score): 8.89 Bug: v8:6831 Change-Id: Ib1089f1bc02eafb8d76ffe617f8fa3e406abd5a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1474559Reviewed-by:
-
Clemens Hammacher authored
This stages wasm code gc behind "--future" to get test coverage while implementing this feature. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Id620ee92518c4dd9cebc0fd47817bfc80e5cf3f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559741 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60722}
-
Clemens Hammacher authored
This adds the {CurrentGCInfo} data structure to the wasm engine. It holds all information needed for the current GC cycle, which is currently only the set of Isolates that still need to report their live code, and the set of dead wasm code (which is potentially reduced when Isolates report live code). Running the GC is guarded by the new '--wasm-code-gc' flag. I will add this to the --future variant in a follow-up CL. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I82e96d986cf5a758bc0f94e49e13ad78fae4e935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559738 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
The --js-arguments flag is gone since https://crrev.com/c/1291469. This CL removes a remaining reference to that, and as a drive-by changes the proposed '--noflag' to '--no-flag'. R=petermarshall@chromium.org Bug: v8:8834 Change-Id: I69a8d008e87949d64329b4350197ba0651b54340 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558087Reviewed-by:
-
Maya Lekova authored
This reverts commit 84853ad1. Reason for revert: Blocking LKGR because of Arm timeouts, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/16047 Original change's description: > [turbofan] Temporarily disable OSR for performance data > > Just set the flag --use-osr to false by default. > If it's set to true on the command line, then it'll be on. > > I'd like to get some performance metrics on various tests spread > throughout our performance bot infrastructure. > > Change-Id: I1ebc33264505af080901e531dca625452880f81b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558089 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60693} TBR=mvstanton@chromium.org,mslekova@chromium.org Bug: chromium:950934 Change-Id: I6c713f33f491bda49cd1d1d2f155f1971217089e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559859Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60719}
-
Clemens Hammacher authored
This adds data structures to track potentially dead code in the wasm engine. The engine will then trigger an engine-wide GC once the potentially dead code reaches a certain threshold. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I13216a66bb8e8e1594b165a65708e53057e9e535 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559736 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:8834 Change-Id: I6cf045b835256c27a196372093ceb302ab22f8d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559856Reviewed-by:
-
Clemens Hammacher authored
The test is working since some time. It was blocked on the jump table, and patching it correctly when redirecting imported functions to the interpreter. R=mstarzinger@chromium.org Bug: v8:7767 Change-Id: Id3a16de9c6403cab0321958b681ff18f216fe978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559852Reviewed-by:
-
Michael Starzinger authored
This adds support for passing/returning reference type parameter/return values when the interpreter is calling extern functions. It expands the existing test coverage to the interpreter. R=clemensh@chromium.org TEST=mjsunit/wasm/anyref-interpreter,mjsunit/wasm/anyfunc-interpreter BUG=v8:8091,v8:7581 Change-Id: I377e9d28aa36866c0441683ffd6a48160b721ec1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559853Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60715}
-
Clemens Hammacher authored
Since wasm optimizations are independent of JS optimizations, we can just combine the "no_liftoff" variant with the existing "stress" variant (which has the similar "--always-opt" option for JS), and add a "Liftoff only" variant as part of "nooptimization". This gives more coverage to find bugs like https://crrev.com/c/1543354 more easy. R=mstarzinger@chromium.org, machenbach@chromium.org Change-Id: I81bb22074c59dcb650a05252da43a4170cd467ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559740 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60714}
-
Jakob Gruber authored
This changes debug builds [1] to compile src/compiler sources twice: 1. with optimizations, used in mksnapshot to improve performance. 2. without optimizations, linked into d8 and v8 libraries. While this adds ~200 compilation targets, these can be built in parallel and should not add much time overall. This brings mksnapshot runtime back down to 11 seconds on my machine. [1] The full condition is: is_debug && !v8_optimized_debug && v8_enable_fast_mksnapshot Cq-Include-Trybots: luci.chromium.try:android_arm64_dbg_recipe Cq-Include-Trybots: luci.chromium.try:fuchsia_x64 Bug: v8:8767 Change-Id: Iac57bf8331395d9eda9be5d192e8eeeded182ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532335 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2c7bf07..e7cb8dd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6145021..072a6f1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1fb0463..224e075 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I77ccd5ff5542e9d64cef6c284cd2dacaa5c15a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559838Reviewed-by:
-
Jakob Gruber authored
Rename the (mksnapshot-specific) --ebt-os flag to --target-os. This flag specifies the target os for mksnapshot-generated files, specifically for embedded.S. In the future we should base all of embedded-file-writer.cc on this (and an upcoming --target-arch) flag and remove other current cross-compilation workarounds (e.g.: V8_TARGET_OS_WIN, V8_TARGET_OS_FUCHSIA). Bug: chromium:945659,v8:9103 Change-Id: I814fa8c5d4ee9ca0542f63dcae790086d887bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559748 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60711}
-
Anton Bikineev authored
This change aims to simplify RawMachineAssembler::CallCFunction interface by use of variadic templates. Change-Id: Ie7081f692f62674f891f09abfd7149e8d95eeb81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526015 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Georg Neis authored
Instead optimize based on the name feedback. This simplifies matters for concurrent optimization. Drive-by: Rename "index" to "key" for clarity where appropriate. Bug: v8:7790 Change-Id: Id6db1174c7840c24044bc655e0ffee6a5b0de21c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559742 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
The new @generatePrint annotation automatically generates ...Print methods for objects from their Torque class definition. While this is mostly geared towards objects derived from Struct, it works on any Torque class. Bug: v8:7793 Change-Id: Iaa772879d397b95c7853dafdd9f09a85dbde8e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557152 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:933093 Change-Id: I3187f4aedb0c7fbbac9385172c301c4058f71214 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559745Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020, chromium:676417 Change-Id: Iadb46d8877ef9f85f0e444be563a94ccf0f8209f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Drive-by fix: In ProcessFeedbackForGlobalAccess, we had forgotten to return the feedback when it already existed. Bug: v8:7790, v8:9094 Change-Id: Ie4be6cef5755bbdd9d8ed472caaa2e32d243893d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554680Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60705}
-
Clemens Hammacher authored
The {remaining_uncommitted_code_space} method is only used for testing. This CL removes it, and replaces all uses by {committed_code_space}. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: Icb50471da3564a5cd114b15836c8b346b932a108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559735 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
Change-Id: I2855af444db5dad910d99acc8179aef75e56d000 Bug: v8:9020 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559734Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
We currently store the {remaining_uncommitted_code_space_}. This CL switches this to store {total_committed_code_space_} plus the maximum allowed (in {max_committed_code_space_}). This counter will be used by the GC to decide when to trigger a GC. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I5946bbd3ba18e9fcbca4631afb942cd5b82834f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558084Reviewed-by: -
Michael Starzinger authored
This adds support for loading and storing mutable imported globals having a reference type in the interpreter. It expands existing test coverage to the interpreter. R=clemensh@chromium.org TEST=mjsunit/wasm/anyref-globals-interpreter BUG=v8:8091,v8:7581 Change-Id: I78e0c5c73664a183e1d92ec91eadf8b9a93e4787 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559743Reviewed-by:
-
Simon Zünd authored
Removing the 'native' flag from ParseInfo removed the last use-site of this flag. R=jgruber@chromium.org Bug: v8:9043 Change-Id: I0e28d77c571c25c7925e8e372e631a9630492c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550705Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/snapshot to 'using' declarations. R=jgruber@chromium.org Bug: v8:8834 Change-Id: Ie555e9ac7e1ec04c20d411647f8ab70f671c1cb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545903 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/debug to 'using' declarations. R=jgruber@chromium.org Bug: v8:8834 Change-Id: I205e14a0b230a26119e5b209a2bcec493a8815e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545901Reviewed-by:
-
Maya Lekova authored
Fixing the computation of the foreground time after original CL: https://chromium-review.googlesource.com/c/v8/v8/+/1547864/ Bug: v8:7790, v8:9074 Change-Id: Ic6af4f17aa6e30f9810bd36b0e9f7151ccb57538 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559737 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Frederik Gossen authored
When compilation hints are disabled (they are by default) the decoder failed on custom sections with the name 'compilationHints'. This is fixed and a test is added. Bug: v8:9003 Change-Id: I5d25c019a702a722d8baf497d1bcd3a578a2d4bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1557150 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
Michael Starzinger authored
This adds support for handling reference types when loading/storing globals. Support for imported mutable globals is still missing and will be done in a follow-up change. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-global-interpreter BUG=v8:8091,v8:7581 Change-Id: I0d14919b1ce7f49c4a0541e3d6a99ee203cfb311 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1558086 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jakob Gruber authored
In mksnapshot, we only need to ensure we generate counter code in (embedded) builtins, if needed. The counter function does not need to do anything useful as long as it returns unique pointers for each counter, and we don't need to dump counters. Tbr: petermarshall@chromium.org Change-Id: I94a53ef5193b89365948d0395e1908e6d3c6e396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549159Reviewed-by:
-
