- 30 Jan, 2017 16 commits
-
-
petermarshall authored
The graphs don't show any performance bump for https://codereview.chromium.org/2659623002, which I do see a much better result for locally. I suspect the function isn't being optimized in turbofan when the benchmarks run. Maybe this warmup flag will trigger that. BUG=v8:5895 Review-Url: https://codereview.chromium.org/2664783002 Cr-Commit-Position: refs/heads/master@{#42776}
-
bmeurer authored
We can constant-fold ReferenceEqual(a,b) to false, if the intersection of the types of a and b is empty. This also repairs a regression in the RestParameter performance test. R=petermarshall@chromium.org BUG=chromium:686668 Review-Url: https://codereview.chromium.org/2666543002 Cr-Commit-Position: refs/heads/master@{#42775}
-
danno authored
Review-Url: https://codereview.chromium.org/2657293002 Cr-Commit-Position: refs/heads/master@{#42774}
-
danno authored
Review-Url: https://codereview.chromium.org/2655023009 Cr-Commit-Position: refs/heads/master@{#42773}
-
machenbach authored
BUG=chromium:681236 NOTRY=true TBR=bradnelson@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2662823002 Cr-Commit-Position: refs/heads/master@{#42772}
-
mvstanton authored
They have the same lifetime. It's a match! Both structures are native context dependent and dealt with (creation, clearing, gathering feedback) at the same time. By treating the spaces used for literal boilerplates as feedback vector slots, we no longer have to keep track of the materialized literal count elsewhere. A follow-on CL removes even more parser infrastructure related to this count. BUG=v8:5456 Review-Url: https://codereview.chromium.org/2655853010 Cr-Commit-Position: refs/heads/master@{#42771}
-
jarin authored
Review-Url: https://codereview.chromium.org/2626013002 Cr-Original-Commit-Position: refs/heads/master@{#42229} Committed: https://chromium.googlesource.com/v8/v8/+/30176976e857d4eb84a93fface84849c44bab793 Review-Url: https://codereview.chromium.org/2626013002 Cr-Commit-Position: refs/heads/master@{#42770}
-
tebbi authored
R=bmeurer@chromium.org BUG=chromium:682570 Review-Url: https://codereview.chromium.org/2664683003 Cr-Commit-Position: refs/heads/master@{#42769}
-
bmeurer authored
Update type of JSForInNext to say String\/Undefined. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2660543003 Cr-Commit-Position: refs/heads/master@{#42768}
-
bmeurer authored
R=ishell@chromium.org BUG=chromium:686102 Review-Url: https://codereview.chromium.org/2662793002 Cr-Commit-Position: refs/heads/master@{#42767}
-
danno authored
Review-Url: https://codereview.chromium.org/2658253002 Cr-Commit-Position: refs/heads/master@{#42766}
-
petermarshall authored
Where the arguments have already been inlined, we can replace these calls with a direct call to construct. We have to make sure that the iteration over the arguments is not observable. BUG=v8:5895 Review-Url: https://codereview.chromium.org/2659623002 Cr-Commit-Position: refs/heads/master@{#42765}
-
petermarshall authored
We need it to be a PropertyCell so that we can list it as a dependency for optimised code. Also drive-by clean up some variable names in src/isolate-inl.h. BUG=v8:5895 Review-Url: https://codereview.chromium.org/2658573008 Cr-Commit-Position: refs/heads/master@{#42764}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2657773006 Cr-Commit-Position: refs/heads/master@{#42763}
-
marja authored
These tests pass without further changes. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2654163008 Cr-Commit-Position: refs/heads/master@{#42762}
-
jochen authored
We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{#42761}
-
- 29 Jan, 2017 3 commits
-
-
caitp authored
emit %DebugPrint(tagged_value) instead of %GlobalPrint(tagged_value) to avoid a CONVERT_ARG_CHECKED() failure when tagged value is not a string. BUG=v8:5268 R=ishell@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2663633002 Cr-Commit-Position: refs/heads/master@{#42760}
-
machenbach authored
BUG=v8:5906 NOTRY=true TBR=binji@chromium.org Review-Url: https://codereview.chromium.org/2659273002 Cr-Commit-Position: refs/heads/master@{#42759}
-
v8-autoroll authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/9907db5..c3f2575 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2666443002 Cr-Commit-Position: refs/heads/master@{#42758}
-
- 28 Jan, 2017 7 commits
-
-
bradnelson authored
Return a regular JSObject in the asm.js -> wasm case. BUG=v8:5877 R=mtrofin@chromium.org,aseemgarg@chromium.org,titzer@chromium.org Review-Url: https://codereview.chromium.org/2664493002 Cr-Commit-Position: refs/heads/master@{#42757}
-
jarin authored
This avoids using kTaggedSigned and kTaggedPointer because the semantic information of those type could be invalid in unreachable code. For example, SmiCheck(0.1) has representation TaggedSigned, but it is later compiled to DeoptimizeUnless(ObjectIsSmi(0.1)) with the constant 0.1 directly connected to the uses. If the use is state-values, which recorded the TaggedSigned representation of CheckSmi, the code generator will be confused because it will see constant 0.1 that claims to be TaggedSigned value. BUG=chromium:675704 Review-Url: https://codereview.chromium.org/2656243004 Cr-Commit-Position: refs/heads/master@{#42756}
-
jarin authored
Revert of [turbofan] Enable escape analysis. (patchset #1 id:1 of https://codereview.chromium.org/2626013002/ ) Reason for revert: Temporarily turn off escape analysis to get a clean canary. Original issue's description: > [turbofan] Enable escape analysis. > > Review-Url: https://codereview.chromium.org/2626013002 > Cr-Commit-Position: refs/heads/master@{#42229} > Committed: https://chromium.googlesource.com/v8/v8/+/30176976e857d4eb84a93fface84849c44bab793 TBR=tebbi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2660063002 Cr-Commit-Position: refs/heads/master@{#42755}
-
machenbach authored
Revert of [stubs] KeyedLoadIC_Generic: prototype chain lookup support (patchset #2 id:20001 of https://codereview.chromium.org/2652213003/ ) Reason for revert: Speculative revert for breaking a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13113 Unfortunately, the test results archive is not giving much info this time. Original issue's description: > [stubs] KeyedLoadIC_Generic: prototype chain lookup support > > Performing lookups on the prototype chain in the stub avoids a > bunch of slow-path runtime calls. For now, only receivers with > dictionary-mode properties do this; fast-mode receivers will follow > if it's beneficial. > > Review-Url: https://codereview.chromium.org/2652213003 > Cr-Commit-Position: refs/heads/master@{#42751} > Committed: https://chromium.googlesource.com/v8/v8/+/82e10f5fbacbbd71bc65e99322f432470692bf41 TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2657393002 Cr-Commit-Position: refs/heads/master@{#42754}
-
jbroman authored
memcpy is faster than UTF-8 encoding/decoding. This yields 10-20% wins on serializing and deserializing long ASCII strings, according to blink_perf.bindings -- and these are already in a fast path where the entire string is known to be ASCII (but this has to be checked). The win may be larger for strings in Latin-1 but not ASCII (though I suspect this is an uncommon case). A change is also made to make ValueSerializerTest.EncodeTwoByteStringUsesPadding survive wire format version number changes. This is the first of a series of wire format changes from the previous Blink format. The deserializer continues to be able to read the old format, but Chromium M56 will no longer be able to read the messages written by this, in M58. BUG=chromium:686159 Review-Url: https://codereview.chromium.org/2658793004 Cr-Commit-Position: refs/heads/master@{#42753}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c3da457..3dada45 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/a7cc7a3..c302711 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/683b84f..9907db5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/dbc7572..0b3a445 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2659873003 Cr-Commit-Position: refs/heads/master@{#42752}
-
jkummerow authored
Performing lookups on the prototype chain in the stub avoids a bunch of slow-path runtime calls. For now, only receivers with dictionary-mode properties do this; fast-mode receivers will follow if it's beneficial. Review-Url: https://codereview.chromium.org/2652213003 Cr-Commit-Position: refs/heads/master@{#42751}
-
- 27 Jan, 2017 14 commits
-
-
lukasza authored
This is needed to insulate generated code from blink::protocol namespace from naming changes that we plan to do in the Great Blink Rename (which in particular will change wtf::StringBuilder::toString into ToString, and similarily will rename reserveCapacity and append methods). This CL also includes roll of inspector_protocol which starts to generate code that uses the new methods of StringUtil adapter: rolling third_party/inspector to 1a131872167f0f7653629326891aa3ec94417f27. BUG=683447 Review-Url: https://codereview.chromium.org/2660503002 Cr-Commit-Position: refs/heads/master@{#42750}
-
binji authored
Review-Url: https://codereview.chromium.org/2643723010 Cr-Commit-Position: refs/heads/master@{#42749}
-
bjaideep authored
Port 3f47c63d Original Commit Message: Previously, when restarting a frame, we would rewrite all frames between the debugger activation and the frame to restart to squash them, and replace the return address with that of a builtin to leave that rewritten frame, and restart the function by calling it. We now simply remember the frame to drop to, and upon returning from the debugger, we check whether to drop the frame, load the new FP, and restart the function. R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5587 LOG=N Review-Url: https://codereview.chromium.org/2663453004 Cr-Commit-Position: refs/heads/master@{#42748}
-
pfeldman authored
BUG=chromium:682521 Review-Url: https://codereview.chromium.org/2659913002 Cr-Commit-Position: refs/heads/master@{#42747}
-
julien.gilli authored
Previously (and still currently for some of them), post-mortem debugging tools were using StandardFrameConstants::kContextOffset as the offset to get the value that represents a frame's type. However since https://codereview.chromium.org/1696043002, a new, more general offset was introduced: CommonFrameConstants::kContextOrFrameTypeOffset. In order for post-mortem debugging tools to use this constant, it is included in the generated post-mortem metadata. R=danno@chromium.org,bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2655553006 Cr-Commit-Position: refs/heads/master@{#42746}
-
bjaideep authored
Port 69747e26 Original Commit Message: We turn a JSCallFunction node for f.apply(receiver, arguments) into a JSCallForwardVarargs node, when the arguments refers to the arguments of the outermost optimized code object, i.e. not an inlined arguments, and the apply method refers to Function.prototype.apply, and there's no other user of arguments except in frame states. We also replace the arguments node in the graph with a marker for the Deoptimizer similar to Crankshaft to make sure we don't materialize unused arguments just for the sake of deoptimization. We plan to replace this with a saner EscapeAnalysis based solution soon. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5267,v8:5726 LOG=N Review-Url: https://codereview.chromium.org/2656363002 Cr-Commit-Position: refs/heads/master@{#42745}
-
marja authored
This unifies the behavior of Scope::DeclareVariableName with Scope::DeclareVariable. BUG=v8:5516 Review-Url: https://codereview.chromium.org/2658063005 Cr-Commit-Position: refs/heads/master@{#42744}
-
machenbach authored
BUG=chromium:685561 NOTRY=true TBR=danno@chromium.org, kjellander@chromium.org Review-Url: https://codereview.chromium.org/2650383008 Cr-Commit-Position: refs/heads/master@{#42743}
-
marja authored
BUG=v8:5402 Review-Url: https://codereview.chromium.org/2663513002 Cr-Commit-Position: refs/heads/master@{#42742}
-
ivica.bogosavljevic authored
Some tests require a lot of memory and they fail on buildbots if they run in parallel with other tests of the same kind. We try to limit this by disabling multiple vairants of the same tests, assuming this would stop the failures in most of the cases. BUG= Review-Url: https://codereview.chromium.org/2653603002 Cr-Commit-Position: refs/heads/master@{#42741}
-
marja authored
These headers only need forward declarations. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2654253002 Cr-Commit-Position: refs/heads/master@{#42740}
-
marja authored
BUG=v8:5516 Review-Url: https://codereview.chromium.org/2659053002 Cr-Commit-Position: refs/heads/master@{#42739}
-
mstarzinger authored
This makes sure all use-site of {ObjectLiteral::constant_properties} are adapted to use the correct {BoilerplateDescription} type instead of just the {FixedArray} base type. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2659603003 Cr-Commit-Position: refs/heads/master@{#42738}
-
tebbi authored
R=mstarzinger@chromium.org BUG=chromium:683566 Review-Url: https://codereview.chromium.org/2653953010 Cr-Commit-Position: refs/heads/master@{#42737}
-