- 08 Mar, 2016 29 commits
-
-
mstarzinger authored
This adds the number of properties to be expected within the boilerplate object for object literals to the TurboFan IR. The reason is that this length can no longer be easily inferred from just the constants array. The length is potentially non-zero for empty object literals and might also diverge in the presence of constant functions or duplicate property names. For future safety and for symmetry reasons, the same change was applied to array literals as well, even though inferring the length from the constant elements is still possible there. R=verwaest@chromium.org BUG=chromium:593008 LOG=n Review URL: https://codereview.chromium.org/1772803003 Cr-Commit-Position: refs/heads/master@{#34594}
-
zhengxing.li authored
port 2aae579c (r34566) original commit message: In case when F tail calls G we should also remove the potential arguments adaptor frame for F. This CL introduces two new machine instructions ArchTailCallCodeObjectFromJSFunction and ArchTailCallJSFunctionFromJSFunction which (unlike existing ArchTailCallCodeObject and ArchTailCallJSFunction) also drop arguments adaptor frame if it exists right before jumping to the target function. BUG= Review URL: https://codereview.chromium.org/1777563002 Cr-Commit-Position: refs/heads/master@{#34593}
-
jyan authored
R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1768383002 Cr-Commit-Position: refs/heads/master@{#34592}
-
zhengxing.li authored
port ddc626e1 (r34546) original commit message: I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new operator takes 3 inputs, the low-word input, the high-word input, and the shift, and produces 2 output, the low-word output and the high-word output. At the moment I implemented the lowering only for ia32, but I think the CL is already big enough. I will add the other platforms in separate CLs. BUG= Review URL: https://codereview.chromium.org/1773083002 Cr-Commit-Position: refs/heads/master@{#34591}
-
zhengxing.li authored
port 22938040 (r34542) original commit message: HInvokeFunction and HApplyArguments instructions now support tail calling. Inlining of calls at tail position is not supported yet and therefore still disabled. The tail-call-megatest was modified so that the usages of "arguments" object do not disable Crankshaft. BUG= Review URL: https://codereview.chromium.org/1767343003 Cr-Commit-Position: refs/heads/master@{#34590}
-
mbrandy authored
Port 2aae579c Original commit message: In case when F tail calls G we should also remove the potential arguments adaptor frame for F. This CL introduces two new machine instructions ArchTailCallCodeObjectFromJSFunction and ArchTailCallJSFunctionFromJSFunction which (unlike existing ArchTailCallCodeObject and ArchTailCallJSFunction) also drop arguments adaptor frame if it exists right before jumping to the target function. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1773053002 Cr-Commit-Position: refs/heads/master@{#34589}
-
mbrandy authored
Port ddc626e1 Original commit message: I64Shl is lowered to a new turbofan operator, WasmWord64Shl. The new operator takes 3 inputs, the low-word input, the high-word input, and the shift, and produces 2 output, the low-word output and the high-word output. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1765383004 Cr-Commit-Position: refs/heads/master@{#34588}
-
titzer authored
R=ahaas@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1770383002 Cr-Commit-Position: refs/heads/master@{#34587}
-
ahaas authored
I removed some stale comments and added a missing unit test. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1772843003 Cr-Commit-Position: refs/heads/master@{#34586}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1774943002 Cr-Commit-Position: refs/heads/master@{#34585}
-
verwaest authored
BUG=chromium:592707 LOG=n Review URL: https://codereview.chromium.org/1775913002 Cr-Commit-Position: refs/heads/master@{#34584}
-
yangguo authored
Previously, the assertion does not include code executed in the custom heap snapshot. TBR=hablich@chromium.org BUG=v8:4810 LOG=N Review URL: https://codereview.chromium.org/1771313002 Cr-Commit-Position: refs/heads/master@{#34583}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1768203002 Cr-Commit-Position: refs/heads/master@{#34582}
-
ahaas authored
R=titzer@chromium.org Review URL: https://codereview.chromium.org/1770333002 Cr-Commit-Position: refs/heads/master@{#34581}
-
mythria authored
BailoutId points to the next bytecode in the bytecode array. Code offset is set to one less than the bail out id. This would point to the end of the current instruction. Since we use it only for summarizing the frame and to compute the source position, it should be safe to set it to the end of current instruction. BUG=v8:4280, v8:4689 LOG=N Review URL: https://codereview.chromium.org/1763783003 Cr-Commit-Position: refs/heads/master@{#34580}
-
mstarzinger authored
This is a pure refactoring and renaming of methods in the compiler API with the goal to increase readability. Also the compiler API is moved to the top of the file, as it is the central piece in that file. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1766623004 Cr-Commit-Position: refs/heads/master@{#34579}
-
machenbach authored
This adds sanitizer-coverage compilation, test-runner features and post processing. Sanitizer coverage is expected to be used together with asan. During test runner execution, the produced sancov files are disambiguated and match the pattern: <executable name>.test.<test id>.sancov. Two additional scripts are added for merging raw sancov files and for generating json data containing all instrumented lines + all covered lines from merged sancov files. Both scripts use multiprocessing for speed. The json data will later be uploaded to google storage for further use, e.g. to show coverage data in rietveld. Sancov documentation: http://clang.llvm.org/docs/SanitizerCoverage.html BUG=chromium:568949 LOG=n NOTRY=true TEST=python -m unittest sancov_formatter_test TEST=python -m unittest sancov_merger_test Review URL: https://codereview.chromium.org/1737263003 Cr-Commit-Position: refs/heads/master@{#34578}
-
mstarzinger authored
This changes the compiler API that finalizes a previously queued optimization job on the main thread, to not deal with code objects directly. This is in sync with the rest of the API now. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1773663003 Cr-Commit-Position: refs/heads/master@{#34577}
-
danno authored
Review URL: https://codereview.chromium.org/1776593002 Cr-Commit-Position: refs/heads/master@{#34576}
-
neis authored
R=adamk@chromium.org BUG= Review URL: https://codereview.chromium.org/1767063002 Cr-Commit-Position: refs/heads/master@{#34575}
-
mstarzinger authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1777473002 Cr-Commit-Position: refs/heads/master@{#34574}
-
yangguo authored
R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e Cr-Commit-Position: refs/heads/master@{#34569} Review URL: https://codereview.chromium.org/1770773002 Cr-Commit-Position: refs/heads/master@{#34573}
-
mstarzinger authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1773593002 Cr-Commit-Position: refs/heads/master@{#34572}
-
danno authored
Before this CL, various code stubs used different techniques for marking their frames to enable stack-crawling and other access to data in the frame. All of them were based on a abuse of the "standard" frame representation, e.g. storing the a context pointer immediately below the frame's fp, and a function pointer after that. Although functional, this approach tends to make stubs and builtins do an awkward, unnecessary dance to appear like standard frames, even if they have nothing to do with JavaScript execution. This CL attempts to improve this by: * Ensuring that there are only two fundamentally different types of frames, a "standard" frame and a "typed" frame. Standard frames, as before, contain both a context and function pointer. Typed frames contain only a minimum of a smi marker in the position immediately below the fp where the context is in standard frames. * Only interpreted, full codegen, and optimized Crankshaft and TurboFan JavaScript frames use the "standard" format. All other frames use the type frame format with an explicit marker. * Typed frames can contain one or more values below the type marker. There is new magic macro machinery in frames.h that simplifies defining the offsets of these fields in typed frames. * A new flag in the CallDescriptor enables specifying whether a frame is a standard frame or a typed frame. Secondary register location spilling is now only enabled for standard frames. * A zillion places in the code have been updated to deal with the fact that most code stubs and internal frames use the typed frame format. This includes changes in the deoptimizer, debugger, and liveedit. * StandardFrameConstants::kMarkerOffset is deprecated, (CommonFrameConstants::kContextOrFrameTypeOffset and StandardFrameConstants::kFrameOffset are now used in its stead). LOG=N Review URL: https://codereview.chromium.org/1696043002 Cr-Commit-Position: refs/heads/master@{#34571}
-
yangguo authored
Revert of [interpreter, debugger] add some missing statement positions. (patchset #1 id:1 of https://codereview.chromium.org/1770773002/ ) Reason for revert: failing tests with ignition. Original issue's description: > [interpreter, debugger] add some missing statement positions. > > R=rmcilroy@chromium.org, vogelheim@chromium.org > BUG=v8:4690 > LOG=N > > Committed: https://crrev.com/4a7722c9930a42ba0e8feeece286d74834211a7e > Cr-Commit-Position: refs/heads/master@{#34569} TBR=rmcilroy@chromium.org,vogelheim@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4690 Review URL: https://codereview.chromium.org/1772293002 Cr-Commit-Position: refs/heads/master@{#34570}
-
yangguo authored
R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1770773002 Cr-Commit-Position: refs/heads/master@{#34569}
-
v8-autoroll authored
Rolling v8/build/gyp to 61259d585ce99d9de8b35188cd0025bdbcb58411 Rolling v8/tools/clang to 7f949627a42e2b8b229522ab74de5b1b6a1ced3e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1768263003 Cr-Commit-Position: refs/heads/master@{#34568}
-
caitpotter88 authored
When possible (non-Proxy receiver, expecting only String-names), walk the instance_descriptors() array rather than performing [[OwnPropertyKeys]]. If the map changes during a call to an accessor property, resort to a slower property lookup. For now, the fast path is not taken if the object contains any element keys. Offers a measurable improvement over the existing version, in select situations. BUG=v8:4663 LOG=N R=cbruni@chromium.org, verwaest@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1751643003 Cr-Commit-Position: refs/heads/master@{#34567}
-
ishell authored
In case when F tail calls G we should also remove the potential arguments adaptor frame for F. This CL introduces two new machine instructions ArchTailCallCodeObjectFromJSFunction and ArchTailCallJSFunctionFromJSFunction which (unlike existing ArchTailCallCodeObject and ArchTailCallJSFunction) also drop arguments adaptor frame if it exists right before jumping to the target function. BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1702423002 Cr-Commit-Position: refs/heads/master@{#34566}
-
- 07 Mar, 2016 11 commits
-
-
titzer authored
R=dschuff@chromium.org BUG= Review URL: https://codereview.chromium.org/1767203002 Cr-Commit-Position: refs/heads/master@{#34565}
-
titzer authored
Local declarations were previously encoded as an optional set of 4 uint16 values as part of the function declaration. This CL implements the current design of moving these declarations to a list of pairs of (type, count) that is part of the body. R=bradnelson@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1763433002 Cr-Commit-Position: refs/heads/master@{#34564}
-
mbrandy authored
Port 22938040 Original commit message: HInvokeFunction and HApplyArguments instructions now support tail calling. Inlining of calls at tail position is not supported yet and therefore still disabled. The tail-call-megatest was modified so that the usages of "arguments" object do not disable Crankshaft. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Review URL: https://codereview.chromium.org/1767173002 Cr-Commit-Position: refs/heads/master@{#34563}
-
yangguo authored
R=littledan@chromium.org BUG=v8:4743 LOG=N Committed: https://crrev.com/22f6735ccbe2e341d341e61b9c38ce308b8da655 Cr-Commit-Position: refs/heads/master@{#34553} Review URL: https://codereview.chromium.org/1774513002 Cr-Commit-Position: refs/heads/master@{#34562}
-
adamk authored
Simply call InitializeForOfStatement (split out from InitializeForEachStatement) instead, which already has all the necessary logic. As part of this, trade one bool arg (is_destructuring) for an int (iterable_pos). Review URL: https://codereview.chromium.org/1740293002 Cr-Commit-Position: refs/heads/master@{#34561}
-
verwaest authored
This avoids a minor unnecessary inefficiency (GetRoot) in setting up the LookupIterator. BUG= Review URL: https://codereview.chromium.org/1767123002 Cr-Commit-Position: refs/heads/master@{#34560}
-
titzer authored
R=ahaas@chromium.org,binji@chromium.org BUG= Review URL: https://codereview.chromium.org/1770913002 Cr-Commit-Position: refs/heads/master@{#34559}
-
cbruni authored
Introducing the KeyAccumulator accidentally removed some crucial fast-paths. This CL starts rewriting the KeyAccumulator, step-by-step introducing the special cases again. BUG=chromium:545503, v8:4758 LOG=y Committed: https://crrev.com/9c61327ecb2ee41f34232632e0cac93202bae6b7 Cr-Commit-Position: refs/heads/master@{#34532} Committed: https://crrev.com/b954c872aac60657b400079b7333216ea658dc8a Cr-Commit-Position: refs/heads/master@{#34548} Review URL: https://codereview.chromium.org/1707743002 Cr-Commit-Position: refs/heads/master@{#34558}
-
ahaas authored
Implementation of https://codereview.chromium.org/1756863002 on arm. R=titzer@chromium.org, v8-arm-ports@googlegroups.com Review URL: https://codereview.chromium.org/1765973002 Cr-Commit-Position: refs/heads/master@{#34557}
-
caitpotter88 authored
Add microbenchmark for these methods. BUG=v8:4663 LOG=N R=adamk@chromium.org, littledan@chrommium.org Review URL: https://codereview.chromium.org/1746383003 Cr-Commit-Position: refs/heads/master@{#34556}
-
ulan authored
Since we record slots for weak list fields, there is no need to iterate over them after evacuation. We just need to update the roots for which we didn't record slots. This speeds up the evacuate_update_pointers_weak phase by ~2.5x. BUG= Review URL: https://codereview.chromium.org/1772803002 Cr-Commit-Position: refs/heads/master@{#34555}
-