- 05 Jun, 2020 24 commits
-
-
Dan Elphick authored
This reverts commit 81c34968 and also 490f3580 which depends on the former. Reason for revert: Break CFI tests in chromium https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/17438 Original change's description: > [heap] Make ReadOnlySpace use bump pointer allocation > > This changes ReadOnlySpace to no longer be a PagedSpace but instead it > is now a BaseSpace. BasicSpace is a new base class that Space inherits > from and which has no allocation methods and does not dictate how the > pages should be held. > > ReadOnlySpace unlike Space holds its pages as a > std::vector<ReadOnlyPage>, where ReadOnlyPage directly subclasses > BasicMemoryChunk, meaning they do not have prev_ and next_ pointers and > cannot be held in a heap::List. This is desirable since with pointer > compression we would like to remap these pages to different memory > addresses which would be impossible with a heap::List. > > Since ReadOnlySpace no longer uses most of the code from the other > Spaces it makes sense to simplify its memory allocation to use a simple > bump pointer and always allocate a new page whenever an allocation > exceeds the remaining space on the final page. > > Change-Id: Iee6d9f96cfb174b4026ee671ee4f897909b38418 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209060 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68137} TBR=ulan@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I68c9834872e55eb833be081f8ff99b786bfa9894 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232552 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68211}
-
Camillo Bruni authored
- remove redundant checks - use switch over PromiseHookType Change-Id: I89a5328009634a7025feb77e22334773c2886868 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224225Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68210}
-
Bill Budge authored
- Use a shorter code sequence for the most likely case (no NaNs or signed 0 errors), and use out-of-line code to handle those cases. - For the likely execution paths, F32x4Min goes from 8 to 6 instructions, while F32x4Max goes from 9 to 6 instructions. - Code size increases by 2 and 3 instructions (the test and branch, and for max, an extra move. Bug: v8:8639 Change-Id: I7966f652c89545e840ae493f25dd652b1e079b91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231653Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#68209}
-
Camillo Bruni authored
- Show map description for selected maps - More instructions for detailed investigation Change-Id: Ia07e847c20cafc52160310c7a358004330d22094 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231356Reviewed-by:
-
Gus Caplan authored
This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Free memory is marked as inaccessible, which means that it contains a zap value and is poisoned in ASAN builds. Before writing the unlinked sentinel, we must unpoison the memory area in ASAN builds. Bug: chromium:1056170 Change-Id: Ib253913cce7d62e1000d4b581bdeb13a1e19cc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232541 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68206}
-
Michael Lippautz authored
The observers can use ResetAllocatedObjectSize() to e.g. implement a growing strategy that resets its limit on this call. Bug: chromium:1056170 Change-Id: Ib9553e00cc530ff89f44e4258c13d47f0b70568e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228885Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Clemens Backes authored
The wasm interpreter was always single-threaded, and there are no plans to change this. Still, there was a concept of threads, but with the hard-coded constraint that there is always exactly one of them. In order to clean up the code, and as a preparation to remove more unneeded functionality before moving the interpreter over to the test directory, this CL removes the concept of threads and merges the {ThreadImpl} class into {WasmInterpreterInternals}. Drive-by: Remove the dead {GetFrameCount} method. R=ahaas@chromium.org Bug: v8:10389 Change-Id: If65cdd21b34ce8debf8ba0f24dbeacec15e0a1d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231354Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68204}
-
Tamer Tas authored
This CL fixes the UnboundLocalError in unittests testsuite. R=machenbach@chromium.org Bug: chromium:1091200 Change-Id: I9a4e032915b2750c28e3eb9f97042b75ca547801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232540 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68203}
-
Andreas Haas authored
R=v8-arm-ports@googlegroups.com, clemensb@chromium.org Bug: v8:10108 Change-Id: I22dce431b8aadf25072288ecd38daa2cde029919 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231351 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68202}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I1e168f967acf0e4d6094106c0693e1a10f409f49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231357 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Clemens Backes authored
Most interface calls are preceded by a reachability check, such that we only generate code if the current instruction is actually reachable. This is particularly important for Liftoff (TurboFan would throw out dead parts of the graph anyway). In order to speed up this check, this CL introduces a boolean flag directly on the {WasmFullDecoder}. This avoids checking whether an error has been set *plus* checking the reachability of the top-most control block. This provides 5-6% speedup on Liftoff compilation locally. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: Idcff623fb9c23473b06ebf91b3caee65cc6ca28b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230521Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68200}
-
Dominik Inführ authored
Prevent deadlock on shutdown by allowing all allocations on background threads after tear down was started. Background threads need the main thread to perform the collection, which never happens when V8 is already shutting down. Bug: v8:10315 Change-Id: I5d3358229624aead7b0ebcfee7e5840315f23329 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230537 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Arnaud Robin authored
Added display of identation, function index, function names and compiler used when tracing function calls in wasm. R=clemensb@chromium.org Bug: v8:10559 Change-Id: I58b4e7b077365bdee7bae9b5ad8a50178c322147 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230532 Commit-Queue: Arnaud Robin <arobin@google.com> Reviewed-by:
-
Igor Sheludko authored
1) make it possible to combine tracing logic with accounting allocator supporting zone compression, 2) make it possible to record zone memory usage via Chrome tracing machinery (especially, for already running process), 3) trace both allocated and actually used memory per zone, Bug: v8:10572 Change-Id: I768e474ada1a384218af09efd0dfce2d9a43ac3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228888 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68197}
-
Manos Koukoutos authored
Changes: - Unpack packed typed in arrays/structs where needed. - i8 should have log-size 0. - Use typed-funcref feature flag instead of gc where appropriate. - Set argument indexes correctly for gc opcodes in function-body-decoder. - Remove no-longer valid TODOs. Bug: v8:7748 Change-Id: I1a73794d0f93da6c7177e496d47df4106031f0eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230520 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Change-Id: I31e16fcfd6641d88b3b6d3195dc30464833d0821 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231345 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=v8-arm-ports@googlegroups.com, clemensb@chromium.org Bug: v8:10108 Change-Id: I7564caaf0d6c1591270b59e275869f335c83ad74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230533 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Add method to make LABs in all local heaps iterable and invoke this function in Heap::MakeHeapIterable(). Bug: v8:10315 Change-Id: I6c8b1ea2337647f68995c13e6244d5ef0673b0e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230534Reviewed-by:
-
Manos Koukoutos authored
Changes: - Remove subtyping checks from value-type.h and move them to dedicated files. Leave a limited version in value-type.h for testing. - Implement subtyping for struct and array types, according to the wasm-gc proposal. - Implement type equivalence checking. - Introduce a subtyping relation cache in WasmModule. - Rename IsSubTypeOf -> IsSubtypeOf. - Fix v8 possible bug where iterator_range took two unused type parameters. - Add unittests for subtyping. Bug: v8:7748 Change-Id: I0ddbda4145e0412196dcf4fc63f3c5875fb3ab5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228497 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68192}
-
Georg Neis authored
The replacement was done using the wrong effect node. Bug: chromium:1086890 Change-Id: I3bfc2473415f7d28fa1bcf0ff14ffe46b82bf87b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231340Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68191}
-
Andreas Haas authored
Due to recent spec changes, We do not have to check if ref.func instructions in global declarations only refer to declared functions. Additionally functions referenced in exports and globals are now considered declared. R=ecmziegler@chromium.org Bug: v8:10556 Change-Id: I79856c7d68155a04eb36769ceed8a58fe62a9f9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228653 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#68190}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdb409c..3142ebd Rolling v8/third_party/aemu-linux-x64: t4ELE6VgcCM5v-3W7_Dv8jFHkyeEu69AW5lwrtqWBOwC..ij0nEFLmrqJqEp81i5YIDjeQ8epXhPrtAI0otT1OId0C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/15d5f65..92c6c3e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e65444f..02dbd01 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/59c0072..fab9ca5 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/90c5e17..4c095d0 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2259439af5cd553d8176d246f7897a9616412e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230852Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68189}
-
Yu Yin authored
All these functions need to do is just write the value to the memory, but EmitHelper will do something more than this, EmitHelper will check if it need generate trampoline code while code generating and it will insert trampoline code at current pc offset, this means there maybe have trampoline code between two consecutive dd()'s target memory(pc), this is not we want. Change-Id: I5537f133be78aabdc4d53d4de07f388fa50f4a64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2224963 Commit-Queue: Yu Yin <xwafish@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68188}
-
- 04 Jun, 2020 16 commits
-
-
Ng Zhi An authored
Bug: v8:10506 Change-Id: Ied4935b559f7298fd3d20f1a9e173ce9e7f8d96c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230788Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68187}
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I24f70dc1f6fb227185b6f8ecb30a81e218dd2a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2223232Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68186}
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ib3cd899d343e50c6c59702cab7ed6aa1df6a11ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227622Reviewed-by:
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ifb818b8aca4c5f148a3fd21acc2d1d4a2b5c43be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227624Reviewed-by:
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: I4416c2bfec08474b805395b95b58a877ddbdb2fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228410Reviewed-by:
-
Seth Brenith authored
This change also removes the kInvalid value from JSRegExp::Flag, so that the values in JSRegExp::Flag correspond only to those which can exist on the heap and not things used temporarily during parsing. Change-Id: I1ded0b1be8c59eab72320edfef26eda42c91a89f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2216302Reviewed-by:
-
Nico Hartmann authored
Speculative BigInt addition fails to throw the expected exception when called with non-BigInt inputs when the result of the computation is unused. In paricular, this CL does: - Remove kNoThrow on speculative BigInt operators - Fix AddWithFeedback to not lose type feedback if builtin throws to elide existing deopt loops - Add handling of TypeCheckKind in RepresentationChanger where this was previously ignored Bug: chromium:1073440 Change-Id: I953a5b790fc3b37a6824f0b6546a0488c51fbb3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228493Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68181}
-
Tobias Tebbi authored
When accessing a field of a non-class type, Torque will generate a CallAccess LocationReference, which has an unknown type. We still tried to access it's type, resulting in a DCHECK failure. Bug: v8:7793 Change-Id: I3650643e29db852783eca1e166b700eebd1b8dc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209056 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Victor Gomes authored
Change-Id: I14632106886f78286034a2624f77cab9dac14b41 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219927Reviewed-by:
-
Andreas Haas authored
Bug: chromium:1084929 Change-Id: I9389a44c93c90ef6beb543e5dc15860e9aa6a338 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230526Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68178}
-
Nico Hartmann authored
This reverts commit 63e243a0. Reason for revert: Speculative revert for https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/31811? Original change's description: > [wasm] Do not log code of functions whose module is not fully loaded > > Under some circumstances, Wasm is trying to log code for which the > wire bytes are not fully loaded yet. This can happen during streaming > compilation when a few functions are already fully compiled but the > engine is still streaming the remaining functions. > > If the profiler now kicks in, it will attempt to log these freshly > compiled functions. As these functions will not be executed before > the module is fully compiled, we can simply defer the logging in this > case. > > R=clemensb@chromium.org > > Bug: chromium:1085852 > Change-Id: Idb1061cafcba7a2a654a207402dca520f79a3bbe > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219938 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68174} TBR=clemensb@chromium.org,ecmziegler@chromium.org Change-Id: I444c70e63b876b8473bf9599643bdfe39c8f1eae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1085852 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230531Reviewed-by:
-
Victor Gomes authored
The flag will be used to upload changes towards the removal of arguments adaptor frame, by reversing the JS arguments in the stack. Change-Id: Ia41f740d9fac51a072487733d387390e69574cfb Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230525 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
Fix arguments order when a call to a CPP builtin is inlined. When V8_REVERSE_JSARGS is set, the arguments should be reversed and the extra builtin parameters should be pushed last, that is, the input nodes should be located before the function arguments. Change-Id: Icfcee15bf9e596b236bfd2615a73ce101c87857d Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218289 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Emanuel Ziegler authored
Under some circumstances, Wasm is trying to log code for which the wire bytes are not fully loaded yet. This can happen during streaming compilation when a few functions are already fully compiled but the engine is still streaming the remaining functions. If the profiler now kicks in, it will attempt to log these freshly compiled functions. As these functions will not be executed before the module is fully compiled, we can simply defer the logging in this case. R=clemensb@chromium.org Bug: chromium:1085852 Change-Id: Idb1061cafcba7a2a654a207402dca520f79a3bbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219938Reviewed-by:
-
Dominik Inführ authored
Introduce ParkedMutexGuard which is similar to base::MutexGuard but also parks the LocalHeap while the thread is blocked. Bug: v8:10315 Change-Id: I149673511df013881ed2fbb42cf22d3f9b17b92d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230518 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Introduce --stress-concurrent-allocation flag. With this flag, V8 will run periodically start an allocation background task, which allocates objects. Will be used for testing background allocation. Bug: v8:10315 Change-Id: Iddb7ff34601a492bc2f26f41cc56a2a899807cfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228889Reviewed-by:
-
