- 02 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js. There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs. Drive by: debugger-script.js and usage of debugger context in inspector code base. R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: v8:5510,chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7 Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47091}
-
- 29 Mar, 2017 1 commit
-
-
kozyatinskiy authored
We need to split creating of console and installing memory getter and remove console.assert hack before migration to builtin. We can implement super fast console.assert after migration. BUG=chromium:588893 R=dgozman@chromium.org TBR=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2781883003 Cr-Commit-Position: refs/heads/master@{#44256}
-
- 23 Nov, 2016 3 commits
-
-
kozyatinskiy authored
New console.assert implementation is faster then custom user implementation. BUG=chromium:663845 R=dgozman@chromium.org Committed: https://crrev.com/f658e41d864267fb9e99ea76faa7758b0b63d5c9 Review-Url: https://codereview.chromium.org/2505493002 Cr-Original-Commit-Position: refs/heads/master@{#41227} Cr-Commit-Position: refs/heads/master@{#41232}
-
machenbach authored
Revert of [inspector] make console.assert much faster (patchset #3 id:40001 of https://codereview.chromium.org/2505493002/ ) Reason for revert: Speculative revert as there seems to be a layout test crash: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/11585 Please reland if it doesn't get green. Original issue's description: > [inspector] make console.assert much faster > > New console.assert implementation is faster then custom user implementation. > > BUG=chromium:663845 > R=dgozman@chromium.org > > Committed: https://crrev.com/f658e41d864267fb9e99ea76faa7758b0b63d5c9 > Cr-Commit-Position: refs/heads/master@{#41227} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:663845 Review-Url: https://codereview.chromium.org/2521323005 Cr-Commit-Position: refs/heads/master@{#41231}
-
kozyatinskiy authored
New console.assert implementation is faster then custom user implementation. BUG=chromium:663845 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2505493002 Cr-Commit-Position: refs/heads/master@{#41227}
-
- 22 Nov, 2016 1 commit
-
-
jgruber authored
* Fix setting script-scope variables through inspector by internalizing their names. * Reconstruct values of Number, String, and Boolean classes. * Adapt a couple of tests for API restrictions. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2512963002 Cr-Commit-Position: refs/heads/master@{#41175}
-
- 21 Nov, 2016 1 commit
-
-
jgruber authored
Adapted various tests to restrictions of inspector protocol: * osr-typing-debug-change: Don't set function variable value. * debug-evaluate-locals: Add variable introduced by eval, run typeof inside evaluate(). * regress-419663: Don't set duplicate breakpoints. * regress-crbug-465298: Compare against function name instead of value. * regress-crbug-621361: Make evaluate return string results. * debug-script: Various counts were off due to new way tests are called. Added new inspector script type. Breakpoints now contain the actual break position, and remote object reconstruction has been extended a bit. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2505363002 Cr-Commit-Position: refs/heads/master@{#41129}
-
- 11 Oct, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org BUG=v8:5049, v8:5086 Review-Url: https://codereview.chromium.org/2402363002 Cr-Commit-Position: refs/heads/master@{#40149}
-
- 31 May, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2026643003 Cr-Commit-Position: refs/heads/master@{#36610}
-
- 05 Feb, 2016 2 commits
-
-
yangguo authored
NOTRY=true TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1668393004 Cr-Commit-Position: refs/heads/master@{#33772}
-
yangguo authored
R=bmeurer@chromium.org, domenic@chromium.org Review URL: https://codereview.chromium.org/1670923003 Cr-Commit-Position: refs/heads/master@{#33770}
-
- 12 Jan, 2016 3 commits
-
-
bmeurer authored
This migrates the remaining Date builtins to C++ and removes obsolete intrinsics and JavaScript wrappers. This reduces the overhead imposed by the Date builtins, and will allow us to optimize them later in the TurboFan compiler, while the interpreter doesn't need to worry about them. R=yangguo@chromium.org BUG=chromium:576574 LOG=n Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281 Cr-Commit-Position: refs/heads/master@{#33228} Review URL: https://codereview.chromium.org/1579613002 Cr-Commit-Position: refs/heads/master@{#33231}
-
machenbach authored
Revert of [builtins] Refactor the remaining Date builtins. (patchset #2 id:20001 of https://codereview.chromium.org/1579613002/ ) Reason for revert: [Sheriff] Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/5711 Original issue's description: > [builtins] Refactor the remaining Date builtins. > > This migrates the remaining Date builtins to C++ and removes obsolete > intrinsics and JavaScript wrappers. This reduces the overhead imposed > by the Date builtins, and will allow us to optimize them later in the > TurboFan compiler, while the interpreter doesn't need to worry about > them. > > R=yangguo@chromium.org > BUG=chromium:576574 > LOG=n > > Committed: https://crrev.com/1e51af1a5c80b1650de47dd4bc8f846fa2d85281 > Cr-Commit-Position: refs/heads/master@{#33228} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:576574 Review URL: https://codereview.chromium.org/1574223002 Cr-Commit-Position: refs/heads/master@{#33230}
-
bmeurer authored
This migrates the remaining Date builtins to C++ and removes obsolete intrinsics and JavaScript wrappers. This reduces the overhead imposed by the Date builtins, and will allow us to optimize them later in the TurboFan compiler, while the interpreter doesn't need to worry about them. R=yangguo@chromium.org BUG=chromium:576574 LOG=n Review URL: https://codereview.chromium.org/1579613002 Cr-Commit-Position: refs/heads/master@{#33228}
-
- 20 Oct, 2015 1 commit
-
-
mvstanton authored
The problem is that the gc pattern is different, and the list of debug scripts may have more or less duplicates than before. The solution is to just turn off --stress-opt for the test. R=yangguo@chromium.org BUG=v8:4502 LOG=N Review URL: https://codereview.chromium.org/1416883002 Cr-Commit-Position: refs/heads/master@{#31415}
-
- 16 Jun, 2015 1 commit
-
-
yangguo authored
This invariant will save us some head ache. The changes to test-debug/DebugStub is due to the fact that it abuses the ability to set break points in code that has no debug break slots. This is now no longer possible. R=ulan@chromium.org BUG=v8:4132 LOG=N Review URL: https://codereview.chromium.org/1181013007 Cr-Commit-Position: refs/heads/master@{#29038}
-
- 21 May, 2015 1 commit
-
-
yangguo authored
Also changed string.js and math.js to adapt this change. R=jkummerow@chromium.org Committed: https://crrev.com/e25058b0b7b9831162579564fc8935d568c1ecdd Cr-Commit-Position: refs/heads/master@{#28521} Review URL: https://codereview.chromium.org/1143993003 Cr-Commit-Position: refs/heads/master@{#28533}
-
- 11 May, 2015 1 commit
-
-
machenbach authored
Revert of Add the concept of a V8 extras exports object (patchset #5 id:80001 of https://codereview.chromium.org/1128113006/) Reason for revert: [Sheriff] Causes gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2167 Original issue's description: > Add the concept of a V8 extras exports object > > Exposed to the extras as extrasExports (on the builtins object), on > which they can put things that should be accessible from C++. Exposed > to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). > > Adding a test (in test-api.cc) required adding a simple extra, > test-extra.js, which we build into the standalone builds. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 > Cr-Commit-Position: refs/heads/master@{#28317} TBR=jochen@chromium.org,yangguo@chromium.org,domenic@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1127313005 Cr-Commit-Position: refs/heads/master@{#28332}
-
- 08 May, 2015 1 commit
-
-
domenic authored
Exposed to the extras as extrasExports (on the builtins object), on which they can put things that should be accessible from C++. Exposed to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). Adding a test (in test-api.cc) required adding a simple extra, test-extra.js, which we build into the standalone builds. R=yangguo@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1128113006 Cr-Commit-Position: refs/heads/master@{#28317}
-
- 16 Jan, 2015 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/856793002 Cr-Commit-Position: refs/heads/master@{#26110}
-
- 28 Nov, 2014 3 commits
-
-
dslomov authored
R=rossberg@chromium.org TBR=hpayer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/d6285620868b15c84eb9affa59f6b4e869f074b8 Review URL: https://codereview.chromium.org/763273002 Cr-Commit-Position: refs/heads/master@{#25577}
-
dslomov authored
Revert of Introduce a kill-switch for shipping features. (patchset #2 id:20001 of https://codereview.chromium.org/763273002/) Reason for revert: Reverted for breaking nosnap: http://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20nosnap/builds/1003/steps/Check/logs/Threading3 Original issue's description: > Introduce a kill-switch for shipping features. > > R=rossberg@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/d6285620868b15c84eb9affa59f6b4e869f074b8 TBR=rossberg@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/763353002 Cr-Commit-Position: refs/heads/master@{#25574}
-
Dmitry Lomov authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/763273002 Cr-Commit-Position: refs/heads/master@{#25570}
-
- 20 Oct, 2014 1 commit
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org BUG=v8:3640 LOG=N Review URL: https://codereview.chromium.org/642233003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2014 1 commit
-
-
wingo@igalia.com authored
R=rossberg@chromium.org BUG=v8:2355 LOG=Y Review URL: https://codereview.chromium.org/573963003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23974 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Aug, 2014 1 commit
-
-
wingo@igalia.com authored
This enables for-of, as well as @@iterator implementations for strings and arrays. R=rossberg@chromium.org BUG=v8:2214 LOG=Y Review URL: https://codereview.chromium.org/446023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22980 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Aug, 2014 3 commits
-
-
yangguo@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/448643002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22923 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts r22918 and r22920. TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/448633002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=jochen@chromium.org, rtoy@chromium.org, svenpanne@chromium.org BUG=v8:3006 LOG=N Review URL: https://codereview.chromium.org/411263004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22918 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-collections flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. Depends on ES6 Symbols: https://codereview.chromium.org/421313004 BUG=v8:1622 LOG=Y R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/427723002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 2 commits
-
-
adamk@chromium.org authored
This approach, of allowing either N or N+1 in this assert, is the same approach used before my Symbols patch that naively changed to use assertEquals. TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/439833002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22834 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
adamk@chromium.org authored
In doing so also remove all references to the --harmony-symbols flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default. BUG=v8:2158 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/421313004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2014 1 commit
-
-
rossberg@chromium.org authored
R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/266243003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
jochen@chromium.org authored
> R=mstarzinger@chromium.org > BUG= > > Committed: https://code.google.com/p/v8/source/detail?r=20211 > > Review URL: https://codereview.chromium.org/206163004 R=rossberg@chromium.org TBR=rossberg@chromium.org LOG=y BUG=n Review URL: https://codereview.chromium.org/219303002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20211 Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20313 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
Reason: breaks Blink layout tests. R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/210853003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/206163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Mar, 2014 1 commit
-
-
adamk@chromium.org authored
This re-re-re-lands enabling Object.observe. The Chromium tests that failed last time this was rolled into Chromium have been disabled in https://src.chromium.org/viewvc/chrome?view=revision&revision=256706 This patch should be safe to merge once that lands. BUG=v8:2409 LOG=Y TBR=rossberg@chromium.org,dslomov@chromium.org,rafaelw@chromium.org Review URL: https://codereview.chromium.org/198383002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Mar, 2014 1 commit
-
-
dslomov@chromium.org authored
This reverts commit r19734 for breeaking ChromiumOS browser tests. 'OpenSpecialTypes/FileManagerBrowserTest.Test/3' started to time out, bisecting the roll led to this change. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22224 TBR=rafaelw@chromium.org,rossberg@chromium.org BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/195123005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19816 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2014 1 commit
-
-
rafaelw@chromium.org authored
Original Issue: https://codereview.chromium.org/183683022/ TBR=rossberg BUG=v8:2409 LOG=Y Review URL: https://codereview.chromium.org/189513010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-