- 04 Mar, 2015 23 commits
-
-
arv authored
Function name property is now standardized in ES6. It was a Mozilla proprietary extension before. With ES6, the property was made configurable, so that it can be used instead of another proprietary property, displayName. This is a revert of revert https://chromium.googlesource.com/v8/v8.git/+/c791d8411225aa95518c880defd9a5b1ea243afc. Last time this broke a Chrome browser test which has since been updated: https://chromium.googlesource.com/chromium/src/+/5f75a3be4c9334aba627d6c5eb884adf965e1d78 BUG=v8:3333 LOG=N R=mstarzinger@chromium.org,verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/977003004 Cr-Commit-Position: refs/heads/master@{#26996}
-
balazs.kilvady authored
Port a820568b Each call to emit_32 uses 5 constant pool slots: * the "emit_32" string * undefined (the receiver) * the argument (heap number) * the load IC * the call IC This change cuts that down 20% to 4, by loading the undefined from the heap roots. BUG= Review URL: https://codereview.chromium.org/963193005 Cr-Commit-Position: refs/heads/master@{#26995}
-
yangguo authored
If we use HashMap::Lookup with insert=true, the returned entry may have NULL as value. This could either mean that the value is 0, or that the entry has just been inserted. This ambiguity can cause false negatives in PartialCacheIndexMap::LookupOrInsert. Also fix a TODO. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/974273002 Cr-Commit-Position: refs/heads/master@{#26994}
-
jarin authored
BUG= Review URL: https://codereview.chromium.org/961973002 Cr-Commit-Position: refs/heads/master@{#26993}
-
yangguo authored
Experimental globals are simply flag values on the builtins object to turn on/off harmony features. We still need to declare them even when we don't turn on harmony features for the snapshot. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/978813002 Cr-Commit-Position: refs/heads/master@{#26992}
-
jarin authored
Removing and fixing some embarrassing stuff in js-typed-lowering. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/981533003 Cr-Commit-Position: refs/heads/master@{#26991}
-
balazs.kilvady authored
BUG= Review URL: https://codereview.chromium.org/975383002 Cr-Commit-Position: refs/heads/master@{#26990}
-
mstarzinger authored
This makes sure that the implicit exception edges in the graph pass the correct exception object and also fixes a bug in the dominance relationship of the value entering the finally block and it's uses. R=jarin@chromium.org TEST=cctest/test-run-jsexceptions/FinallyBreak Review URL: https://codereview.chromium.org/970253002 Cr-Commit-Position: refs/heads/master@{#26989}
-
yangguo authored
Revert of Remove default value for number of threads in Isolate::Init. (patchset #1 id:1 of https://codereview.chromium.org/978773002/) Reason for revert: build failures. Original issue's description: > Remove default value for number of threads in Isolate::Init. > > Just fixing a TODO. > > R=jochen@chromium.org > > Committed: https://crrev.com/fbcebbc5bdfd8eed82d121faf07b536eb3142fb7 > Cr-Commit-Position: refs/heads/master@{#26987} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/964743003 Cr-Commit-Position: refs/heads/master@{#26988}
-
yangguo authored
Just fixing a TODO. R=jochen@chromium.org Review URL: https://codereview.chromium.org/978773002 Cr-Commit-Position: refs/heads/master@{#26987}
-
vogelheim authored
Revert of Default-enable external startup data for Linux for stand-alone builds. (patchset #1 id:1 of https://codereview.chromium.org/956373002/) Reason for revert: The CL caused two issues: - a weird build issue on V8 mips builder - d8 cannot be invoked via PATH, since then it doesn't find its external snapshot. The 2nd issue might even be WAI, but this needs more consideration. Original issue's description: > Default-enable external startup data for Linux for stand-alone builds. > > Notes: > - Other platforms to follow later. > - This follows Chromium practice, that mostly uses this feature these days. > - The statically linked-in startup data will stay. So whoever prefers > the old way just needs to set the flag differently. > > Reland crrev.com/959693002, once crrev.com/960883003 is in. > > R=machenbach@chromium.org > BUG= > > Committed: https://crrev.com/a0bdb103b676b4c7fa6b9f2e7149e716549c05d1 > Cr-Commit-Position: refs/heads/master@{#26980} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/981463005 Cr-Commit-Position: refs/heads/master@{#26986}
-
hpayer authored
Before the max_old_space_size was set for each space, which is not intuitive and not what we want. There is still a miss match between capacity and actual committed memory which should be cleaned up in a follow up cl. BUG= Review URL: https://codereview.chromium.org/979783002 Cr-Commit-Position: refs/heads/master@{#26985}
-
bmeurer authored
Word32 shifts are always safe on ia32 and x64, independent of whether SSE4.1 is available. R=dcarney@chromium.org Review URL: https://codereview.chromium.org/975363002 Cr-Commit-Position: refs/heads/master@{#26984}
-
yangguo authored
We now have BreakLocation::Iterator to iterate via RelocIterator, and create a BreakLocation when we are done iterating. The reloc info is stored in BreakLocation in a GC-safe way and instantiated on demand. R=ulan@chromium.org BUG=v8:3924 LOG=N Review URL: https://codereview.chromium.org/967323002 Cr-Commit-Position: refs/heads/master@{#26983}
-
yangguo authored
Re-installing experimental natives after deserialization causes failures if said experimental native is already included in the snapshot. However, there is no way to tell whether a certain harmony feature has been included. Experimental natives may also be turned on/off on-demand, which a snapshot that includes them would not support for all cases. The simple solution for the meantime is to never include experimental natives in the snapshot and initialize them after deserialization on-demand. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/981473002 Cr-Commit-Position: refs/heads/master@{#26982}
-
dcarney authored
BUG=v8:3929 LOG=y Review URL: https://codereview.chromium.org/977893002 Cr-Commit-Position: refs/heads/master@{#26981}
-
vogelheim authored
Notes: - Other platforms to follow later. - This follows Chromium practice, that mostly uses this feature these days. - The statically linked-in startup data will stay. So whoever prefers the old way just needs to set the flag differently. Reland crrev.com/959693002, once crrev.com/960883003 is in. R=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/956373002 Cr-Commit-Position: refs/heads/master@{#26980}
-
erikcorry authored
Each call to emit_32 uses 5 constant pool slots: * the "emit_32" string * undefined (the receiver) * the argument (heap number) * the load IC * the call IC This change cuts that down 20% to 4, by loading the undefined from the heap roots. R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/980563002 Cr-Commit-Position: refs/heads/master@{#26979}
-
vogelheim authored
Fix Initialize & Dispose for external snapshot. Make sure v8::V8::(Initialize|Dispose) can be called in any order. This is a follow-on to crrev.com/960883003, which fixed a memory leak in this code, but uncovered another, more subtle bug: Previously, the code expected you would v8::V8::Initialize once, and v8::V8::Dispose once. The first bug was that in this case the holder_ variable would point to deallocated memory. The second bug was that once the snapshot was disposed, there was no way to get it back on a future Initialize. These are uncovered by the InitializeAndDisposeMultiple test case. The fix is to keep memory to the raw snapshot and to then cleanly build & destroy the tables in Initialize & Dispose. Since sometimes setNativesBlob is called just after Initialize, that situation must be handled, too. BUG= Review URL: https://codereview.chromium.org/974943003 Cr-Commit-Position: refs/heads/master@{#26978}
-
mvstanton authored
Until this is addressed, we can simply use the regular IC, as we do in times of serialization. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/974853002 Cr-Commit-Position: refs/heads/master@{#26977}
-
thakis authored
BUG=none LOG=N Review URL: https://codereview.chromium.org/969653004 Cr-Commit-Position: refs/heads/master@{#26976}
-
thakis authored
Shouldn't make a difference in practice, but it's a bit more readable and it gets the case of a 0 shift correct without undefined behavior. BUG=463436 LOG=N Review URL: https://codereview.chromium.org/975283002 Cr-Commit-Position: refs/heads/master@{#26975}
-
hans authored
Bit-shifts have undefined behaviour if the shift amount is greater or equal to the width of the type. In this case the code would do imm32 >> 32 when rot == 0. A newer version of Clang unrolled the loop, optimized the first iteration away, causing the test suite to fail with: # # Fatal error in ../src/arm/assembler-arm.cc, line 1212 # Check failed: !rn.is(ip). # as well as crashing when running Chromium tests on Android (at least we think this was the cause, see the bug). BUG=463436, 444089 LOG=Y Review URL: https://codereview.chromium.org/979633002 Cr-Commit-Position: refs/heads/master@{#26974}
-
- 03 Mar, 2015 17 commits
-
-
bmeurer authored
Revert of [x86] Use better left operand heuristic for Float64Add and Float64Mul. (patchset #1 id:1 of https://codereview.chromium.org/958583003/) Reason for revert: Tanks on Atom and Haswell Original issue's description: > [x86] Use better left operand heuristic for Float64Add and Float64Mul. > > R=dcarney@chromium.org > > Committed: https://crrev.com/9da259fb1f4ecfefeb2cf7efbe449d8aa1904032 > Cr-Commit-Position: refs/heads/master@{#26849} TBR=dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/972243002 Cr-Commit-Position: refs/heads/master@{#26973}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 Cr-Commit-Position: refs/heads/master@{#26966} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26972}
-
rossberg authored
R=dslomov@chromium.org BUG=3983 LOG=Y Review URL: https://codereview.chromium.org/977543002 Cr-Commit-Position: refs/heads/master@{#26971}
-
mstarzinger authored
Reason for disabling failure on ARM64 simulator in no-snap mode. TBR=dslomov@chromium.org TEST=cctest/test-run-jsexceptions/DeoptFinallyReturn NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/975003002 Cr-Commit-Position: refs/heads/master@{#26970}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #8 id:130001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm compilation again. Aaaarrrrrghhhhhh!!! Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} > > Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 > Cr-Commit-Position: refs/heads/master@{#26966} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/976693002 Cr-Commit-Position: refs/heads/master@{#26969}
-
mstarzinger authored
This just contains test, no fixes. Note that some of the tests are still disabled because they either fail or we don't want ClusterFuzz to pick up the flag yet. R=jarin@chromium.org TEST=cctest/test-run-jsexceptions/Deopt,mjsunit/compiler/try-deopt Review URL: https://codereview.chromium.org/972943004 Cr-Commit-Position: refs/heads/master@{#26968}
-
balazs.kilvady authored
Port 4acbc93d BUG= Review URL: https://codereview.chromium.org/974873002 Cr-Commit-Position: refs/heads/master@{#26967}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26966}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #7 id:110001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm buildre complains again (why v8_linux_arm_dbg does not complain?) Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/974963002 Cr-Commit-Position: refs/heads/master@{#26965}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/962963007 Cr-Commit-Position: refs/heads/master@{#26964}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26963}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/969353003 Cr-Commit-Position: refs/heads/master@{#26962}
-
mvstanton authored
Revert of Implement subclassing Arrays. (patchset #6 id:90001 of https://codereview.chromium.org/975463002/) Reason for revert: ARM build failure... Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} TBR=arv@chromium.org,rossberg@chromium.org,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/975693002 Cr-Commit-Position: refs/heads/master@{#26961}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26960}
-
bmeurer authored
Also allow inlining of native functions. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/962963006 Cr-Commit-Position: refs/heads/master@{#26959}
-
jarin authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/968913002 Cr-Commit-Position: refs/heads/master@{#26958}
-
mstarzinger authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/960273002 Cr-Commit-Position: refs/heads/master@{#26957}
-