- 19 Jun, 2018 27 commits
-
-
Sigurd Schneider authored
This CL enables embedded builtins to get benchmark feedback. We need this feedback to identify and address remaining performance problems. Bug: v8:6666 Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233 Reviewed-on: https://chromium-review.googlesource.com/1105834Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53836}
-
Sigurd Schneider authored
If a call to a builtin is generated at run-time (vs at snapshot time) we don't need to tag the call/jump with relocation info, as the builtin address will not change. The only way to generate a builtin call at snapshot time is via MacroAssembler::JumpToInstructionStream where we keep OFF_HEAP_TARGET. The reloc info for builtin calls and jumps is set to NONE. Bug: v8:6666 Change-Id: I9e8ad9f23481a2177e69352a56010084336402e7 Reviewed-on: https://chromium-review.googlesource.com/1105758 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=jarin@chromium.org Change-Id: I369684ee6ccff83329bcc4f463b922e0263ae0b0 Reviewed-on: https://chromium-review.googlesource.com/1105823Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53834}
-
Clemens Hammacher authored
We need to create one {WasmCompiledModule} before creating the {WasmModuleObject}. This CL refactors the code such that the {WasmModuleObject} itself creates the {WasmCompiledModule}. This moves us closer to removing the {WasmCompiledModule}. R=titzer@chromium.org Change-Id: I9f85e47f643c39840036f4f1f92df736732c8f74 Reviewed-on: https://chromium-review.googlesource.com/1105762Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53833}
-
Michael Achenbach authored
The blacklist is needed to make compilation work. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:853202 Change-Id: Ie867b3605a42ddbcf02514965652ff89121be14d Reviewed-on: https://chromium-review.googlesource.com/1105830Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53832}
-
Clemens Hammacher authored
This also restores some uniformity in these headers. R=mstarzinger@chromium.org Change-Id: Ic3a941bce287596f564ba9f87f3a8ca2c46c2ee2 Reviewed-on: https://chromium-review.googlesource.com/1105763Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53831}
-
Michael Achenbach authored
This reverts commit 2c1e4aa9. Reason for revert: https://ci.chromium.org/buildbot/client.v8.ports/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/11591 Original change's description: > [test] Initialize slow-dcheck runtime flag with compile time value > > This makes sure slow dchecks are part of the snapshot when the compile > time flag is set. It'll also obviate the need to set the runtime flag > in general, making configurations simpler. > > It's still possible to opt out at runtime for the non-snapshot dchecks > using the negated runtime flag. > > Bug: v8:7853 > Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d > Reviewed-on: https://chromium-review.googlesource.com/1105050 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53819} TBR=machenbach@chromium.org,cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: If209aa824749f358a892218dda99c30b1a63b99d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7853 Reviewed-on: https://chromium-review.googlesource.com/1105857Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 733b7c82. The arm64 bug was fixed in https://crrev.com/c/1105051. Original change's description: > [wasm] Introduce jump table > > This introduces the concept of a jump table for WebAssembly, which is > used for every direct and indirect call to any WebAssembly function. > For lazy compilation, it will initially contain code to call the > WasmCompileLazy builtin, where it passes the function index to be > called. > For non-lazy-compilation, it will contain a jump to the actual code. > The jump table allows to easily redirect functions for lazy > compilation, tier-up, debugging and (in the future) code aging. After > this CL, we will not need to patch existing code any more for any of > these operations. > > R=mstarzinger@chromium.org, titzer@chromium.org > > Bug: v8:7758 > Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f > Reviewed-on: https://chromium-review.googlesource.com/1097075 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53805} TBR=titzer@chromium.org,mstarzinger@chromium.org Bug: v8:7758 Change-Id: I68555230c6db97e70f0b8fef784188f55ee04794 Reviewed-on: https://chromium-review.googlesource.com/1105158 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53829}
-
Leszek Swirski authored
To avoid repeating code for the few places where we can call GetIsolate and GetHeap safely. Bug: v8:7786 Change-Id: I6c6de81488bfa79dca50cfd2b6356f432401b68e Reviewed-on: https://chromium-review.googlesource.com/1104684 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53828}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:853202 Change-Id: Ibdb74e840820a7524db7767f94afb84768773da5 Reviewed-on: https://chromium-review.googlesource.com/1105824Reviewed-by:
-
Dan Elphick authored
This removes several GetIsolate calls from Map:: methods and instead passes the Isolate in. This is a very noisy change but mostly it is just adding Isolate to method declarations and forwarding it on. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I159505e50a9462d01066f14da0fcc29762bd5531 Reviewed-on: https://chromium-review.googlesource.com/1075267Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53826}
-
Simon Zünd authored
This CL changes all ArraySort benchmarks to execute the setup function for each iteration (one run call), instead of only once for all iterations. Even though we now also measure the time needed to copy and prepare the array, this is needed, otherwise we would mainly measure sorting already sorted arrays. R=cbruni@chromium.org, jgruber@chromium.org Change-Id: I2e0e301b52b0288b8c825c3c8401c348c4a0dee7 Reviewed-on: https://chromium-review.googlesource.com/1105045Reviewed-by:
-
Sigurd Schneider authored
TurboFan returned null handles if compilation did not succeed. This CL changes that to a MaybeHandle to make it explicit that client code needs to handle the error. Bug: v8:7856 Change-Id: I6087e6263faa1150b9788213dd22c398b4a2fc2d Reviewed-on: https://chromium-review.googlesource.com/1104688 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53824}
-
Toon Verwaest authored
Change-Id: I566ab09800f4a2873aca86423c858b63c58d6d98 Reviewed-on: https://chromium-review.googlesource.com/1105049 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Leszek Swirski authored
We want to remove GetIsolate calls, but this particular one is safe and necessary to avoid either storing the isolate in the parser/scopes, or passing it through as a parameter throughout the parser. Bug: v8:7786 Change-Id: I07765f5c20b2c9925bb0b980bc9fe850c91d7811 Reviewed-on: https://chromium-review.googlesource.com/1104685Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Change-Id: Ibb35c1ae090cd8e79e48c977735af1188414f531 Reviewed-on: https://chromium-review.googlesource.com/1105054Reviewed-by:
-
Dan Elphick authored
Replace all but one Handle<T*>(T*) calls with ones that explicitly pass in an Isolate. Requires plumbing Isolate* through several Parser functions which previously avoided it because of worries about accessing the heap off the main thread. In all off-main-thread cases, isolate will be nullptr and every such function asserts with: DCHECK_EQ(parsing_on_main_thread_, isolate != nullptr); Also deletes unused function ParseInfo::ReopenHandlesInNewHandleScope. Bug: v8:7786 Change-Id: I3dd9c49dcde49fdbcb684ba73f47a30d00fc495e Reviewed-on: https://chromium-review.googlesource.com/1087272 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53820}
-
Michael Achenbach authored
This makes sure slow dchecks are part of the snapshot when the compile time flag is set. It'll also obviate the need to set the runtime flag in general, making configurations simpler. It's still possible to opt out at runtime for the non-snapshot dchecks using the negated runtime flag. Bug: v8:7853 Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d Reviewed-on: https://chromium-review.googlesource.com/1105050Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: v8:7859 Change-Id: Ie3d21f21b12bc2d36eb1b0ea798e2d6030342492 Reviewed-on: https://chromium-review.googlesource.com/1105760 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
{WasmCompileLazyFrameConstants::kFixedFrameSizeFromFp} did not incorporate padding. This CL fixes that. R=mstarzinger@chromium.org No-Try: true Bug: chromium:853468 Change-Id: I042e68623bdfd81c96180a39c29ecd70271ba1be Reviewed-on: https://chromium-review.googlesource.com/1105051 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
Bump limit for isolate creation in cctest; the test started crashing recently on nosnap.debug builds, hence we bump the limit. Bug: v8:7856 Change-Id: I7c2396c7f112a2ed7fc189f0fa72658e0ed75050 Reviewed-on: https://chromium-review.googlesource.com/1104691Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 380dba0a. Reason for revert: Fails gc-stress: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/1471 Original change's description: > [runtime][gc] Drop AllocationSite::weak_next field for sub-literals > > Use AllocationSite without Weaknext field for all the allocations in nested > literal except for Root. The nested field is sufficient to link all the > allocations in a nested literal. Only the Root is added to heap weak_alloc_list > for GC to traverse > > Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 > Reviewed-on: https://chromium-review.googlesource.com/1101323 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53813} TBR=ulan@chromium.org,cbruni@chromium.org,chandanreddy@google.com Change-Id: Icc87027f14f917da3033db256c2535e08e2a4a34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1105159Reviewed-by:
-
Théotime Grohens authored
This CL adds a 'constexpr String' type to Torque, which gets compiled to 'const char*'. It makes it easier to pass strings around in Torque files, especially when trying to Print() them. Bug: v8:7793 Change-Id: I2d4feac7012f5401f2b467475f8df086e46ac18a Reviewed-on: https://chromium-review.googlesource.com/1104466 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53814}
-
Creddy authored
Use AllocationSite without Weaknext field for all the allocations in nested literal except for Root. The nested field is sufficient to link all the allocations in a nested literal. Only the Root is added to heap weak_alloc_list for GC to traverse Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 Reviewed-on: https://chromium-review.googlesource.com/1101323 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53813}
-
Simon Zünd authored
This CL enables out-of-bounds checks for debug builds when loading or storing FixedArray elements. Since "--enable-slow-asserts" is not passed through to mksnapshot, the OOB checks were basically never executed. Bug: v8:7853 Change-Id: I81bdd9ac04868f9ffc362c3f4fd8fa3ddd122ee1 Reviewed-on: https://chromium-review.googlesource.com/1103568 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53812}
-
Simon Zünd authored
This CL fixes a bug that allowed OOB read/stores on fastpaths when a comparison function caused the underlying FixedArray to change while keeping the elements kinds and size property on the original JSArray the same. R=jgruber@chromium.org Bug: chromium:852592 Change-Id: I09af357d10e7f41e75241e4c87430fc9aa806f8c Reviewed-on: https://chromium-review.googlesource.com/1104158 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Anna Henningsen authored
Refs: https://ci.chromium.org/buildbot/client.v8/V8%20Linux64%20TSAN/21047 Bug: v8:7836 Change-Id: Ic825065de419bbab97972d9b7a2beb6527b0a48a Reviewed-on: https://chromium-review.googlesource.com/1103560 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53810}
-
- 18 Jun, 2018 13 commits
-
-
Alexey Kozyatinskiy authored
Inspector test expectations may be changed without changes inside src/inspector directory. R=dgozman@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3196209a4b974d4cf32c76c51116d77e589a9dbb Reviewed-on: https://chromium-review.googlesource.com/1104303Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53809}
-
Alexey Kozyatinskiy authored
This is a reland of 4363a693 Original change's description: > [inspector] fixed location of top level function return > > We should pass false as has_braces argument to create FunctionLiteral > for top level function. > > R=dgozman@chromium.org,bmeurer@chromium.org > TBR=bmeurer@chromium.org > > Bug: none > Change-Id: I397f31b562d32c71f3a12bfc9ceeed16c367aa80 > Reviewed-on: https://chromium-review.googlesource.com/1098018 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53769} TBR=dgozman@chromium.org Bug: v8:7858 Change-Id: Ie636bc101f9d29d9d40bd10b96e62da6505c2734 Reviewed-on: https://chromium-review.googlesource.com/1104497 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53808}
-
Clemens Hammacher authored
This reverts commit 733b7c82. Reason for revert: breaks arm64 gc-stress: https://ci.chromium.org/buildbot/client.v8.ports/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/11659 Original change's description: > [wasm] Introduce jump table > > This introduces the concept of a jump table for WebAssembly, which is > used for every direct and indirect call to any WebAssembly function. > For lazy compilation, it will initially contain code to call the > WasmCompileLazy builtin, where it passes the function index to be > called. > For non-lazy-compilation, it will contain a jump to the actual code. > The jump table allows to easily redirect functions for lazy > compilation, tier-up, debugging and (in the future) code aging. After > this CL, we will not need to patch existing code any more for any of > these operations. > > R=mstarzinger@chromium.org, titzer@chromium.org > > Bug: v8:7758 > Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f > Reviewed-on: https://chromium-review.googlesource.com/1097075 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53805} TBR=mstarzinger@chromium.org,titzer@chromium.org,clemensh@chromium.org,sreten.kovacevic@mips.com Change-Id: Iea358db2cf13656a65cf69a6d82cbbc10d3e7e1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7758 Reviewed-on: https://chromium-review.googlesource.com/1105157Reviewed-by:
-
Igor Sheludko authored
Now TFJ builtins can use their own descriptors so there's no need to keep the hacky BuiltinDescriptor around. Bug: v8:7754 Change-Id: Ia7f23a21fb979370fd2149fef13186b83a3d5d30 Reviewed-on: https://chromium-review.googlesource.com/1104428 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53806}
-
Clemens Hammacher authored
This introduces the concept of a jump table for WebAssembly, which is used for every direct and indirect call to any WebAssembly function. For lazy compilation, it will initially contain code to call the WasmCompileLazy builtin, where it passes the function index to be called. For non-lazy-compilation, it will contain a jump to the actual code. The jump table allows to easily redirect functions for lazy compilation, tier-up, debugging and (in the future) code aging. After this CL, we will not need to patch existing code any more for any of these operations. R=mstarzinger@chromium.org, titzer@chromium.org Bug: v8:7758 Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f Reviewed-on: https://chromium-review.googlesource.com/1097075 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Move Slot recording to concurrent and incremental marking phase and out of the atomic pause. Records more slots to remove slot recording completely from the pause. Bug: chromium:844008 Change-Id: I13ba20b4839990134dc37bd909fb0a2d66e13c64 Reviewed-on: https://chromium-review.googlesource.com/1104348 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
-
Clemens Hammacher authored
Currently each isolate stores its own array of {CallInterfaceDescriptorData}. This array has size 173, and each entry has 40 bytes. That's already 7kB per isolate. Additionally, each {CallInterfaceDescriptorData} allocates two heap-allocated arrays, which probably add up to more than the static size of the {CallInterfaceDescriptorData}. Note that all the {CallInterfaceDescriptorData} instances are initialized eagerly on isolate creation. Since {CallInterfaceDescriptor} is totally isolate independent itself, this CL refactors the current design to avoid a copy of them per isolate, and instead shares them process-wide. Still, we need to free the allocated heap arrays when the last isolate dies to avoid leaks. This can probably be refactored later by statically initializing more and avoiding the heap allocations all together. This refactoring will also allow us to use {CallInterfaceDescriptor}s from wasm background compilation threads, which are not bound to any isolate. R=mstarzinger@chromium.org, titzer@chromium.org Bug: v8:6600 Change-Id: If8625b89951eec8fa8986b49a5c166e874a72494 Reviewed-on: https://chromium-review.googlesource.com/1100879 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53803}
-
Toon Verwaest authored
For now we keep params since NewSloppyArguments uses it to figure out how to structure the arguments object. We should be able to only keep params in case we have a special case though. E.g., leaf functions with no duplicate parameters don't need special treatment. Or we simply encode the parameter index for each context slot. (I'm not sure duplicates need special treatment.) Change-Id: Icfbb844e5331aeb93c50bc07edd58246c8aeb1d7 Reviewed-on: https://chromium-review.googlesource.com/1104420 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
We currently store the {WasmModule} (generated during decoding) in a unique_ptr and pass ownership to the {WasmModuleObject} after compilation. I plan to move the {Managed<NativeModule>} from {WasmCompiledModule} to {WasmModuleObject}, which will force us to create the {WasmModuleObject} *before* compilation, so that the {CompilationState} is available during compilation. This CL prepares that refactoring by storing the {WasmModule} in a {shared_ptr} in the {AsyncCompileJob}. Note that it will eventually be stored in a {shared_ptr} in the {Managed} anyway. R=titzer@chromium.org Change-Id: Iac5e3c1067af2801e938f77a455a68807801526a Reviewed-on: https://chromium-review.googlesource.com/1104117 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Théotime Grohens authored
This CL completely reimplements the DataView setters in Torque, and removes the former C++ runtime implementation. Change-Id: I66cdd35712e46f3931d6530a4512fa3c8eb3b3bf Reviewed-on: https://chromium-review.googlesource.com/1104162 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Reading up on the bug description, this is a test that is triggered by TurboFan execution. This can be done with natives and does not need excessive loop iterations. Additionally, we have a more specific regression test for the original issue in the repo: http://crrev.com/c/584837 Bug: v8:7783 Change-Id: Id022b515b663e6fb897acb29f43ef92b70b547b8 Reviewed-on: https://chromium-review.googlesource.com/1101018Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:851393 Change-Id: I53cbf16068efbf24a2bd233c0b4c56e8361f9931 Reviewed-on: https://chromium-review.googlesource.com/1104317Reviewed-by:
-
Georg Neis authored
This adds an overload of JSGraph::Constant that takes an ObjectReference rather than a Handle<Object>. ObjectReference is a new superclass of HeapReference. Also several refactorings and renaming, e.g.: - Rename HeapReference to HeapObjectRef. - Rename ContextHeapReference to ContextRef. - ... - Rename HeapReferenceType to HeapObjectType. Bug: v8:7790 Change-Id: Id3e567cbaf7c326189b99b2fd4ced6bff02f9640 Reviewed-on: https://chromium-review.googlesource.com/1104337Reviewed-by:
-
