- 02 Jul, 2018 22 commits
-
-
Clemens Hammacher authored
On Windows (32-bit), we need to emit explicit stack limit checks for stack frames bigger than one page (4kB). This CL implements this by emitting corresponding code at the end of Liftoff functions if needed. R=mstarzinger@chromium.org Bug: v8:7908, v8:6600 Change-Id: Iacb3e7afdd433a4e68620d9230bd0ba473611da8 Reviewed-on: https://chromium-review.googlesource.com/1120175 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54141}
-
Michael Starzinger authored
This correctly serializes {RelocInfo::INTERNAL_REFERENCE} addresses in a position-independent form, so that they can be properly relocated when the code is deserialized again. We store the offset within the code in the serialized stream. R=clemensh@chromium.org TEST=mjsunit/wasm/compiled-module-serialization BUG=chromium:857049 Change-Id: Ie8c84ee67bdfc17a65faa159a21cc1f2a78ac924 Reviewed-on: https://chromium-review.googlesource.com/1122414Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54140}
-
Leszek Swirski authored
FeedbackVector and AllocationSite are now NeverReadOnlySpaceObjects Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6109c0c4a391b19c5c77c61b52aae989707fecc4 Reviewed-on: https://chromium-review.googlesource.com/1120532 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54139}
-
Dan Elphick authored
Pass Isolate to ConsumedPreParsedScopeData::SetData (guaranteed to be called on main thread) and use it to create the handle in ConsumedPreParsedScopeData::GetDataForSkippableFunction, rather than calling GetIsolate. Bug: v8:7786 Change-Id: Ibd632bb57f35a921f37c620d77dd6dfdb1f092c6 Reviewed-on: https://chromium-review.googlesource.com/1088703 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54138}
-
Predrag Rudic authored
Change-Id: Ia5028a01c302c100169c24140e1bde2dce76ce4a Reviewed-on: https://chromium-review.googlesource.com/1120182Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#54137}
-
jgruber authored
git grep 'V(\w*' src/external-reference.h | sed 's/.*V(\(\w*\).*/\1/' | sort | uniq | while read e; do echo -n "$e "; git grep "ExternalReference::$e" | wc -l; done Bug: v8:7754 Change-Id: I702ada4a98a1f1d51b2f4e890dbb5a7abb8c5731 Reviewed-on: https://chromium-review.googlesource.com/1122227Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54136}
-
Creddy authored
This promotes CompileTimeValue as a seperate struct instead of FixedArray. This reduces the heap object size by one word (size field of FixedArray) Change-Id: Id09d9e04c4c1a98aa9fa53b1a44ec17e8cd06f34 Bug: v8:7787, chromium:818642 Reviewed-on: https://chromium-review.googlesource.com/1119918 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54135}
-
Leszek Swirski authored
TBR=jarin@chromium.org Bug: v8:7786 Change-Id: Ie9615de46298df3fbd8492841a35ad0337dd2ccc Reviewed-on: https://chromium-review.googlesource.com/1120485Reviewed-by:
-
Daniel Clifford authored
In the process, create a shared array utility GetLengthProperty that fast-paths accessing the length properties of JSArray. Bug: v8:7793 Change-Id: I6d7f0007c162794773dc0fc3e8bf12b3adf12fa0 Reviewed-on: https://chromium-review.googlesource.com/1116221 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54133}
-
Gergely Nagy authored
When parsing a numeric literal in a line like "a=0x0e+b|0;", currently the scanner consumes the "e+" part (as it thinks it's the start of an exponent). In the ECMAScript lexical grammar HexIntegerLiteral cannot contain exponents, which means the '+' character should be parsed as a binary operator. R=bradnelson@chromium.org BUG=v8:7893 Change-Id: I97a0d4ea2ee1d38a3462efbfaef5eb87b8ea704b Reviewed-on: https://chromium-review.googlesource.com/1116551Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I5e12f49038f569187b751cc07a3bfad5eb904949 Reviewed-on: https://chromium-review.googlesource.com/1121460 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54131}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I44d0bde25283ac8c00155344f879eb1143b43bc9 Reviewed-on: https://chromium-review.googlesource.com/1119688Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I422277d565173273e632db07e0e762ee7ae01e87 Reviewed-on: https://chromium-review.googlesource.com/1122116Reviewed-by:
-
Leszek Swirski authored
Adds a instance types for each HashTable subtype, rather than reusing HASH_TABLE_TYPE. This allows us to check for these types by checking the instance type directly, rather than by comparing against the map in the root set. Also, as a drive-by, do the same for SCRIPT_CONTEXT_TABLE_TYPE, and use instance type checks rather than map checks for Context types. This is a good general clean-up, but in particular is intended for GetIsolate removal. TBR=jarin@chromium.org Bug: v8:7786 Change-Id: I420abdd12906dfa20c922e486ecdc657eb3c6ef0 Reviewed-on: https://chromium-review.googlesource.com/1114958Reviewed-by:
-
Peter Marshall authored
Currently we don't check the result of AllocateUninitialized and just continue execution, failing at the following memcpy. Instead, check for a nullptr result from the embedder-provided allocator and crash with OOM. Bug: chromium:853706 Change-Id: I7a9b4e5d0ce3ef2b2cbb5fd3dc949ec2705bdfaa Reviewed-on: https://chromium-review.googlesource.com/1113454Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54127}
-
Stephan Herhut authored
This change helps mostly to reduce register pressure. By default, we compile LoadStackPointer into a move from the stack register into some general purpose register and then later use that register. This might trigger a spill to free up space, which is particularly costly in loops. Change-Id: I886233f890b7833f873fc24773f621add7cf0588 Reviewed-on: https://chromium-review.googlesource.com/1104351 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54126}
-
Rodrigo Bruno authored
Change-Id: Ic32383b9a4116b8f05568d7e8e0ca70a18813cea Reviewed-on: https://chromium-review.googlesource.com/1121458Reviewed-by:
-
Michael Starzinger authored
This makes sure the reverse tag translation of direct call targets to respective call tags is properly performed. Otherwise all direct call end up being deserialized to call the function with index '0'. Ooops! R=clemensh@chromium.org TEST=mjsunit/wasm/compiled-module-serialization BUG=chromium:857049 Change-Id: I37c1ee72b000daec87efdeed08d60a067b1a1b0c Reviewed-on: https://chromium-review.googlesource.com/1120256Reviewed-by:
-
Michael Achenbach authored
This reverts commit 8d4572a2. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21312 Original change's description: > [builtins] Add %IsTraceCategoryEnabled and %Trace builtins > > Adds the builtin Trace and IsTraceCategoryEnabled functions > exposed via extra bindings. These are intended to use by > embedders to allow basic trace event support from JavaScript. > > ```js > isTraceCategoryEnabled('v8.some-category') > > trace('e'.charCodeAt(0), 'v8.some-category', > 'Foo', 0, { abc: 'xyz'}) > ``` > > Bug: v8:7851 > Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 > Reviewed-on: https://chromium-review.googlesource.com/1103294 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54121} TBR=fmeawad@chromium.org,yangguo@chromium.org,cbruni@chromium.org,bmeurer@chromium.org,jasnell@gmail.com Change-Id: I352e2413aa771ba9eb069bcc26c04414abfc500f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7851 Reviewed-on: https://chromium-review.googlesource.com/1122036Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54123}
-
Anna Henningsen authored
Provide a more complete BigInt API. Bug: v8:7712 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic8562d616f3125deabdf8b52c7019b191bef0e07 Reviewed-on: https://chromium-review.googlesource.com/1101198 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
James M Snell authored
Adds the builtin Trace and IsTraceCategoryEnabled functions exposed via extra bindings. These are intended to use by embedders to allow basic trace event support from JavaScript. ```js isTraceCategoryEnabled('v8.some-category') trace('e'.charCodeAt(0), 'v8.some-category', 'Foo', 0, { abc: 'xyz'}) ``` Bug: v8:7851 Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 Reviewed-on: https://chromium-review.googlesource.com/1103294 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54121}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/23d647e..213a0e3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id0d7a996abe5b5bc7e92cfcc7b125d40dee12659 Reviewed-on: https://chromium-review.googlesource.com/1121959Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54120}
-
- 01 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b79f5b5..23d647e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iedbe6547eac1badd18f35ee32aae1319ea220c25 Reviewed-on: https://chromium-review.googlesource.com/1121821Reviewed-by:
-
- 30 Jun, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f76f0b4..34f0d7e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a19649b..024a331 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I847abf895aa5182d1dbab83746223d34635954c6 Reviewed-on: https://chromium-review.googlesource.com/1121625 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 29 Jun, 2018 16 commits
-
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8e3406c..b79f5b5 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/9c9fd97..0dd5c6f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e2d6bbc..f76f0b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ae1f033..a19649b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/de629a4..dec27d7 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5721136b50509762c2b22a0782b9fbfd370fbde5 Reviewed-on: https://chromium-review.googlesource.com/1121079Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Aseem Garg authored
This CL adds simd select, addHoriz, shuffle, anyTrue and all true to the interpreter. It also gets rid of SIMD_COMPILED_AND_LOWERED_TEST and SIMD_COMPILED_TEST macros. R=gdeepti@chromium.org BUG=v8:6020 Change-Id: I44abbcaddc3223a95c79ccc65ae9c6bf1a911c5d Reviewed-on: https://chromium-review.googlesource.com/1119258 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54116}
-
Rodrigo Bruno authored
This is a reland of 6b810dad Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} Bug: chromium:845409 Change-Id: I71576bd397ca70d9ce76de279c2d9d1fa5a70596 Reviewed-on: https://chromium-review.googlesource.com/1120365Reviewed-by:
-
Rodrigo Bruno authored
This reverts commit 5863c0b6. Reason for revert: Breaks GPU bots (https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/1648) Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I77787df6aef2efec95c79714d1baf43feeb8a27e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1120265Reviewed-by:
-
Clemens Hammacher authored
Liftoff needs to emit the same code, thus move it to a place where it can be reused. Also, switch the _MSC_VER switch to V8_OS_WIN. It is unclear if _MSC_VER would also be set in clang. V8_OS_WIN seems to fit better. Drive-by: Reorder the code to save one jmp in the loop (loop inversion). R=mstarzinger@chromium.org Bug: v8:7908, v8:6600 Change-Id: Ia76aa4dad3f96e179a9daad8c1551b1aab499878 Reviewed-on: https://chromium-review.googlesource.com/1120174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: chromium:829771 Change-Id: I0e3f81b14d971d077afba2f4065e229b99948808 Reviewed-on: https://chromium-review.googlesource.com/1119687Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ia5f1d52df1b2ebbe4ea4d38464fc59b0d128426d Reviewed-on: https://chromium-review.googlesource.com/1119924Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 Reviewed-on: https://chromium-review.googlesource.com/1118164 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Simon Zünd authored
This CL fixes the NumberDictionary fast-path in Array.p.sort, when storing to a read-only property that was never read from. R=jgruber@chromium.org Bug: v8:7907 Change-Id: I2b772fb5b1619a94a7d239ba4417ecb7902a167c Reviewed-on: https://chromium-review.googlesource.com/1119910 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54109}
-
Rodrigo Bruno authored
This is a reland of 9072bef0 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} Bug: chromium:845409 Change-Id: Icff4e2a2b974942f73f5e6bb0bfd6ee8655e8ce7 Reviewed-on: https://chromium-review.googlesource.com/1119985Reviewed-by:
-
Clemens Hammacher authored
Since the wire bytes are now stored on the C++ heap, referenced directly from the {NativeModule}, there is no need any more for the additional copy in the {CompilationState}. R=mstarzinger@chromium.org Bug: v8:7868 Change-Id: I3ca25981b37bc14037a83a199354b70b4e52f8c7 Reviewed-on: https://chromium-review.googlesource.com/1118886 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I0cbd3e82a865aa2e52019057cea796cd6a8b17e2 Reviewed-on: https://chromium-review.googlesource.com/1118560 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Just a refactoring to make clear that we are talking about function names. Note that there are also names for locals inside functions, which we currently don't use. Drive-by: Remove style-guide violation by {WasmModule::names_} field. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I9c47ea01893f128e1716be01032adfaf006ae28a Reviewed-on: https://chromium-review.googlesource.com/1118271Reviewed-by: -
jgruber authored
This change somehow got lost when relanding an earlier CL in https://crrev.com/c/1118139 Bug: v8:7891 Change-Id: I31244be136322cccfb465c24356f1d0fd5e0c6d6 Reviewed-on: https://chromium-review.googlesource.com/1119786Reviewed-by:
-
Sreten Kovacevic authored
Commit edec05ea Usage of Print function was not consistent with it's signature, which caused failures in compilation. Original commit message: `All Object::Print functions now take an Isolate* parameter. Various XX::XXPrint functions now take an Isolate if it's needed rather than calling GetIsolate(). Such method use DECL_PRINTER_WITH_ISOLATE rather than DECL_PRINTER. The _v8_internal_Print_ function (intended for use in gdb) now uses Isolate::Current() to get hold of an Isolate. Reduces the GetIsolate and GetHeap count by 9 and 5 respectively. Also removes unneeded gdb/lldb macros (along with their support functions), jfv, jfm, jda and jta, since job does the same thing.` Cr-Original-Commit-Position: refs/heads/master@{#54029} Change-Id: I5d4eb974340159ae91a50c1c2272ab195fc514ea Reviewed-on: https://chromium-review.googlesource.com/1116965Reviewed-by:
-
Clemens Hammacher authored
No need to go via the {ModuleEnv} in the {CompilationState}. R=mstarzinger@chromium.org Change-Id: I11ff647824ad107131ce329453b365d6ecaec7fb Reviewed-on: https://chromium-review.googlesource.com/1118561Reviewed-by:
-
