- 09 Sep, 2021 17 commits
-
-
Ng Zhi An authored
By delegating to the macro-assembler, emit AVX instructions for some float opcodes (float sqrt, round, conversions to and from int, extract/insert/load word). Since they now support AVX, we rename the instruction ops to remove the SSE prefix, changing it to be IA32. Bug: v8:12148 Change-Id: Ib488f03928756e7d85ab78e6cb28eb869e0641f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131374Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76755}
-
Ng Zhi An authored
Change-Id: I51dee467f5b843e96ffccbe6e99ba203e8c3bf10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3111266Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76754}
-
Philip Pfaffe authored
Bug: chromium:1241860 Change-Id: Ieee7d5c67f1a42c0c9855148a7d497586d6c5555 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149456Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#76753}
-
Georg Neis authored
Bug: chromium:1247763 Change-Id: I6f09d5113ef7e4774032ea586d5a1ada98aa4b1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149462Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76752}
-
Georg Neis authored
It could happen that the information about the feedback vector cached in a JSFunctionData disagreed with the current value of the function's feedback cell. The inlining code wasn't prepared for that and a CHECK could fail. The CL fixes this by removing the caching of has_feedback_vector and feedback_vector and by getting hold of the bytecode array before fetching the feedback vector in inlining. Bug: v8:12172, v8:7790 Change-Id: Ife3ab8872085d9496e6d1f34514114a086f653ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Liviu Rau authored
R=hablich@chromium.org, vahl@chromium.org Change-Id: Ibec33a0f0299cea3e215aebfcf0cc873356f795e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149461 Auto-Submit: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Lutz Vahl <vahl@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76750}
-
Ilja Iskovs authored
Use an immediate zero operand for floating point comparison nodes when possible. This results in up to 20-25% runtime improvement in some microbenchmarks, as well as 1-1.5% runtime improvement in some real-use benchmarks on Cortex-A55 and Neoverse N1. Change-Id: I39d10871a08a037dbe8c0877d789d110476e1a58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3133143Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/main@{#76749}
-
Rakhim Khismet authored
We add call_ref and return_call_ref to the fuzzed module. We alter call function to generate call_ref in it. Bug: v8:11954 Change-Id: I972b8e053d7eab758ac343d48f0c4631ef24b22b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148011Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76748}
-
Clemens Backes authored
Test that also signal handlers cannot write to code, even if a {CodeSpaceWriteScope} is open when the signal is triggered. R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Change-Id: I1e49e4b31ba196948f7f7adfdf88675816e0a58a Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140607Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76747}
-
Jakob Gruber authored
The icu object cache consists of 5 keys at most -> change it from an unordered_set to a plain array. Possible return values of CompareStrings are {-1,0,1}. Return those directly instead of going through Factory::NewNumberFromInt. Bug: v8:12196 Change-Id: Ia42bb6b1a0ebdc99550f604aa79cb438b150ee88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149454 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76746}
-
Marja Hölttä authored
They need to agree about when to delegate to CloneFastJSArray, since it produces arrays which are potentially COW. If they don't agree, TF generates code which produces a COW array and then expects it to be non-COW -> immediate deopt. This CL gets rid of the discrepancy in the case when there's exactly one argument and it's the number 0. Some corner cases remain, e.g., 1st argument not a number but ToInteger returns 0. These should be extremely rare in the real world. Bug: v8:12194 Change-Id: I10230245c97f8997da4d79702f29ebff11297229 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147910 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Patrick Thier authored
AbstractCode doesn't fully support Sparkplug code yet (SourcePosition and SourcePositionStatement are not supported). Fall back to using BytecodeArray as AbstractCode at call-sites where we use these functions. Bug: chromium:1246259 Change-Id: I839cbff65c96eaaa0057c1e5a8bdd12e2bd721ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147594Reviewed-by:
-
Michael Achenbach authored
Depends on https://crrev.com/c/3148012 to land first. No-Try: true Bug: chromium:1136844 Change-Id: I08b57e1d070a905dc7df71fce18891c9615a0153 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148013Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#76743}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/c23a001..1bd8098 Optimized docs installation (#1225) (Vitaly Zaitsev) https://chromium.googlesource.com/external/github.com/google/benchmark/+/1bd8098 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I2fa85b1c9ea2a3bc3422977560b8280f0723d649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149526Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76742}
-
Georg Neis authored
... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1e4482b..17d097b Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/fc37619..17de752 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/edf77b2..44ea7ab Rolling v8/third_party/aemu-linux-x64: ExffPYjGXL4Gz5i52elIFTU-ZZZ3Rgom_ZGpSi12LBoC..QewYN5289B8deg5Mn6clWEv58UqpocHGKeob2F0T87kC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c678081..664e425 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If5bde624ec64e78723a8e9d83a2cacb385fb1271 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149524Reviewed-by:
-
Zhao Jiazhong authored
The t6-t8 are scratch registers and should not be allocatable. Besides, add s0, s1, s2, s5 and s8 as allocatable registers. Change-Id: I0805cc5273d0e0ec5040a0376bcbfba276202077 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147315 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76739}
-
- 08 Sep, 2021 23 commits
-
-
Ng Zhi An authored
No functionality change is expected. Bug: v8:11217 Change-Id: I131d52794e4de24ec838cc23f15828edbfc656ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131372Reviewed-by:
-
Ng Zhi An authored
Merge the SSE and AVX opcodes for I16x8Eq and I16x8GtS. We delegate to the macro-assembler to check for AVX. No functionality change is expected. Bug: v8:11217 Change-Id: I873b261d6f949bfc6755fe4c0e09b964a02c3684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131371 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Change-Id: I8afa821412ae248ddea990755404a9bf5f33184e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125434Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/3da1e2f..715537d Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fbef918..1e4482b Rolling v8/third_party/aemu-linux-x64: aSVGWUgGw-Nuh-08X80jtqA2bVKylBoNa1h7D-6Kzf0C..ExffPYjGXL4Gz5i52elIFTU-ZZZ3Rgom_ZGpSi12LBoC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d69b31c..7285666 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/195c102..c678081 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 Rolling v8/tools/luci-go: git_revision:3e1f1f7a109ed8aefc7feba94fa737f0b5b4847e..git_revision:7b62727dc713b47d7a7ce9bca27500cb8e82ebd7 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id805d5bb7032f8208273f5e2aaa0532c7b03fc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149517Reviewed-by:
-
Milad Fa authored
This CL takes advantage of the z15 `store byte reverse element` instructions to optimize Simd StoreLane opcodes. On the simulator we only run `store element` as reversing is not required. Change-Id: I723f6db535799470c46a1e298a9c1af7574ad5b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144373Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76734}
-
Ng Zhi An authored
Combine the SSE and AVX versions, delegate to the macro-assembler functions to check for AVX support. Change Pand, Por, Pxor to generate the *ps version of the instruction when AVX is not supported. The *ps versions are 1 byte shorter, and have no performance difference on SSE-only processors. Bug: v8:11589 Bug: v8:11217 Change-Id: I9d51054359dcc909efcbb2c3d3bb63d399cd6721 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124101Reviewed-by:
-
Ng Zhi An authored
Do not require that dst == src1, this leaves more flexibility for the operands. We check in the macro-assembler if dst alias any of the input operands, then use vfma231/vfma132/vfma213 appropriately. Bug: v8:11659 Change-Id: I3644f5e0e75bd047d4e5f5b52d4234e54d329d15 Fixed: v8:11659 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131370 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76732}
-
Francis McCabe authored
Bug: v8:12191 Change-Id: I867e81a62341f9c95cf56466b9d97a877d9debdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145990Reviewed-by:
-
Milad Fa authored
globals are no longer LE enforced after https://crrev.com/c/2944437. LANE is used instead to pick the correct lane on BE machines. Change-Id: I106bebda2633a4673ad4b5165c0440cc445d9475 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148036Reviewed-by:
-
Jakob Kummerow authored
In addition to inputs consisting entirely of random bits, the bigint test shell now also generates inputs that are powers of two (i.e. have many 0-bits) and inputs with many 1-bits. Empirically, these kinds of inputs are more likely to flush out corner case bugs. Bug: v8:11515 Change-Id: Ib69f12bf215055991b028196dc54ebbc00780bae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055292 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#76729}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: I99546c99de2283c1169b299b5ae3cd89298a8a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148134Reviewed-by:
-
Jakob Kummerow authored
No multiplications needed, just putting bits directly into the right places. Bug: v8:11515 Change-Id: I65e5658bb5ed12caec9325f414563526f8edbbf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055291 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Backes authored
This adds some basic tests for WebAssembly code protection, in four different configurations: - no protection - mprotect-based protection - PKU-based protection - PKU with fallback to mprotect If PKU is not supported by the OS or hardware, then PKU is identical to no protection, and PKU with fallback is identical to mprotect. We always execute all four configurations anyway. If protection is effective, we expect code to be writable within a {CodeSpaceWriteScope}, and not writable otherwise. When trying to write to non-writable code, we expect a crash of the process (checked via {ASSERT_DEATH_IF_SUPPORTED}). R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Change-Id: I4ec0ce9426f70ff41a292b9ea25be1e8956a670e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138210 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Milad Fa authored
This is a port of the following 2 CL on Chromium: https://crrev.com/c/3139927 https://crrev.com/c/2672580 Bug: gn:252 Change-Id: I7c0636fad9d9f07c73e5f77b9b0a342d0326800f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145613Reviewed-by:
-
Yoshisato Yanagisawa authored
Bug: chromium:1233780 Change-Id: I92d097e04702f9db88113584c1d3e5e940d0f1ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147317 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Also bump the minimum size determined by manually testing with: mjsunit/harmony/modules-import-13 Bug: v8:12197 Change-Id: Ic21d42547ba14cd927d158388ad4bc6f1891f45c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147453 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Fixed: v8:12192 Change-Id: Ifcb006bd1746e7bcf3b16c0e31e8cda9c920483c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147590 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#76722}
-
Zhao Jiazhong authored
We should use pc relative branch instruction rather than loading target address from memory for better performance. Besides, just like arm64, currently we assume that none of our relocation types are pc relative pointing outside the code buffer nor pc absolute pointing inside the code buffer. Change-Id: I9cce2e79c0afb00af967638405469f65df1deda2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147314Reviewed-by:
Liu yu <liuyu@loongson.cn> Commit-Queue: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76721}
-
Thibaud Michaud authored
Bug: v8:8091, chromium:1247119 Change-Id: Icafd0bf9277aed835032396c2512e7d991407e0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144910Reviewed-by:
-
Michael Achenbach authored
These tests require a certain stack-size as otherwise range errors show up in the test expectations, which are compared verbatim. Bug: v8:12197 Change-Id: I0e420fe6b03965241003ac69fd7d96fa61682c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147592 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
We add an option to BuildTFGraph to not emit stack checks and call tracing and use it in inlined functions. Also, we add tests for zero/multiple return values, as well as infinite loops in the inlined function. Bug: v8:12166 Change-Id: I5f34c57d9870592085804853ff23ba94897cc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141589Reviewed-by:
-
Leszek Swirski authored
Change-Id: Ic917bf0e6a3d5f6624f77c72cb9d16626d6508fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145418 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#76717}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/4f80705..c23a001 Remove unused parameter from lambda. (#1223) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/c23a001 add to final releasing step (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/92f50a2 bump version to 1.6 in preparation for release (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/f91b6b4 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I69c037d549e7d2887962e6d7cfa3ba87d990fe2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3146793Reviewed-by:
-
