1. 30 Jan, 2019 1 commit
  2. 19 Sep, 2018 3 commits
    • Clemens Hammacher's avatar
      Reland "[wasm] Introduce a soft limit on reserved memory" · 5e94b208
      Clemens Hammacher authored
      This is a reland of 3bb5cb63
      
      Original change's description:
      > [wasm] Introduce a soft limit on reserved memory
      > 
      > Currently, wasm memory and wasm code use a shared limit for the total
      > size of reservations. This can cause wasm code reservations to fail
      > because wasm memories used all available reservation space.
      > This CL introduces a soft limit which is used when allocating wasm
      > memory with full guards. If this limit is reached and the respective
      > flag is set, we fall back to allocation without full guards and check
      > against the hard limit. Code reservations always check against the hard
      > limit.
      > 
      > R=ahaas@chromium.org
      > 
      > Bug: v8:8196
      > Change-Id: I3fcbaeaa6f72c972d408d291af5d6b788d43151d
      > Reviewed-on: https://chromium-review.googlesource.com/1233614
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56028}
      
      Bug: v8:8196
      Change-Id: If8baf429b02e23b344346f7335bc911b99ae5579
      Reviewed-on: https://chromium-review.googlesource.com/1233756Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56044}
      5e94b208
    • Leszek Swirski's avatar
      Revert "[wasm] Introduce a soft limit on reserved memory" · 196874aa
      Leszek Swirski authored
      This reverts commit 3bb5cb63.
      
      Reason for revert: Breaks Win64 bot https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/26418
      
      Original change's description:
      > [wasm] Introduce a soft limit on reserved memory
      > 
      > Currently, wasm memory and wasm code use a shared limit for the total
      > size of reservations. This can cause wasm code reservations to fail
      > because wasm memories used all available reservation space.
      > This CL introduces a soft limit which is used when allocating wasm
      > memory with full guards. If this limit is reached and the respective
      > flag is set, we fall back to allocation without full guards and check
      > against the hard limit. Code reservations always check against the hard
      > limit.
      > 
      > R=​ahaas@chromium.org
      > 
      > Bug: v8:8196
      > Change-Id: I3fcbaeaa6f72c972d408d291af5d6b788d43151d
      > Reviewed-on: https://chromium-review.googlesource.com/1233614
      > Reviewed-by: Andreas Haas <ahaas@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#56028}
      
      TBR=ahaas@chromium.org,clemensh@chromium.org
      
      Change-Id: If645e738b4a5800eceabd993738ac2285f4a63bc
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8196
      Reviewed-on: https://chromium-review.googlesource.com/1233834Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56031}
      196874aa
    • Clemens Hammacher's avatar
      [wasm] Introduce a soft limit on reserved memory · 3bb5cb63
      Clemens Hammacher authored
      Currently, wasm memory and wasm code use a shared limit for the total
      size of reservations. This can cause wasm code reservations to fail
      because wasm memories used all available reservation space.
      This CL introduces a soft limit which is used when allocating wasm
      memory with full guards. If this limit is reached and the respective
      flag is set, we fall back to allocation without full guards and check
      against the hard limit. Code reservations always check against the hard
      limit.
      
      R=ahaas@chromium.org
      
      Bug: v8:8196
      Change-Id: I3fcbaeaa6f72c972d408d291af5d6b788d43151d
      Reviewed-on: https://chromium-review.googlesource.com/1233614Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56028}
      3bb5cb63
  3. 07 Jun, 2018 1 commit
    • Eric Holk's avatar
      [wasm] Fall back on bounds checks when guarded memory unavailable · b984b70c
      Eric Holk authored
      This CL adds the simplest version of a trap handler fallback. At
      instantiation time, we check whether the module was compiled to use
      trap handlers and the memory is guarded. If the memory is not guarded
      but the module is supposed to use trap handlers, we recompile the
      module with bounds checks so that we can use an unguarded memory.
      
      The compiled module is replaced with a bounds checking version, meaning
      future instances from this module will also use bounds checks.
      
      Some likely desirable features that are current missing but can be
      added future CLs include:
      * Disabling trap handler mode entirely.
      * Recompiling all old instances so that trap handler and bounds checked
        code does not coexist in the same process.
      
      Bug: v8:7143
      
      Change-Id: I161fc0d544133b07dc4a93cc6af813369aaf3efe
      Reviewed-on: https://chromium-review.googlesource.com/1018182
      Commit-Queue: Eric Holk <eholk@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53566}
      b984b70c