- 08 Aug, 2017 3 commits
-
-
Benedikt Meurer authored
Bug: v8:6679 Change-Id: I1fff8ffa037629636f31ecd2b731f5b9de89ce44 Reviewed-on: https://chromium-review.googlesource.com/604789Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47209}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/181c098..411d3b5 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/1fec0c8..98218d1 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client/+log/a56c2b3..42721e1 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I3d2d98ec9abd9d813986d3d82c010c8b0d46fa67 Reviewed-on: https://chromium-review.googlesource.com/604549Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47208}
-
Adam Klein authored
This code appears to have been wrong forever, as it only threw in strict mode (presumably predating ES2015 const). In order to get exactly the right behavior, special handling of sloppy named function expressions is required. Rather than polluting PropertyAttributes with another dummy value, this CL simply adds a bool output argument to Context::Lookup to indicate that case. Bug: v8:6677 Change-Id: I34daa5080d291808f10cbaefc91d716f0b22963b Reviewed-on: https://chromium-review.googlesource.com/602690Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47207}
-
- 07 Aug, 2017 27 commits
-
-
Benedikt Meurer authored
The ConstructFunctionForwardVarargs and ConstructForwardVarargs builtins, which are used when inlining the Reflect.construct builtin into TurboFan optimized code, didn't properly check the new.target parameter whether it's a constructor. Bug: chromium:752481 Change-Id: I9b8f8c429d6eaed0ff8d27fc3f6b52eb906766a2 Reviewed-on: https://chromium-review.googlesource.com/604187 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47206}
-
Mircea Trofin authored
This is part of the effort to consolidate the ownership of wasm instantiation/specialization parameters. This change is focused solely on the interpreter part of that effort, to verify we're not regressing performance in interpreter benchmarks. There are two aspects being addressed: - dataflow-wise, we always fetch the interpreter's memory view from the runtime objects (i.e. WasmInstanceObject/WasmCompiledModule). This is consistent with how other instance-specific information is obtained (e.g. code, indirect functions). - representation-wise, we do not reuse ModuleEnv/WasmInstance just for the memory view, because it is surprising that other instance info isn't accessed from there. Bug: Change-Id: I536fbffd8e1f142a315fa1770ba9b08319f56a8e Reviewed-on: https://chromium-review.googlesource.com/602083Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47205}
-
Tobias Tebbi authored
The code accidentally jumped over the actual left-shift part when the head of the array was the hole. Bug: chromium:752722 Change-Id: I300a3ebcfafb07d6ecebc01fa57c66eb26f349ac Reviewed-on: https://chromium-review.googlesource.com/603717Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#47204}
-
Tobias Tebbi authored
Bug: chromium:752438 Change-Id: I6e168f0e8101cf9f28915ca94c40d408ed75d079 Reviewed-on: https://chromium-review.googlesource.com/603612 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47203}
-
Alexandre Talon authored
Currently only A test operators had output, but since ABReducer and BCReducer perform in-place replacement of A nodes into B nodes, and then sometimes into C nodes, we need B and C nodes to have as many outputs. Otherwise, we run into a situation where a node {x} has a use {y}, but its operators has 0 outputs, which is inconsistent. Bug: Change-Id: I0f73b83d2115dfeda3c9cbc97b9a2fc168f4c31b Reviewed-on: https://chromium-review.googlesource.com/603716Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Alexandre Talon <alexandret@google.com> Cr-Commit-Position: refs/heads/master@{#47202}
-
Ulan Degenbaev authored
Bug: chromium:752750 TBR: mlippautz@chromium.org Change-Id: I95ca30742c05be03dcaebb0cd32af04b226e23e2 Reviewed-on: https://chromium-review.googlesource.com/603652Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47201}
-
Maya Lekova authored
This reverts commit 15ef03cb. Reason for revert: Found the following bugs Bug: chromium:752846, chromium:752712, chromium:752850 Original change's description: > Reland "[builtins] Port getting property from Proxy to CSA" > > This reland is after fix in [heap] Delete wrong DCHECK. > It includes moving ProxyGetProperty to its own stub to reduce > binary size. > > This is a reland of 47a97aa5 > Original change's description: > > [builtins] Port getting property from Proxy to CSA > > > > Bug: v8:6559, v8:6557 > > Change-Id: If6c51f5483adb73ddd2495cede5d85e887a3c298 > > Reviewed-on: https://chromium-review.googlesource.com/589212 > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Maya Lekova <mslekova@google.com> > > Cr-Commit-Position: refs/heads/master@{#47113} > > Bug: v8:6559, v8:6557 > Change-Id: I76acd97ba1acb62b7e7983db1741441d997050f0 > Reviewed-on: https://chromium-review.googlesource.com/600215 > Commit-Queue: Maya Lekova <mslekova@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47159} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,franzih@chromium.org,jgruber@chromium.org,ishell@chromium.org,bmeurer@chromium.org,mslekova@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I51bef25a031b02cf4deab11282473acae57f1ed3 Reviewed-on: https://chromium-review.googlesource.com/603708 Commit-Queue: Maya Lekova <mslekova@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47200}
-
Ross McIlroy authored
Refactors CompileUnoptimizedCode to do all the finalization for both inner and the outermost function after having prepared and executed their compile jobs. This will enable the function to be split into an off-thread phase and a finalization main thread phase. BUG=v8:5203 Change-Id: I400933c27b7aa52f9a7318b721adecfc94c80981 Reviewed-on: https://chromium-review.googlesource.com/602236 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47199}
-
Ross McIlroy authored
Moves creation of the CompilationInfo for unoptimized compilation into the respective CompilationJobs for Igntition, Fullcode and asm.js. This unifies the behaviour with respect to the optimized compilation jobs, and enables the CompileInfo to be owned by the CompilationJob. As part of this change, we no longer build new dummy ParseInfos for eager inner functions, instead using just the single outer ParseInfo created during the actual parsing. BUG=v8:5203 Change-Id: I6813758dfc5eeff44f5a40bf621184e330593bf9 Reviewed-on: https://chromium-review.googlesource.com/601990 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47198}
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: Iad6f815d2476c59a498b7f580ec664417e83c675 Reviewed-on: https://chromium-review.googlesource.com/600050 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47197}
-
Benedikt Meurer authored
Drop the deprecated CallConstructStub and remove the use of CallICStub from fullcodegen, since that feedback is unused completely every since Crankshaft got removed, thus we can safely unlink all the CallIC stuff from fullcodegen nowadays, and completely nuke the CallICStub and the CallICTrampolineStub now (we can also transitively nuke the unused CreateAllocationSiteStub and CreateWeakCellStub). Instead the CallIC logic is integrated into Ignition now, and part of the bytecode handlers for [[Call]] and [[Construct]]. There's still some follow-up cleanup with the way the Array constructor feedback is integrated, but that's way easier now. Bug: v8:5517, v8:6399, v8:6409, v8:6679 Change-Id: I0a6c6046faceca9b1606577bc9e63d9295e44619 Reviewed-on: https://chromium-review.googlesource.com/603609 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47196}
-
Clemens Hammacher authored
The interpreter was not able to call imported wasm functions (hitting UNIMPLEMENTED). This CL fixes this by creating a "CWasmEntry", which is signature-specific. It has JS linkage and receives the wasm code object to call and a buffer containing all arguments (similar to the interpreter entry). It loads all arguments from the buffer and calls the given code object. The c-wasm-entry code objects are cached per instance, such that we only create them once per signature. These wasm entry stubs will also allow us to call back to compiled code from the interpreter, which we might want to do to reduce the slowdown of executing wasm for debugging. R=titzer@chromium.org Bug: chromium:735792 Change-Id: I7fecec3a7bec62a9de40fff115b684759b12a28b Reviewed-on: https://chromium-review.googlesource.com/600308 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47195}
-
Benedikt Meurer authored
As of https://chromium-review.googlesource.com/600968 the CallIC no longer supports AllocationSite feedback for [[Call]], so we can drop the TurboFan bits that deal with AllocationSites for JSCall nodes as well. This further simplifies the handling of the Array constructor. Drive-by-fix: Rename Builtins::kArrayCode to Builtins::kArrayConstructor for sake of consistency. Bug: v8:6399 Change-Id: I9e6a684fc00dd72e25f925db5f407c3f3f715873 Reviewed-on: https://chromium-review.googlesource.com/602354 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47194}
-
Michael Achenbach authored
This reverts commit 6c541561. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds/17240 Original change's description: > [ic] Properly integrate the CallIC into Ignition. > > Drop the deprecated CallConstructStub and remove the use of CallICStub > from fullcodegen, since that feedback is unused completely every since > Crankshaft got removed, thus we can safely unlink all the CallIC stuff > from fullcodegen nowadays, and completely nuke the CallICStub and the > CallICTrampolineStub now (we can also transitively nuke the unused > CreateAllocationSiteStub and CreateWeakCellStub). > > Instead the CallIC logic is integrated into Ignition now, and part of > the bytecode handlers for [[Call]] and [[Construct]]. There's still some > follow-up cleanup with the way the Array constructor feedback is > integrated, but that's way easier now. > > Bug: v8:5517, v8:6399, v8:6409, v8:6679 > Change-Id: Ia0efc6145ee64633757a6c3fd1879d4906ea2835 > Reviewed-on: https://chromium-review.googlesource.com/602134 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47192} TBR=rmcilroy@chromium.org,yangguo@chromium.org,bmeurer@chromium.org Change-Id: I416ce6646f62ceb4127b3acee43912ee0d701c23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5517, v8:6399, v8:6409, v8:6679 Reviewed-on: https://chromium-review.googlesource.com/603647Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#47193}
-
Benedikt Meurer authored
Drop the deprecated CallConstructStub and remove the use of CallICStub from fullcodegen, since that feedback is unused completely every since Crankshaft got removed, thus we can safely unlink all the CallIC stuff from fullcodegen nowadays, and completely nuke the CallICStub and the CallICTrampolineStub now (we can also transitively nuke the unused CreateAllocationSiteStub and CreateWeakCellStub). Instead the CallIC logic is integrated into Ignition now, and part of the bytecode handlers for [[Call]] and [[Construct]]. There's still some follow-up cleanup with the way the Array constructor feedback is integrated, but that's way easier now. Bug: v8:5517, v8:6399, v8:6409, v8:6679 Change-Id: Ia0efc6145ee64633757a6c3fd1879d4906ea2835 Reviewed-on: https://chromium-review.googlesource.com/602134 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47192}
-
Clemens Hammacher authored
I want to reuse the PassType helper in another CL, thus move it from logging.h to template-utils.h, and rename it to pass_value_or_ref to match other helpers there. Also, add a boolean template parameter to declare whether array dimensions should be removed. The default is to do so, which helps to reduce the number of template instantiations by always passing arrays as pointers. Also, fix the usages in logging.h to actually use that helper when instantiating other template functions. This will reduce the number of instantiations. And finally, we now have unit tests for the template utils, to document what we expect, and test that this works on all architectures. R=ishell@chromium.org, tebbi@chromium.org Change-Id: I1ef5d2a489a5cfc7601c5ab13748674e3aa86cd6 Reviewed-on: https://chromium-review.googlesource.com/594247 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#47191}
-
Benedikt Meurer authored
The debugger replaces the bytecode array when breakpoints are set by walking the stack and mutating the dedicated stack slots for the bytecode arrays. This means that Ignition has to properly reload the bytecode array after calls, which works for a single call inside a bytecode handler, but fails if there are multiple calls. R=rmcilroy@chromium.org Change-Id: Ia7744edc91490014d77ad9ad17a328cab5f8530f Reviewed-on: https://chromium-review.googlesource.com/603410Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47190}
-
Ulan Degenbaev authored
This reverts commit 20d4840e. Bug: chromium:694255 TBR: mlippautz@chromium.rg Change-Id: Ie7743ca5607e6ab6d7f5683180c698d0c08fcd66 Reviewed-on: https://chromium-review.googlesource.com/603367Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47189}
-
Ulan Degenbaev authored
It was accidentally enabled in 82202251 Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I7febb8528a5116cfd43efdc41208db33841da495 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/603308Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47188}
-
Jakob Gruber authored
This reverts commit 82202251. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/14346/steps/Mjsunit/logs/large-object-literal-.. Original change's description: > [heap] Improve concurrent marking pausing protocol. > > This patch allows the concurrent marker to process more objects before > checking for the interrupt request from the main thread. > > Bug: chromium:694255 > TBR: mlippautz@chromium.org > Change-Id: I876d3156ca9843196f2fdddbd8bd28d1a3f472b1 > Reviewed-on: https://chromium-review.googlesource.com/602131 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47182} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I92ef49c4fb51468d5b5d689abbe5323f3637f1e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:694255 Reviewed-on: https://chromium-review.googlesource.com/603327Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47187}
-
Ulan Degenbaev authored
Bug: v8:6663 Change-Id: I8bf7169c21141a34e3bcb0bb2193ceb1746b33b2 Reviewed-on: https://chromium-review.googlesource.com/600908Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47186}
-
Michaël Zasso authored
The ThrowIllegalInvocation runtime function is not used anywhere. Bug: Change-Id: I1bb5386e917f0a4ff787a071cef5e13a3f85ee30 Reviewed-on: https://chromium-review.googlesource.com/600230 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47185}
-
Ulan Degenbaev authored
This patch makes the check lock-free. When concurrent marking is on, the main thread checks two marking worklist: bailout and shared. Often the bailout worklist empty, so the emptiness check is in hot path. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I5c92ea3fb6c5300d653fbd27b536241851231f24 Reviewed-on: https://chromium-review.googlesource.com/602351Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47184}
-
jgruber authored
If the subject string is a string, it's pointer-equal to the search string, and position <= 0, then we can simply return 0 and skip all other logic in String.p.indexOf. Further context at: https://twitter.com/hashseed/status/893539117367271425 Bug: Change-Id: I93ce724f0ade6332599ba395fe8c662a28f05ade Reviewed-on: https://chromium-review.googlesource.com/602214Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47183}
-
Ulan Degenbaev authored
This patch allows the concurrent marker to process more objects before checking for the interrupt request from the main thread. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I876d3156ca9843196f2fdddbd8bd28d1a3f472b1 Reviewed-on: https://chromium-review.googlesource.com/602131Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47182}
-
Ben L. Titzer authored
Move unnecessarily public methods from frames.h into .cc file. Remove dead StackFrame::SetCallerFp(). R=mstarzinger@chromium.org Bug: Change-Id: I7b66a430cfb01bb38046c9e92f504134ba8316a3 Reviewed-on: https://chromium-review.googlesource.com/602271Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47181}
-
v8-autoroll authored
Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ec00334..7770b47 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Ib4ad4ffc4ecd2c8a2bd89292c16cadab4653091e Reviewed-on: https://chromium-review.googlesource.com/603155Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47180}
-
- 06 Aug, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/0fb50e3..33a9271 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I267dd8e245167659ccb9bc609edf2effbe7ca50a Reviewed-on: https://chromium-review.googlesource.com/602643Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47179}
-
- 05 Aug, 2017 3 commits
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4736539..181c098 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/275b8c4..f4bcb07 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/a62e07f..0fb50e3 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I8f16db339cb3b16a15895cef4dbd2017d86d07d6 Reviewed-on: https://chromium-review.googlesource.com/602971Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47178}
-
Aseem Garg authored
This reverts commit 25f03308. Reason for revert: Fix the cause of bot failure and reland Original change's description: > Revert "[wasm] redirect wasm calls to js functions through a GCed table" > > This reverts commit eb65f35e. > > Reason for revert: Broke jetstream benchmark on android. > > BUG=chromium:750828 > > Original change's description: > > [wasm] redirect wasm calls to js functions through a GCed table > > > > With this patch, rather than embedding the JSReceiver address directly > > in the WasmToJS wrappers, we put that in a fixed array with global handle > > scope and instead embed the location of the handle and the index in the > > wrapper. This ensures that the wrapper doesn't need to be patched if the > > GC kicks in. This is needed to get the WASM code off the GCed heap. > > > > R=mtrofin@chromium.org > > > > Bug: > > Change-Id: Ie5a77a78cdecec51b04f702c63b8e4285e6a2d8d > > Reviewed-on: https://chromium-review.googlesource.com/581682 > > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#46884} > > TBR=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I26f49ee0a1fe73cc5d8852ded87b56638be39ebf > Reviewed-on: https://chromium-review.googlesource.com/596268 > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47059} R=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org,sullivan@chromium.org Change-Id: I29ef35f6e612a706d9f571da3e7beb1da8b5052b Bug: chromium:750828 Reviewed-on: https://chromium-review.googlesource.com/597010 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#47177}
-
Eric Holk authored
Bug: v8:6514 Change-Id: Ifda1b80a80fc0b077e982005d9493e0fe7ced471 Reviewed-on: https://chromium-review.googlesource.com/599021Reviewed-by: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47176}
-
- 04 Aug, 2017 6 commits
-
-
Adam Klein authored
It started timing out on trybots after commit 575ec863. Tbr: gdeepti@chromium.org Change-Id: Iab025ccbce15a6c9f978b737f064695d11704c93 Reviewed-on: https://chromium-review.googlesource.com/602990Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47175}
-
Bill Budge authored
This reverts commit bec2b4d2. Reason for revert: NewArrayOOM fails. Original change's description: > [Memory] Experiment to try using regular version of 'new T[]'. > > - Use normal new, vs. nothrow new. > - Modify NewArray to have only 1 invocation of new. > > Bug: chromium:752056 > Change-Id: I1a2fb3626264b1bf647af9227d55e9b54e44e8b6 > Reviewed-on: https://chromium-review.googlesource.com/600895 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47173} TBR=bbudge@chromium.org,mlippautz@chromium.org Change-Id: I881f3b75209714d11d93fae6268171ffa9cc47a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:752056 Reviewed-on: https://chromium-review.googlesource.com/602847Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#47174}
-
Bill Budge authored
- Use normal new, vs. nothrow new. - Modify NewArray to have only 1 invocation of new. Bug: chromium:752056 Change-Id: I1a2fb3626264b1bf647af9227d55e9b54e44e8b6 Reviewed-on: https://chromium-review.googlesource.com/600895Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#47173}
-
Deepti Gandluri authored
- Implemented ops: I32AtomicAnd, I32AtomicAnd8U, I32AtomicAnd16U, I32AtomicOr, I32AtomicOr8U, I32AtomicOr16U, I32AtomicXor, I32AtomicXor8U, I32AtomicXor16U - Refactor wasm-compiler AtomicOp to use macros - Tests Bug:V8:6532 R=binji@chromium.org, bbudge@chromium.org, bradnelson@chromium.org Change-Id: I7e4dc8ad8cf3e211c3aef721a02778f2a4621322 Reviewed-on: https://chromium-review.googlesource.com/600539Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#47172}
-
Adam Klein authored
This was suggested by bmeurer after running into the confusing example of: x => {x:x} which might appear to be an arrow function that returns an object literal containing its argument, but instead is an arrow function that does nothing. While it's unclear whether the language would change to make this probable programmer error an actual syntax error, we can at least gather some data on the question of whether we see any such code in the wild. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I08202039ecf7a7a4c71ad95ecd839436b4ec2af8 Reviewed-on: https://chromium-review.googlesource.com/600888 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47171}
-
Marja Hölttä authored
In some cases, PreParser cannot replicate the Scope structure created by Parser. It happens esp. with arrow function parameters, since the relevant information is already lost by the time we figure out it's an arrow function. In these cases, PreParser should bail out of trying to create data for skipping inner functions. Implementation notes: - The arrow function case is more fundamental; the non-arrow case could be hacked together somehow if we implemented tracking is_simple for each param separately; but now that it's possible to bail out consistently from both cases, I don't think the is_simple complication is worth it. - The added mjsunit test cases are based on the test262 test cases which exposed the problem. - cctest/preparser/PreParserScopeAnalysis was exercising similar cases, but the problem didn't show up because the function parameters didn't contain skippable functions. Those test cases have been repurposed for testing the bailout. - Extra precaution: the bailout tests are in a separate file, to guard from the bug that a bailout case results in bailing out of *all* data creation, which would make all skipping tests in the same file useless. BUG=v8:5516 Change-Id: I4324749a5ec602fa5d7dc27647ade0284a6842fe Reviewed-on: https://chromium-review.googlesource.com/599849Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47170}
-