- 18 Mar, 2019 25 commits
-
-
Ulan Degenbaev authored
This reverts commit 8f1c985c. Reason for revert: breaks mkgrokdump Original change's description: > [heap] Reduce page size to 256KB > > The page size of PPC is kept unchanged because PPC has larger > physical pages (64KB). > > Bug: chromium:852420 > > Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#60296} TBR=ulan@chromium.org,hpayer@chromium.org,jyan@ca.ibm.com Change-Id: I16175bea8845ac5d16dd43af1add4f2d9e94debc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528247Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60298}
-
Simon Zünd authored
The serialize set of microbenchmarks serializes Error.stack of a prepared set of error objects. When all objects have been serialized, the benchmark then wrapped around and only accessed the resulting string properties. This, of course, is a lot faster and benchmark results are heavily fluctuating when the end is reached. This CL fixes this by introducing a payload that should be similiar to the specific workload, which is executed after the end is reached. R=petermarshall@chromium.org Bug: v8:8742 Change-Id: I7183d04e7c06af0c16fe3412e902f0d33605bc25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524485Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60297}
-
Ulan Degenbaev authored
The page size of PPC is kept unchanged because PPC has larger physical pages (64KB). Bug: chromium:852420 Change-Id: Ib888ea00a476ff103e00211dbb439186148ef81e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1481631 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60296}
-
Michael Achenbach authored
Change-Id: I49aecc92054bb959278c46393ea2e5a4da262064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528241Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60295}
-
Milad Farazmand authored
The next built-in function throws a "StopIteration" when iterator is exhausted which will crash and stop the test runner. Asking it to return a "None" instead will fix the issue. Change-Id: I3ca4ff8f28f359798c9faf6f1ffbbaa6bb95f156 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524719 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Maciej Goszczycki authored
Change-Id: I626340e61e9c1a46e0d1c882cc4fa86454d93e8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526013 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60293}
-
peterwmwong authored
Bug: v8:8996 Change-Id: I035c380768c324d8912aa8bc414d533dbf7f3e5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524640 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60292}
-
Jaroslav Sevcik authored
Bug: chromium:939316 Change-Id: I2a132b6cce208e110fe30de8d75743ac7534fc94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525942 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60291}
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:8834 Change-Id: Ib6f8e8fbc571b51fdfbb389d9fc7a38c60208c1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528432Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:923361, v8:8834 Change-Id: I6ec42aeb74bea5c0629fcdc3f95c125f5de534a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526195 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Matheus Marchini authored
On LoadCodeObjectEntry check for IsOffHeapTrampoline instead of BuiltinIndexOffset so LoadCodeObjectEntry can correctly jump to the on-heap trampoline when we use --interpreted-frames-native-stack. R=jgruber@chromium.org, yangguo@google.com Bug: v8:8911 Change-Id: I172d4735671726d32328de246990b513106e3a7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516692 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Async compilation introduces nondeterminism, thus disable it for foozzie. R=ahaas@chromium.org, machenbach@chromium.org Bug: v8:8949, chromium:942941 Change-Id: Ieeb92c530de299cdd34f0d9cc3a1293b2dc5e139 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526194Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60287}
-
Andreas Haas authored
Clients of the code-assembler.h shouldn't depend on lots of compiler internals. Do not include anything from src/compiler there! R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ie6f66af47153fad0b95c53d4d9cb03b95d3501fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526196Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#60286}
-
Simon Zünd authored
Bug: v8:8834 Change-Id: I8e53e9288491a5eb50e9f27e95a6b40747e718ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526198Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60285}
-
Yu Yin authored
Change-Id: I1a30de8d889c60c59b6ef38a13f19f1fb7268622 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524756Reviewed-by:
-
Igor Sheludko authored
This reverts commit 68612784. Reason for revert: I'll follow Jakob's suggestion and fix unaligned accesses in C++ with ReadUnalignedValue(). Original change's description: > [build] Suppress UBSan alignment checks in pointer compression > > It is a design decision of pointer compression to allow unaligned pointers, > so disable this check in UBSan. > > Bug: v8:7703 > Change-Id: I3fab34e77ad755cdef3cd385a3615e3d0e350c16 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523346 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60235} TBR=jkummerow@chromium.org,machenbach@chromium.org,leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I17e669e7b5e2dea8f0686911730d27f3d2732b85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526200Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60283}
-
Mike Stanton authored
Bug: chromium:941743 Change-Id: Ic8f72bb39be43096373407ef0ec99391bbee217f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526018Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Andreas Haas authored
Anyfunc globals are very similar to anyref globals. This CL is mostly about extending the conditions which guard the anyref globals code. R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ia92ac4560102cc3ed0060342f92758db28f415ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526004Reviewed-by:
-
Andreas Haas authored
R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ica85ba80c29d6d5c5b9163df8cf743c0f1da7f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520715 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit acadb202. Reason for revert: chromium:941952 Original change's description: > [turbofan] add fast path for String.p.startsWith > > Add a fast path for String.p.startsWith(str) when length of str is 1. > > Bug: v8:8400 > Change-Id: I65e657549902dc3ad064a213d815dd098ce6455f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1491872 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60091} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400 Change-Id: Iabd66b8db0d6958686ea15a042d8567955700c9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524205 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60279}
-
Jakob Gruber authored
This was always the intended behavior: when --embedded-variant is not passed, we should assume "Default". What actually happened in this case was that we'd initialize to nullptr. This CL adds the missing nullptr check. Bug: v8:6666 Change-Id: I87247c6c6cfec20da86d2714732a2f6044bb9b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526193 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 6d209c9b. Reason for revert: chromium:941952 Original change's description: > [turbofan] add CheckSmi call to String.p.startsWith > > Add a CheckSmi call to the value of the position argument to > String.prototype.startsWith(search, [position]). > > Bug: v8:8400, chromium:939746 > Change-Id: I7462bebe0d3fde605a4c27a34c0d9bb3f0cc1c20 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514198 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60216} TBR=sigurds@chromium.org,bmeurer@chromium.org,usharma1998@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8400, chromium:939746 Change-Id: Ifee58b9e57313bbf93bca293e92d88af279a0261 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524204 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 4925495c. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20nosnap%20-%20shared/32627 https://ci.chromium.org/p/v8/builders/ci/V8%20Win64/29699 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60274} TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I62fa43fc614c1b1dffd841aa22a7a590c3a63cd1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528232Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: I8569f99d498b79d943c1c178eafea48629d68fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526017Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60275}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..c899486 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..efe902b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I439f9415dd63820d8f665550a5ff89372e8620c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60274}
-
- 16 Mar, 2019 4 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ae9325..e8b8ab7 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c79f348..a14f996 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8e2315..4e9bccd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/04600b4..24b5f90 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icfe9aaa08e5ab196c1ce375a9fbfc753a44ccc8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526729Reviewed-by:
-
Michael Achenbach authored
This ports: https://crrev.com/c/1519726 TBR=tmrts@chromium.org Bug: chromium:930050 Change-Id: I3afcfd28e8fdd5b97946e327997a58a488d4f1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526014Reviewed-by:
-
Alexei Filippov authored
This is a reland of 5a61630d Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org Bug: v8:8988 Change-Id: I9b1db01856a43636c1eb8ad2ec36e3727353228d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524668 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60271}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/a2b5691..2f5d8e7 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2f5d8e7 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/0e1021a Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/b65f68d Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2c9b327 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/5ad5fe2 Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/b2fefbd Update index.bs (Sven Sauleau) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/2478368 Normative: Read the imports synchronously in WebAssembly.instantiate(Module). (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/16a91bd ... TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I33cb12bc8c456517c809485e4d8aca1c19df0605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526725Reviewed-by:
-
- 15 Mar, 2019 11 commits
-
-
Matt Gardner authored
The existing has property handling did not account for the fact an IC can have LOAD_IGNORE_OUT_OF_BOUNDS while some of the maps in the IC do not allow out of bounds loads. bug: chromium:942068 Change-Id: I935402d9d72e9c0228510ef69154ea130d1c71f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525876Reviewed-by:
-
Santiago Aboy Solanes authored
We have a version for each (Any, Pointer, Signed) Bug: v8:8977 Change-Id: I1df994f96e24183a136c25818bf4917d9f8126d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524481Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This slot has become obsolete now that all CEntry stubs are builtins (which are part of the rootset) and no longer need to be kept alive explicitly by a slot in the frame. R=verwaest@chromium.org BUG=v8:8834 Change-Id: I7b791cc509ef800bcf7aa5faab31ddf35370f944 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520725Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This asserts that we run e.g. GC finalization tasks. Without that, we might run ouf of memory. R=ahaas@chromium.org Bug: chromium:938739 Change-Id: Ic80074f877183bcabb3353fbeff94842a534efab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526007Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I5c391f606994ba1fc3dfb53483a0cc0f1caa25e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521107Reviewed-by:
-
Clemens Hammacher authored
We were just counting the number of stack elements instead of their actual memory usage. This limits recursion a lot more and helps avoiding OOM situations. R=titzer@chromium.org Bug: chromium:938739 Change-Id: I0e0ec2949f9fbad9c9e2c8677ec0223d5cd6a24b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526006Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60264}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/77c810a..6ae9325 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1c2fa0f..04600b4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I97e0449cc11eb30e890862c044cfde59172ed75d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525864Reviewed-by:
-
Michael Starzinger authored
This changes gcmole's bootstrapping script so that it always creates binaries that link libstdc++ statically (both plugin and Clang) and do not link against unneeded libraries (only Clang). For deployment of gcmole on our infrastructure, it is much easier to have fewer external dependencies. R=machenbach@chromium.org BUG=v8:8813 Change-Id: If6f2f3cc3b1f661f7dafbb406eaaf2e639981640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526002Reviewed-by:
-
Simon Zünd authored
Compiling without -fno-exceptions causes compilation errors, this CL fixes that. The reason for the compilation error is a mismatch of "V8_NOEXCEPT" on mixins for base::Optional where it is not present for deleted copy/move constructors, but present on base::Optional for defaulted ones. Bug: v8:8985 Change-Id: I54af77496657fde44292c050221d11533a54db03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518175 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60261}
-
Michael Achenbach authored
Bug: v8:8813 Change-Id: I3c173a0c8846a2728e020581fbcaac269f850162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523786Reviewed-by:
-
Michael Starzinger authored
This is a false positive of a potential evaluation order problem flagged by the newest version of gcmole. While this is strictly speaking safe, it is not statically known that the default argument of the fourth parameter to {AbsoluteAndNot} is a nullptr and hence not a stale raw reference. Since this is the only false positive of this kind in the code base, I would vote to just avoid it by sequencing the operations. R=jkummerow@chromium.org BUG=v8:8813 Change-Id: I4a8f2ed4eb09766ce98e4e3d32f680a3a84eedf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523548Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60259}
-
