- 18 Mar, 2021 15 commits
-
-
Michael Achenbach authored
Ensure more testing of --future for different test types on Mac. No-Try: true Bug: v8:11527 Change-Id: Iac499dc48dde3342ad2057f86ef1ad5fa43b4eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772981Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73514}
-
Clemens Backes authored
We do not emit this opcode in the asm.js to wasm translator, hence we do not need to handle this case in the function body decoder. Replace it by a DCHECK to catch bugs where we might accidentally emit the opcode. R=thibaudm@chromium.org Change-Id: Ibaa07099f30b871c28e3d3cebae96277f46e3164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2768619Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73513}
-
Milad Fa authored
Port d16eefe0 Original Commit Message: We currently canonicalize shuffles in the architecture specific instruction selector. This has the drawback that if we want to pattern match on nodes that have a shuffle as input, they need to individually canonicalize the shuffle. There can also be a subtle bug if we canonicalize the same shuffle node twice (see bug for details). This moves the canonicalization to "construction time", in wasm-compiler, when building the graph. As such, any pattern matches in instruction-selector will only need to deal with canonicalized shuffles. We introduce a new kind of parameter for shuffle nodes, ShuffleParameter, to store the 16 bytes plus a bool indicating if this is a swizzle. A swizzle essentially: inputs to the shuffle are the same or all indices only touch 1 input. We calculate this when canonicalizing, so store this bit of information inside of the node's parameter. We update the tests in x64 to handle special cases where, even though the node's inputs are not swapped (due to canonicalization), they need to be swapped for the specific instruction selected (e.g. palignr). The test data also contains canonicalized shuffles, so we have to manually canonicalize them. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I9872fcdaa06739c8972f02d81e77bcbf372126c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2773138Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73512}
-
Jakob Kummerow authored
This patch moves a first function, Compare, from src/objects/bigint.cc to src/bigint/, to blaze the trail. More to follow! Bug: v8:11515 Change-Id: Id7fa0b40ea852dbed1360f7ab439cb32d0c15762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2737295Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73511}
-
Thibaud Michaud authored
Live ranges defined by a constant operand normally don't require a spill slot since they can just rematerialize the value from the constant. In the attached issue however, deoptimization adds an explicit slot requirement for a range that is defined by a constant operand. This case is not expected in the register allocator and we eventually hit a DCHECK. This fix allocates a new stack slot during the MeetRegisterConstraints and adds the missing gap move. Drive-by: remove dead method LiveRange::NextSlotPosition. R=sigurds@chromium.org CC=nicohartmann@chromium.org Bug: chromium:1146880 Change-Id: I08fbb890f2f3d9574196989cf3e5ef6232433484 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563689Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73510}
-
Ross McIlroy authored
Reduces the overhead of mid-tier optimization without much impact on mid-tier generated code performance. BUG=v8:9684 Change-Id: I81889049f718ec2b18a805b11aab119754466c95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772611 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#73509}
-
Ross McIlroy authored
RepresentationFor is quite hot in MidTierAllocator profiles. To optimize this, instead stash the representation in the VirtualRegisterData and pass that about consistently instead of passing the virtual_register int and having to retrieve both representation and VirtualRegisterData for the vreg multiple times. This improves mid-tier allocation time by ~8% on Octane benchmarks. BUG=v8:9684 Change-Id: Ied01fbdab013c278da022d1df321b08fbfc68a4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2768618Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73508}
-
Georgia Kouveli authored
The previous uses of LR here allowed overwriting it with arbitrary addresses that aren't signed. Change this so we never return to an arbitrary LR. This makes a difference even when we replace the RET with a BR, because BR is constrained by BTI, whereas RET isn't. Bug: v8:10026 Change-Id: Ibbf326ccf0cf32f6d9541c7a82108dc0373827df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767015Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#73507}
-
Georgia Kouveli authored
Bug: v8:10026 Change-Id: Ie040d36d9a98943f97236998df53408bb060d028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764760Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#73506}
-
Igor Sheludko authored
... when v8_enable_short_builtin_calls is enabled for current build configuration. Bug: v8:11527 Change-Id: Ie7edf7ede5822f3b8f7ec815c89d0c50ec7657bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2770880 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73505}
-
Thibaud Michaud authored
Fix target stack height of multi-value try blocks. R=clemensb@chromium.org Bug: chromium:1187896 Change-Id: I698b06141e65f7b545a695c035b862af31dd8875 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772236Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73504}
-
Igor Sheludko authored
... because serialization of RUNTIME_ENTRY reloc infos is not supported yet. Bug: v8:11527 Change-Id: I0a0451710f7dd57b6393b8fad1620d29346a9f49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772602Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73503}
-
Manos Koukoutos authored
This reverts commit a3b1233e. Reason for revert: This approach has multiple issues and we have to reconsider it. Original change's description: > [turbofan] Optimize TrapIf/Unless in BranchElim. and CommonOp-Reducer > > Bug: v8:11510 > Change-Id: I1e8fcb54444e494c7d765ad556d09d954441361f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752876 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73468} Bug: v8:11510 Change-Id: Id35bc4ebcb45a617f61993d857ad2291b0287ad6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772600 Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73502}
-
Igor Sheludko authored
This is a reland of 5f9f09f4 Original change's description: > [sparkplug] Enable shorter builtin calls behind --short-builtin-calls > > ... on desktop x64 and arm64 if pointer compression is enabled. > > Bug: v8:11527 > Change-Id: Ie23b59312c6db34a5f40e23347b3c4f11173612d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767222 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73498} Bug: v8:11527 Change-Id: I5b5524b6b4b301e4afcc09e4621942b77b56c07d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2772235Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73501}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/37b76d6..ff9d9de Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b965b65..c730dae Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/36de4be..2737963 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/752611e..41f9e2d Rolling v8/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816 Rolling v8/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816 Rolling v8/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7a3f21d3d171596b6d98a843379bd1c146f2ae54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2771598Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73500}
-
- 17 Mar, 2021 25 commits
-
-
Zhi An Ng authored
This reverts commit 5f9f09f4. Reason for revert: Broke https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20-%20release%20builder/21079/overview Original change's description: > [sparkplug] Enable shorter builtin calls behind --short-builtin-calls > > ... on desktop x64 and arm64 if pointer compression is enabled. > > Bug: v8:11527 > Change-Id: Ie23b59312c6db34a5f40e23347b3c4f11173612d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767222 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73498} Bug: v8:11527 Change-Id: I48ec54a134a293e31d4d26ce3a82a27a714fde6a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2770599 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73499}
-
Igor Sheludko authored
... on desktop x64 and arm64 if pointer compression is enabled. Bug: v8:11527 Change-Id: Ie23b59312c6db34a5f40e23347b3c4f11173612d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767222 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73498}
-
Thibaud Michaud authored
Throwing an object that needs special property lookup currently traps when we catch it in wasm. We should just return undefined to let the caller know that this is not a wasm exception object. Drive-by: use the named {caught_tag} register consistently. R=clemensb@chromium.org Bug: chromium:1188825 Change-Id: I8ebd4db756ac7ba04208ab43c7349c28b813fc49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767519Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73497}
-
Jakob Kummerow authored
This brings the WasmModuleBuilder in the mjsunit test suite up to date wrt. the latest changes of the GC proposal. Bug: v8:7748 Change-Id: I4e1a3d34a1e83626ab89d2fa0e10ca4aa61d75ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2690590 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73496}
-
Ng Zhi An authored
We currently canonicalize shuffles in the architecture specific instruction selector. This has the drawback that if we want to pattern match on nodes that have a shuffle as input, they need to individually canonicalize the shuffle. There can also be a subtle bug if we canonicalize the same shuffle node twice (see bug for details). This moves the canonicalization to "construction time", in wasm-compiler, when building the graph. As such, any pattern matches in instruction-selector will only need to deal with canonicalized shuffles. We introduce a new kind of parameter for shuffle nodes, ShuffleParameter, to store the 16 bytes plus a bool indicating if this is a swizzle. A swizzle essentially: inputs to the shuffle are the same or all indices only touch 1 input. We calculate this when canonicalizing, so store this bit of information inside of the node's parameter. We update the tests in x64 to handle special cases where, even though the node's inputs are not swapped (due to canonicalization), they need to be swapped for the specific instruction selected (e.g. palignr). The test data also contains canonicalized shuffles, so we have to manually canonicalize them. Bug: v8:11542 Change-Id: I4e78082267bd03d6caedf43d68d81ef3f5f364a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762420Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73495}
-
Michael Lippautz authored
Refactor SpacePolicy on a non-templated class to avoid the situation of having MakeGarbageCollectedTraitBase<T>::SpacePolicy<U> refer to different T and U which make it hard for the compiler to alias anything. Bug: chromium:1056170 Change-Id: I78eb0362d43403ad2712bcb65746eeb9f6ad44fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2769338Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73494}
-
Ulan Degenbaev authored
Previously we needed to register the backing stores globally because the embedder could create them from a raw pointer. This is no longer possible after the removal of the old API. The global backing store registry now keeps track only of wasm memory backing stores. Bug: v8:9380 Change-Id: Iffefbf14dcafc1f9ce0dc3613335c754c9cb649a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2763874Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#73493}
-
Milad Fa authored
Also added multiply low/high and vector merge instructions to the simulator. Change-Id: I889004b5572ee7df75be706c424ac2e83e53e8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2769058 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73492}
-
Shu-yu Guo authored
Bug: chromium:1188868 Change-Id: If3916891806b7db7c4556f0dc50ae73afa06036c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2766223 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73491}
-
Clemens Backes authored
This tests the 'beforeScriptWithSourceMapExecution' mode of setInstrumentationBreakpoint for wasm. R=bmeurer@chromium.org Bug: chromium:1151211 Change-Id: I3020ab3e67e090407e2641a105c513e7614aa305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764342 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73490}
-
Ng Zhi An authored
These tests require --validate-asm, which is available only on WebAssembly enabled builds. This was causing problems on https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/15320/overview. Moving them into regress/asm, the status file automatically skips these tests if WebAssembly is not enabled. Bug: v8:11238 Change-Id: Ib337fb6bd43319f61a33302efd4277c092935a9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767600 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73489}
-
Igor Sheludko authored
Bug: v8:11421 Change-Id: Ia4d3a20b9fdb5bc262cf480ece6e189aedff388f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2762143 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73488}
-
Andreas Haas authored
The machine graph verifier did not handle kUnalignedLoad and kUnalignedStore yet, which caused problems with debug builds on arm. R=mvstanton@chromium.org Bug: v8:11384 Change-Id: I1a33c1e5993f9f0dd453a2d3f757e0eaff65b479 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2756213Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73487}
-
Omer Katz authored
Sweeper cannot assume that platform never changes, so that we can support using testing-specific platforms. Instead, the sweeper gets the current platform from HeapBase on sweeping start. The platform is set to nullptr whenever sweeping is not active. Bug: chromium:1056170 Change-Id: I749e1dbfa204635fbb446a8c383aaa2548a717be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767139Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73486}
-
Camillo Bruni authored
- Fix link to older tool versions - Adapt card style to versions page NOTRY=true Change-Id: Id857cc1220605d9bf62e1b810bd46c5766633383 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767228 Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73485}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: If779c3c581317fb062c062a3ad60d1eebc1743d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767142Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73484}
-
Milad Fa authored
Change-Id: Ic4dff5209279f51ed75c76f2a0b159c727fb6164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767198Reviewed-by: Junliang Yan <junyan@redhat.com> Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#73483}
-
Ng Zhi An authored
Bug: v8:11577 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ie83cb991bdd9f6dc680824fa313fafa198ad9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767599 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73482}
-
Andreas Haas authored
The bulk-memory proposal and the reference types proposal have been merged into the main repository, so we don't have to run the proposal tests anymore. R=ecmziegler@chromium.org Change-Id: I14583b8c1c387075442a402458ce04e7c6071f89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2752165 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#73481}
-
Thibaud Michaud authored
If the block is unreachable, the interface is not called and the {try_info} field is not set. Therefore, check it before accessing it. R=clemensb@chromium.org Bug: chromium:1188975 Change-Id: Ic6d7d2b7e26b0448143076e25a89c036216e8618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767017Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73480}
-
Thibaud Michaud authored
This completes support for encoding/decoding exception values of any type, and with that completes exception handling support in Liftoff. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ie70b16478061cb68f3165b96c3806503f9908b6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767141 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73479}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I0d02162e1a6974b550ec23ebb93c2478112a704d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767023 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73478}
-
Clemens Backes authored
The text representation of that opcode is "memory.grow", so the macro should also be called WASM_MEMORY_GROW. This is also consistent with WASM_MEMORY_SIZE. R=thibaudm@chromium.org Change-Id: Ibda328e52418d04392856820d3099f2dadaaf98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764466Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73477}
-
Igor Sheludko authored
This is a speed-for-memory tradeoff, which can be achieved by re-mapping the builtins code blob into existing code range. This CL handles cases where both embedded and un-embedded off-heap builtins' PCs might appear on the call stack. The v8_enable_short_builtin_calls build flag is still disabled. Bug: v8:11527, v8:11421 Change-Id: Ie3db6eb8e264854df42b936a97d3e73d01de5dfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749636 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#73476}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:11453 Change-Id: I3aada28f3cb9839b2d5fc7e85f5fe87018d17d1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767022 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73475}
-