- 14 Jun, 2019 28 commits
-
-
Milad Farazmand authored
Port 7b48dd55 Original Commit Message: This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. R=delphick@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ie696468685517333515bf4b0b78fdd7d8c4e7763 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660628Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#62187}
-
Sigurd Schneider authored
This is a reland of 7e7c1b10 Original change's description: > [cleanup] Add operator parameter accessor for S8x16Shuffle > > Bug: v8:7517, v8:9183 > Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 > Auto-Submit: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62177} TBR=tebbi@chromium.org Bug: v8:7517, v8:9183 Change-Id: Ia72d73416b2d6b8e7e2fba97cfce39e4ab387a08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660610 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62186}
-
Daniel Vogelheim authored
This extends the existing Isolate::SetAllowCodeGenerationFromStringsCallback mechanism, by adding SetModifyCodeGenerationFromStringCallback, which can also modify the eval argument (it could e.g. add escaping). Bug: chromium:940927 Change-Id: I2b72ec2e3b77a5a33f428a0db5cef3f9f8ed6ba2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593336Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#62185}
-
Igor Sheludko authored
It will allow us to use knowledge about the type of field during value decompression upon field read. Use the new class for HeapObject::MapField. Bug: v8:9353 Change-Id: I1368426ec2e25fcec3af8d5cccd7a78d80423e72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658150 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: I3913ce4bb69895994a0e397f0f96c83813668ea4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660480Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#62183}
-
Tobias Tebbi authored
This is a reland of 6eff6cc9 Original change's description: > [torque] introduce separate implicit parameters for JavaScript calling convention > > Implicit parameters for builtins with JavaScript linkage are now separate, using > the keyword "js-implicit". They have to be one of: > - context: Context > - receiver: Object (this in JS) > - target: JSFunction (arguments.callee in JS) > - newTarget: Object (new.target in JS) > > Bug: v8:9120 v8:7793 > > Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62174} TBR=tmrts@chromium.org Bug: v8:9120 v8:7793 Change-Id: Idb25d316d9d87e345ab74c2df583ff2648da012c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660483 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Bug: v8:8801,v8:8394,v8:9183 Change-Id: If6a4f39991f222337f1c49bd0439e9669d89b030 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660486 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 7e7c1b10. Reason for revert: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8910673611629290864/+/steps/OptimizeForSize/0/logs/RunWasm_S16x4Reverse_simd_lowered/0 Original change's description: > [cleanup] Add operator parameter accessor for S8x16Shuffle > > Bug: v8:7517, v8:9183 > Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 > Auto-Submit: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62177} TBR=sigurds@chromium.org,tebbi@chromium.org Change-Id: Ic26376c9fe28e7e74cbdb1fa9ec2f7627d2adeee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7517, v8:9183 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660609Reviewed-by:
-
Yang Guo authored
This reverts commit a66e3e57. Reason for revert: Likely to have caused UBSAN issues: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/6671 Original change's description: > [csa] Tweak CSA pipeline to eliminate more redundant checks > > - Lower LoadObjectField to LoadFromObject > - Mark LoadFromObject and StoreToObject as non-allocating > - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check > > R=jarin@chromium.org, tebbi@chromium.org > > Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 > Commit-Queue: Georg Schmid <gsps@google.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62173} TBR=jarin@chromium.org,tebbi@chromium.org,gsps@google.com Change-Id: I0a1c0515a8a61d32f77a392f1efc0751b6aae2a1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660485Reviewed-by:
-
Ross McIlroy authored
Bug=v8:8801,v8:8394,v8:9183 Change-Id: I5bd3505938a49dab0299f1d1d022e8a31cc806c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660479 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7517, v8:9183 Change-Id: Ic9beade6893b81aaa77f9c634cbeb7444260907b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/973375 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62177}
-
Sergiy Belozorov authored
See example v8_linux64_perf_try(_triggered) builds on this CL triggered using the following command lines: python tools/try_perf.py --linux64 --confidence-level 1 compile python tools/try_perf.py --linux64 --confidence-level 1 arewefastyet python tools/try_perf.py --linux64 --confidence-level 3 arewefastyet This also fixes running tools/run_perf.py --help and adds logging for the current confidence level, which allows users to monitor progress. Example runs: https://chrome-swarming.appspot.com/task?id=456e4d6e743cc510 (Compile) https://chrome-swarming.appspot.com/task?id=456e5145615aa510 (JetStream) https://chrome-swarming.appspot.com/task?id=456e53eeb9104410 (JSBench) https://chrome-swarming.appspot.com/task?id=456e541e0e13bc10 (AreWeFastYet) Finally, this adds support for fractional confidence levels. Example runs: https://chrome-swarming.appspot.com/task?id=456e5970e6f24410 (AreWeFastYet) https://chrome-swarming.appspot.com/task?id=456e5a8f3f407c10 (Compile) R=tmrts@chromium.org, machenbach@chromium.org Bug: chromium:880724 Change-Id: I725a83060c0bdd3ef08a7f0e4df843611c712d37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660471Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#62176}
-
Yang Guo authored
This reverts commit 6eff6cc9. Reason for revert: Presubmit failure. Original change's description: > [torque] introduce separate implicit parameters for JavaScript calling convention > > Implicit parameters for builtins with JavaScript linkage are now separate, using > the keyword "js-implicit". They have to be one of: > - context: Context > - receiver: Object (this in JS) > - target: JSFunction (arguments.callee in JS) > - newTarget: Object (new.target in JS) > > Bug: v8:9120 v8:7793 > > Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62174} TBR=sigurds@chromium.org,tebbi@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: Ide206788745bd15677bd60fe32d2476321967069 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9120 v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660482Reviewed-by:
-
Tobias Tebbi authored
Implicit parameters for builtins with JavaScript linkage are now separate, using the keyword "js-implicit". They have to be one of: - context: Context - receiver: Object (this in JS) - target: JSFunction (arguments.callee in JS) - newTarget: Object (new.target in JS) Bug: v8:9120 v8:7793 Change-Id: I916f60971bb53d5046b6006725d0ce39291ca55e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658159Reviewed-by:
-
Georg Schmid authored
- Lower LoadObjectField to LoadFromObject - Mark LoadFromObject and StoreToObject as non-allocating - Use optimizable BitcastTaggedSignedToWord in TaggedIsNotSmi check R=jarin@chromium.org, tebbi@chromium.org Change-Id: I42992d46597be795aee3702018f7efd93fcc6ebf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657926 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
-
Ross McIlroy authored
Bug=v8:8801,v8:8394,v8:9183 Change-Id: I9d88d2aa2b261b0f8df83dd6075b68cbc626161f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660476 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Simon Zünd authored
The CL https://crrev.com/c/1646846 changed column numbers for Wasm frames in Error.stack traces. Instead of using the offset relative to the beginning of the function, the absolute offset inside the module is displayed as hex. This CL propagates that change to the StackTrace C++ API, so StackFrame::GetColumn() also returns the absolute offset. Note that the StackFrame API historically uses "0" to signal "no information", so the line and column numbers for Wasm frames are also adjusted to 1-based, even though they signify function index and absolute offset into the module. This CL does not touch Script::PositionInfo.column. That field still contains the offset relative to the function start. Bug: v8:8742 Change-Id: If4fd37fa681c7ebd0823ce0d95eccc1335c35272 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655300 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Dan Elphick authored
This changes Generate_ContinueToBuiltinHelper to generate code to load the builtin address directly from the builtins table rather than going via the executable code in the trampoline's code object. The set up for Generate_ContinueToBuiltinHelper is changed so that the builtin index is stored on the stack in place of the builtin Code object which is no longer needed. Bug: v8:9338 Change-Id: I83f66af99fb27f131fc39ff426fdca4b1d674b70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648155 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62170}
-
Andreas Haas authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: Ia534816b460eaf005a0017afeb2d55ccb3402a37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660473Reviewed-by:
-
Andreas Haas authored
R=mythria@chromium.org Bug: v8:9183 Change-Id: Id7c29452ef6d643b59eb3252df188bf288e2de23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660469Reviewed-by:
-
Jakob Kummerow authored
Func::type() was broken for functions created with Func::make(). Change-Id: I2867bcf00d9e5c1488165a804598c9ca8081ff25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655648 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62167}
-
Andreas Haas authored
I removed the following entries: .d8_history - afaict, this does not exist anymore. If it exists, it would be in the out/ directory and thereby ignored anyways. /hydrogen.cfg - hydrogen is no more. /obj - this is now also in the out/ directory. d8_g - I think this does not exist anymore, or would be in the out/ directory. shell - If it still exists, it would be in the out/ directory. shell_g - same here. NOTRY=true R=jkummerow@chromium.org Bug: v8:9183 Change-Id: Iadb8d2533bfdda1190ec3a31a9ca9c199e087fd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660468Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
When iterating over the holdings inside the cleanup callback, we could potentially unregister the weakref which is next or prev on the key list causing these checks to be incorrect. Bug: v8:9360, v8:8179 Change-Id: I53ea12346eb4882b16a82677b64ba2c756d23a1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658161Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62165}
-
Simon Zünd authored
This CL introduces two usage counters for two CallSite functions in sloppy mode: - getFunction() - getThis() Chromium CL: https://crrev.com/c/1657902 Bug: v8:8742 Change-Id: I81e8fec48534f5932a72de86d9d21f3b370c66a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657919 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Yu Yin authored
Port ea420655 https://crrev.com/c/1651470 Original Commit Message: API calls made via the CallApiCallback builtin, which is used from the ICs and optimized code, are currently misattributed to the wrong counter InvokeFunctionCallback instead of FunctionCallback. In addition we don't use the C trampoline when only runtime call stats are enabled, but the Chrome DevTools profiler is not active, which means that these calls will not be attrituted properly at all, and that had to be worked around using all kinds of tricks (i.e. disabling fast-paths in ICs when RCS is active and not inlining calls/property accesses into optimized code depending on the state of RCS). All of this was really brittle and only due to the fact that the central builtin didn't properly check for RCS (in addition to checking for the CDT profiler). With this fix it's now handled in a central place and attributed to the correct category, so user code doesn't need to worry about RCS anymore and can just call straight into the fast-path. core hand-written native code with the API callback logic. Change-Id: I6bcc8c4d7f4642381803a8b6c8282ceb8f3d056c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1659988 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#62163}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/afe9cbd..be4d13b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5b97b40..8756a42 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/78822a6..ad46488 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/727d7ca..e502dbc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/374a128..bc23ca1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/fe6c647..539db7d TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Icfa6b96961df31243cd0597ca0b1c8c8ee6003bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1660030Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62162}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/a9abd4..49eee8b Bug: v8:7834 Change-Id: I90de157926001b8db0c7992965b9c2ee762d78ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1656055Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Yu Yin authored
Change-Id: I2453256c192a5b58f241c4c73a32e8d41cf55a0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657973 Auto-Submit: Yu Yin <xwafish@gmail.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#62160}
-
- 13 Jun, 2019 12 commits
-
-
Fabrice de Gans-Riberi authored
Zircon VMOs are now created non-resizeable by default. This family of flags is now a no-op and they will soon be removed. Bug: chromium:973981 Change-Id: I99b5a18b9744e32ebb3f33f1a848ee9b5c51eb0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1659568 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#62159}
-
Z Nguyen-Huu authored
Use FastJSArrayForRead pattern. Add test of array.reduce, array.reduceRight for non-extensible, sealed, frozen objects similar to mjsunit/array-reduce.js ~3x perf improvement in JSTests/ObjectFreeze micro-benchmark Before: ArrayReduce ArrayReduce-Numbers(Score): 0.0740 ArrayReduceRight ArrayReduceRight-Numbers(Score): 0.0767 After: ArrayReduce ArrayReduce-Numbers(Score): 0.249 ArrayReduceRight ArrayReduceRight-Numbers(Score): 0.261 Bug: v8:6831 Change-Id: I98f54f010256993fcd05bb24be968fb2d0f5c966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1656851 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Maya Lekova authored
Remove dead code and move a condition earlier, as discussed in http://doc/1I1yzlXM79M7W5QfVjTwSSTEQsRCjdfo8cgSQXkeqlZQ#heading=h.e7x2k9l4bmi7 Bug: v8:9183 Change-Id: Iaba7233e47ee19d2be5501ce6046f3956532513c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658155 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#62157}
-
Z Nguyen-Huu authored
Bug: v8:6831 Change-Id: I61d4080e11e354fb47d5c79c3c26076488f3fe13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1656852 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Dan Elphick authored
Disable bytecode flushing for test as it messes up lazy source positions and the flags aren't representative anyway. Bug: v8:8510 Change-Id: I6d5bc8dcd174a9bfc48f682518e6c62d79acb691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658152 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of 811bfbbc Original change's description: > [regexp] Move AST-to-Node code to a dedicated file > > Prior to this CL, jsregexp contains a bunch of things that are slightly > related but would be cleaner in separate files, including: AST-to-Node > transformations, the compiler implementation, and a debugging printer. > > This CL extracts AST-to-Node transformations. > > Bug: v8:9359 > Change-Id: I030cfca5c40cfd72e3a7abe2188e4654cfe2277c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655303 > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62148} Tbr: yangguo@chromium.org Bug: v8:9359 Change-Id: I68a16086dc56c9a059547033ca8bc1e9de1080db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658568Reviewed-by:
-
Seth Brenith authored
Include API-instantiated functions in the definition of Callable so that PromiseReactionJobTask::handler can verify correctly. Also make Callable verification stricter regarding JSProxy instances: they must have the callable bit set. Also update test-weak-references to use a different object type, since FeedbackVector::optimized_code_weak_or_smi should never point to a FixedArray. Bug: v8:9311 Change-Id: I4242df993e381a75f5b53302fee8fd2b12e96d34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1650563 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Mythri A authored
The store element handlers don't check if the array length is writable before updating the length. Since this is not expected to be a common case no need of handling this in the element handlers. Just moving to megamorphic would be sufficient. Bug: chromium:967104 Change-Id: I7a7f9ea768266b9ffd6289328d61d2297d455619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658154 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Dan Elphick authored
Since TurboAssembler::CallBuiltinPointer actually takes the builtin_index as input, rename the function to CallBuiltinByIndex. Bug: v8:9183 Change-Id: I4958d96f18a48a2ec91525d80d597a35e45d5989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1657915 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Darius Mercadier authored
With this flag enabled, some statistics about the oldspace's freelists (and free/used spaced in general) are printed before and after each major garbage collection. It is useful to get some intuition about fragmentation and debug freelists. (This flag helped me track down the issues fixed by CLs 1647162 and 1648476) Additionally, the verbose version (FLAG_trace_gc_freelists_verbose) prints the freelists of each page of old_space. Bug: v8:9329 Change-Id: Ifa80426bf9d97ac9950459154507a585b039326d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655302 Commit-Queue: Darius Mercadier <dmercadier@google.com> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 811bfbbc. Reason for revert: Breaks noi18n build (https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/27201) Original change's description: > [regexp] Move AST-to-Node code to a dedicated file > > Prior to this CL, jsregexp contains a bunch of things that are slightly > related but would be cleaner in separate files, including: AST-to-Node > transformations, the compiler implementation, and a debugging printer. > > This CL extracts AST-to-Node transformations. > > Bug: v8:9359 > Change-Id: I030cfca5c40cfd72e3a7abe2188e4654cfe2277c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655303 > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62148} TBR=yangguo@chromium.org,jgruber@chromium.org,petermarshall@chromium.org Change-Id: I079e15b02d73d81aef806992f324f08d7008e367 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1658160Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62149}
-
Jakob Gruber authored
Prior to this CL, jsregexp contains a bunch of things that are slightly related but would be cleaner in separate files, including: AST-to-Node transformations, the compiler implementation, and a debugging printer. This CL extracts AST-to-Node transformations. Bug: v8:9359 Change-Id: I030cfca5c40cfd72e3a7abe2188e4654cfe2277c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655303 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
