1. 12 May, 2016 19 commits
  2. 11 May, 2016 21 commits
    • lpy's avatar
      Revert of Implement CPU time for OS X and POSIX. (patchset #10 id:180001 of... · bfb1c9e6
      lpy authored
      Revert of Implement CPU time for OS X and POSIX. (patchset #10 id:180001 of https://codereview.chromium.org/1959103004/ )
      
      Reason for revert:
      Buildbot is failing on Mac release build.
      
      Original issue's description:
      > Implement CPU time for OS X and POSIX.
      >
      > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch
      > implements CPU time for OS X and POSIX to provide more accurate
      > accounting of CPU time used by each thread.
      >
      > BUG=v8:4984
      > LOG=n
      >
      > Committed: https://crrev.com/025f3d262bab2748362374f1b90ac723a9655ee4
      > Cr-Commit-Position: refs/heads/master@{#36188}
      
      TBR=jochen@chromium.org,bmeurer@chromium.org,fmeawad@chromium.org,rsesek@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4984
      
      Review-Url: https://codereview.chromium.org/1966173003
      Cr-Commit-Position: refs/heads/master@{#36189}
      bfb1c9e6
    • lpy's avatar
      Implement CPU time for OS X and POSIX. · 025f3d26
      lpy authored
      V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch
      implements CPU time for OS X and POSIX to provide more accurate
      accounting of CPU time used by each thread.
      
      BUG=v8:4984
      LOG=n
      
      Review-Url: https://codereview.chromium.org/1959103004
      Cr-Commit-Position: refs/heads/master@{#36188}
      025f3d26
    • jshin's avatar
      Use ICU case conversion/transliterator for case conversion · b348d47b
      jshin authored
      When I18N is enabled, use ICU's case conversion API and transliteration
      API [1] to implement String.prototype.to{Upper,Lower}Case and
      String.prototype.toLocale{Upper,Lower}Case.
      
      * ICU-based case conversion was implemented in runtime-i18n.cc/i18n.js
      * The above 4 functions are overridden with those in i18n.js when
        --icu_case_mapping flag is turned on. To control the override by the flag,
        they're overriden in icu-case-mapping.js
      
      Previously, toLocale{U,L}Case just called to{U,L}Case so that they didn't
      support locale-sensitive case conversion for Turkic languages (az, tr),
      Greek (el) and Lithuanian (lt).
      
      Before ICU APIs for the most general case are called, a fast-path for Latin-1
      is tried. It's taken from Blink and adopted as necessary. This fast path
      is always tried for to{U,L}Case. For toLocale{U,L}Case, it's only taken
      when a locale (explicitly specified or default) is not in {az, el, lt, tr}.
      
      With these changes, a build with --icu_case_mapping=true passes a bunch
      of tests in test262/intl402/Strings/* and intl/* that failed before.
      
      Handling of pure ASCII strings (aligned at word boundary) are not as fast
      as Unibrow's implementation that uses word-by-word case conversion. OTOH,
      Latin-1 input handling is faster than Unibrow. General Unicode input
      handling is slower but more accurate.
      
      See https://docs.google.com/spreadsheets/d/1KJCJxKc1FxFXjwmYqABS0_2cNdPetvnd8gY8_HGSbrg/edit?usp=sharing for the benchmark.
      
      This CL started with http://crrev.com/1544023002#ps200001 by littledan@,
      but has changed significantly since.
      
      [1] See why transliteration API is needed for uppercasing in Greek.
          http://bugs.icu-project.org/trac/ticket/10582
      
      R=yangguo
      BUG=v8:4476,v8:4477
      LOG=Y
      TEST=test262/{built-ins,intl402}/Strings/*, webkit/fast/js/*, mjsunit/string-case,
           intl/general/case*
      
      Review-Url: https://codereview.chromium.org/1812673005
      Cr-Commit-Position: refs/heads/master@{#36187}
      b348d47b
    • bjaideep's avatar
      PPC: [Interpreter] Fix incorrect frame walking in arguments create stubs · adcc5119
      bjaideep authored
      Port 40f34541
      
      Original commit message:
      
          The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
          looked at the function slot in order to skip stub frames
          and find the JS frame. However, stub frames do not have a
          function slot (in fact their fixed frame ends one slot
          before the JS frame's function slot). Therefore, if this
          location in the stub frame happens to have the function
          object the create arguments stubs won't skip this frame
          correctly.
      
          Replace this approach with one where the stub is
          specialized to either skip a frame if required (since
          there will only ever be one extra frame on Ignition
          the loop approach isn't necessary).
      
      R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
      
      BUG=v8:4928
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1966263002
      Cr-Commit-Position: refs/heads/master@{#36186}
      adcc5119
    • bjaideep's avatar
      PPC: Cleanup allocation folding states in lithium. · 8bb88e85
      bjaideep authored
      Port 6e15433d
      
      R=hpayer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
      
      BUG=chromium:580959
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1970563004
      Cr-Commit-Position: refs/heads/master@{#36185}
      8bb88e85
    • bjaideep's avatar
      PPC: [crankshaft] Fragmentation-free allocation folding. · ce7d7761
      bjaideep authored
      Port 61f5fbbb
      
      Original commit message:
      
            The new allocation folding implementation avoids fragmentation between folded allocation.
            As a consequence, our heap will always be iterable i.e. we do not have to perform a
            garbage collection before iterating the heap.
      
      R=hpayer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
      
      BUG=chromium:580959
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1970633002
      Cr-Commit-Position: refs/heads/master@{#36184}
      ce7d7761
    • ulan's avatar
      Fix live bytes counter in large object space after right trimming. · 12fa3fff
      ulan authored
      BUG=chromium:609761
      LOG=NO
      
      Review-Url: https://codereview.chromium.org/1964143004
      Cr-Commit-Position: refs/heads/master@{#36183}
      12fa3fff
    • ahaas's avatar
      Revert of [wasm] Implement parallel compilation. (patchset #6 id:100001 of... · be8c688a
      ahaas authored
      Revert of [wasm] Implement parallel compilation. (patchset #6 id:100001 of https://codereview.chromium.org/1961973002/ )
      
      Reason for revert:
      The ThreadSanitizer finds data races.
      
      Original issue's description:
      > [wasm] Implement parallel compilation.
      >
      > With this CL it is possible to compile a wasm module with multiple
      > threads in parallel. Parallel compilation works as follows:
      >
      > 1)   The main thread allocates a compilation unit for each wasm function.
      > 2)   The main thread spawns WasmCompilationTasks which run on the
      >      background threads.
      > 3.a) The background threads and the main thread pick one compilation unit
      >      at a time and execute the parallel phase of the compilation unit.
      >      After finishing the execution of the parallel phase, the compilation
      >      unit is stored in a result queue.
      > 3.b) If the result queue contains a compilation unit, the main thread
      >      dequeues it and finishes its compilation.
      > 4)   After the execution of the parallel phase of all compilation units has
      >      started, the main thread waits for all WasmCompilationTasks to finish.
      > 5)   The main thread finalizes the compilation of the module.
      >
      > I'm going to add some additional tests before committing this CL.
      >
      > R=titzer@chromium.org, bmeurer@chromium.org, mlippautz@chromium.org, mstarzinger@chromium.org
      >
      > Committed: https://crrev.com/17215438659d8ff2d7d55f95226bf8a1477ccd79
      > Cr-Commit-Position: refs/heads/master@{#36178}
      
      TBR=bmeurer@chromium.org,mlippautz@chromium.org,mstarzinger@chromium.org,titzer@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/1965243003
      Cr-Commit-Position: refs/heads/master@{#36182}
      be8c688a
    • rmcilroy's avatar
      [Interpreter] Fix incorrect frame walking in arguments create stubs · 40f34541
      rmcilroy authored
      The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
      looked at the function slot in order to skip stub frames
      and find the JS frame. However, stub frames do not have a
      function slot (in fact their fixed frame ends one slot
      before the JS frame's function slot). Therefore, if this
      location in the stub frame happens to have the function
      object the create arguments stubs won't skip this frame
      correctly.
      
      Replace this approach with one where the stub is
      specialized to either skip a frame if required (since
      there will only ever be one extra frame on Ignition
      the loop approach isn't necessary).
      
      BUG=v8:4928
      LOG=N
      CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
      
      Review-Url: https://codereview.chromium.org/1949023003
      Cr-Commit-Position: refs/heads/master@{#36181}
      40f34541
    • vogelheim's avatar
      Remove TypingResetter. · 0bc5bf3a
      vogelheim authored
      This code was used exclusively by its own unit test and can be safely removed.
      
      BUG=v8:4947
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1965373002
      Cr-Commit-Position: refs/heads/master@{#36180}
      0bc5bf3a
    • verwaest's avatar
      Support subclassing API functions. · 73ee7943
      verwaest authored
      When instantiating a subclassed API function, the instance cache is avoided. There is currently no direct API yet to instantiate a Template while passing in a new.target. It probably makes sense to extend ObjectTemplate::NewInstance to accept a new.target, in line with Reflect.construct.
      
      BUG=v8:3330, v8:5001
      
      Review-Url: https://codereview.chromium.org/1972613002
      Cr-Commit-Position: refs/heads/master@{#36179}
      73ee7943
    • ahaas's avatar
      [wasm] Implement parallel compilation. · 17215438
      ahaas authored
      With this CL it is possible to compile a wasm module with multiple
      threads in parallel. Parallel compilation works as follows:
      
      1)   The main thread allocates a compilation unit for each wasm function.
      2)   The main thread spawns WasmCompilationTasks which run on the
           background threads.
      3.a) The background threads and the main thread pick one compilation unit
           at a time and execute the parallel phase of the compilation unit.
           After finishing the execution of the parallel phase, the compilation
           unit is stored in a result queue.
      3.b) If the result queue contains a compilation unit, the main thread
           dequeues it and finishes its compilation.
      4)   After the execution of the parallel phase of all compilation units has
           started, the main thread waits for all WasmCompilationTasks to finish.
      5)   The main thread finalizes the compilation of the module.
      
      I'm going to add some additional tests before committing this CL.
      
      R=titzer@chromium.org, bmeurer@chromium.org, mlippautz@chromium.org, mstarzinger@chromium.org
      
      Review-Url: https://codereview.chromium.org/1961973002
      Cr-Commit-Position: refs/heads/master@{#36178}
      17215438
    • mstarzinger's avatar
      [compiler] Pass inlining_id via relocation info. · 32049620
      mstarzinger authored
      This passes the inlining_id of deoptimization points via the relocation
      info instead of via a side-channel to the CPU profiler. This is one step
      towards deprecating the side-channel in question and avoid the need for
      performing a lookup of the return address of the deopt point.
      
      R=jarin@chromium.org
      
      Review-Url: https://codereview.chromium.org/1956693002
      Cr-Commit-Position: refs/heads/master@{#36177}
      32049620
    • ishell's avatar
      [runtime] Record runtime call stats for Map::TransitionTo*Property,... · af02c033
      ishell authored
      [runtime] Record runtime call stats for Map::TransitionTo*Property, Map::SetPrototype and property deletion to separate buckets.
      
      Review-Url: https://codereview.chromium.org/1973473002
      Cr-Commit-Position: refs/heads/master@{#36176}
      af02c033
    • ishell's avatar
      [runtime] Refine runtime call stats for IC misses. · 61b49b3c
      ishell authored
      Now we are able to distinguish different kind of misses based on which handler/stub did we actually use.
      
      Review-Url: https://codereview.chromium.org/1969733002
      Cr-Commit-Position: refs/heads/master@{#36175}
      61b49b3c
    • titzer's avatar
      [formatting] Remove all double blank lines in WASM code. · bf90d9a3
      titzer authored
      R=ahaas@chromium.org,mstarzinger@chromium.org
      BUG=
      
      Review-Url: https://codereview.chromium.org/1970543003
      Cr-Commit-Position: refs/heads/master@{#36174}
      bf90d9a3
    • cbruni's avatar
      [tools] improving callstats.html istructions and making callstats.py executable · c4af1ba7
      cbruni authored
      BUG=
      
      Review-Url: https://codereview.chromium.org/1964453002
      Cr-Commit-Position: refs/heads/master@{#36173}
      c4af1ba7
    • nikolaos's avatar
      Add script injection when replaying with callstats.py · 5fa1c61e
      nikolaos authored
      This allows benchmarking without --single-process and correctly
      gathering --runtime-call-stats numbers.
      
      Add optional parameter to %GetAndResetRuntimeCallStats
      
      -  Without any parameter, it returns a string with the runtime call
         statistics (as before).
      -  With one string parameter, it appends the statistics to the file with
         that file name.
      -  With one integer parameter (which must be 1=stdout or 2=stderr), it
         prints the statistics to the output with of that file descriptor.
      
      The injected script is automatically generated.
      Also, callstats.py does not have a hardwired DEFAULT_SITES anymore.
      
      R=cbruni@chromium.org
      BUG=
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1966193002
      Cr-Commit-Position: refs/heads/master@{#36172}
      5fa1c61e
    • oth's avatar
      [interpreter] Add checks for source position to test-bytecode-generator. · 52600c6b
      oth authored
      Prints source position information alongside bytecode.
      
      BUG=v8:4280
      LOG=N
      
      Review-Url: https://codereview.chromium.org/1963663002
      Cr-Commit-Position: refs/heads/master@{#36171}
      52600c6b
    • machenbach's avatar
      [gn] Refactoring - inverse libplatform config dependency · a78a32dc
      machenbach authored
      This makes sure that targets depending on v8_libplatform
      apply the required config.
      
      BUG=chromium:474921
      NOTRY=true
      
      Review-Url: https://codereview.chromium.org/1962423003
      Cr-Commit-Position: refs/heads/master@{#36170}
      a78a32dc
    • titzer's avatar
      [wasm] Introduce custom asm.js bytecodes for loads and stores. · f00efdae
      titzer authored
      R=ahaas@chromium.org,bradnelson@chromium.org
      BUG=
      
      Review-Url: https://codereview.chromium.org/1968943002
      Cr-Commit-Position: refs/heads/master@{#36169}
      f00efdae