- 02 Apr, 2019 8 commits
-
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Change-Id: I5c6988aa5670deaed59647e2dd4b40ee9c368a20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1549155Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60569}
-
Sigurd Schneider authored
This happened because {EphemeronKeyWriteBarrierFromCode} will also be called if both table and key are in old-space, and key is an evacuation candidate. Bug: chromium:948307, v8:8557 Change-Id: Ic1284209584b74cb343163e4beec632a3f1544b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547858 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60568}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I44c722357434a32ae9400a0e44dbc522dafe873a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547849 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60567}
-
Clemens Hammacher authored
This CL adds all the necessary {WasmCodeRefScope}s in the code base, or at least a good approximation. A follow-up CL will enable a check that a {WasmCodeRefScope} exists whenever a pointer to a {WasmCode} object is returned from the {NativeModule}. This should flush out any missing scopes. R=titzer@chromium.org Bug: v8:8217 Change-Id: I54c7eb39aeb1acde38273c399396e6b1390a4cb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533860 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60566}
-
Leszek Swirski authored
Don't just DCHECK that intrinsic calls are one-byte, but explicitly check and return (a failure) when they are not. Bug: chromium:948248 Change-Id: If2c16f337e9c97e5a585d21a51a985f4abbe1c29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547857 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60565}
-
Frederik Gossen authored
This is a reland of 09fa63a9 Original change's description: > [wasm-hints] Enabled Lazy Compilation by Hint > > Hints for lazy compilation are now taken into consideration. If the > custom hints section suggests lazy compilatin we do so unless the module > consists of a single function. > > Bug: v8:9003 > Change-Id: Ibdc400453cee20d4d5c814733887b38fb675b220 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535827 > Commit-Queue: Frederik Gossen <frgossen@google.com> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60557} Bug: v8:9003 No-Try: true Change-Id: I8d6f4518aa548c815fba4e6e62d2206129336cc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547851 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60564}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a72af28..af636cf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5b63b1f..83131f4 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/21a33af..cb85131 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/82dbc02..fdca78e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I28eeadb22b369aab6bc89219bdaa31a3af35a65d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1548591Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60563}
-
Clemens Hammacher authored
In {TryAllocateBackingStore} we already have two gc-and-retry loops. This CL adds a third one, and pulls out the gc-and-retry loop to a helper method. R=ulan@chromium.org Bug: v8:8898, chromium:909723 Change-Id: I830aa86b899223825d2e6abfcbacad0ccbf3485b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547666Reviewed-by:
-
- 01 Apr, 2019 25 commits
-
-
Daniel Clifford authored
Change-Id: I873a8a53f93d0b43d18f6dbc620a2fa3f4b30d32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547850Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#60561}
-
Milad Farazmand authored
This is a reland of dd07cbcf Original change's description: > PPC/S390: [heap] Clean-up keys of oldspace weakmaps during scavenge > > Port 6604f182 > > Original Commit Message: > > This CL adds handling for cleaning up weakmap (EphemeronHashTable) > keys during scavenge, even if the weakmap resides in oldspace. > > Change-Id: Idf8b6115e57b1229864afefe6ffee85acb5e7547 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538320 > Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com> > Reviewed-by: Junliang Yan <jyan@ca.ibm.com> > Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#60446} Change-Id: I8136d873cfc399c84a4daf4de9a1043f016561cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546561 Auto-Submit: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60560}
-
Mythri A authored
Lower the interrupt budget so we allocate feedback vectors earlier. The earlier budget of 2048 causes ~3% regressions in speedometer. From earlier experiments, there was no noticeable memory savings between 2048 and 1024. Bug: v8:8394 Change-Id: I6327e22c4df60c262420975f2e204cdbacefb485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547662Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60559}
-
Frederik Gossen authored
This reverts commit 09fa63a9. Reason for revert: Falkes on https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20shared/29942 Original change's description: > [wasm-hints] Enabled Lazy Compilation by Hint > > Hints for lazy compilation are now taken into consideration. If the > custom hints section suggests lazy compilatin we do so unless the module > consists of a single function. > > Bug: v8:9003 > Change-Id: Ibdc400453cee20d4d5c814733887b38fb675b220 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535827 > Commit-Queue: Frederik Gossen <frgossen@google.com> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60557} TBR=mstarzinger@chromium.org,clemensh@chromium.org,frgossen@google.com Change-Id: I18dd424fe8cf05f220f7498bb1ebe4b9fce7d240 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9003 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547668Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60558}
-
Frederik Gossen authored
Hints for lazy compilation are now taken into consideration. If the custom hints section suggests lazy compilatin we do so unless the module consists of a single function. Bug: v8:9003 Change-Id: Ibdc400453cee20d4d5c814733887b38fb675b220 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535827 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Change-Id: I1b7026b4cbd02932e315ce3e00d987e59f4e64f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547663Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9032 Change-Id: Ibd607d164bbc31aa41887db51c4ade575a37b227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547658Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60555}
-
Sigurd Schneider authored
This is a reland of 6604f182 Original change's description: > [heap] Clean-up keys of oldspace weakmaps during scavenge > > This CL adds handling for cleaning up weakmap (EphemeronHashTable) > keys during scavenge, even if the weakmap resides in oldspace. > > Change-Id: If8d711c050ddbcae4dd6e8da549e0c0d08ba47b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523787 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60432} CQ_INCLUDE_TRYBOTS=luci.chrome.try:Mac Builder Perf Change-Id: Ie640f2b0340637a5391fb17ba3c9e6422eaf306a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541476 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Mythri A authored
It is not safe to access flags from concurrent marking visitor. We access FLAG_flush_bytecode and FLAG_stress_flush_bytecode when visiting SharedFunctionInfo and JSFunction to decide if we need to collect bytecode. This cl adds a bytecode_flushing_mode which will be initialized when creating the visitor. This way we can avoid accessing flags. Bug: v8:9045 Change-Id: I84bf09ec2dd1543abad54bd87f8bf953830b89e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541108Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60553}
-
Mythri A authored
We added %PrepareForOptimization, that holds the bytecode array strongly until the function is optimized, to test using assertOptimized. This function expects that the function is optimized before preparing the next function for optimization. In some tests, we may not explicitly optimize a function because it got inlined into other functions or if it was already optimized. This cl relaxes this condition and holds onto multiple bytecode arrays. Bug: v8:8801, v8:8395 Change-Id: Iebccc4a798aa3f35be9ee295eb3c4917da659c22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541055Reviewed-by:
-
Jaroslav Sevcik authored
Drive-by: make sure that Allocate node consistently take intptr input as size (as opposed to sometimes intptr, sometimes int32). Bug: v8:8984 Change-Id: Ida56b9788cd11b470cc866f1b7df71f03ef0075f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541037Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60551}
-
Georg Neis authored
- We didn't take stability dependencies on the inferred maps in case of kUnreliableReceiverMaps. - We didn't take stability dependencies on the prototype chains. Bug: v8:9041 Change-Id: I85418dbed219f51e7fb46c59a0cb9cbb9b499bc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541107 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
It was missing a control output. Bug: chromium:946889 Change-Id: I85f203fc6e27a60f0b86e0e2999dd798a5416dfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547655 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I67e052b3a15ef88c21d056ca824d32da68cbbcfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541049 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 5fbc5015 Original change's description: > [mjsunit] Add test that calls functions on prototypes with no arguments > > Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60541} TBR=jarin@chromium.org Change-Id: I409e3dab72057bcba6c729f3b181fc29e8c861ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547654Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in base code to 'using' declarations. R=mlippautz@chromium.org Bug: v8:8834 Change-Id: Ic5c3d7fa2e50938c6f43e9ff304dc2289fed1133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547650Reviewed-by:
-
Michael Lippautz authored
Without the proper check V8 would not delegate to the embedder (Blink) for processing wrappable objects. Bug: chromium:946941 Change-Id: I5aa3ca85e5113ab8d28a61eca6a5e0593c62f6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547649 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 5fbc5015. Reason for revert: Fails on noi18n: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/26006 Original change's description: > [mjsunit] Add test that calls functions on prototypes with no arguments > > Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60541} TBR=jarin@chromium.org,sigurds@chromium.org Change-Id: I4b9c747e6d73dd3ff01af81c3d1e6143dcab6ecd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547652Reviewed-by:
-
Georg Neis authored
... from Object to HeapObject, as they are never Smis. Change-Id: I4cbe12985091ed1b1e94dab2803a977ae3e25224 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541104 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The CheckNonEmptyString lowering was the wrong way around and would deoptimize if it doesn't see the empty string. This leads to the creation of invalid ConsStrings and also to unnecessary deopt loops with proper code. Bug: chromium:947949, v8:8834, v8:8931, v8:8939, v8:8951 Change-Id: Ib2cc4e92cc9ec7e0284d94f74d14f67f8c878dec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545908Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: If32de05a48bddf5f746b2a3ea810ee350f6a7dda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60540}
-
Sigurd Schneider authored
Change-Id: I71a97bf686e9d821b607504c4211b21a4fe8234b Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545906 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/1443de9..8059cd6 Update instructions.rst (#995) (Søren Sjørup) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/8059cd6 [interpreter] Check argument types on invoke (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/5ea9d89 [test] Add test when start function traps (#994) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/559a10d TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Id73ec7683a566f5d206426fcfbbc75f726cbe244 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547414Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/524030d..a72af28 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/adc6ac4..82dbc02 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie4d1344c408d094000b7a2c4f61ba6bcdbf20085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547413Reviewed-by:
-
- 31 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/99a60dd..524030d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7b483abcaed40e74e54bc950a03c31d12e54e04f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547125Reviewed-by:
-
- 30 Mar, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/4406612..1443de9 [interpreter] Fix in JS conversion (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/1443de9 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I6bd1f78bacb7b805730246fc6e3ce6bbad8ab6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546929Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/c7664bb..c69a8ff Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a525b65..99a60dd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/eda23ac..459baaf Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aab7e31..5b63b1f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/803c869..8d3ba46 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/40cc341..21a33af TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7c82fed3eac96ae2a5f09de2642b624f681d2878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545088Reviewed-by:
-
- 29 Mar, 2019 4 commits
-
-
Milad Farazmand authored
Porting: 138d2dfc Original comment: This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Change-Id: I8442642126555f47a47d511f0ca9d4c00ed82da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546050 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Alexei Filippov authored
That saves some bytes on the frontend side and some cycles when generating and parsing protocol JSON for stacks. BUG=chromium:946411 Change-Id: I36b3a48b5d8246a05b877bc21f36c08803a1c304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542800 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60532}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/objects to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Iec455b40e9256ee3aae867a42c0e949a338d417c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545893Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Iad000c91323b9eef799b1e17f25bd3e9d345ab2d Bug: v8:8635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543850Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60530}
-
