- 13 Aug, 2018 5 commits
-
-
Simon Zünd authored
R=jgruber@chromium.org Bug: chromium:873555 Change-Id: I6268bedf47a89194875d1179e603bcfe972c9d68 Reviewed-on: https://chromium-review.googlesource.com/1172282Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55077}
-
Andreas Haas authored
With the origin trial for WebAssembly threads, threads can be turned on and off by the embedder depending on the context we are currently in. With this CL we call the embedder callback stored on the isolate to determine whether threads are enabled in the current context or not. Design decision: I decided to extend the {WasmFeaturesFromIsolate} function to ask the embedder if WebAssembly threads are enabled. This is the function which defines dynamically which features are turned on. It would be awkward to have two such functions, one which calls the embedder and one which does not. A downside is that in WasmJs::Install the embedder does not seem to be ready to be called. That's why I changed the code there to call {WasmFeaturesFromFlags} instead. R=titzer@chromium.org, mstarzinger@chromium.org Bug: chromium:868844 Change-Id: I6bfa89960a54cec71992756e3717bbb3a9fe195e Reviewed-on: https://chromium-review.googlesource.com/1169180 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55076}
-
Ivica Bogosavljevic authored
This CL implements several things needed for full SIMD BE support in WASM: * Global variables are now kept in little-endian order as per specification * Added support for SIMD on BE in wasm interpreter * Fixed several tests that didn't work on BE because input or output data were not using LE in-memory layout Change-Id: I4542d13d09fd276e15b0fc39f02e4a58831f65e4 Reviewed-on: https://chromium-review.googlesource.com/1160484 Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#55075}
-
Yang Guo authored
The break id is no longer used. Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib07046d66497cbd5e01a8a1248afd890180200bf Reviewed-on: https://chromium-review.googlesource.com/1172136Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/68bf4b8..6705895 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id30b10fbbbe7d29edb71f08d02e9641ae777f52a Reviewed-on: https://chromium-review.googlesource.com/1172151 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55073}
-
- 12 Aug, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5c13474..68bf4b8 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/1da4e38..74c827a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia676fa56d262206c40bcabfe479a3f74159a1eec Reviewed-on: https://chromium-review.googlesource.com/1172077 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 11 Aug, 2018 7 commits
-
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: I8225cd481835470235496d38023794068980dc3d Reviewed-on: https://chromium-review.googlesource.com/1171240Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55071}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: Ica0061605b76c699516a0bc83e14cb7ed744346e Reviewed-on: https://chromium-review.googlesource.com/1171236Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:826280 Change-Id: Ia68c012ee80ce99982c9561dedcab3c4a6bb14e0 Reviewed-on: https://chromium-review.googlesource.com/1171235 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:775123 Change-Id: Ie1e1f150aa2f7255bd2fc3c3b778620c77c56425 Reviewed-on: https://chromium-review.googlesource.com/1168489 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:872257 Change-Id: I4de1a9dfccbb0d123c1c42c31a1f697e628623fa Reviewed-on: https://chromium-review.googlesource.com/1171224 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55067}
-
Ulan Degenbaev authored
This reverts commit 5b434929. Changes after the original CL: - Right-trimming registers the array as an object with invalidated slots. - Left-trimming moves the array start in the invalidated slots map. Original change's description: > Fix invalidation of old-to-old slots after object trimming. > > A recorded old-to-old slot may be overwritten with a pointer to a new > space object. If the object containing the slot is trimmed later on, > then the mark-compactor may crash on a stale pointer to new space. > > This patch ensures that: > 1) On trimming of an object we add it to the invalidated_slots sets. > 2) The InvalidatedSlotsFilter::IsValid returns false for slots outside > the invalidated object unless the page was already swept. > > Array left-trimming is handled as a special case because object start > moves and cannot be added to the invalidated set. Instead, we clear > the freed memory so that the recorded slots contain Smi values. > > Bug: chromium:870226,chromium:816426 > Change-Id: Iffc05a58fcf52ece45fdb085b5d1fd4b3acb5d53 > Reviewed-on: https://chromium-review.googlesource.com/1163784 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54953} Change-Id: I1f1080f680196c581f62aef8d3a00a595f9bb9b0 Reviewed-on: https://chromium-review.googlesource.com/1165555 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55066}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f5a5b7b..5c13474 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bca7d20..21cd5a3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/15a5a77..6a4e31b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I05740cbd9d85888d3b6568bb96eac9598cb7d8cc Reviewed-on: https://chromium-review.googlesource.com/1171953 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 10 Aug, 2018 27 commits
-
-
Michael Achenbach authored
This is a reland of 18c90f48 Original change's description: > [test] Pass suite environment to Android test runner > > TBR=sergiyb@chromium.org > > Bug: v8:8046 > Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b > Reviewed-on: https://chromium-review.googlesource.com/1170779 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55051} NOTRY=true Bug: v8:8046 Change-Id: I73923a2ae532bb7d773c87fd77844b4e655b568c Reviewed-on: https://chromium-review.googlesource.com/1171382 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is a reland of a4355b77 Original change's description: > [test] Add files not pushed for test on Android > > TBR=neis@chromium.org > NOTRY=true > > Bug: v8:8047 > Change-Id: I6d59cd9137f56a5061d836afb02b33f7b25d4aa0 > Reviewed-on: https://chromium-review.googlesource.com/1170772 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55047} TBR=neis@chromium.org NOTRY=true Bug: v8:8047 Change-Id: If273d9407ed17f4de827b08039efe4d5cd34632e Reviewed-on: https://chromium-review.googlesource.com/1171282Reviewed-by:
-
Sathya Gunasekaran authored
Previously, we created a JSObject with a non null prototype for an internal object which isn't what we want as it casues side effects. Bug: chromium:872514 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3318044a03318f3d7099f3ba889450c651cea9e1 Reviewed-on: https://chromium-review.googlesource.com/1171186Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55062}
-
Vasili Skurydzin authored
https://bugs.chromium.org/p/v8/issues/detail?id=8043 Bug: v8:8043 Change-Id: Ia671e6ebf9dad7379f57bf55ce47cc6cd12809b6 Reviewed-on: https://chromium-review.googlesource.com/1168085 Commit-Queue: John Barboza <jbarboza@ca.ibm.com> Reviewed-by:
John Barboza <jbarboza@ca.ibm.com> Reviewed-by:
-
Ben Smith authored
|Shell::externalized_contents_| is guarded by |Shell::workers_mutex_|, but wasn't being acquired when the serialize WriteValue call failed. Bug: v8:8034 Change-Id: Idd0448e9f44d6b26c17987405d5d7394449e8bb3 Reviewed-on: https://chromium-review.googlesource.com/1170316Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#55060}
-
Michael Achenbach authored
This is a reland of 4c094342 Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} Bug: chromium:866862 Change-Id: Icf7e04c75d4abeab7254d10ba21240e46b0022ae Reviewed-on: https://chromium-review.googlesource.com/1170643Reviewed-by:
-
Sergiy Byelozyorov authored
This reverts commit 4c094342. Reason for revert: Unfortunately this broke all perf builders. Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: If80129810586b709dab762c9b5724888e15daec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866862 Reviewed-on: https://chromium-review.googlesource.com/1170962Reviewed-by:
-
Sergiy Byelozyorov authored
This reverts commit a4355b77. Reason for revert: needs to be reverted prior to https://crrev.com/c/1170962 Original change's description: > [test] Add files not pushed for test on Android > > TBR=neis@chromium.org > NOTRY=true > > Bug: v8:8047 > Change-Id: I6d59cd9137f56a5061d836afb02b33f7b25d4aa0 > Reviewed-on: https://chromium-review.googlesource.com/1170772 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55047} TBR=machenbach@chromium.org,neis@chromium.org Change-Id: I8c00550fd6c4b75014f35fa90aa3bd7af410f892 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8047 Reviewed-on: https://chromium-review.googlesource.com/1171004Reviewed-by:
-
Sergiy Byelozyorov authored
This reverts commit 18c90f48. Reason for revert: needs to be reverted prior to https://crrev.com/c/1170962 Original change's description: > [test] Pass suite environment to Android test runner > > TBR=sergiyb@chromium.org > > Bug: v8:8046 > Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b > Reviewed-on: https://chromium-review.googlesource.com/1170779 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55051} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I2c874305251b8b73f3bc0aaaf31a81ef30d6c15d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8046 Reviewed-on: https://chromium-review.googlesource.com/1171002Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420,chromium:852420 Change-Id: I873666df415c6b4919f8b3385494c9a08f105188 Reviewed-on: https://chromium-review.googlesource.com/1170700Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55055}
-
jgruber authored
This is an attempt to make builtin symbols visible in crash stack traces. Can be reverted if unsuccessful. TBR=yangguo@chromium.org Bug: v8:6666, v8:7722 Change-Id: I74a44b23d1a39d8885992f73d7ed02baf43cfa30 Reviewed-on: https://chromium-review.googlesource.com/1170830Reviewed-by:
-
Michael Achenbach authored
Also skip slowest test on the slowest extra variant. TBR=sigurds@chromium.org Bug: v8:7783 Change-Id: I565fa8edd9c3f20fe15af84e1b9023450ef4593e Reviewed-on: https://chromium-review.googlesource.com/1170832 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Not unexpectedly, always emitting bounds checks regressed performance quite a bit. This CL disables release builds bounds checks for now, until we found and disabled the performance critical bounds checks. Bug: v8:8029 Change-Id: Ifab95b2baf88adc5443765e8c132f80ed2bb4aad Reviewed-on: https://chromium-review.googlesource.com/1170768 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55052}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:8046 Change-Id: I201f7a7ee119628e14c864602a2d3cbadfc4052b Reviewed-on: https://chromium-review.googlesource.com/1170779Reviewed-by:
-
Creddy authored
No need to create allocation site for literals in oneshot code since they are executed only once. The interpreter emits a runtime call to CreateObjectLiteralWithoutAllocationSite for creating literals in oneshot code instead. Change-Id: I224b3a30f10361cfe9ff63129b36da8230c5e403 Reviewed-on: https://chromium-review.googlesource.com/1163615 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55050}
-
Ivica Bogosavljevic authored
In Trunc_ul_d and Trunc_ul_s, register result is optional and this is signaled by setting its value to invalid. AreAliased expects that all registers are valid. For this reason the compilation fails in snapshot generation mode. This CL fixes the issue by calling AreAliased macro only with valid registers. Change-Id: Iae931447887b94e64b19b50c53e605656b8c3906 Reviewed-on: https://chromium-review.googlesource.com/1170766Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55049}
-
Tobias Tebbi authored
This is a follow-up to https://crrev.com/c/1166910 Bug: v8:8029 Change-Id: I2605f9b2a7b25c096da5a57c3c23b9b636213fff Reviewed-on: https://chromium-review.googlesource.com/1169051Reviewed-by:
-
Michael Achenbach authored
TBR=neis@chromium.org NOTRY=true Bug: v8:8047 Change-Id: I6d59cd9137f56a5061d836afb02b33f7b25d4aa0 Reviewed-on: https://chromium-review.googlesource.com/1170772Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I865826c0e8927aea264a4f9177380ec3bb8aee4f Reviewed-on: https://chromium-review.googlesource.com/1170764Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: I73a5db1c09e0adb3eab0ee0bdf675edbdea6c6e7 Reviewed-on: https://chromium-review.googlesource.com/1170762Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 38584fd4. Reason for revert: failures on Mac64 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64/23574 Original change's description: > Reland "[wasm] Publish new code from the background threads." > > This is a reland of f991465b > > Original change's description: > > [wasm] Publish new code from the background threads. > > > > R=clemensh@chromium.org > > BUG=v8:7921 > > > > Change-Id: Ib86cb5f742907b6e54365827facfc765867ca22e > > Reviewed-on: https://chromium-review.googlesource.com/1156384 > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54985} > > Bug: v8:7921 > Change-Id: I08c5eb689fe4f8ef2f7b576f0145eb0ae617fd9d > Reviewed-on: https://chromium-review.googlesource.com/1170603 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55042} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Ia7526f97fc7bd9d8c0627c958647fe6137eb98ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7921 Reviewed-on: https://chromium-review.googlesource.com/1170802Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 60d1277f. Reason for revert: This is not sound as long as cast<FixedDoubleArray>() doesn't do the same. Original change's description: > [csa] CSA type checks: allow the empty FixedArray to be CAST() to FixedDoubleArray > > This should allow to re-land https://crrev.com/c/1039190 > > Bug: chromium:871886 > > Change-Id: If815537410b3fa09902026dc26205421f5c36ae5 > Reviewed-on: https://chromium-review.googlesource.com/1169019 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55015} TBR=jarin@chromium.org,tebbi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:871886 Change-Id: Ib81f3a069776f9e1aa01d16b9d4979de7c56fcde Reviewed-on: https://chromium-review.googlesource.com/1170742Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55043}
-
Michael Starzinger authored
This is a reland of f991465b Original change's description: > [wasm] Publish new code from the background threads. > > R=clemensh@chromium.org > BUG=v8:7921 > > Change-Id: Ib86cb5f742907b6e54365827facfc765867ca22e > Reviewed-on: https://chromium-review.googlesource.com/1156384 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54985} Bug: v8:7921 Change-Id: I08c5eb689fe4f8ef2f7b576f0145eb0ae617fd9d Reviewed-on: https://chromium-review.googlesource.com/1170603Reviewed-by:
-
Michael Achenbach authored
This adds a new command abstraction for running commands on Android using dockered devices on swarming. The new abstraction handles pushing all required files to the device. The logic used for pushing and running is reused from the perf runner. This adds only the mjsunit test suite. Others will be handled in follow up CLs. The suite logic is enhanced with auto-detection of files to be pushed to devices, for e.g. load or import statements. Some test cases need an extra resource section for specifying required files. Remaining failing tests are marked in the status files for later triage. Bug: chromium:866862 Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 Reviewed-on: https://chromium-review.googlesource.com/1150153Reviewed-by:
-
Toon Verwaest authored
This is a reland of c1226cea1ec11d5b766226c912c475647a731274 Original change's description: > [scanner] Simplify TemplateSpan raw literal character handling > > Instead of adding and removing literal chars, only add raw literal characters when we have to and never remove them. > > Change-Id: Ib604c8c9fb69a96708eec3a03de102e0668c01d7 > Reviewed-on: https://chromium-review.googlesource.com/1167505 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Caitlin Potter <caitp@igalia.com> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> Change-Id: Ia15501d75c3beaf336e90a80e0abb738f696ef9e Reviewed-on: https://chromium-review.googlesource.com/1170604Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds a ToObject_Inline CSA macro that avoids the "ToObject" builtin call if the passed argument is already a JSReceiver. The CL also replaces all occurences of ToObject in Torque code with ToObject_Inline. R=jgruber@chromium.org Change-Id: I1cd66d5d51dde5a93d9a0c55489b13a6f4ba9dc2 Reviewed-on: https://chromium-review.googlesource.com/1169819 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Bret Sepulveda authored
Log::MessageBuilder was already escaping most unsafe characters when they were being logged, but plain backslashes were not. Merely updating the existing escaping path was not sufficient, as recursion would cause escape codes to be doubly escaped. This patches refactors the API to ensure incoming text is escaped exactly once. Bug: v8:8039 Change-Id: Id48aabf29fb6153189ae4a1ad7dfaaf4b41b62ad Reviewed-on: https://chromium-review.googlesource.com/1169049Reviewed-by:
-
