- 11 Jun, 2019 4 commits
-
-
Simon Zünd authored
This CL changes IncrementalStringBuilder to write short strings directly to {current_part_} instead of shortening {current_part}, allocating a new part and concatenate everything using ConsString. This optimization requires the IncrementalStringBuilder to either use two byte encoding, or the incoming string is flat with one byte representation. This CL improves stack trace serialization micro benchmarks up to 10%. Bug: v8:8742 Change-Id: I5cc8339be8035c42438381883544d108591fb945 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647696 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62075}
-
Oliver Dunk authored
Quotes have been added around the token to make the message clearer. Bug: chromium:943636 Change-Id: Ic38f3e6d307157af2c0146e69fb611a2cfb46564 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593307 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#62074}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bc47a86..aeede42 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/93cd912..ace1f8b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e30736f..fd919c8 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/31200de..076b7f7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7789751..fe6c647 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ibf4480540dff2019e4b28a27a18cd771f419442e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1652116Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62073}
-
Yu Yin authored
port https://crrev.com/c/1339866 https://crrev.com/c/1511274 Change-Id: Iea6bd86cfeb4230316ff3416d744fa9f4598a75f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649260 Auto-Submit: Yu Yin <xwafish@gmail.com> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#62072}
-
- 10 Jun, 2019 4 commits
-
-
Z Nguyen-Huu authored
The path for sealed elements is handled by using the same path for SmiOrObjectElementKind, just need to extend a DCHECK in CodeStubAssembler::IsFixedArrayWithKind. The only special case is when we write to a hole in holey sealed elements. Since we can not write in that case, just bail out. Bug: chromium:967101 Change-Id: Ibf837ae053fe609bca83da432f298ef056f3aced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632830 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62071}
-
Z Nguyen-Huu authored
This is reland of Ib1c3f78d1f1a44c6628d351fed3bcdc91ca08cb5 Just fix lint error for unused arguments in Torque. > Original commit message: > The fast path for IsExtensible proxy trap is already implemented, we just need to use this for ReflectIsExtensible. Now, ReflectIsExtensible is now a Torque builtin (previously CPP). Other cases will fall back to runtime. > Bug: v8:6664 > Change-Id: Ib1c3f78d1f1a44c6628d351fed3bcdc91ca08cb5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645438 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#62031} Bug: v8:6664 Change-Id: If44ac321ce712a969b3f5076411573eb3968cc14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646900 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#62070}
-
Samuel Huang authored
This reverts commit 333615cf. Reason for revert: Likely culprit for browser_tests netinfo/gc-unused-listeners.html failure for "Win10 Tests x64". Original change's description: > Reland "Enable lazy feedback allocation" > > This is a reland of 8c10501b. > Reland after fixing test failures. > > Original change's description: > > Enable lazy feedback allocation > > > > Bug: v8:8394 > > Change-Id: I29ffd38725bdcaa9dd11221045dba681eb0d567b > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643430 > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Commit-Queue: Mythri Alle <mythria@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#61991} > > Bug: v8:8394 > Change-Id: Icc9e276ab22ca6455b775f3c27e0d43c3f08b887 > TBR: rmcilroy@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647161 > Reviewed-by: Mythri Alle <mythria@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62018} TBR=rmcilroy@chromium.org,mythria@chromium.org,delphick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8394 Change-Id: Id977275f4d53a39c2372f289f2b0471efae241b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1650275 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#62069}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a9a3ecc..bc47a86 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7ee072e..7789751 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ibdb327d012a1551f1c0a4da95b3d4e1cf772da13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1650278Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62068}
-
- 09 Jun, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d39a2f6..a9a3ecc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fafbed9..93cd912 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I51012040d44d452249562eac18ef8a335058d314 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648673Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62067}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/41747be..7940fa4 [test] Fix unintended errors in negative tests (#1034) (Erik McClure) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/7940fa4 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I4bb02e1314966f9526dcfb5fdf75fc6b55c0e711 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1651161Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62066}
-
- 08 Jun, 2019 5 commits
-
-
Benedikt Meurer authored
The introduction of the FeedbackVector solved the problem of inconsistent feedback between ICs in unoptimized and optimized code. Bug: v8:2029, v8:9183 Tbr: jkummerow@chromium.org Change-Id: Id61033c1661e5a2efb740988552de76f7f148d0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649566Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#62065}
-
Benedikt Meurer authored
The CloneObject bytecode was only able to handle objects, null and undefined, and explicit bytecode had to be generated to perform the ToObject outside the bytecode (unlike the other IC bytecodes that just perform the ToObject implicitly). That means the simplest possible object cloning would also generate a sequence of 5 bytecodes (at least): ``` Mov <register>, a0 JumpIfNull @1 JumpIfUndefined @1 ToObject <register> 1: CloneObject <register> ``` That is quite wasteful and unnecessary, since the core logic in the runtime already does the ToObject properly anyways. This change refactors the CloneObjectIC slightly to behave more like the other ICs and do the ToObject implicitly when necessary. Bug: v8:7611, v8:9114, v8:9183, v8:9343 Change-Id: I11973e90bf875f154a5a7739287bee17041e4a7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649554Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#62064}
-
Ben Smith authored
PrintWasmText is used for disassembling wasm code in DevTools, but many instructions are not implemented. This test should make it easier to remember to implement this when adding new instructions. Change-Id: I6030a70113320f11a1ac0436bf0d220b5c41e6d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647475 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62063}
-
Jakob Kummerow authored
The DoubleToFloat32 helper takes care of everything, so use it consistently. Bug: chromium:969498 Change-Id: If71e5374684b89615006548cb0329f4d4cb7fd6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648253 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62062}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b83cffc..d39a2f6 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/0218c0f..2e18a95 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9913025..fafbed9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/073b8ac..e30736f Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/9b1b0ed..96f1257 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ib83c93c8f824dc5727aacdb715487d0a7f334eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1650724Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62061}
-
- 07 Jun, 2019 17 commits
-
-
Johannes Henkel authored
New rev: 91eb1c8784ab3d88ca1e327ffa727d922dd2ce70 Change-Id: I0be17a324ff64b2ee6c2657e3c2cea5d09f6c494 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649227 Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#62060}
-
Irina Yatsenko authored
This adds crash keys containing the isolate address and addresses of the read_only, map, and code spaces to crash report minidumps. When not compiling V8 with Chrome, a noop implementation is used. Bug: v8:9323 Change-Id: I8523630e7a4ff792855163c06bf76dab35b1b9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1641326Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62059}
-
Darius Mercadier authored
The linked lists of FreeLists could contain empty elements (FreeListCategories whose `top()` is null). The code is carefuly written so that this case won't break anything (probably just slow things a little bit). When `FreeList::FindNodeIn` (the fast path of `FreeList::Allocate`) found such an empty `FreeListCategory`, it removed it by calling `FreeList::RemoveCategory`, and looked in the next `FreeListCategory` of the same size. However, on the slow path of `FreeList::Allocate`, the functions that iterates the `FreeListCategory` are `FreeList::TryFindNodeIn` and `FreeListCategory::PickNodeFromList`, none of which removed empty elements. Therefore, it could happen that a `FreeListCategory` "real" first element could be used, but was never considered due to the top of the linked list being empty. The behavior for the slow path should be the same as for the fast path on that regard. The problem was actually deeper than that: FreeListCategories were not always in a consistent state, since they could have empty members. The removal of those empty elements should be done as soon as they are created, ie when allocating the last element. This CL ensures that empty FreeListCategories are removed as soon as they become empty. Bug: v8:9329 Change-Id: Idda8096dc5978745894854a0405da59f7e8691a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648476 Commit-Queue: Darius Mercadier <dmercadier@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#62058}
-
Santiago Aboy Solanes authored
It was hiding the nodes, but never showing them. Therefore it wasn't 'toggling'. Change-Id: I6fe57860f44ba05abac0f1575678a494f9d07ae8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649557Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62057}
-
Santiago Aboy Solanes authored
Some of the tooltips had the wrong text on them when hovering over with the mouse. Change-Id: I4d1ba37b0fad276356b76d16710a5dba7dedc6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649556Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62056}
-
Darius Mercadier authored
When trying to find a spot in the freelists for a tiniest object, the tiny freelist was never searched. This was fixed by modifying FreeList::Allocate in order to handle that special case. A test was added in cctest/heap/test-spaces.cc. It allocates a Tiny object on a new page, then fills up the page, then frees the first object, and finally tries to allocate a Tiniest object. Before, this Tiniest object would go on a different page; now it goes on the same one (which is what the test checks for). Bug: v8:9329 Change-Id: Ia810726d1bfe1dae4ef2055a7f5b314b1514ee9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647162 Commit-Queue: Darius Mercadier <dmercadier@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62055}
-
Georg Schmid authored
Currently, decompression elimination may reduce phis by pushing decompressions in the value inputs of the phi "down" and replacing it by a single decompression following the phi node. Because of the way that the replacement is currently done, other reducers in the same phase will not generally get a chance to revisit the modified phi. In the specific case of v8:9335 this blocked an additional optimization in CommonOperatorReducer from being applied, causing the overall load elimination test to fail. This CL fixes the replacement behavior in decompression elimination to also allow for revisitations of the modified phi node. Bug: v8:9335 v8:9336 Change-Id: I3ca5686dacb41a525160b08456905ba77cf28b39 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Change-Id: I3ca5686dacb41a525160b08456905ba77cf28b39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648238Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Georg Schmid <gsps@google.com> Cr-Commit-Position: refs/heads/master@{#62054}
-
Sigurd Schneider authored
Change-Id: Ia7d37e72b16123e98b2f2e4d4e5d614f9b8c8d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649558 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#62053}
-
Igor Sheludko authored
Bug: v8:8948 Change-Id: Ia123989ed1ca68781d2b38b1485b8e83b03a523c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648477Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62052}
-
Maciej Goszczycki authored
This reverts commit fb4d5480. Reason for revert: Breaks the noembed build Original change's description: > Reland "[roheap] Enable shared ro-heap by default if ptr compression is disabled" > > This is a reland of 81abe8f7 > > It also disables ro-heap sharing in nosnap builds > > Original change's description: > > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > > > Shared read-only heap is currently incompatible with pointer compression. > > Enable sharing only if pointer compression is disabled. > > > > Bug: v8:7464 > > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > > Reviewed-by: Dan Elphick <delphick@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > > Cr-Commit-Position: refs/heads/master@{#61963} > > Bug: v8:7464 > Change-Id: I6b620152d380864db2a725c25f3c916d695d4f81 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1639298 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62015} TBR=rmcilroy@chromium.org,delphick@chromium.org,goszczycki@google.com Change-Id: If0ceb39a1399e3f731dfca36e6632f327c8226ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648154Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#62051}
-
Andreas Haas authored
I realized that the parameter order of ValuesTypes::IsSubType is inconsistent with the parameter of e.g. DCHECK_LT. DCHECK_LT(a, b) is satisfied if a < b. For ValueTypes it was the other way around. ValueTypes::IsSubType(a, b) returned true if b was a subtype of a. R=mstarzinger@chromium.org Bug: v8:9183 Change-Id: Ifb192bbecdcfe002ef8ca0887d1497393e16e11e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649358Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62050}
-
Nico Hartmann authored
Implements the addition of BigInts as a Torque builtin, which performs necessary checks and then calls into C++. The core logic of MutableBigInt::AbsoluteAdd, MutableBigInt::AbsoluteSub and MutableBigInt::AbsoluteCompare is now used by both the runtime and the Torque generated builtin for best performance. Bug: v8:9213 Change-Id: I5f6af4dd226f11e6287bd04272ccae6ee5c26498 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640211Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@google.com> Cr-Commit-Position: refs/heads/master@{#62049}
-
Yang Guo authored
R=machenbach@chromium.org Change-Id: I2682e2321513c372940181041e66444388cd1515 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648263 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62048}
-
Jakob Kummerow authored
Breakpad used to put a custom identifier 0x8003 into minidumps to indicate arm64 architecture. Crashpad now uses the new standardized value 12. This CL updates grokdump.py to understand both. Change-Id: Ie9bf5106beba8059e89a48d42d32ac8069493925 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648258 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62047}
-
Toon Verwaest authored
This way we walk the input string twice, but we reduce the number of branches per ascii char in the long-ascii-sequence case from 2 per char to ~ 1 + 2 / sizeof(intptr). Let's land and see what the bots say. Change-Id: I574971c7df896237f3382be634a9bedc920fc827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649356Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#62046}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/03613cf..b83cffc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d71ff5d..9913025 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8a37389..073b8ac TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iafc77da51233517ce78510f83bf764418b15ecf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649048Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62045}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:971383 Change-Id: I39d26a63c0735f595a809959c06cb2ac1c141451 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648098 Commit-Queue: Frank Tang <ftang@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62044}
-
- 06 Jun, 2019 8 commits
-
-
Deepti Gandluri authored
Registering shared wasm memory with the memory tracker was implemented to track which instances need to be upated across threads on grow. As the growing of memory when it is shared is behind a flag, the registering should also be gated by the flag so as to not create global handles that keep the memory alive. Bug: v8:9075 Change-Id: I379a19413befa281cd384c9167fbc22ba52f4c2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646882Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#62043}
-
Frank Tang authored
Bug: v8:8866 Change-Id: I3a25c68fe4d8536596118352804daa3c6025da37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643466Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#62042}
-
Frank Tang authored
quarter option- see https://github.com/tc39/ecma402/pull/345 dayPeriod option- see https://github.com/tc39/ecma402/pull/346 fractionalSecondDigits option- see https://github.com/tc39/ecma402/pull/347 2019-6-5 TC39 presentation- http://shorturl.at/mtB12 test262: https://github.com/tc39/test262/pull/2194 I2I: http://shorturl.at/beCNV (for quarter) I2I: http://shorturl.at/bekrZ (for dayPeriod) I2I: http://shorturl.at/flwF5 (for fractionalSecondDigits) Bug: v8:9282,v8:9283,v8:9284 Change-Id: I99f4c0f861507c7451497b735a276780bb8aead6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621445 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62041}
-
Bill Budge authored
TBR=machenbach@chromium.org Change-Id: I401a00483425a37ea0e571b1ffa822a665da388e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649015Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#62040}
-
Frank Tang authored
DesignDoc: https://goo.gl/ZAtL1f Chrome Status: https://www.chromestatus.com/feature/5430420699086848 I2I: http://shorturl.at/sE168 I2S: http://shorturl.at/qsHU9 Bug: v8:8518 Change-Id: Ib9d6ce4782c12745d3d44500991074646254621a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1639698 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62039}
-
Jakob Kummerow authored
Adding and improving tests should have as little friction as possible. Change-Id: I61c09ccadf12b7367979fbf3b8cb97a64e0c70bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648243 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62038}
-
Igor Sheludko authored
Bug: v8:9247 Change-Id: If3af83b241481e620d4ef05d6608864cea75640f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648475 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62037}
-
Igor Sheludko authored
Bug: v8:9247 Change-Id: I5ea725d4661290353b7ca9928bf7d46644868efe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648244Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62036}
-