- 02 May, 2017 19 commits
-
-
jkummerow authored
The test and associated bug have been fixed a while ago. BUG=chromium:336820,v8:6325 Review-Url: https://codereview.chromium.org/2851343002 Cr-Commit-Position: refs/heads/master@{#45023}
-
Ross McIlroy authored
Since the feedback vector is itself a native context structure, why not store optimized code for a function in there rather than in a map from native context to code? This allows us to get rid of the optimized code map in the SharedFunctionInfo, saving a pointer, and making lookup of any optimized code quicker. Original patch by Michael Stanton <mvstanton@chromium.org> BUG=v8:6246 Change-Id: I60ff8c408c3001bc272b4b198c9cbaea2872a9e5 Reviewed-on: https://chromium-review.googlesource.com/476891 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#45022}
-
mlippautz authored
Currently used for observing moves for profiling. In the future this will be used to transfer colors for the minor MC too. BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2846043003 Cr-Commit-Position: refs/heads/master@{#45021}
-
jkummerow authored
Give the IC one more chance to get itself into a state that's in line with Turbofan's capabilities and the following assertOptimized expectation. BUG=v8:6101,v8:6325 Review-Url: https://codereview.chromium.org/2848193003 Cr-Commit-Position: refs/heads/master@{#45020}
-
Michael Starzinger authored
This ensures exceptions thrown during parsing are properly propagated into the surrounding {v8::TryCatch} block. Otherwise running more than one test input in the same Isolate can fail due to pending exceptions. R=jochen@chromium.org BUG=chromium:715037 Change-Id: Iaa5735515dc097d8cb12dcf8672451f3c9503440 Reviewed-on: https://chromium-review.googlesource.com/490047 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#45019}
-
daniel.bevenius authored
This commit adds a getter for the private is_verbose_ member. The use case for this comes from Node.js where the ability to avoid calling FatalException if the TryCatch is verbose would be nice to have. BUG= Review-Url: https://codereview.chromium.org/2840803002 Cr-Commit-Position: refs/heads/master@{#45018}
-
Wiktor Garbacz authored
As jobs are picked up in the same order by background tasks as they are when FinishAll is called it may happen that the main thread just waits for background threads without doing any work. So first run jobs, that are not running in background, to completion and then wait for remaining jobs to finish. BUG=v8:6093 Change-Id: Ica83db2a504771b633cfdfc4e95e1ac8e43111d6 Reviewed-on: https://chromium-review.googlesource.com/488244Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45017}
-
Wiktor Garbacz authored
While parsing top-level code eager functions are skipped just like lazy ones, but also a parse task is created for each. The parse tasks are run by the compiler dispatcher and can be executed either on background thread or in idle time. After parsing of top-level code finishes it waits for all unfinished parser tasks - possibly picking up and executing them on current thread. Afterwards parse task results are stitched together with top-level AST, in case of failures eager functions are treated just like lazy - parsing/compilation is retriggered for them in the runtime and proper errors are generated (performance is not optimized for error case at all). BUG=v8:6093 Change-Id: Ie6508211a04b90becfe44139cce1c8ecec386b6e Reviewed-on: https://chromium-review.googlesource.com/486725Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45016}
-
Clemens Hammacher authored
ErrorThrower is not concurrency safe, thus we should not use it from background tasks. Instead, allocate an ErrorThrower whenever we actually want (or might) throw. Pass the ErrorThrower from step 4 to step 5 explicitly. R=ahaas@chromium.org, mtrofin@chromium.org Change-Id: Ifb6b16cab7939ec9c81e4f2db59ee42d5ddd7f85 Reviewed-on: https://chromium-review.googlesource.com/489501 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#45015}
-
neis authored
In the simulators, the ExternalReference constructor rewrites external addresses, which involves mutating a linked list rooted in the isolate. We already construct external references concurrently (at least in Turbofan), but the list mutation was not thread-safe (though no crashes are known). This CL adds the necessary locking. BUG=v8:6048 Review-Url: https://codereview.chromium.org/2852983002 Cr-Commit-Position: refs/heads/master@{#45014}
-
Wiktor Garbacz authored
BUG=v8:6093 Change-Id: I365fbd7c3f33e2de47e0a84ee3ea631b4ffa6d35 Reviewed-on: https://chromium-review.googlesource.com/488243Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Cr-Commit-Position: refs/heads/master@{#45013}
-
jkummerow authored
As required by #sec-built-in-function-objects. They were strict functions before (see e2f1c269), but that got lost when they were ported to ASM builtins. This makes optimized and non-optimized code agree on the same behavior in regress-105.js. BUG=v8:105,v8:5778,v8:6325 Review-Url: https://codereview.chromium.org/2848313004 Cr-Commit-Position: refs/heads/master@{#45012}
-
Igor Sheludko authored
Bug: chromium:716804 Change-Id: I0ef5169e2af34ec2d794c99e99d9e31035599744 Reviewed-on: https://chromium-review.googlesource.com/493146 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#45011}
-
Wiktor Garbacz authored
BUG=v8:6325 Change-Id: I5a638c47b33d6e75d31f020c499ffd084348fea4 Reviewed-on: https://chromium-review.googlesource.com/489505 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#45010}
-
wychen authored
This is for https://crrev.com/2851953002/ BUG= chromium:716359 Review-Url: https://codereview.chromium.org/2853783002 Cr-Commit-Position: refs/heads/master@{#45009}
-
Franziska Hinkelmann authored
Bug:v8:6325 Change-Id: Ic829561c013673137c405538c6d7d854b07c36d3 Reviewed-on: https://chromium-review.googlesource.com/490110Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#45008}
-
landell authored
BUG= Review-Url: https://codereview.chromium.org/2806313002 Cr-Commit-Position: refs/heads/master@{#45007}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3b48c72..4a81c96 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/1c3f4b9..9300a23 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I47fa12dafc25c48be4f86c8d4324474be3019ec3 Reviewed-on: https://chromium-review.googlesource.com/492846Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#45006}
-
gdeepti authored
- Ops: S128Load, S128Store, S128And, S128Or, S128Xor, S128Not, I32x4AddHoriz, I16x8AddHoriz - Add x64 assembler support for - phaddd, phaddw, pand, por - Enable tests for Globals, other tests applicable to x64 apart from tests for implemented ops BUG=v8:6020 R=bbudge@chromium.org, bmeurer@chromium.org, zvi.rackover@intel.com Review-Url: https://codereview.chromium.org/2849463003 Cr-Commit-Position: refs/heads/master@{#45005}
-
- 01 May, 2017 4 commits
-
-
aseemgarg authored
R=bbudge@chromium.org,gdeepti@chromium.org,mtrofin@chromium.org BUG=v8:6020 Review-Url: https://codereview.chromium.org/2843523002 Cr-Commit-Position: refs/heads/master@{#45004}
-
kozyatinskiy authored
getPossibleBreakpoints implementation can enforce function compilation which potentially can produce syntax error, we need to have a context to correctly report this error. BUG=chromium:715334 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2851853002 Cr-Commit-Position: refs/heads/master@{#45003}
-
gdeepti authored
BUG=v8:6325 R=bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2844163006 Cr-Commit-Position: refs/heads/master@{#45002}
-
stanisc authored
This makes the size of the class smaller by 8 bytes on 64-bit. I looked at the usage pattern. Even though it seems the number of instances doesn't get higher than a few thousand, this class is still very hot because it is constructed and passed by value a lot. So perhaps reducing the size would make passing this class by value or growing arrays more optimal and might save some cycles. Before: class v8::internal::compiler::Constant [sizeof = 24] { [sizeof=4] v8::internal::compiler::Constant::Type type_ <padding> (4 bytes) [sizeof=8] __int64 value_ [sizeof=4] v8::internal::RelocInfo::Mode rmode_ <padding> (4 bytes) } After: class v8::internal::compiler::Constant [sizeof = 16] { [sizeof=4] v8::internal::compiler::Constant::Type type_ [sizeof=4] v8::internal::RelocInfo::Mode rmode_ [sizeof=8] __int64 value_ } BUG=chromium:710933 Review-Url: https://codereview.chromium.org/2841343002 Cr-Commit-Position: refs/heads/master@{#45001}
-
- 30 Apr, 2017 2 commits
-
-
Clemens Hammacher authored
The error thrower did allocate the exception at the moment the error was detected. For async compilation, this meant in another step than when it was actually thrown. Since the HandleScope of the exception already died at that point, this would have lead to memory errors. With this refactoring, we only store the information needed to generate the exception in the ErrorThrower, and only generate the exception object once it is actually needed. With regression test. R=ahaas@chromium.org, mtrofin@chromium.org Also-by: ahaas@chromium.org Change-Id: Iffcab1f8d1cf5925e3643fcf0729ba9a84c7d277 Reviewed-on: https://chromium-review.googlesource.com/490085 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45000}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/853f22f..3b48c72 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/fa1d11d..1c3f4b9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Id2423842f165fdf342fc28453b7a5c80b1ebe9fe Reviewed-on: https://chromium-review.googlesource.com/490730Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44999}
-
- 29 Apr, 2017 7 commits
-
-
danno authored
This CL changes certain frequently-called Array builtins to use CodeStubArguments rather than peek at the stack frames above array builtins to determine if options arguments have been passed into them. Previous failure likely due to unfortunate/unluckily timed GC that moved due to changed timing/allocation from this CL. Test mitigation for allocation-site-info.js included. BUG=v8:1956 LOG=N Review-Url: https://codereview.chromium.org/2829093004 Cr-Commit-Position: refs/heads/master@{#44998}
-
danno authored
Revert of [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins (patchset #8 id:140001 of https://codereview.chromium.org/2829093004/ ) Reason for revert: Still fails. Likely has to do with gc heap size for allocation site tests, mitigation pending... Original issue's description: > [turbofan] Reland: Avoid going through ArgumentsAdaptorTrampoline for select CSA array builtins > > This CL changes certain frequently-called Array builtins to use CodeStubArguments > rather than peek at the stack frames above array builtins to determine if options > arguments have been passed into them. > > Previous failure cannot be reproed with failing config. Flake? > > BUG=v8:1956 > LOG=N > > Review-Url: https://codereview.chromium.org/2829093004 > Cr-Commit-Position: refs/heads/master@{#44996} > Committed: https://chromium.googlesource.com/v8/v8/+/7ca381e84792b83581d0199dfae2888781785273 TBR=mvstanton@chromium.org,ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1956 Review-Url: https://codereview.chromium.org/2851063002 Cr-Commit-Position: refs/heads/master@{#44997}
-
danno authored
This CL changes certain frequently-called Array builtins to use CodeStubArguments rather than peek at the stack frames above array builtins to determine if options arguments have been passed into them. Previous failure cannot be reproed with failing config. Flake? BUG=v8:1956 LOG=N Review-Url: https://codereview.chromium.org/2829093004 Cr-Commit-Position: refs/heads/master@{#44996}
-
danno authored
Revert of [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins (patchset #8 id:140001 of https://codereview.chromium.org/2829093004/ ) Reason for revert: Nosnap failure Original issue's description: > [turbofan] Avoid going through ArgumentsAdaptorTrampoline for select CSA/C++ builtins > > This CL changes certain frequently-called Array builtins to use CodeStubArguments > rather than peek at the stack frames above array builtins to determine if options > arguments have been passed into them. > > BUG=v8:1956 > LOG=N > > Review-Url: https://codereview.chromium.org/2829093004 > Cr-Commit-Position: refs/heads/master@{#44994} > Committed: https://chromium.googlesource.com/v8/v8/+/680356278ddc7577e3b967fcc92055522ce00856 TBR=mvstanton@chromium.org,ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1956 Review-Url: https://codereview.chromium.org/2851703005 Cr-Commit-Position: refs/heads/master@{#44995}
-
danno authored
This CL changes certain frequently-called Array builtins to use CodeStubArguments rather than peek at the stack frames above array builtins to determine if options arguments have been passed into them. BUG=v8:1956 LOG=N Review-Url: https://codereview.chromium.org/2829093004 Cr-Commit-Position: refs/heads/master@{#44994}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/02044bf..853f22f Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/9c9ac13..fa1d11d Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/05d5695..0ad2bcb TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: I0621ed2aba116528d4699e8407d20b16c6cd8ae9 Reviewed-on: https://chromium-review.googlesource.com/490867Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#44993}
-
Daniel Ehrenberg authored
This reverts commit 4968b2c4. Reason for revert: Speculative revert for severe perf regression https://bugs.chromium.org/p/chromium/issues/detail?id=716468#c3 Original change's description: > [intl] Switch to using declared accessors > > This patch cleans up the Intl code by switching to using declared > accessors, rather than embedder fields, for holding references to > ICU objects. Additionally: > - Rename classes to be more similar to how other classes are named > - Make some unreachable paths into check-fails, rather than throwing > JS exceptions > - Move some macros from objects-inl.h into object-macros.h, to allow > the implementation here to not touch objects.h > - Some setup logic is moved from runtime-i18n.cc to i18n.cc. > > This patch leaves type tags as they are; a future patch should move > from a special Intl type tagging system to object types as other system > objects use. Future patches should also move more logic to i18n.cc > > BUG=v8:5402,v8:5751,v8:6057 > CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng > > Change-Id: Ia9cbb25cf8f52662e3deb15e64179d792c10842c > Reviewed-on: https://chromium-review.googlesource.com/479651 > Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#44804} TBR=adamk@chromium.org,marja@chromium.org,mstarzinger@chromium.org,littledan@chromium.org,jwolfe@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. BUG=v8:5402,v8:5751,v8:6057 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I7a45d7def1f1de0f21e3efb7de9b31f6bcfea46d Reviewed-on: https://chromium-review.googlesource.com/490328Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#44992}
-
- 28 Apr, 2017 8 commits
-
-
Andreas Haas authored
The current test/fuzzer/wasm directory is used for two things: 1) as the corpus directory for clusterfuzz 2) to test in v8 that the fuzzer runs correctly. With the newly added files from the wasm spec tests this directory grew quite big and adds unnecessary load on the trybots. Therefore I want to do the following steps: 1) In this CL for V8: create a new directory for the clusterfuzz corpus 2) In chromium: use the new corpus directory 3) In v8: clean up the old directory to use it on the trybots. R=bradnelson@chromium.org CC=mmoroz@chromium.org Change-Id: If690022558bb5780edf5a3649fb9745ef9c7407a Reviewed-on: https://chromium-review.googlesource.com/490367 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#44991}
-
kozyatinskiy authored
- we should always set creation async stack if it's available regardless existing of current parent async stack, - we should cleanup parent link iff there is no creation and schedule async stack for parent. Let's consider example: Promise.resolve().then(x => x).then(x => x), there is three promises which will call following instrumentation: 1) created #1 (Promise.resolve()) - collected stack #1 2) scheduled #1 - collected stack #2 3) created #2 with #1 as parent (first .then) - collected stack #3 4) created #3 with #2 as parent (first .then) - collected stack #4 5) started #2 - use stack #2 as scheduled 6) scheduled #2 - collected stack #6 7) finished #2 8) started #3 - use stack #6 as scheduled 9) scheduled #3 - collected stack #7 10) finished #3 If we collect stacks between step 4 and 5, it's possible to collect scheduled stack #2 but still have creation stack for #2 - stack #3 - so we always need to add creation event if scheduled is collected. If we collect stacks between created and scheduled we should not remove parent link even if parent was not scheduled yet. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2844753002 Cr-Commit-Position: refs/heads/master@{#44990}
-
stanisc authored
This reduces sizeof of these classes by 8 bytes on 64-bit (16 bytes considering allocation size granularity for some of these classes). I don't know how many instances remain at the end of loading a page. These objects are Zone objects which makes it more difficult to count the number of instances. But looking at allocations only on cnn.com I've got 70K for BinaryOperation, 20K for CompareOperation, 1.5K for CaseClause. There aren't not many allocations of NativeFunctionLiteral but I decided to fix it too to keep the same layout pattern. Before: class v8::internal::CaseClause [sizeof = 56] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression <padding> (4 bytes) [sizeof=8] v8::internal::Expression* label_ [sizeof=8] v8::internal::Label body_target_ [sizeof=8] v8::internal::ZoneList<v8::internal::Statement *>* statements_ [sizeof=8] v8::internal::AstType* compare_type_ [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ <padding> (4 bytes) } After: class v8::internal::CaseClause [sizeof = 48] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ [sizeof=8] v8::internal::Expression* label_ [sizeof=8] v8::internal::Label body_target_ [sizeof=8] v8::internal::ZoneList<v8::internal::Statement *>* statements_ [sizeof=8] v8::internal::AstType* compare_type_ } Before: class v8::internal::BinaryOperation [sizeof = 56] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression [sizeof=1] bool has_fixed_right_arg_ <padding> (3 bytes) [sizeof=4] int fixed_right_arg_value_ <padding> (4 bytes) [sizeof=8] v8::internal::Expression* left_ [sizeof=8] v8::internal::Expression* right_ [sizeof=8] v8::internal::Handle<v8::internal::AllocationSite> allocation_site_ [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ <padding> (4 bytes) } After: class v8::internal::BinaryOperation [sizeof = 48] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ [sizeof=8] v8::internal::Expression* left_ [sizeof=8] v8::internal::Expression* right_ [sizeof=8] v8::internal::Handle<v8::internal::AllocationSite> allocation_site_ [sizeof=1] bool has_fixed_right_arg_ <padding> (3 bytes) [sizeof=4] int fixed_right_arg_value_ } Before: class v8::internal::CompareOperation [sizeof = 48] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression <padding> (4 bytes) [sizeof=8] v8::internal::Expression* left_ [sizeof=8] v8::internal::Expression* right_ [sizeof=8] v8::internal::AstType* combined_type_ [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ <padding> (4 bytes) } After: class v8::internal::CompareOperation [sizeof = 40] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression [sizeof=4] v8::internal::FeedbackSlot feedback_slot_ [sizeof=8] v8::internal::Expression* left_ [sizeof=8] v8::internal::Expression* right_ [sizeof=8] v8::internal::AstType* combined_type_ } Before: class v8::internal::NativeFunctionLiteral [sizeof = 40] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression <padding> (4 bytes) [sizeof=8] v8::internal::AstRawString* name_ [sizeof=8] v8::Extension* extension_ [sizeof=4] v8::internal::FeedbackSlot literal_feedback_slot_ <padding> (4 bytes) } After: class v8::internal::NativeFunctionLiteral [sizeof = 32] : public v8::internal::Expression { [sizeof=12] v8::internal::Expression [sizeof=4] v8::internal::FeedbackSlot literal_feedback_slot_ [sizeof=8] v8::internal::AstRawString* name_ [sizeof=8] v8::Extension* extension_ } BUG=chromium:710933 Review-Url: https://codereview.chromium.org/2843293003 Cr-Commit-Position: refs/heads/master@{#44989}
-
kschimpf authored
Only WASM has the notion of changing the maximum memory pages. This CL corrects the UMA stats to only collect this data for WASM only. BUG=v8:6321 R=bradnelson@chromium.org,bbudge@chromium.org Review-Url: https://codereview.chromium.org/2845163002 Cr-Commit-Position: refs/heads/master@{#44988}
-
Franziska Hinkelmann authored
Bug:v8:6325 Change-Id: I8ab20111f53207178e4d17bfe5b55266d7c17916 Reviewed-on: https://chromium-review.googlesource.com/490306Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44987}
-
Franziska Hinkelmann authored
Bug:v8:6325 Change-Id: I0c66d24994a4b6811c7aec80f4aa298ba6d209e4 Reviewed-on: https://chromium-review.googlesource.com/490366Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#44986}
-
Mythri authored
1. Replaces --crankshaft with --opt in tests. 2. Also fixes presubmit to check for --opt flag when assertOptimized is used. 3. Updates testrunner/local/variants.py and v8_foozie.py to use --opt flag. This would mean, nooptimize variant means there are no optimizations. Not even with %OptimizeFunctionOnNextCall. Bug:v8:6325 Change-Id: I638e743d0773a6729c6b9749e2ca1e2537f12ce6 Reviewed-on: https://chromium-review.googlesource.com/490206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44985}
-
Toon Verwaest authored
Bug: v8:6325 Change-Id: I2f15a504690c334a43620bfd396a7fab10340b46 Reviewed-on: https://chromium-review.googlesource.com/489524Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#44984}
-