- 24 Jun, 2022 7 commits
-
-
Liu Yu authored
Port commit e35039e7 Bug: v8:12191 Change-Id: I1e6c49c22b3b94306d5b46e2672594cb842232d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723159Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#81347}
-
Hao Xu authored
Defer the branch to load receiver's map from a Smi because it is less likely to be used as a receiver, especially when the path to handle Smi receiver is already deferred. Change-Id: I2b55c146e36e548129a6c5460b55fef32df2c2f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719959Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#81346}
-
Lu Yahan authored
Port commit e35039e7 Change-Id: I19c3fddcf8b89dee74bd207909b2df4820c80f2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723540 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81345}
-
JianxiaoLuIntel authored
Change-Id: I4f3d03ebad41f32eff5d6570ad4d011586f1bac7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3722486 Commit-Queue: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81344}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5753f4e..ae20ef2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifa7c75592ca2e1400b082314136ccd827c3568b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723063 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81343}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/linux64: git_revision:ae474cc51337c3fe823f936371c5e92891e86b48..git_revision:29accf5ac2eadfc53e687081583b7bc1592a8839 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/92ef8d4..b5f3d3b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c083518..3236751 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/28190a2..d9a9c40 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220622.0.1..version:8.20220623.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic27392879f4f3a067f67634866129586d69dbc48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723062 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81342}
-
Fanchen Kong authored
For small positive integer exponents, calculate the result with an inlined loop. This change may improve the average runtime of JetStream2/raytrace for ~8%. Change-Id: I0e3939dc9c21b0c392c04d61fd197bf618004ab4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3708024 Commit-Queue: Fanchen Kong <fanchen.kong@intel.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#81341}
-
- 23 Jun, 2022 22 commits
-
-
Shu-yu Guo authored
It is an invariant that objects in the shared heap never point into per-Isolate heaps. This is currently broken by DependentCode. At the same time, shared maps and other holders of DependentCode are designed to never invalidate optimized code. E.g., shared maps are effectively immutable. This CL does two things: 1. Prevent shared objects from being depended upon 2. DCHECK that shared objects never cause deoptimization Bug: v8:12547, v8:12761 Change-Id: I0fedae9134a8f786a9200e70f99dba7b38cd2d80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704809Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81340}
-
Shu-yu Guo authored
Bug: v8:12939 Change-Id: I853a718dec39485ae1ab1263e2be8f04567447f1 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3722455Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81339}
-
Michael Lippautz authored
LocalHeap only uses LABs for allocation with size below kMaxLabObjectSize. Larger allocations used a path that was unaware of alignment restrictions. Bring implementations of LocalHeap and regular PagedSpace closer together by assuming the caller of their free list allocations takes care of size and alignment adjustments. Drive-by: Use unaligned allocations when possible which avoids a call into PreceedWithFiller(size) which would only bail out late for 0-sized fillers. Bug: chromium:1338687 Change-Id: I0f52c54359326a249b2ebe95bb73184ad95194f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721817Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81338}
-
Andy Wingo authored
Following change in https://github.com/WebAssembly/stringref/pull/22. This adds two new parsing modes: a strict UTF-8 parsing mode, and a sloppy mode that should replace invalid subsequences with U+FFFD. Bug: v8:12868 Change-Id: I03bd8d2a3408c399ce68f7b150d7650908804113 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719919Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andy Wingo <wingo@igalia.com> Cr-Commit-Position: refs/heads/main@{#81337}
-
Ilya Rezvov authored
Bug: v8:12946 Change-Id: I3d9037a6dd940fe25f737efca49835b098d55081 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691129Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Ilya Rezvov <irezvov@chromium.org> Cr-Commit-Position: refs/heads/main@{#81336}
-
Shu-yu Guo authored
In the case of bugs creating shared->local edges, this lets us catch dangling pointers via CHECKs before they happen. Also removed some redundant checks in the shared struct verifier. Existing heap verification already checks that all of a Heap's pointers are contained within it. Bug: v8:12547 Change-Id: Ic7a007b3b6559e3dfd0286fbf869586023c6f801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704911Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81335}
-
Shu-yu Guo authored
SeqStrings have their padding bytes serialized as 0s for deterministic snapshot contents. Currently this is done by mutating the SeqStrings and memsetting their padding bytes to 0 when serializing. This mutation is not threadsafe in the presence of shared strings. This CL removes the mutation by serializing the data and padding payloads separately for SeqStrings. Bug: v8:12939 Change-Id: I58c3ada767ce41e0a874a2d6e6392a86142fa1e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3715715Reviewed-by: Patrick Thier <pthier@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81334}
-
Andy Wingo authored
This will allow us to more easily add a strict UTF-8 decoder, for use in stringrefs. Bug: v8:12868 Change-Id: I6835dca619417f4d2994d8283728cf8ebe599bd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714660Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81333}
-
Jakob Kummerow authored
Follow-up to 032dfb82. No-Try: true Change-Id: Ia12343a7ce9e1b865da4fbf562bdd9169892932c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721816 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81332}
-
Nico Hartmann authored
This reverts commit 543acf34. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/10365/overview Original change's description: > cppgc: Minor fix in cppgc efficiency calculation > > Efficiency calculation (freed bytes over GC duration) assumes that the > duration of the GC is non zero. However, if the clock resolution is > not small enough and the entire GC is very short, the timed value > appears to be zero. This leads to NaN values showing in metrics and > CHECKs failing. This CL fixes the issue. > > Bug: chromium:1338256 > Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356 > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81329} Bug: chromium:1338256 Change-Id: Ie9a23651494fc28a11bb59485a9812ee1a7cff48 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721697 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81331}
-
snek authored
Code for map methods was added a really long time ago but no one ever brought that to set. Adds new common lowering for both collections and updates the SetPrototypeHas builtin. My initial testing shows this to be as much as 50x faster in some cases. Change-Id: Ifea5be01c9e51013d57ac00bd817759ceace6669 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3709246Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: snek <snek@chromium.org> Cr-Commit-Position: refs/heads/main@{#81330}
-
Nikolaos Papaspyrou authored
Efficiency calculation (freed bytes over GC duration) assumes that the duration of the GC is non zero. However, if the clock resolution is not small enough and the entire GC is very short, the timed value appears to be zero. This leads to NaN values showing in metrics and CHECKs failing. This CL fixes the issue. Bug: chromium:1338256 Change-Id: I1dbc52072fcde3411aa38fa0c11da25afd107ca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714356Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#81329}
-
Milad Fa authored
Port e35039e7 Original Commit Message: If the returned promise rejects, we switch to the suspender's stack and throw the value. Re-purpose the WasmOnFulfilled data to also represent the rejecting case and rename it to WasmResumeData. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic9e5b959df90f1041353662dc054a849fea9874e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721416Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81328}
-
Sunny Sachanandani authored
This reverts commit 83f60359. Reason for revert: RB-Dev crash - crbug.com/1338687 Original change's description: > [snapshot] Turn alignment DCHECKS into CHECKS > > This is a temporary change to get more detailed crash reports for > further investigations. > > Bug: chromium:1330861 > Change-Id: Ifdd8d61692577dffd54d07fadb65575a5c30dcd3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3707592 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81262} Bug: chromium:1330861, chromium:1338687 Change-Id: I845aee5cfe02dee399851484d1a72f73dc56f1f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718943 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81327}
-
Thibaud Michaud authored
Throw a wasm trap when trying to re-enter a suspender that is active or suspended. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Ic448a15db29de14fb8d6bb8408af8fbaae82a2b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716481Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81326}
-
Thibaud Michaud authored
If the returned promise rejects, we switch to the suspender's stack and throw the value. Re-purpose the WasmOnFulfilled data to also represent the rejecting case and rename it to WasmResumeData. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I91a301c3c6d9d243efbfabe7263555e11f0d9277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706606Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81325}
-
Patrick Thier authored
To be able to share external strings, we need to share the external pointer table in sandbox builds. To avoid branches at runtime all pointers for external strings are stored in the shared external pointer table. Bug: v8:12957 Change-Id: Iaa6be7839a2f5e50f80fd58c5b33fb9c6af61057 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695263Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#81324}
-
Leon Bettscheider authored
MinorMC events were incorrectly grouped under the V8.GCScavenger trace event name. This CL introduces the trace event name V8.GCMinorMC and uses it when MinorMC is used instead of Scavenger. Change-Id: Ide22526adfa9cc6dec91d3c34186b1c2ea6eb862 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717989 Commit-Queue: Leon Bettscheider <bettscheider@google.com> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81323}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I2984b3ed6ac6b769f9b4ce758fdf4bfc3b6f6d49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714661Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81322}
-
Hao Xu authored
Change-Id: I171a2562517f589e20950b8d6df14bfa488885ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719686Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#81321}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3a562c9..5753f4e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ia87b7dd33a1b7c943a2582f82040f54ca219f9e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719050 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81320}
-
Lu Yahan authored
Change-Id: Ib606da34b76b28fd55811225de47e407a1ebd8ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717551Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81319}
-
- 22 Jun, 2022 11 commits
-
-
Manos Koukoutos authored
TrapIf and TrapUnless had an effect input, but not an effect output. This is not canonical for Turbofan graphs. This CL puts them properly into the effect chain. Drive-by: - Remove premature optimization in WasmGraphBuilder::TrapIfEq{32,64}. - Change LoadFromObject to Load when loading from a stack slot. Change-Id: I3fc43e693fa0507406dc31208e487026b0e5156b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714240Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81318}
-
Liviu Rau authored
Bug: skia:10306 Change-Id: Ibcddc8c724130e315471413c2835687fe0571475 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718660 Auto-Submit: Liviu Rau <liviurau@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81317}
-
Shu-yu Guo authored
Bug: v8:12547 Change-Id: I13ef21d5246fb1115cf75fb1f6b4bcde33f84dd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3715379 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#81316}
-
snek authored
A lot of logic is missing from the Wasm entry for fast api calls. The majority of the lowering is shared between wasm and js, and uses the same graph operators, so this adds a common fast api call builder which can be called from the wasm compiler and the js compiler. Bug: chromium:1052746 Change-Id: I9dbd82548951b2b155a7b2459714239d0b251d71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3708842 Commit-Queue: snek <snek@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81315}
-
Shu-yu Guo authored
Add ParkedScopes in d8 where it blocks. Change-Id: I369fbdb361b4e357ff6ceef53fbf52f543979438 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704903Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81314}
-
Milad Fa authored
Changes for TF instruction selector will be pasted in the CL comments and will get applied once all relaxed opcodes have been implemented in codegen/liftoff. Change-Id: I231aa6fcc702a19704b7707331eba549c44232d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718393Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#81313}
-
Shu-yu Guo authored
This reverts commit c801d529. Reason for revert: Broke perfetto builder: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug%20-%20perfetto%20-%20builder/19620/overview Original change's description: > Refactor dynamic name to perfetto::DynamicString > > Recently perfetto introduced `perfetto::DynamicString` to allow clients > to wrap dynamic event name strings. So that clients don't have to > manually set event name inside trace lambda. > > With that: > > TRACE_EVENT("cat", nullptr, [&](EventContext ctx) { > ctx.event().set_name(dynamic_name_str) > }); > > is simplified to: > > TRACE_EVENT("cat", perfetto::DynamicString{dynamic_name_str}); > > In this change we are making use of perfetto::DynamicString to pass > dynamic event name string. > > Change-Id: Ic6b501df67409d6faa4d60b59095ad0e79ce585e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3716473 > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> > Commit-Queue: Mohit Saini <mohitms@google.com> > Cr-Commit-Position: refs/heads/main@{#81298} Change-Id: I06d1d6baa4413e53acfd7ac1e3163c5a6a15597c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3718436 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Shu-yu Guo <syg@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81312}
-
Andreas Haas authored
With recent changes, we resolve the promise of e.g. WebAssembly.compile with the external API, and not the V8-internal API. The external API, however, also handles microtasks, and depending on the MicrotasksPolicy, may also execute microtasks immediately. This means the then-handler of WebAssembly.compile may get executed within all the scopes that were open when the external API was called. One of the open scopes is the CancelableTask that finishes WebAssembly compilation. The deadlock seen in the issue arises now when {quit()} gets called in the then-handler of WebAssembly compilation. The reason is that {quit()} terminates the isolate, and during isolate termination, we wait for all running CancelableTasks to finish. This, however, means a deadlock, because the task that terminates the isolate is waiting for itself to finish. R=jkummerow@chrommium.org Bug: chromium:1338150 Change-Id: I89243daffc76a456293519e24bfaad88277bb99a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717990Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81311}
-
Shu-yu Guo authored
Also remove the unused AllocateTwoByteInternalizedString method. Change-Id: I28e2c39a0196c48e56942efc263009aa3676cdec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714988Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81310}
-
Danylo Boiko authored
- "Remember graph layout" button - Graph layout caching (almost 10x speed up) - Camera position and zoom saving - Refactored graph.ts, graph-layout.ts and graphmultiview.ts Bug: v8:7327 Change-Id: I6a9db1ddbbaf506bff0b9d1c1e015f245c7c3974 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714248 Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#81309}
-
Andy Wingo authored
Following change in https://github.com/WebAssembly/stringref/pull/22. Bug: v8:12868 Change-Id: Ic7728bff5d03ab547cb26ff41d6966f95bfb6b62 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3717986 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81308}
-