- 02 Feb, 2021 18 commits
-
-
Benedikt Meurer authored
Previously the WebAssembly debugger support completely ignored the condition on breakpoints. With this change, we check conditions (snippets of JavaScript) properly, which enables not only conditional breakpoints in the front-end, but also other features like 'Never pause here' (which simply sets `false` as condition) and log points. Fixed: chromium:1173007 Bug: chromium:1173006 Change-Id: I02c740d383378a1f4cc08134ad571bea08e9a905 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666690Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72485}
-
Clemens Backes authored
We are often stepping multiple times without inspecting the state in-between. Hence, the generated debug side table is often not being used. Instead of always generating it, we can generate it lazily on demand, which can avoid the need to generate it at all. R=thibaudm@chromium.org TEST=inspector/debugger/wasm-stepping Bug: chromium:1172299 Change-Id: I9b9ff4485d65d720d23585856b3d672925460667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664446 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72484}
-
Santiago Aboy Solanes authored
Also, enable concurrent GetBackPointer(). Bug: v8:7790 Change-Id: If92cb7cdd9e6f5eb9a636764ca8abe2fc2c05ab2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650205 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#72483}
-
Jakob Kummerow authored
When constant-folding the test based on static types in the function body decoder, we have to ensure Liftoff's value stack is properly updated. Fixed: chromium:1172912 Change-Id: I618992608882b850a8a4bce0b267ce456e4c2a40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664447Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72482}
-
Clemens Backes authored
This reverts commit a850668c. Reason for revert: new test flaking on many bots, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win32/31068/overview Original change's description: > [d8] Fix a crash when getting the worker's onmessage handler > > Bug: chromium:1162473 > Change-Id: Ided2f52882aaf02e1dc9a8d0ba883fedf029464d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663004 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72473} TBR=marja@chromium.org,cbruni@chromium.org Change-Id: I5ec056185967974a94fd61baec8a75e855e1a272 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1162473, v8:11383 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666693Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72481}
-
Leszek Swirski authored
Add a simple backtrace/bt command to the simulator debugger, which does the frame-pointer stack walk and dumps pc/fp/sp for each frame. This is strictly less powerful than the full JS stack dump, but can be used to debug issues with corrupted frames that prevent the JS stack dumper from working correctly. Change-Id: I26cc962ab8d22c0a219d6a35548544602aa89418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666688 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#72480}
-
Leszek Swirski authored
Extract out the command processing from Simulator::Debug(), and expose it to gdb as a new 'sim' command. Example usage: (gdb) sim p x15 (gdb) sim stack The sim command will execute that one command, and will return to gdb. For a list of all commands, you can call (gdb) sim help Note that sim won't resume simulator execution until gdb continues execution; for example, `sim next` will set a breakpoint on the next instruction, and will return to gdb. The user then has to continue execution in gdb, at which point the simulator will break. The user can then re-enter gdb with the gdb command. This will look like this: (gdb) sim next (gdb) continue ... sim> gdb (gdb) ... Change-Id: I678e71e2642d8427950b5f7ed65890ceae69e18d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664448 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#72479}
-
Clemens Backes authored
Conditional breakpoints are not implemented yet; the condition is just ignored for wasm. This CL adds a test for conditional breakpoints. The output is expected to change once the implementation is finished. R=bmeurer@chromium.org Bug: chromium:1173007 Change-Id: I15e0053ec8b57e28b8eadc208f35bbf70437682e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666692 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#72478}
-
Manos Koukoutos authored
Changes: - Rename ObjectReferenceKnowledgs::object_must_be_data_ref to reference_kind, introduce an enum to describe it. - In both compilers, remove the dynamic check whether the object is an array/struct. This is known statically. Instead, if we are checking for a function, just check for rtt equality and exit. - Remove is_data_ref_type(), replace it in the compilers with calls to has_signature(). - Restructure AllocateSubRtt() to handle function rtts properly. - Add a couple execution tests. Bug: v8:7748 Change-Id: I46fbbfe2f2a7d29b583de0d536d71c534b98322f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661460Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#72477}
-
Jakob Gruber authored
The removed flags are: 1. --turbo-nci-as-midtier 2. --turbo-nci-cache-ageing 3. --turbo-nci-delayed-codegen Flag 1. was used by a testing mode that is no longer used. Flags 2. and 3. were used to experiment with codegen and cacheing heuristics, no longer needed now that work is suspended. Bug: v8:8888 Change-Id: Ib4a89f09340c2d94ee7688928c8235276c1f1032 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661461 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#72476}
-
Mythri A authored
Optional chain checks check if the object is null or undefined and if it is we don't perform the load but just load accumulator with undefined. For calls the value of the accumulator needs to be stored in the callee register. We were doing this only when the object isn't null or undefined. This cl fixes it by storing it to callee always. Bug: chromium:1171954 Change-Id: I391af18e783486fed70be561027bd8aba97b93cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665466 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72475}
-
Georg Neis authored
Boolean denotes the boolean JS values and doesn't make sense for the result of a WordEqual. Change-Id: Id504bbe1171c2603ed4070ed922fcafd94d846c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666689 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#72474}
-
Marja Hölttä authored
Bug: chromium:1162473 Change-Id: Ided2f52882aaf02e1dc9a8d0ba883fedf029464d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663004Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#72473}
-
Camillo Bruni authored
Add comments and simpify code a bit for less chance of cargo culting. Change-Id: Ica3fc60b0b7c11cc99a4c9ba9e3255662bbbb6bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642459 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#72472}
-
Liu Yu authored
Port: 3b302d5c Port: 45b99aaa Besides, removed redundant DCHECK. Change-Id: Ifac825ae7670b075750603b2c61a3d60a85cc373 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2662581Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72471}
-
LiuYu authored
Port: 6d3a53e7 Bug: v8:11331 Change-Id: I6aaba8e4d25e01121f0f7e01f67af3b5c7202ba6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666712 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#72470}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dce1147..dc9dc45 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9904915..fc5af1a Rolling v8/third_party/aemu-linux-x64: Y_rckHsnBv6dqNUbG4QoVkl3njqEx7ewCNGmqOE_h1MC.._nJMIPzu-ykpL-XPjf14IZ3CAFT3iQRtsbzyiSm9u7QC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/91735e2..4920147 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cb07c52..8c95595 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c876c8f..bf44340 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9290907..ec98581 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic364444072e5b2405dc05d3cce7133585cce84c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666713Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72469}
-
Michael Lippautz authored
- Allow downcasting construciton and assignment; - Add WeakCrossThreadPersistent::Lock() that safely retrieves a strong handle for a weak reference; Bug: chromium:1056170 Change-Id: I5f8d85a87c9955506dd87723ffb4c80d66770c04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663160 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72468}
-
- 01 Feb, 2021 17 commits
-
-
Milad Fa authored
Port 6d3a53e7 Original Commit Message: This is a reland of commit 9c09c227. The fix for gc stress failure is merged: https://crrev.com/c/2656857. Original change's description: > Bug: v8:11331 > Change-Id: Ie394ec841a1a1c4030c4f589eac2cee8a6a2a1f9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639033 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72304} R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I68991b81c18e06714d272f019dab7994419692bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665894Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#72467}
-
Junliang Yan authored
Port 07b03b83 Original Commit Message: c_entry_fp is normally cleared in `LeaveExitFrame`, but we adjust the frame without it in the exception path. This can cause the SafeStackFrameIterator to assume we have an exit frame and iterate over frames incorrectly, which for arm64 can cause pointer authentication failures with CFI enabled. Even without the pointer authentication failure, we iterate over frames incorrectly, so make this change for other architectures too. Also clear c_entry_fp in the beginning of JSEntry, after pushing it on the stack. Not doing this doesn't cause pointer authentication failures, but it will make the SafeStackFrameIterator assume we are executing C++ and miss the JS frames on top. R=georgia.kouveli@arm.com, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com, mfarazma@redhat.com BUG= LOG=N Change-Id: Id12286a0f18fce928f9e44825fc13cd0338bac46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665893Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72466}
-
Ng Zhi An authored
This is a reland of commit 9c09c227. The fix for gc stress failure is merged: https://crrev.com/c/2656857. Original change's description: > Bug: v8:11331 > Change-Id: Ie394ec841a1a1c4030c4f589eac2cee8a6a2a1f9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2639033 > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72304} Bug: v8:11331 Change-Id: I82f57b3fe5f0c456472aa7ce404703f34b73d17e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659511Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72465}
-
Ng Zhi An authored
Bug: v8:10975 Change-Id: Icfc5982c96132ef3eaa4d8b9dc2b8229d87ab15e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659509Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72464}
-
Ng Zhi An authored
Change them to wasm-linkage.h. Bug: v8:11074 Change-Id: Ic29cdd85b3d20cf384952aacc7ca82236e3bf276 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659502Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72463}
-
Daniel Clark authored
The DCHECK is firing because the fuzzer doesn't set any HostImportModuleDynamically callback. Previously RunHostImportModuleDynamicallyCallback would not assert for this and would just return a rejected promise. After https://chromium-review.googlesource.com/c/v8/v8/+/2620578, this results in a failed DCHECK. This change restores the old behavior by loosening the DCHECK such that it only fails if both the deprecated and the new callback are set. Bug: chromium:1172121 Change-Id: Ifda28eb28572a40d3752928997edf25d607b61c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659505Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72462}
-
Georg Neis authored
Make the crash_on_error parameter false by default, so that the typical use is easier to read: Use GetOrCreateData(obj) if you expect the object to be known already. Use TryGetOrCreateData(obj) if you don't. Bug: v8:7790 Change-Id: I5732ad13ec582c2a1112032f88be54c833906a6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658327 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72461}
-
Clemens Backes authored
Minor cleanup before starting to refactor the debug side table. R=thibaudm@chromium.org Bug: chromium:1172299 Change-Id: I507cb297e66954488194a346aac31664a34a20f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659260Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72460}
-
Liviu Rau authored
Used for testing infra change https://crrev.com/c/2650208 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: chromium:1144601 Change-Id: I93ea610c45d3cbc9557f9a13e2ccc74927720384 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659256 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72459}
-
Georgia Kouveli authored
c_entry_fp is normally cleared in `LeaveExitFrame`, but we adjust the frame without it in the exception path. This can cause the SafeStackFrameIterator to assume we have an exit frame and iterate over frames incorrectly, which for arm64 can cause pointer authentication failures with CFI enabled. Even without the pointer authentication failure, we iterate over frames incorrectly, so make this change for other architectures too. Also clear c_entry_fp in the beginning of JSEntry, after pushing it on the stack. Not doing this doesn't cause pointer authentication failures, but it will make the SafeStackFrameIterator assume we are executing C++ and miss the JS frames on top. Bug: v8:10026 Change-Id: Ie94834920f51e9f1cc5c1c775596726b61fc0507 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2642256Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#72458}
-
Ulan Degenbaev authored
The flags are enabled by default and have stable coverage. This also removes the corresponding bots. Bug: v8:10315 Change-Id: Icce01383050dff758b6554db8e0c3589d6e5459c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658324 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72457}
-
Peter Wong authored
- Removed no longer used StringBuiltinAssembler methods (DispatchOnStringEncodings, PointerToStringDataAtIndex) - Removed no longer used Runtime functions (StringIncludes, StringIndexOf, StringIndexOfUnchecked). - Overall builtin code size is reduced (652 bytes on Mac x64.release build), builtin size breakdown: BEFORE ====== TFS Builtin, StringIndexOf, 1092 TFJ Builtin, StringPrototypeIncludes, 1784 TFJ Builtin, StringPrototypeIndexOf, 1536 Total = 4412 AFTER ===== TFC Builtin, StringIndexOf, 2036 (+944) TFJ Builtin, StringPrototypeIncludes, 1072 (-712) TFJ Builtin, StringPrototypeIndexOf, 652 (-884) Total = 3760 (-652) Bug: v8:8996 Change-Id: I9a88c095e2097f7d570e58e744d6692dc524ddf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660995 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72456}
-
Manos Koukoutos authored
Changes: - Remove an obsolete TODO from wasm-module-builder. - Replace CHECK with gTest's EXPECT in unittests. - Remove setting of --experimental-wasm-liftoff-extern-ref in wasm-gc. - Test test-gc/JSAccess with Liftoff. - Remove useless #undef's from module-decoder-unittest. Change-Id: I11b4a3dde9683cc9c7d1eb89b1a63e1859505aad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659063 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72455}
-
Shu-yu Guo authored
Bug: v8:9548 Change-Id: I92b8c3b305f0e18557fb6628c42c668faf694bd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659512 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72454}
-
Iain Ireland authored
RegExpParser::ParseRegExpSyntax was added to allow the SpiderMonkey embedding of irregexp to report early errors. It was removed in https://chromium-review.googlesource.com/c/v8/v8/+/2509596 because it was unused. This patch restores it, with a comment to prevent future deletion. Bug: v8:11368 Change-Id: Iebec7e14b92e9a0fccc08f2f1c85d8ff4d6173f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2658037Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#72453}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I56a5e0a3e3141ef781a816656dc50d0d0a1573cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659258 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72452}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7a702b2..dce1147 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia57ea2e2a6b9ad9e89136ac4b1509b45fb54a44d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2662502Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72451}
-
- 31 Jan, 2021 2 commits
-
-
Manos Koukoutos authored
br_on_* instructions need a precisely typed branch target, as opposed to being treated like regular br instructions. Bug: v8:7748 Change-Id: Iedace79faf59d61cf2ce5ac88e633e07b5a2a43f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655507 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72450}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/568bd76..7a702b2 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a6400cfa7e2b7ae8737fd263ed01b877d1ead45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661901Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72449}
-
- 30 Jan, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c083992..568bd76 Rolling v8/third_party/aemu-linux-x64: 2AjFHxe4t1iSrrSx8ayS9uaUpVgbf4uevQoAj-Pt5_0C..Y_rckHsnBv6dqNUbG4QoVkl3njqEx7ewCNGmqOE_h1MC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9d5ec46..91735e2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/558a304..cb07c52 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f097906..f4147b2 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2c183c9..c876c8f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cc8d00a..9290907 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9be1ce5e4cd16c80304d60694429ad74cff0ddc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660942Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#72448}
-
Bill Budge authored
This reverts commit 352b9ecb. Reason for revert: fuzzers turned up more problems: https://bugs.chromium.org/p/chromium/issues/detail?id=1171759 https://bugs.chromium.org/p/chromium/issues/detail?id=1171846 tbr=ahaas@chromium.org,neis@chromium.org Original change's description: > Reland "Reland "[compiler][wasm] Align Frame slots to value size"" > > This is a reland of 1694925c > > Minor fix to linkage for constexpr. > > TBR=ahaas@chromium.org,neis@chromium.org > > Original change's description: > > Reland "[compiler][wasm] Align Frame slots to value size" > > > > This is a reland of cddaf66c > > > > Original change's description: > > > [compiler][wasm] Align Frame slots to value size > > > > > > - Adds an AlignedSlotAllocator class and tests, to unify slot > > > allocation. This attempts to use alignment holes for smaller > > > values. > > > - Reworks Frame to use the new allocator for stack slots. > > > - Reworks LinkageAllocator to use the new allocator for stack > > > slots and for ARMv7 FP register aliasing. > > > - Fixes the RegisterAllocator to align spill slots. > > > - Fixes InstructionSelector to align spill slots. > > > > > > Bug: v8:9198 > > > > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840 > > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#71644} > > > > Bug: v8:9198 > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390 > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#72195} > > Bug: v8:9198 > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72209} TBR=bbudge@chromium.org,neis@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9198 Change-Id: Ifee566e3e82f2e774525996b038ce135190d0be1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660378 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72447}
-
- 29 Jan, 2021 1 commit
-
-
Milad Fa authored
kNumberOfSavedGpParamRegs is based on the number of registers defined under Generate_WasmCompileLazy within the builtins and not the list under wasm-linkage.h. More information can be found within the comments of this CL: https://crrev.com/c/2656857 Change-Id: I9d2122545120c95b7686c98eb838ab25ea376bf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659756 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72446}
-