- 09 Jun, 2020 33 commits
-
-
Ng Zhi An authored
This constructor can be default, and since it isn't doing anything, can be removed. See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: I5da7d78063c57d318f6cec578185bad6f83a1a3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233980 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#68274}
-
Ng Zhi An authored
Making them private was a way to hide the functions, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I27cb7b9aa3d2b90e1c05c1f12585f94c746cbdb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233981 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#68273}
-
Ng Zhi An authored
The constructor of AbstractState isn't doing anything interesting, so can be removed. See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: If413a69aa83689f55a51e48179b75287a4620d5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233857Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68272}
-
Clemens Backes authored
The interpreter is only used for testing, and is now instantiated and invoked directly instead of via the {WasmDebugInfo}, holding the {InterpreterHandle}. This CL removes both classes. R=ahaas@chromium.org Bug: v8:10389 Change-Id: Iede3feea413decae1edc28146b871a819e204768 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237132Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
The reference types wasm proposal dropped all subtyping. Subsequently, the 'anyref' type was renamed to externref. This changes all references of the *type* anyref to externref. Additionally, the flag that permits this extension is renamed to "reftypes" to mirror the proposal name. Bug: v8:7748 Change-Id: Icf323f13b9660fd10540e65125af053fca3a03f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232941 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68270}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/036a45e..7ad9ac5 Rolling v8/third_party/aemu-linux-x64: WCiGqc2IsqMVCcj8UruU8vGLvhfosP46CB3tAy6N2boC..pcue74MrtwdptQfnABqz12W-F6Br8-PlTN1pD5o_aQsC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/69b4144..03e7ff4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a85d58e..dcb5c85 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3c04a1b..6ddf849 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f54772060f8f45968bcd35ab6cd8e928b00a2ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235655Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68269}
-
Clemens Backes authored
The existing {OwnedVector::New} value-initializes all elements, which means zeroing them in case on integral types. In many cases though we know that we will overwrite the content anyway, so the initialization is redundant. In the case of assembly buffers for wasm compilation, this zeroing showed up with several percent of execution times for some benchmarks. Hence this CL introduces a new {OwnedVector::NewForOverwrite} (along the lines of {std::make_unique_for_overwrite}), which only default-initializes the values (meaning no initialization for integral values). R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8d2806088acebe8a264dea2c7ed74b0423671d4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237140 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68268}
-
Milad Farazmand authored
Change-Id: I782f5b0dd8ed374df406fb615f6e74efed8b5368 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235658Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68267}
-
Zhao Jiazhong authored
This CL also fixes bitmask instructions on mips platform. Change-Id: I550daca3b6b4ece151928836f316d3960a7af437 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2230090 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68266}
-
Clemens Backes authored
The test takes several minutes, because the {slice} call does thousands of runtime calls, which again call {ValidateElements} for every single added element (in debug mode). Hence this CL skips the test in the slow_path variant. R=leszeks@chromium.org Change-Id: I2fbaaf32809ecb34de1f563f34bd65ce8b7ab238 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237628Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68265}
-
Manos Koukoutos authored
Reference types in function definitions signatures are not allowed to refer to function types (this will change when we fully integrate the typed function references proposal). Bug: v8:7748 Change-Id: I2456b810f85e608c48a952ef9e64d7a8ff78892b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231352 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Georg Neis authored
This caused a CHECK failure after my recent CL. Bug: chromium:1084820, chromium:1092650 Change-Id: Icdc2a755c6b30ad01dccc908e0e5e137fedf8918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237145Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68263}
-
Leszek Swirski authored
Landing this simple fix rather than reverting Tbr: rmcilroy@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I230300c32bf6a97cd82376c46461735dd34378b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237632 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Ambroise Vincent authored
This includes the instruction opcode, its use in TF, its support in the simulator and the detection of the associated CPU feature. The instruction can be tested in the simulator with the new --sim-arm64-optional-features flag. Change-Id: I6047fa16696394fe0ced4535f7788d2c8716a18c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2222348Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68261}
-
Marja Hölttä authored
Promise.{all,allSettled,any,race} should check resolve is a function before opening their iteratable. PR: https://github.com/tc39/ecma262/pull/1912 PR for Promise.any: https://github.com/tc39/proposal-promise-any/pull/65 This CL includes the following cleanup changes: - Made it more explicit that the constructor is a Constructor. - Removed unnecessary nested try blocks (a try can have both a catch and a label). - Moved commonly used definitions out of promise-race.tq where they don't belong. - Made the parameter order of PerformPromiseAll match the spec. Bug: v8:10578 Change-Id: I9deb5d5106db7350a0d0ad52f165ff2469e7074b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232544 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68260}
-
Clemens Backes authored
The {NONE} reloc info is the one used most often, i.e. for every assembler call that takes an {Immediate} on x64 which is not relocatable. Hence assign value 0 to {NONE} such that constructing such immediates is faster and also checking for this most common case is faster. R=ishell@chromium.org Bug: v8:10576 Change-Id: I3c048710b80dd31fa5b5d3b1415d72a24d95cb90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237136Reviewed-by: -
Clemens Backes authored
Avoid going through the {WasmDebugInfo}, which existed for debugging in the interpreter in production. Instead, tests now instantiate the interpreter directly. This will unblock the removal of the whole {WasmDebugInfo}, and finally moving the interpreter to the test directory. R=ahaas@chromium.org Bug: v8:10389 Change-Id: I8ae76a1d5bff716c129781b11a15369a80b13603 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235543Reviewed-by: -
Clemens Backes authored
The reference stack was set by the scope, and reset when leaving the scope, in order to avoid leaking objects via cycles in the reference tree, involving global handles which are considered strong roots. Since the interpreter cannot call out to JS any more, we cannot create such cycles any more. Hence, the ReferenceStackScope is removed, and the FixedArray for the reference stack is allocated as a global handle instead. This will unblock removing the WasmDebugInfo object, which was used by the ReferenceStackScope before this CL. R=ahaas@chromium.org Bug: v8:10389 Change-Id: I2e3c6a03750846679eecd9e6a07042db962aad9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235542Reviewed-by:
-
Dominik Inführ authored
Fix dcheck failure where committed was smaller than used memory. This was because of background threads allocating between calculating both stats and used memory could already be larger due to those background allocations. Avoid this first calculating used memory and committed memory afterwards. Bug: v8:10563, v8:10315 Change-Id: Ic07970f607941140e3028bddde3e365b66aa4b5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237138 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68256}
-
Dominik Inführ authored
Rename CreateFillerObjectFromSweeper to CreateFillerObjectAtBackground. Also use CreateFillerObjectAtBackground in PagedSpace::Free since this is used from both main and background threads. Bug: v8:10315 Change-Id: I1dc8ca2b1c81bdfd192c0ae8d8547eb577f3f8c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235534 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Nico Hartmann authored
A previous CL removed the kNoThrow flags from both SpeculativeBigIntAdd and SpeculativeBigIntSubtract. This introduced a bug, because the JSTypeHintLowering phase, where these operators are introduced during inlining, does not support the generation of throwing operators. Since these operators always deoptimize in case of an error, instead of throwing the exception directly, it is safe to mark them as kNoThrow. Bug: chromium:1091461 No-Try: true No-Tree-Checks: true Change-Id: I551616b0c462647574e5af8824d9ed7b3252659d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235113 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Arnaud Robin authored
Added wasm tracing support for turbofan with the flag --trace-wasm. The test suite was updated accordingly. R=clemensb@chromium.org Bug: v8:10559 Change-Id: Ie6ee2a05142081416d8572d4d72dcd315e0bf285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235536Reviewed-by:
-
Santiago Aboy Solanes authored
Change-Id: I56264fae4f60018a324667ec093bc02296d74d87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232546 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Return no value when global memory scheduling is off. Previously returned new_space->Capacity()+1 since this value was used in the callers to compare the result to. Bug: v8:10315 Change-Id: I7c7289ee9319fe9c791c3cb9b9b46cca54815904 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235704 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
OldGenerationAllocationCounter() needs to be invoked in safepoint, otherwise invocation races with background threads incrementing the counter. Bug: v8:10315 Change-Id: Iab005582bab7ebf63e7a5a796b25690f499a99eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235544 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Change-Id: Ic6130cee088d3bc12fdfb4a5f947138b34466456 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232545 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit f7f72b7b. Reason for revert: Flaky timeouts of slow-path tests -- specifically, mjsunit/regress/wasm/regress-9017, which appears to have regressed from ~2 min to ~3-4 min https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8878016799136124416/+/steps/Check_-_slow_path__flakes_/0/logs/regress-9017/0 Original change's description: > [wasm-simd] Prototype f64x2 rounding instructions > > Implements f64x2 ceil, floor, trunc, nearestint, for interpreter and > x64. > > Bug: v8:10553 > Change-Id: I12a260a3b1d728368e5525d317d30fc9581cae04 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213082 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68241} TBR=gdeepti@chromium.org,tebbi@chromium.org,zhin@chromium.org Change-Id: I9915dd375c7f0e08b5414189efb29ed1c90cb96d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237131Reviewed-by:
-
Andreas Haas authored
This CL * Adds the xadd instruction to the ia32 assembler and disassembler; * Implements the AtomicAdd instructions, except AtomicAddU64, on ia32; R=clemensb@chromium.org Bug: v8:10108 Change-Id: Ic8653a9f96148282951104fefb4185c4c0db89a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232719Reviewed-by:
-
Iain Ireland authored
There are at least three equivalence classes where this assertion should not actually hold: '\u0390\u1fd3', // ΐΐ '\u03b0\u1fe3', // ΰΰ '\ufb05\ufb06', // ſtst Bug: v8:10591 Change-Id: I26cb43d2e67c54e689f1831ea13be46c73d5e92d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2231595Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68246}
-
Zhi An Ng authored
This reverts commit 3692bef9. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11514? Original change's description: > [wasm-simd][x64] Prototype i32x4.dot_i16x8_s > > This implements I32x4DotI16x8S for x64 and interpreter. > > Bug: v8:10583 > Change-Id: I404ac68c19c1686a93f29c3f4fc2d661c9558c67 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229056 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68244} TBR=gdeepti@chromium.org,tebbi@chromium.org,zhin@chromium.org Change-Id: I8760d480a783ba6c8a2ec2eaeb0131c7d4e11159 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10583 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2236961Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68245}
-
Ng Zhi An authored
This implements I32x4DotI16x8S for x64 and interpreter. Bug: v8:10583 Change-Id: I404ac68c19c1686a93f29c3f4fc2d661c9558c67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229056Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html. Bug: v8:10488 Change-Id: I0808eee42c3339d9de653125b0d853b8ae5e5540 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233856Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html. Bug: v8:10488 Change-Id: I9de63b954f99a1725b5d20ff7bb3f416cf22131a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233408Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68242}
-
- 08 Jun, 2020 7 commits
-
-
Ng Zhi An authored
Implements f64x2 ceil, floor, trunc, nearestint, for interpreter and x64. Bug: v8:10553 Change-Id: I12a260a3b1d728368e5525d317d30fc9581cae04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213082 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I39d0beb3e30cc5810eac32ec203191ec840cd6d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225608 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Gus Caplan authored
This allows fast call callbacks to be created in cases where C++ templates cannot be used, for example C or Rust. Bug: chromium:1052746 Change-Id: I90122444297f6c00428cd7345e0c0c7eca010716 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235914Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Gus Caplan <me@gus.host> Cr-Commit-Position: refs/heads/master@{#68239}
-
Clemens Backes authored
This is a little cleanup to use the {GraphAssembler} for implementing {TraceMemoryOperation}. The {GraphAssembler} needs to be extended by a straight-forward {StackSlot} method. R=tebbi@chromium.org CC=arobin@google.com Bug: v8:10123 Change-Id: Ic872870bfd8609bb09383a0458b5c08fd7586993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2232556 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
This reverts commit 31c66193. Reason for revert: Speculative revert for lots of timeouts on the tree, some seem heap related, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20cfi/25151 Original change's description: > [heap] Expand new space in safepoint > > Move expansion of the new space into the safepoint. Otherwise background > threads race with the main thread when accessing the new space capacity. > This will most likely also be required to allow the allocation of new > space objects from background threads. > > Bug: v8:10315 > Change-Id: Ia8ac0c9f582876b655eaf4e35082aeadfbdb830e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235532 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68226} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: I8da9aa000090a9bff43bb15b7bb55bb5a3138fe5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235539Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I89d0fbe6b73bf1b8765bb532fff58b1960fed09a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235537 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds allocation-based heap growing strategy that triggers GC based on some limit. The limit is computed based on previous live memory and a constant growing factor. For invoking GC, we support two modes: with and without conservative stack scanning. Without conservative stack scanning, an invoker makes sure that we schedule a GC without stack using the existing platform. Bug: chromium:1056170 Change-Id: I1808aeb5806a6ddd5501b556d6b6b129a85b9cda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228887Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
