- 21 May, 2021 12 commits
-
-
Clemens Backes authored
This ports https://crrev.com/c/2905602 to the other platforms. R=cbruni@chromium.org Change-Id: Iee941d22449b1e05bc131cc05d87e036e8f223d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912588Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74714}
-
Igor Sheludko authored
... and use the generated WasmObject instance type range for data refs checks. Bug: v8:11804 Change-Id: I855ff76404ff7e3ca919dabec238d35cb39c0baf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910784 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74713}
-
Michael Achenbach authored
This adds a new status file indicator "HEAVY" to mark tests with high resource demands. There will be other tests running in parallel, but only a limited number of other heavy tests. The limit is controlled with a new parameter --max-heavy-tests and defaults to 1. The change also marks a variety of tests as heavy that recently had flaky timeouts. Heavy also implies slow, hence heavy tests are executed at the beginning with a higher timeout like other slow tests. The implementation is encapsulated in the test-processor chain. A new processor buffers heavy tests in a queue and adds buffered tests only if other heavy tests have ended their computation. Bug: v8:5861 Change-Id: I89648ad0030271a3a5af588ecc9c43285b728d6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905767 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#74712}
-
Ross McIlroy authored
They have been disabled for some time and are superseeded by lazy feedback vector allocation. Change-Id: Iafc3989b0c1f866ce7d6295d9b13ccaa5ef1c115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905609Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74711}
-
Andreas Haas authored
R=ecmziegler@chromium.org Change-Id: Ibe9b1793a60d21ba853501b19c53647be5321288 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910786Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74710}
-
Manos Koukoutos authored
Additional changes: - Clean up liftoff implementation of br_on_*. - Bundle operations everywhere based on operation rather than type. - Remove reference argument from WASM_BR_ON_* macros, to bring them in sync with WASM_BR_ON_CAST. - Add missing function decoding unittests for br_on_*. Bug: v8:7748 Change-Id: I5f5ebfac5b50b5a9a201acb435344d7471326242 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909857Reviewed-by:
-
Mythri A authored
AsmWasmFunctions don't allocate / use feedback vectors. Bug: chromium:1206289 Change-Id: I970d5eaba6603809a844c2fc5753efba411cd719 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909854 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74708}
-
Ulan Degenbaev authored
Dev experiment shows it helps to mitigate crashes on some Android devices. Bug: chromium:889460,v8:11619 Change-Id: I8c836e82e93f6373724d66598448c2610ab188d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910775 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74707}
-
Marja Hölttä authored
Existing tests already exercise KeyedStoreIC; this CL makes them take the fast path instead of the slow path. Bug: v8:11111 Change-Id: I13b84650ae37abe1a8a46d53c9a9b7104bed31de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910315 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#74706}
-
Nico Hartmann authored
Generating C++ source files is very cumbersome using raw ostreams. This CL introduces a few classes und the torque::cpp namespace that build an abstraction of printing/formatting C++ source code (mostly functions for now). This is an initial implementation with a limited set of features and uses. Landing features incrementally shall avoid huge CLs (+reviews) and complex rebasing. Bug: v8:7793 Change-Id: I3ae869755156175c7b37ea9f649e2f9c431ce3a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784688Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74705}
-
Ross McIlroy authored
These don't improve codegen and are unecessary overhead. BUG=v8:9684 Change-Id: I2feb1c1200eb0c347f4a21be5444b6a15924e6de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903162Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#74704}
-
Benedikt Meurer authored
Trivial follow up fix for https://crrev.com/c/1946349 which fixes the call to length on a half-initialized ScopeInfo. ScopeInfo::length() looks at the uninitialized fields (i.e. in case of ScopeInfo for module scopes) and would thus crash. Bug: chromium:1027475, v8:9938, chromium:1072939 Change-Id: I7e4e81edfbbde25063ab40b8e7807fd70625a8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910773 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#74703}
-
- 20 May, 2021 17 commits
-
-
Junliang Yan authored
Change-Id: Ia1b8bf3ada1957c27334e98207d57bb2e644ecdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910796 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74702}
-
Milad Fa authored
This CL adds vector splat byte, word and halfword to codegen, disassembler and the simulator. It also optimizes a number of Simd opcodes by using the added instructions as well as VSX splat immediate (xxspltib). Change-Id: I2c4eba33e81542f901d7cdc669c50b510e48c4c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909525Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74701}
-
Santiago Aboy Solanes authored
Continuing the cleanups and using the tags rather than synchronized_ in the name of the accessors. Bug: v8:7790 Change-Id: I3fe942b1decae3b248f8662547d793777acd0e8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897096 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit 1186fc50. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/16531/overview Original change's description: > [heap] Disable the young generation in shared heaps > > A shared heap will not have a young generation in the beginning. > > Bug: v8:11708 > Change-Id: I947ddb91a23a72a8cee3aa3e554723dda8146011 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891569 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74697} Bug: v8:11708 Change-Id: I8de67f70b00b5bd3066659e07fb1fd3ecfb76211 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909693 Auto-Submit: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74699}
-
Ulan Degenbaev authored
This also removes small TODOs that are not worth tracking in a bug Change-Id: If61acd1239ac90a908327694b280846b1f676c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909859Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74698}
-
Dominik Inführ authored
A shared heap will not have a young generation in the beginning. Bug: v8:11708 Change-Id: I947ddb91a23a72a8cee3aa3e554723dda8146011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891569 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Michael Hablich authored
TBR=machenbach@chromium.org notry=true Change-Id: I9110ef10d6e817b64a377108158014cd9f04ad84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910321Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#74696}
-
Ulan Degenbaev authored
Calling Heap::Print in GC is not safe because the function tries to print the stack and may allocate. Change-Id: I48fe29863076792657e2184c52d355821375f969 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835239Reviewed-by:
-
Clemens Backes authored
The old code was relying on identical alignment of both the source and the destination of the Relaxed_Memcpy. This is not always given, thus check for alignment of both. R=mlippautz@chromium.org Bug: chromium:1208782, v8:11704 Change-Id: Ic5dca3a5f0ecaea0df6eb123105520bd7785853c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905611Reviewed-by:
-
Michael Lippautz authored
Used include-what-you-use [1] to clean up cppgc API headers. The tool does somewhat work but requires some cleanup afterwards as it cannot nicely deal with `v8config.h` and the defines it generates. [1] https://github.com/include-what-you-use/include-what-you-use/ Bug: chromium:1056170 Change-Id: I7b03797c615f8e033510fc959bbdb792d8b7a4ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2907612Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74693}
-
Ulan Degenbaev authored
Change-Id: Idbe26a82ba0e208985ab2b1e5b85c6f98c3ec925 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2844663Reviewed-by:
-
Georg Neis authored
Also make the output more helpful in the error case. Bug: v8:11724 Change-Id: Ibb8bd328f936f3d4f847ba7e14adf9c30b9460f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903158 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#74691}
-
Andreas Haas authored
With this CL, V8 adds an internal field to the WebAssembly Table object that is sent to DevTools to also show table entries. As WebAssembly Tables get initialized lazily, V8 only shows the name of the function instead of the function object itself. Screenshot before change: https://imgur.com/a/XFvy3lA Screenshot after change: https://imgur.com/kT84kst R=kimanh@chromium.org Change-Id: I56a0b07785ff3484f1447419fe39ae5ec3f93247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897097Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74690}
-
Manos Koukoutos authored
This is a reland of 8f39a585 Changes compared to original: Change the type of arguments of WASM_I32V from byte to int for MSVC compatibility. Original change's description: > [wasm-gc] Implement br_on_cast_fail > > Bug: v8:7748 > Change-Id: I7894ad51ccf8ac41a5081c272a583a4ff25c1835 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900225 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74652} Bug: v8:7748 Change-Id: I39f39ff6979382f5618683a8e7754f56df4ec9e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905599Reviewed-by:
-
Milad Fa authored
gcc may throw the following compilation error if UNREACHABLE is used within a constexpr function: ``` error: call to non-'constexpr' function 'void V8_Fatal(const char*, ...)' ``` Bug: v8:11420 Change-Id: I7f8237d00ba1a5d9bd778d45eb833b89cbe8eb24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2906032 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
This fixes a compile error if webassembly is disabled. It was introduced in https://crrev.com/c/2902731. R=cbruni@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: Icf12b22d54dbd4710130e0f2b56c44f42ac86424 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905602 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4036cf1..d3e8244 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/20b1d0f..b9af93e Rolling v8/third_party/aemu-linux-x64: -Sz2gSN_5yVSHDlitjxUlmZpHuz-F2kFDW6TnmggCZoC..uDQJbkoDWGwLYtnDu3A7LnRVwsKkaFQkUWtChrVO_hYC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c1e1d55..7da48e9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6b0a611..51e3708 Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/7d0d906..e539e80 Rolling v8/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898 Rolling v8/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898 Rolling v8/tools/luci-go: git_revision:22d464e2f8f3bd2bd33f69fe819326d63f881008..git_revision:9cd9603def7a649cd3e29517180d6622be2fa898 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia80861e8b13e2b9c57916f1ac0a55fca6bb50227 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2908255Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74686}
-
- 19 May, 2021 11 commits
-
-
Junliang Yan authored
Change-Id: I24081a3fe941d083cefa782d4ba712acf7776980 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905766 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Francis McCabe authored
This reverts commit 5ef4e14f. Reason for revert: Seems to be causing a lot of flakes e.g., https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64/42913 Original change's description: > [heap] Replace usages of CollectionRequested with SafepointRequested > > CollectionRequested was used exclusively on the main thread when a > background thread requested a GC. The main thread never used > SafepointRequested at any time. Now with the shared GC we might need to > stop multiple isolates in a safepoint in the future. In such a situation > we would need to use SafepointRequested also on the main thread. > > This CL prepares V8 for this situation by using SafepointRequested > instead of CollectionRequested and friends on the main thread. The slow > path of Safepoint(), Park() and Unpark() will check in the future > whether the main thread needs to halt for a shared GC or needs to > perform a local GC. At the moment, simply performing the local GC is > still enough. > > Bug: v8:11708 > Change-Id: I819b6f7db8251074a4adf8b554e0a1393c76f7da > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2891834 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74673} Bug: v8:11708 Change-Id: I51c51e68110e83f729bd43ef62eef1396aa0cb96 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2906913 Auto-Submit: Francis McCabe <fgm@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74684}
-
Luis Fernando Pardo Sixtos authored
Refactoring ScopeInfo::ContextSlotIndex so it accepts a pointer to LookupResult instead of references to the individual arguments. Change-Id: I52bc7800f14e790bd4788c213ab0eff2354ab20e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900837 Commit-Queue: Luis Fernando Pardo Sixtos <lpardosixtos@microsoft.com> Reviewed-by:
-
Jakob Kummerow authored
We used to recompile WasmCapiCallWrappers whenever they were needed, but never garbage-collected them, which caused a memory leak when many short-lived instances of the same module were created. This patch makes the wrappers cacheable and caches them, which avoids both repeated compilation effort and the unbounded memory growth. Drive-by cleanup: unify WasmCapiFunctionData with the other Wasm*FunctionData classes by making it inherit from WasmFunctionData. Bug: v8:11774 Change-Id: Ia0c0d76be2938dc7bebfdc845f4a1cfeafef4a70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905605 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When adding new instances to the WeakArrayList of a script's instances, use Append() instead of AddToEnd() to allow possible compaction of the WAL. Also, check for interrupt requests every now and then, which allows incremental marking to get finalized when appropriate. Bug: v8:11774 Change-Id: I8be959a78d8ef370f65e8f9849f48e34c9691a13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905603 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74681}
-
Junliang Yan authored
Change-Id: I1ada6628e8d17d313f6ee73fda40bb867e3e0ee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2906013 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Jakob Kummerow authored
Attempting to trace object stats ran into an UNREACHABLE because the FieldStatsCollector didn't override VisitMapPointer. Change-Id: I38f2739c204e462e5a35f2a7ca6e0f100161b240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905604 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Victor Gomes authored
This is a follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/2833920 Bug: chromium:1209210, chromium:1198188 Change-Id: I43f18649434b06431dac6cae7946505fc4b5b398 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905607 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
This is a reland of 4a037f87 Changes compared to original change: None. This seems not to create problems after all. Original change's description: > [wasm][bug] Fix a couple of bugs in validation of unreachable code > > Changes: > - SetBlockType now instantiates the block's start merge with values of > the correct type in unreachable code. > - EnsureStackArguments now keeps the existing stack values and moves > them over the new bottom values. > - Drop stack size validation in Drop(). > - Add new tests in unreachable-validation.js. > > Change-Id: Ie68b3d9abb0a41d1623d4a123fb526e71941c4e7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902733 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74650} Change-Id: Id620f7fb6677b772b0dcfd38108256384db44439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905598Reviewed-by:
-
Junliang Yan authored
Change-Id: I1449424536b721e54f95aeb2e3b68fb25d6a5ccf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2906033Reviewed-by:
-
Benedikt Meurer authored
When setting a breakpoint on a line (in the DevTools front-end), the front-end sends a columnNumber of 0 and the inspector automatically resolves the actual location (in bytecode execution order). In order to also support changing source code, the inspector memorizes a text hint, and uses that to adjust the location upon reload. This hint was however taken based on the original line and column numbers, rather than the resolved location, which causes trouble when syntactic order doesn't match execution order, as in case of `await o.m()`. In order to address that we now remember the textual hint based on the resolved location. Fixed: chromium:1081162 Also-By: kimanh@chromium.org Change-Id: I7d08373440693b7abc18c29c1a05929d771d3031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905606 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
