Commits · ec18b79fac932038a2c0e45a69fc6d865c48f1bd · Linshizhi / V8

19 Feb, 2014 24 commits

Add comments about lazy parsing and lazy compilation. · ec18b79f

marja@chromium.org authored Feb 19, 2014

Also rename is_lazily_compiled in (Pre)Parser; it really means "is lazily
parsed" and doesn't correspond to the lazy compilation decision.

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/169223009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19492 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec18b79f

A64: Fix r19474: Tidy up Push and Pop TODOs. · d9b31caa

jacob.bramley@arm.com authored Feb 19, 2014

This fixes some snapshot=off, debug-mode regressions.

  - Call CheckConstPool when entering InsturctionAccurateScopes. This
    fixes a problem in PushMultipleTimes where 'count' is very high.
    Each call to PushHelper starts an InstructionAccurateScope
    immediately after the last one finishes, with no opportunity for the
    constant pool to be generated.

  - Temporarily disable AssertStackConsistency in PrepareForPush. This
    assertion seems to push the code size too far, and several cctests
    (intermittently) fail due to buffer size limitations. I would like
    to renable this assertion later.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/172453002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19491 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9b31caa

Upgrade Symbol implementation to match current ES6 behavior. · 0d34254f

rossberg@chromium.org authored Feb 19, 2014

Refresh the implementation of Symbols to catch up with what the
specification now mandates:

* The global Symbol() function manufactures new Symbol values,
  optionally with a string description attached.

* Invoking Symbol() as a constructor will now throw.

* ToString() over Symbol values still throws, and
  Object.prototype.toString() stringifies like before.

* A Symbol value is wrapped in a Symbol object either implicitly if
  it is the receiver, or explicitly done via Object(symbolValue) or
  (new Object(symbolValue).)

* The Symbol.prototype.toString() method no longer throws on Symbol
  wrapper objects (nor Symbol values.) Ditto for Symbol.prototype.valueOf().

* Symbol.prototype.toString() stringifies as "Symbol("<description>"),
  valueOf() returns the wrapper's Symbol value.

* ToPrimitive() over Symbol wrapper objects now throws.

Overall, this provides a stricter separation between Symbol values and
wrapper objects than before, and the explicit fetching out of the
description (nee name) via the "name" property is no longer supported
(by the spec nor the implementation.)

Adjusted existing Symbol test files to fit current, adding some extra
tests for new/changed behavior.

LOG=N
R=arv@chromium.org, rossberg@chromium.org, arv, rossberg
BUG=v8:3053

Review URL: https://codereview.chromium.org/118553003

Patch from Sigbjorn Finne <sigbjornf@opera.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d34254f

Clean up weak objects in optimized code. · db608946

ulan@chromium.org authored Feb 19, 2014

This prepares for weak objects in IC stubs.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/172233003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19489 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db608946

Revert "Second attempt at introducing a premonomorphic state in the call" · 73b679cb

mvstanton@chromium.org authored Feb 19, 2014

This reverts commits r19463 and r19457 (includes MIPS port), there was a
Sunspider perf issue and on reflection we can achieve the necessary
result in a new way.

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/172383003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19488 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73b679cb

Harmony: optimize Math.clz32. · 139134ac

yangguo@chromium.org authored Feb 19, 2014

R=svenpanne@chromium.org
BUG=v8:2938
LOG=N

Review URL: https://codereview.chromium.org/172133003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19487 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

139134ac

Harmony: implement Math.cbrt, Math.expm1 and Math.log1p. · 84cf8559

yangguo@chromium.org authored Feb 19, 2014

BUG=v8:2938
LOG=N
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/163563003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19486 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

84cf8559

Prepare push to trunk. Now working on version 3.25.1. · 76bdb032

machenbach@chromium.org authored Feb 19, 2014

R=danno@chromium.org
TBR=danno@chromium.org

Review URL: https://codereview.chromium.org/170283011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

76bdb032

Retrieve bleeding edge push revision from trunk commit message. · fb0fb8e0

machenbach@chromium.org authored Feb 19, 2014

This is part of moving towards an lkgr-push script and prepares the deprecation of the prepare push commit.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/169843002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fb0fb8e0

Bugfix in check elimination with a regression test. · 1342cb8b

ishell@chromium.org authored Feb 19, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/172173003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19481 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1342cb8b

Fix cornercase in r19475 · 70d0da76

jkummerow@chromium.org authored Feb 19, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/169353003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19480 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70d0da76

ES6: Tighten up Object.prototype.__proto__ · 13d99fe7

rossberg@chromium.org authored Feb 19, 2014

The spec requires that we throw under certain conditions.

BUG=v8:3064
LOG=y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/103853006

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13d99fe7

Refactor persisting state in push and merge scripts. · a56d0da6

machenbach@chromium.org authored Feb 19, 2014

- The backed state dict is now persisted and restored in the step template as a json file
- All explicit persist/restore calls are removed
- Added testing an unexpected script failure + restart with state recovery to the merge-to-branch test
- This CL is not changing external behavior of the scripts

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/170583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a56d0da6

Narrows predicate for type bounds · ae76ce8f

rossberg@chromium.org authored Feb 19, 2014

R=danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/170943005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19476 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae76ce8f

Fix Hydrogen bounds check elimination · 6e3b81a7

jkummerow@chromium.org authored Feb 19, 2014

When combining bounds checks, they must all be moved before the first load/store
that they are guarding.

BUG=chromium:344186
LOG=y
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/172093002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19475 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6e3b81a7

A64: Tidy up Push and Pop TODOs. · 6d9fcf11

jacob.bramley@arm.com authored Feb 19, 2014

This addresses several TODOs:
  - Push and Pop requests can be queued up so that arrays of Registers
    can be pushed efficiently, with just one PrepareForPush/Pop.
  - PushMultipleTimes now takes an Operand. This allows variable-length
    arguments arrays to be initialized, for example.
  - A NoUseRealAbortsScope has been added to Abort so that
    AssertStackConsistency can be called from PrepareForPush without
    introducing infinite recursion.

BUG=
R=rmcilroy@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/170623002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d9fcf11

A64: Remove early_exit unused mechanism in CompareMap. · 78b2a18d

baptiste.afsa@arm.com authored Feb 19, 2014

R=jochen@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/169733003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

78b2a18d

A64: Replace a Cmp/Branch sequence by a conditional compare. · 53f2aefe

baptiste.afsa@arm.com authored Feb 19, 2014

R=jochen@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/169403003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19472 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

53f2aefe

Do not emit receiver map in CheckPrototypes. · cf568ea0

ulan@chromium.org authored Feb 19, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/170613002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf568ea0

Makefile: don't force -Dv8_optimized_debug=0 unnecessarily · 21cb5ca2

jkummerow@chromium.org authored Feb 19, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/170243003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

21cb5ca2

(Pre)Parser: Move ParseExpression and ParseArrayLiteral to ParserBase. · 5b9465c2

marja@chromium.org authored Feb 19, 2014

Notes:
- The functions already did the same thing -> no changes in logic.
- One less glue function needed now.

R=ulan@chromium.org
BUG=v8:3126
LOG=N

Review URL: https://codereview.chromium.org/169853002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5b9465c2

Fix zone_allocator to support comparison · 71be0fdb

jkummerow@chromium.org authored Feb 19, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/171713004

Patch from Daniel Clifford <danno@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71be0fdb

Fast-forward version number on bleeding_edge to 3.25.0 · 06a41fb2

machenbach@chromium.org authored Feb 19, 2014

BUG=
R=danno@chromium.org

Review URL: https://codereview.chromium.org/170843008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06a41fb2

Prepare push to trunk. Now working on version 3.24.41. · 28463385

machenbach@chromium.org authored Feb 19, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/171783002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28463385

18 Feb, 2014 16 commits

MIPS: Second attempt at introducing a premonomorphic state in the call target caches. · d4bcbb70

plind44@gmail.com authored Feb 18, 2014

Port: r19457 (9d8d5f3)

Original commit message:
This time we don't go through the premonomorphic state for
the Array call target caches to avoid losing information from
allocation sites that aren't only used once, but where the
resulting array is used heavily.

Patch from Kasper Lund <kasperl@chromium.org>.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/170903002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d4bcbb70

A64: Fix WrapReceiver corrupting receiver register · 59fdc54a

m.m.capewell@googlemail.com authored Feb 18, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/170433006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19462 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

59fdc54a

A64: Let the Simulator trap BLR XZR instructions. · 1f268f4b

alexandre.rames@arm.com authored Feb 18, 2014

This instruction is used as a guard for the constant pool.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/170673003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1f268f4b

Add filler at the new space top when forcing scavenge. · 58d0682f

jarin@chromium.org authored Feb 18, 2014

We only seem to force scavenge in our cctest test suite, so this is
expected to fix some flakiness in our tests, but it will not
improve stability of v8 itself.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/167423004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

58d0682f

MIPS: Reland "Allow ICs to be generated for own global proxy." · ff0dbe37

plind44@gmail.com authored Feb 18, 2014

Port r19430 (70bb668)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/170343004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff0dbe37

DevTools: Drop kSinTable dependency off the heap profiler ArrayBuffer backing_store test · b4354d6d

alph@chromium.org authored Feb 18, 2014

LOG=N
R=dslomov@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/170253008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4354d6d

Second attempt at introducing a premonomorphic state in the call · 5224c3d0

mvstanton@chromium.org authored Feb 18, 2014

target caches.

This time we don't go through the premonomorphic state for
the Array call target caches to avoid losing information from
allocation sites that aren't only used once, but where the
resulting array is used heavily.

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/169683003

Patch from Kasper Lund <kasperl@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19457 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5224c3d0

A64: Minor code generation improvement: only load the object map if needed. · d54305e1

alexandre.rames@arm.com authored Feb 18, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/170503004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19456 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d54305e1

Load target types and handlers before IC computation. · dafb11f8

ulan@chromium.org authored Feb 18, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/170563002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dafb11f8

Fix compile on Windows · 8bdf7c29

alph@chromium.org authored Feb 18, 2014

TBR=yurys@chromium.org,dslomov@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/170543002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8bdf7c29

Fix merge-to-branch options. · 77c278b9

machenbach@chromium.org authored Feb 18, 2014

BUG=
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/170443003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77c278b9

Fix merge-to-branch python port. · 0f2c040c

machenbach@chromium.org authored Feb 18, 2014

This fixes a forgotten parameter when calling the script's toplevel method and adds the same usage message as in the bash script.

BUG=
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/164373015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f2c040c

Fix compile error. · 901dee8d

alph@chromium.org authored Feb 18, 2014

LOG=N
TBR=yurys@chromium.org,dslomov@chromium.org

Review URL: https://codereview.chromium.org/166193005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

901dee8d

Fix merge-to-branch imports. · f15c7003

machenbach@chromium.org authored Feb 18, 2014

BUG=
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/170513002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f15c7003

A64: Fix compiler warning in r19444. · 3cd96949

jacob.bramley@arm.com authored Feb 18, 2014

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/167463004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19447 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3cd96949

Make merge-to-branch python port executable · 6af4512b

machenbach@chromium.org authored Feb 18, 2014

BUG=
TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/170493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19446 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6af4512b