- 04 Aug, 2017 9 commits
-
-
Clemens Hammacher authored
In order to limit the overall length of error message, limit the output of string provided by the user. This is implemented by a helper class which takes the maximum length as template argument and has simple accessors for the start address and the length of the truncated string. This is the compromise CL after https://chromium-review.googlesource.com/c/566815 and https://chromium-review.googlesource.com/c/594288. R=titzer@chromium.org Bug: chromium:740023, chromium:749041, v8:6634 Change-Id: I7c154eb18b3a6befd5ecabbd2f435b015ad71542 Reviewed-on: https://chromium-review.googlesource.com/600547Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#47157}
-
Michael Starzinger authored
This fixes a missing fast-path check in the code-stub implementation of the {Array.prototype.filter} method. Appending to the target JSArray is only correct if the underlying length did not change. R=jgruber@chromium.org TEST=mjsunit/regress/regress-6657 BUG=v8:6657 Change-Id: Ida8d3511485b649b70d9a4b161742d494ebe4dac Reviewed-on: https://chromium-review.googlesource.com/600467Reviewed-by:Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47156}
-
Ulan Degenbaev authored
Bug: chromium:694255 Change-Id: Id1ae4eb069a4ba79a35f1bb6b2bc2b1c445edb96 Reviewed-on: https://chromium-review.googlesource.com/600969Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47155}
-
Ben L. Titzer authored
Remove the include of frames.h in isolate.h and the include of frames-inl.h from various places, e.g. architecture-specific builtin files. R=yangguo@chromium.org Bug: Change-Id: If8d13188474702fd0b0c298f8e45ef393184b877 Reviewed-on: https://chromium-review.googlesource.com/600212Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
concurrent marker. Bug: chromium:694255 Change-Id: I973ba8df7a4afc5f58ede02f3f6d043cf7038784 Reviewed-on: https://chromium-review.googlesource.com/600970Reviewed-by:
-
Yang Guo authored
R=petermarshall@chromium.org Change-Id: Ie62129f39e1085a94737406dc07b07e359294c4e Reviewed-on: https://chromium-review.googlesource.com/599813Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47152}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6a89d4e..4736539 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/c8c5d6b..a62e07f TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I9b54d11ef4f0d14b098f47d6257403d976faa419 Reviewed-on: https://chromium-review.googlesource.com/601551Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47151}
-
Jakob Kummerow authored
extending existing transition target storage (so both inline storage on the map, and the "target" slots in TransitionArrays are supported). Change-Id: Ib360b9755b8ca5f08bc3a25dd27833f348badaf4 Reviewed-on: https://chromium-review.googlesource.com/584192 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#47150}
-
Tobias Tebbi authored
Bug: Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I2e1b36303f8b9ad4a3dc4e488123e6e4ce8b02ec Reviewed-on: https://chromium-review.googlesource.com/533033 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47149}
-
- 03 Aug, 2017 31 commits
-
-
Deepti Gandluri authored
R=mtrofin@chromium.org Change-Id: I665065b7e1161bcef6315a03083437410c574755 Reviewed-on: https://chromium-review.googlesource.com/601174 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47148}
-
Karl Schimpf authored
This fixes the collection of function sizes (see comment #1 of v8:6361). This was done by adding a wrapper function around VerifyWasmCode() that updates UMA stats for function size (as well as decode time when validating). Bug: v8:6361 Change-Id: Ia2597db22cbed5b0429d9c8514e96cdea5d7323a Reviewed-on: https://chromium-review.googlesource.com/600530 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#47147}
-
Karl Schimpf authored
Collect compile time separately for asm.js and Wasm functions. Note: Dependent on CL https://chromium-review.googlesource.com/c/598542 Bug: v8:6361 Change-Id: I77c43b663cb66261f17bca73db03ab1a4af5e11d Reviewed-on: https://chromium-review.googlesource.com/598930 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
-
Anisha Rohra authored
Port 4b0099a4 R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= LOG=N Change-Id: I4be5357b265ca970a8d1a0db41ddc73ff47bffdc Reviewed-on: https://chromium-review.googlesource.com/600512Reviewed-by:
Jaideep Bajwa <bjaideep@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47145}
-
Ulan Degenbaev authored
This patch removes tracking of - V8.GCIdleTimeAllottedInMS - V8.GCIdleTimeLimit.Overshot - V8.GCIdleTimeLimit.Undershot BUG=chromium:751045 Change-Id: Iccaa0fff609d3caa4cf38ebcc8aca7cdca33c442 Reviewed-on: https://chromium-review.googlesource.com/595588 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Adam Klein authored
Change-Id: Ic9da54513d92736899ce8ad67a5e588011314640 Reviewed-on: https://chromium-review.googlesource.com/600988Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47143}
-
Ulan Degenbaev authored
On advancing the iterator we need to reset the current object, so that it can be lazily reloaded later on. TBR=mlippautz@chromium.org Bug: chromium:694255 Change-Id: If7ddd8670df9d11837f491503312919b55b451fe Reviewed-on: https://chromium-review.googlesource.com/600687 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47142}
-
Ben Smith authored
Make sure to fail PrepareTransfer when the transferables array contains a non-ArrayBuffer, otherwise the function leaks a scheduled_exception. Bug: chromium:736565 Change-Id: I64c2e09eb92720519c7bda2dca41749ff5ac9c8d Reviewed-on: https://chromium-review.googlesource.com/599357 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Andreas Rossberg authored
R=titzer@chromium.org Bug: Change-Id: I2710aa5605bf2a26b6f86db98338dd54b6b87d2a Reviewed-on: https://chromium-review.googlesource.com/600235 Commit-Queue: Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
-
Andreas Rossberg authored
R=titzer@chromium.org Bug: Change-Id: Ib1a13b5131ec1b5a155c893de3c5ceb376bd33a3 Reviewed-on: https://chromium-review.googlesource.com/600227 Commit-Queue: Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
We need to modify that module, e.g. to add signatures to the signature maps. Hence it cannot be const. R=titzer@chromium.org CC=mtrofin@chromium.org Change-Id: I261af5b4233a0b2ec8031a9cbe0cf9f826316ae0 Reviewed-on: https://chromium-review.googlesource.com/600428Reviewed-by:
-
Adam Klein authored
Change-Id: I42f51fd00b1a21a1ff7ef2379fbf81a42266a737 Reviewed-on: https://chromium-review.googlesource.com/599111Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47137}
-
Karl Schimpf authored
This fixes collection of function decoding time (See comment #20 of v8:6361). Updated other path for decoding to also update UMA stat. Bug: v8:6361 Change-Id: I8e6cb398aebd7847e064d3b9a979586ded118513 Reviewed-on: https://chromium-review.googlesource.com/598458 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
R=mstarzinger@chromium.org Bug: Change-Id: Ia416acd8c12a3c8e3fdfabc56a4cd31cb946c88c Reviewed-on: https://chromium-review.googlesource.com/599949 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Miran.Karic authored
An optimization in li checks if a value has all their "n" LSBs set to one, and their "64-n" MSBs set to zero. This is done by checking base::bits::IsPowerOfTwo(value + 1), but this doesn't cover the case when only MSB is zero, and other bits are one. Added another check that covers the missing case, this also fixes Dsubu test. BUG= TEST=cctest/test-assembler-mips/Dsubu Change-Id: I97b8fb4984af3b7f974ba901e3a1a9c89e925805 Reviewed-on: https://chromium-review.googlesource.com/598228Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Commit-Queue: Miran Karić <Miran.Karic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#47134}
-
Andreas Rossberg authored
R=titzer@chromium.org Bug: v8:5815 Change-Id: Ied267a431ed294f022628169e811069f2a4851b1 Reviewed-on: https://chromium-review.googlesource.com/599875 Commit-Queue: Andreas Rossberg <rossberg@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This reverts commit b9acf4ed. Bug: chromium:694255 Change-Id: I62766e8b32cfa16af39a28ad07fecd72441ad8cd Reviewed-on: https://chromium-review.googlesource.com/598468Reviewed-by:
-
Ulan Degenbaev authored
This is a reland of 35c923cc Original change's description: > [heap] Add support for atomic access to page flags. > > This patch renames AsAtomicWord to AsAtomicPointer and > adds new AsAtomicWord that works with intptr_t. > > Slot recording uses atomic page flag accessors. > > BUG=chromium:694255 > > Change-Id: I1c692813244b41320182e9eea50462d1802fcd98 > Reviewed-on: https://chromium-review.googlesource.com/597688 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47086} Bug: chromium:694255 Change-Id: I36780ff4001e068815d4be1e16cd06f1a4f98d13 Reviewed-on: https://chromium-review.googlesource.com/599909Reviewed-by:
-
Maya Lekova authored
This DCHECK is incorrect in no-snapshot builds because we can run garbage collection while deserializing the snapshot. Bug: v8:6559, v8:6557 Change-Id: I0b8456ee19443f796889656952b236ff40b1e2fb Reviewed-on: https://chromium-review.googlesource.com/600367Reviewed-by:
-
Ross McIlroy authored
BUG=v8:5203 Change-Id: I2c4854096bda35fbfb50820e9fb2ece2cb029e55 Reviewed-on: https://chromium-review.googlesource.com/597927Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47129}
-
Andreas Rossberg authored
R=titzer@chromium.org Bug: v8:6647 Change-Id: I73f19111b5c40988d57e9086852da902ba36acb2 Reviewed-on: https://chromium-review.googlesource.com/599872Reviewed-by:
-
Ben L. Titzer authored
R=rossberg@chromium.org Bug: Change-Id: I2401709b42106c7e325144b53be3c3b3d1ed16c7 Reviewed-on: https://chromium-review.googlesource.com/599874Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47127}
-
Michael Lippautz authored
This mitigates the problem of blocking on the main thread when the platform is unable to execute background tasks in a timely manner. Bug: v8:6671 Change-Id: I741d4b7594e8d62721dad32cbfb19551ffacd0c3 Reviewed-on: https://chromium-review.googlesource.com/599528 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Starzinger authored
The predicate in question used to report true on both, Crankshaft and TurboFan code. It has hence become obsolete and can be replaced by the existing {Code::is_turbofanned} predicate. This also frees up a bit in the second kind-specific bit field. R=jarin@chromium.org BUG=v8:6408 Change-Id: I204d7dd78a639c752c9749fd305c7006c6b6aca3 Reviewed-on: https://chromium-review.googlesource.com/599868Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47125}
-
Michael Starzinger authored
R=tebbi@chromium.org Change-Id: I9d22e0731da3e170fe40aa34667ff8948e11bb5c Reviewed-on: https://chromium-review.googlesource.com/595972Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47124}
-
Clemens Hammacher authored
For determining whether unaligned memory accessed is allowed, it is actually sufficient to pass the MachineRepresentation instead of the MachineType. As the MachineRepresentation is an enum, this allows to store the set of unsupported types as an EnumSet instead of std::vector. R=mstarzinger@chromium.org Change-Id: Ibe44717bae3a6034bae683057e80bd40d92e70ae Reviewed-on: https://chromium-review.googlesource.com/598790 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Albert Mingkun Yang authored
Bug: 749486 The feature is off by default, and could be turned on via `v8_enable_csa_write_barrier = true`. With this CL, only x64 uses this feature Change-Id: Ie024f08b7d796a4cc4d55285dc9fe796780f0e53 Reviewed-on: https://chromium-review.googlesource.com/588891Reviewed-by:
-
Tobias Tebbi authored
This is a reland of a6c3f143 Original change's description: > [turbofan] enable new implementation of escape analysis > > Bug: > Change-Id: I0218ab67bf391deb8f1b1b78811643eb84745b7c > Reviewed-on: https://chromium-review.googlesource.com/595508 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47032} Change-Id: Ide3d11f4b25eae2bbcaca9fc3cdb983d73ba846c Reviewed-on: https://chromium-review.googlesource.com/599827Reviewed-by:
-
Clemens Hammacher authored
Currently, EnumSet cannot be used with scoped enums (declared as "enum class" or "enum struct"), as these cannot be implicitly casted to their underlying integral type. This CL changes this by adding a static cast. Plus drive-by fixes. R=mstarzinger@chromium.org Change-Id: I3aa2ef78e896b2734f1e5695237efc8a1130703c Reviewed-on: https://chromium-review.googlesource.com/598789 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Don't hold a pointer to parse_info in compilation_info, and instead explicitly add the fields needed in compiation_info. The intention is to make ParseInfo only actually needed for parsing, and eventually make it possible to compile with only a CompileInfo. BUG=v8:5203 Change-Id: Iecd39245e44c218874401c3991eeaf3ceef2816f Reviewed-on: https://chromium-review.googlesource.com/595738Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47119}
-
Tobias Tebbi authored
Bug: Change-Id: Ifd233c9b592c784d6326d3663c491e5e32e9ddeb Reviewed-on: https://chromium-review.googlesource.com/600047Reviewed-by:
-
