- 30 Jan, 2019 18 commits
-
-
Marja Hölttä authored
This replaces WeakFactory with FinalizationGroup. New API is here: https://weakrefs.netlify.com/ BUG=v8:8179 Change-Id: I8c1c4a70deb42581d17117423dd29d93bdd35cb0 Reviewed-on: https://chromium-review.googlesource.com/c/1435938Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#59204}
-
Ross McIlroy authored
BUG=v8:8751,v8:8752 Change-Id: Ib99d5b9c399d5f2ab616399fdd3c7f190e2d0399 Reviewed-on: https://chromium-review.googlesource.com/c/1445971Reviewed-by:
-
Jakob Gruber authored
This is an initial step towards clarifying the layout of the instruction area. As follow-ups, we should remove additional safepoint and handler table offset parameters, and perhaps alter Code::safepoint_table_offset (handler_table) semantics to always contain a real offset and avoid the magic 0 signifying nonexistent tables. Bug: v8:8758 Change-Id: I9f54629ff3ddad69904b0e1ce2a58e047397aa15 Reviewed-on: https://chromium-review.googlesource.com/c/1434036 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59202}
-
Tamer Tas authored
Procs return the result by increasing recursion through result_for. This CL eliminates that mechanism from the Processor interface and uses boolen return values for sending tests to signal success or the failure to load the test into the execution queue. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174,v8:8731 Change-Id: I073a86ca84bcf88da11132b90013d4c8455bc61e Reviewed-on: https://chromium-review.googlesource.com/c/1439239 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59201}
-
Igor Sheludko authored
Currently, in debug mode the snippets check that the result of decompression equals to the full value stored in the field. Bug: v8:7703 Change-Id: I43d20f15510de57582ee00ca23d676dfd4d06636 Reviewed-on: https://chromium-review.googlesource.com/c/1440049Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#59200}
-
Michael Starzinger authored
This implements preliminary handling of exceptions thrown by external functions that have been imported into the module. Note that handling internal function is still missing, but tests have been added. R=clemensh@chromium.org TEST=cctest/test-run-wasm-exceptions BUG=v8:8091 Change-Id: I9d07739d8b4715a5643114fd7a868cdd8d72efd0 Reviewed-on: https://chromium-review.googlesource.com/c/1445751 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59199}
-
Toon Verwaest authored
Bug: chromium:926819 Change-Id: I44832f8707c413d40e5632ed39b97624059f1fba Reviewed-on: https://chromium-review.googlesource.com/c/1445891Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59198}
-
Camillo Bruni authored
We can directly skip the write barrier in the case we set only a Smi. Change-Id: Ic2f4f13f9edb851a18878bec14981a2ad7687433 Reviewed-on: https://chromium-review.googlesource.com/c/1444957Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#59197}
-
Andreas Haas authored
We extracted the platform-specific API header into separate, platform- specific header files to avoid OS-specific includes in include/v8.h. As the platform-specific headers are only needed on their specific platform, we did not make them available on other platforms in BUILD.gn. Unfortunately, this is not possible, because the `include` validation in `gn gen --check` checks the availability of header files without considering `#ifdef` in the source files. Therefore the check fails on Windows when the POSIX-specific header file is not available. With this CL platform-specific headers will be generally available. This is no problem because they can only be included on their specific platform anyways. R=adamk@chromium.org Bug: chromium:921971 Change-Id: Iee7cc22063ce31a536f937d73799b7217ac1a94e Reviewed-on: https://chromium-review.googlesource.com/c/1443057Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Stephan Herhut authored
This change lands a change to the register allocator. Other than classical linear scan, we now take control flow events into account when deciding spill descisions. The basic idea is to restore the state of a predecessor on entry of a successor. In the case of multiple predecessors, we use heuristics to compute the new state based on the predecessors. The main addition to the machinery is to support unspilling live ranges and to undo live range splitting in certain cases. Currently, disabled behind a flag. Change-Id: I37a70c948be826a90d8b806a52856ad81f475573 Reviewed-on: https://chromium-review.googlesource.com/c/1426129 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Michael Lippautz authored
In future, weak handles will be considered as independent and MarkActive() will not be supported anymore. Users should switch to TracedGlobal, when relying on special cases for using handles with v8::EmbedderHeapTracer. Bug: chromium:923361, v8:8562 Change-Id: Ic6e01a1ab59a25c5fb0aa2ebfb8ddb02e454d72d Reviewed-on: https://chromium-review.googlesource.com/c/1443064 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Maya Lekova authored
Add tests for proper serialization of inlinee targets. Bug: v8:7790 Change-Id: I6bf86de1352f91fddf5f6eba9e889e7d5ac9767c Reviewed-on: https://chromium-review.googlesource.com/c/1443058 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59193}
-
Sigurd Schneider authored
This removes the unnecessary helper GetNumberOfIncomingArguments from several frames. Clients should use ComputeParametersCount instead. Change-Id: I54c261fd6ff0a8a5dc6d1832a0b397429a7ba726 Bug: v8:8757 Reviewed-on: https://chromium-review.googlesource.com/c/1442642Reviewed-by:
-
Frank Tang authored
Bug: v8:8756 Change-Id: Ie0f74f1029bd566924ef6e33a6b0c293489f8234 Reviewed-on: https://chromium-review.googlesource.com/c/1445136Reviewed-by:
-
Leszek Swirski authored
Change-Id: I0895d9b9131a0c06edd3d1359c080b8b6830d236 Reviewed-on: https://chromium-review.googlesource.com/c/1443060Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7a588f4..5d6f467 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/eae881c..1a9772f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9f5b861..b695155 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/0544fee..8e8db13 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic1bcffed12aca1a09f1d4c46aa2eb867da7f0e7a Reviewed-on: https://chromium-review.googlesource.com/c/1445212Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59189}
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org Bug: chromium:922125 Change-Id: Ieaaf3ec8870d74034a7cd7d1d939b3002f2a89c8 Reviewed-on: https://chromium-review.googlesource.com/c/1425202 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The code reads whatever the stack pointer points at, and only later decides whether to use that value for anything. Change-Id: I9930cb046c4fcb3ba0c931058a9c3dd75df482f0 Reviewed-on: https://chromium-review.googlesource.com/c/1443503Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59187}
-
- 29 Jan, 2019 22 commits
-
-
Jakob Kummerow authored
This is a speculative fix for issue 8744. I couldn't get it to repro locally, but the stracktrace from the failing bot run points at TickSample::Init, and according to code comments in that function the value of {regs.sp} can be "arbitrary", so we must read from that address using a method that's robust towards unalignment. Bug: v8:8744 Change-Id: I7a45cc257e0eb557715ec67d9e66e54a6f2c1867 Reviewed-on: https://chromium-review.googlesource.com/c/1440463Reviewed-by: -
tzik authored
-fno-inline is unavailable on clang-cl nor cl.exe, and causes a build failure on Windows bot. This CL updates that flag to "/Ob0", which is msvc-equivalent of -fno-inline. Change-Id: Id9ffed03a855ac0b773ee28625472de664c3cb30 Reviewed-on: https://chromium-review.googlesource.com/c/1442013Reviewed-by:
-
Deepti Gandluri authored
The motivation of this change was originally to preserve is_growable flag over PostMessage in d8. Adding a more general constructor that uses SharedArrayBuffer::Contents. Change-Id: Ib8f6c36d659e91f6cfb6487f56de34fa7e8841a9 Bug: v8:8564 Reviewed-on: https://chromium-review.googlesource.com/c/1383093 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Michael Lippautz authored
TracedGlobal integrates with the use case of EmbedderHeapTracer and replaces regular weak Global or Persistent nodes for such cases. This allows to simplify the case for regular weak handles in a sense that they follow regular weak semantics (if the underlying object is otherwise unreachable the weak handle will be reset). TracedGlobal requires slightly different semantics in the sense that it can be required to keep them alive on Scavenge garbage collections because there's a transitive path that is only known when using the EmbedderHeapTracer. TracedGlobal accomodates that use case. TracedGlobal follows move semantics and can thus be used in regular std containers without wrapping data structure. The internal state uses 20% less memory and allows for only iterating those nodes when necessary. The design trades the virtual call when iterating interesting persistents in the GC prologue with calling out through the EmbedderHeapTracer for each node which is also a virtual call. There is one less iteration over the set of handles required though and the design is robust against recursive GCs that mutate the embedder state during the prologue callback. Bug: chromium:923361 Change-Id: Idbacfbe4723cd12af9de21058a4792e51dc4df74 Reviewed-on: https://chromium-review.googlesource.com/c/1425523 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Sven Sauleau authored
Enables WebAssembly's js-api module/customSection. The specification has been updated; see https://github.com/WebAssembly/spec/issues/915. V8 was already using DOMString. Bug: v8:8633 Change-Id: I4c3e93c21594dbba84b3697e7e85069c3ff8b441 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/1415554 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
Andreas Haas authored
In the trap handler we validate the list of registered code objects every time we register or de-register a new code object. The complexity of this validation is O(num-code-objects * num-instructions). For big WebAssembly modules with several hundred thousand code objects, this validation causes significant overhead (we saw up to 10x) and makes debugging very tedious. With this CL I mark the validation as slow. Thereby it is still enabled in most tests on our bots, but it is possible to disable validation when debugging large web applications. The referenced bug issue was created by developers who had problems with debugging because of this issue. R=mark@chromium.org Bug: v8:8536 Change-Id: If7ecb554eebcb04eb43a1f791b96c7a42a47e60f Reviewed-on: https://chromium-review.googlesource.com/c/1442634Reviewed-by:
-
Z Duong Nguyen-Huu authored
Adding implementation for step 9 which is missing for spec: https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys Update bytecode_expectations as well. Bug v8:6776 Change-Id: Id191f9604e2dc08e71cbcff8ebd5707c233af193 Reviewed-on: https://chromium-review.googlesource.com/c/1419779Reviewed-by:
-
Clemens Hammacher authored
This reverts commit b022e825. Reason for revert: Fails nosnap: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/22761 Original change's description: > [builtins] Verify Isolate compatibility with the embedded blob > > Embedded builtins (= the embedded blob) have a few dependencies on the > snapshot state. For instance, they require that metadata stored on > builtin Code objects as well as the builtins constant table remain > unchanged from mksnapshot-time. Embedders may violate these > assumptions by accident, e.g. by loading a snapshot generated with > different build flags, leading to seemingly unrelated failures later > on. > > This CL introduces an Isolate hash stored in the embedded blob which > hashes relevant parts of builtin Code objects and the builtins > constant table. It's verified in Isolate::Init in debug builds. > > Bug: v8:8723 > Change-Id: Ifc9bdbe6f56ea67d8984f162afa73a3572cfbba8 > Reviewed-on: https://chromium-review.googlesource.com/c/1442641 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59177} TBR=sigurds@chromium.org,jgruber@chromium.org Change-Id: I027ae2585bd06290ea3245b1fc23efba544eb470 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8723 Reviewed-on: https://chromium-review.googlesource.com/c/1443059Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I0576e44aad53f0d2a14526749ec7cc0140a54ab8 Reviewed-on: https://chromium-review.googlesource.com/c/1443052 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Embedded builtins (= the embedded blob) have a few dependencies on the snapshot state. For instance, they require that metadata stored on builtin Code objects as well as the builtins constant table remain unchanged from mksnapshot-time. Embedders may violate these assumptions by accident, e.g. by loading a snapshot generated with different build flags, leading to seemingly unrelated failures later on. This CL introduces an Isolate hash stored in the embedded blob which hashes relevant parts of builtin Code objects and the builtins constant table. It's verified in Isolate::Init in debug builds. Bug: v8:8723 Change-Id: Ifc9bdbe6f56ea67d8984f162afa73a3572cfbba8 Reviewed-on: https://chromium-review.googlesource.com/c/1442641 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: If48109451676b7f028367f8366848a539949c3a8 Reviewed-on: https://chromium-review.googlesource.com/c/1442255 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Registered callbacks should not keep the NativeModule alive. Otherwise, tiering will always run to completion, even if the NativeModule is not being used any more. This change can cause the callback to not be called if the module dies before it finishes top-tier compilation. This is the desired behaviour. R=ahaas@chromium.org CC=titzer@chromium.org, bbudge@chromium.org Bug: v8:8689, chromium:719172 Change-Id: Ide9d639f465497c3ed3439c7ce25c76dceeb97eb Reviewed-on: https://chromium-review.googlesource.com/c/1435937Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59175}
-
Junliang Yan authored
This fixes RunWasmInterpreter_* tests on big endian mips/ppc/s390. Change-Id: I4b9b767d0de45004ee1195ac225c6d1027c17a05 Reviewed-on: https://chromium-review.googlesource.com/c/1439517 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59174}
-
Clemens Hammacher authored
This is not needed generally, and might prevent catching bugs where labels are not bound correctly. Instead, only unuse labels on errors. R=mstarzinger@chromium.org Change-Id: I1dc77ea21ca80c5be801f17ba284908e1c04abe0 Reviewed-on: https://chromium-review.googlesource.com/c/1443051 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
On Liftoff bailout, instead of binding all unbound labels (to avoid triggering DCHECKS in their destructor), just Unuse them. R=mstarzinger@chromium.org Bug: chromium:924843 Change-Id: Icf581bca06eaa7369ab2bbd5d805112289d6a801 Reviewed-on: https://chromium-review.googlesource.com/c/1442645Reviewed-by:
-
Maya Lekova authored
This is a reland of acb60162 Original change's description: > [test] Add testing facility for SerializerForBackgroundCompilation > > R=neis@chromium.org > > Bug: v8:7790 > Change-Id: Id759112d0c780ff857eb094102245b38fcbb1709 > Reviewed-on: https://chromium-review.googlesource.com/c/1434375 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59153} Bug: v8:7790 Change-Id: I1593a768c77c563707b498d47b34a2b1e7fa5dea Reviewed-on: https://chromium-review.googlesource.com/c/1442234 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Andreas Haas authored
In some test-run-wasm-js cctests we want to call wasm code through the js-to-wasm wrapper. This did not work if we wanted to run the wasm code in the interpreter, because we never compiled a WasmInterpreterEntry, and we did not patch the jump table. With this CL we do both now. R=clemensh@chromium.org CC=fgm@chromium.org Change-Id: I49971c5079053ed572928da7eab3e6ea3cb57c25 Reviewed-on: https://chromium-review.googlesource.com/c/1435941 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Daniel Bratell authored
jumbo.gni will check whether use_jumbo_build is set or not and if it's not set it will just check that |jumbo_excluded_sources| lists do not include non-existing files. That means that there is little/nothing to lose by always routing v8_source_set that way, and it adds a bit in build file simplicity and local checking of |jumbo_excluded_sources|. Change-Id: I19ed91d304f4a2edbf10661d20e5f5d3180b3a35 Reviewed-on: https://chromium-review.googlesource.com/c/1430832 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
-
Clemens Hammacher authored
During execution, the tier can be switch from Liftoff to TurboFan. We already handle this in some locations by getting the tier before execution, so that we later know which was the requested tier for that unit. In the case of the --wasm-tier-mask-for-testing flag, this accounting was not right because the tier was already switched in the constructor. This CL changes the compilation units to store both the requested and the executed tier explicitly, so we know which counter to decrement when the unit finishes. R=ahaas@chromium.org Bug: chromium:925671 Change-Id: I673463135e9b3ab17e40cfdfd5d3a526ad5a9b79 Reviewed-on: https://chromium-review.googlesource.com/c/1442639Reviewed-by:
-
Clemens Hammacher authored
There is no linking stage any more, and all the {Link} method did was to set the module to executable. Thus rename the method to reflect that. R=ahaas@chromium.org Bug: v8:8562 Change-Id: Ifc83b5cbbb1377312d7c318e50a0f9d1ede45aa6 Reviewed-on: https://chromium-review.googlesource.com/c/1439237Reviewed-by: -
Andreas Haas authored
This is a followup change for https://crrev.com/c/1437275 to keep the core wasm spec tests in sync with the tests checked out in test/wasm-js/data. R=clemensh@chromium.org Change-Id: I3c78c5db647e9c871b4c64efbc9656acd1266efb Reviewed-on: https://chromium-review.googlesource.com/c/1442638 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Currently, errors somewhere deep in a promise chain are not reported as test failures. We would print the error, but still return with exit status 0. This CL fixes this to treat any uncaught exception as failure, as we already do in {Shell::ExecuteString}. R=yangguo@chromium.org Change-Id: Idc4e58cc0d45f8fca3f7b2c5070ab68d317fc00b Reviewed-on: https://chromium-review.googlesource.com/c/1439378Reviewed-by:
-
