Skip to content

V
V8
Switch branch/tag
  1. 24 Apr, 2017 8 commits
  3. 23 Apr, 2017 1 commit
  5. 22 Apr, 2017 1 commit
  7. 21 Apr, 2017 26 commits
  9. 20 Apr, 2017 4 commits
    • sampsong's avatar
      PPC: Allow share input in ShiftLeftPair and ShiftRightPair · 5204f087
      sampsong authored 
      BUG=
R=jyan@ca.ibm.com, bjaideep@ca.ibm.com, joransiu@ca.ibm.com

Review-Url: https://codereview.chromium.org/2829713003
Cr-Commit-Position: refs/heads/master@{#44759}
      5204f087
    • Eric Holk's avatar
      Restrict range for int64_t to immediate conversions · ec772a4f
      Eric Holk authored 
      The included test case illustrates the problem. It subtracts (16 << 27)
from another number. The Machine Operator Reducer would replace the
shift computation with 0x0000000080000000, and then change the subtract
to an add of -(0x0000000080000000), which is 0xffffffff80000000.
The instruction selector would determine that this value could be an
immediate, because it fits in 32 bits, so it would select the lea
instruction. Finally, the code generator would detect that the
immediate was less than 0, flip the sign and replace the add with a
subtract of 0x80000000. Because the x64 subtract instruction's
immediate field is 32 bits, the processor would interpret this as
0xffffffff80000000 instead of an unsigned value.

This change fixes the issue by making the CanBeImmediate check
explicitly compare against INT_MIN and INT_MAX. We disallow INT_MIN
as an immediate precisely because we cannot tell 0x0000000080000000
from 0xffffffff80000000 when truncated to 32 bits.

Bug: chromium:711203
Change-Id: Ie371b8ea290684a6bb723bae9c693a866f961850
Reviewed-on: https://chromium-review.googlesource.com/482448
Commit-Queue: Eric Holk <eholk@chromium.org>
Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44758}
      ec772a4f
    • Adam Klein's avatar
      Remove Accessors::FunctionSetPrototype · de9daff0
      Adam Klein authored 
      It was a straight pass-through to JSFunction::SetPrototype, with the
added wrinkle that it appeared to sometimes throw (although it never did).

Also improves typing of JSFunction::SetInstancePrototype signature to
require being passed a JSReceiver.

Change-Id: Ie85b9a74955f72bf988cd902c5eec34e32b51a24
Reviewed-on: https://chromium-review.googlesource.com/482421Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarBrad Nelson <bradnelson@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44757}
      de9daff0
    • jkummerow's avatar
      [gm.py] Add support for building mkgrokdump · 0cbe6454
      jkummerow authored 
      Now you can do: "gm.py x64.release mkgrokdump"

NOTRY=true

Review-Url: https://codereview.chromium.org/2827383003
Cr-Commit-Position: refs/heads/master@{#44756}
      0cbe6454