- 03 Nov, 2021 20 commits
-
-
Junliang Yan authored
Change-Id: Ie46687a1af834b9c1a6c8fa5bcf5badb61cc1647 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259645Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77686}
-
Thibaud Michaud authored
We only expect the "wasm_exception_values_symbol" property to be a fixed array if the property actually exists. If the property is not found, JSReceiver::GetProperty returns "undefined", so skip the check in this case. R=clemensb@chromium.org Bug: chromium:1262582 Change-Id: I28d7891064bdd7632ff1a4c94ba021163401fd88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3244416 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77685}
-
Al Muthanna Athamina authored
Bug: v8:12185 No-Try: true Change-Id: Ib8296171d8101594949deddbf0a7c2a24ee5c7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257717 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77684}
-
Jakob Kummerow authored
If index > JSObject::kMaxElementIndex, we have to perform a prototype chain lookup for a named property. The corresponding check was missing for string receivers. Fixed: chromium:1265043 Change-Id: Ibccd058a4bd108eeee235762bea0bc4163aaa0b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257704 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77683}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Iffebca251d18d5637884b2181acdfb3e6c5496a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257715Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77682}
-
Jakob Gruber authored
Happy hunting. Bug: chromium:1262676 Change-Id: I0f3a5519cb9ed3dc4787acd61cb437ee8c2bf2d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257716 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77681}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Ib0997ca8cedaf1065fc6803d5297c30621b49949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257714Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77680}
-
Georgia Kouveli authored
`UseScratchRegisterScope` should be used in a block scope, to avoid keeping the scratch register in use for longer than it's needed. Spotted when experimenting with the `v8_enable_heap_sandbox` and `v8_enable_external_code_space` flags. Change-Id: I34330f3e4dbd114aa75efb0ebdcf557f0bd45f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256997Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/main@{#77679}
-
Igor Sheludko authored
In order to avoid some of the unnecessary Code <-> CodeDataContainer conversions in builtins we need to be able to embed CodeDataContainer references to builtins. This CL makes it possible by introducing a table of builtins' CDCs. Eventually, usages of the builtins table containing Code objects will be replaced by usages of this table. Bug: v8:11880 Change-Id: Iffffd1507d5c7b38af34c42071a4577a8d18e8eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257710Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77678}
-
Manos Koukoutos authored
The runtime function 'WasmIsValidRefValue' can be called from C-API and JS wrappers and needs to be passed an instance. Therefore, we always have to define an instance node, even when it is just undefined. See also https://chromium-review.googlesource.com/c/v8/v8/+/3236719. Bug: v8:11510, chromium:1266080 Change-Id: Ib9712fe3a3880db8656ee4882bec0ae7635cc60f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257708Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77677}
-
Leszek Swirski authored
This is a reland of 35a6eeec Reland fixes: * Add a SharedFunctionInfo::CopyFrom to encapsulate updating the SFI from the placeholder. This now includes copying scope_info (which wasn't included in the original CL and caused some of the issues) * Make sure that LocalHandleScope is initialised only inside of UnparkedScope (fixed TSAN issues) * Clean-up: Don't add `script_` to ParseInfo, but instead pass it separately to Parser. Eventually we'd ideally get rid of ParseInfo entirely (splitting it into input and output) so let's not add more fields to it. Reverts changing CreateScript to InitializeScript. Original change's description: > [off-thread] Allow off-thread top-level IIFE finalization > > Allow off-thread finalization for parallel compile tasks (i.e. for top- > level IIFEs). > > This allows us to merge the code paths in BackgroundCompileTask, and > re-enable the compiler dispatcher tests under the off-thread > finalization flag. Indeed, we can simplify further and get rid of that > flag entirely (it has been on-by-default for several releases now). > > Change-Id: I54f361997d651667fa813ec09790a6aab4d26774 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226780 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77615} Change-Id: If1a5b14900aa6753561e34e972a293be0be9a07d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256692 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77676}
-
Yang Guo authored
Change-Id: I5c8452a0fb5512a007f9b892c81711a30f65344c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257707 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77675}
-
Jakob Gruber authored
.. as a custom data structure with questionable value. Also: a few drive-by refactors. Change-Id: I74957b70c4357795dc46ef5520d58b6a78be31b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240823 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77674}
-
Jakob Gruber authored
Unfortunately, CharacterRanges may use 0x10ffff as a marker value signifying 'highest possible code unit' irrespective of whether the regexp instance has the unicode flag or not. This value makes it through RegExpCharacterClass::ToNode unmodified (since no surrogate desugaring takes place without /u). Correctly mask out the 0xffff value for purposes of building our uint16_t range array. Note: It'd be better to never introduce 0x10ffff in the first place, but given the irregexp pipeline's lack of hackability I hesitate to change this - we are sure to rely on it implicitly in other spots. Drive-by: Refactors. Fixed: chromium:1264508 Bug: v8:11069 Change-Id: Ib3c5780e91f682f1a6d15f26eb4cf03636d93c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256549 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/main@{#77673}
-
Dominik Inführ authored
It is easy to miss that a LocalHandleScope can only be created when the current thread is in the running state and not parked. Add a DCHECK for this, such that we don't need to rely on TSAN for finding such issues. Bug: v8:12357 Change-Id: I1f2f9b1fdf05814009f2edccf192afbb1caf6baf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257705 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77672}
-
Yang Guo authored
NewJSObjectWithNullProto has use cases outside of the debugger. We previously changed it to create dictionary mode objects, which affects the performance of non-debugger use cases. This change partially reverts that change by differentiating between use cases. Fixed: chromium:1266160 Change-Id: I875073bdc062cf187ef24da62324f743169d2e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257706 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77671}
-
Dominik Inführ authored
With LocalHeaps multiple threads may now access the heap. We now need to bring background threads to a safepoint and make all LABs iterable in order to be able to safely iterate the heap. Bug: v8:12338 Change-Id: Ia39f3bf7ac13ba405c86ee2f0048c600ce36c2d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256690Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77670}
-
Zhao Jiazhong authored
Port commit 4de20cb1 Change-Id: I753c9e02b517d73caf12e12104196f1a5b82847c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258452 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Liu yu <liuyu@loongson.cn> Commit-Queue: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77669}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1eb779c..cf32591 Rolling v8/third_party/android_ndk: https://chromium.googlesource.com/android_ndk/+log/9644104..401019b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2c76b34..75c4ea8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/aebf624..57c928c TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ib09b9883a06199b1e00e4fb6fa3a03f23a2f55a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257209Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77668}
-
Lu Yahan authored
Port 4de20cb1 Change-Id: I8801bbcf9647c1abcb9cc5fb41720009e002d153 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257964 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77667}
-
- 02 Nov, 2021 20 commits
-
-
Milad Fa authored
This CL makes sure the offset is calculated correctly to be the return address from a C Function. Checking the size of generated code is also fixed to take into account the extra instruction we have from LoadPC. Change-Id: I585c11efbe4342bc5a0d3068683b54cb563a3bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257206Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77666}
-
Michael Lippautz authored
- Fix definition and declaration of noexcept methods not matching - Disable test using deprecated APIs. Only having clang coverage is okay here. Change-Id: I412d0b0087b2858fb72b0365b94b82ebc13462de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256693 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77665}
-
Joyee Cheung authored
This improves the performance of initializing instances with private methods by 5-6x and makes it on par with initializing instances with only public methods. Drive-by: remove the obsolete AddPrivateField runtime function along with the AddPrivateBrand function. Bug: v8:10793, v8:12355 Change-Id: Ic0896adb2102db7790f955fecbdd22f61ab2e7ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256999 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77664}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Iee80a34255a9c8ee5000719340a475331ab82942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3254004Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77663}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I5890c4a95da6ea8098a0f7d8a90f503a89704d45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3254003Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77662}
-
Scott Violet authored
I'm in the process of evaluating impact of v8 snapshot and would like to understand the amount of time spend decompressing. BUG=chromium:1257321 TEST=none Change-Id: I122a2151e48f61db3352da56763e3e66f7415efe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256006 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77661}
-
Leszek Swirski authored
This reverts commit 12e0978d. Reason for revert: Issues should be fixed by https://crrev.com/c/3123420 Original change's description: > Skip code flushing tests failing on NumFuzz bots > > Bug: v8:12088 > Change-Id: Ibc4db95125d44eca110829f1c043e769de5bd349 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123416 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Auto-Submit: Mythri Alle <mythria@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76527} Bug: v8:12088 Change-Id: I5fcf0f149028d34ade3aa5aabc2e8de73631cac2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256551Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77660}
-
Maria Tîmbur authored
Add support for non-nullable reference types. Refactor the GetValueType function. Emit a meaningful initializer for every ref type in globals instead of an empty one. Avoid the non-nullable recursive type by only allowing indices that are strictly less than the current index. Bug: v8:11954 Change-Id: Id1a405525080de7eb9dbbd4f2b8aea5f05684665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251171 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77659}
-
Tobias Tebbi authored
Explicitly specify the enum base type for Flags enums generated from Torque bitfield structs. Before, this was implicitly a signed integer type. This caused a recent gcc compile issue with signed and unsigned comparisons triggered by https://chromium-review.googlesource.com/c/v8/v8/+/3251177 Bug: v8:7793 Change-Id: Iceb3c8632cfc95766b5e6ce7fae47cf5d002b9f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3253358 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77658}
-
Thibaud Michaud authored
Apply a "modulo" (i32.rem_s) operator to the array size before allocating the array. The unbounded array allocations frequently lead to out-of-memory crashes in the fuzzer. R=manoskouk@chromium.org Bug: chromium:1238063, chromium:1258319 Change-Id: Ie344f783323294c711d75b6e004ff2dca4da5923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256548 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77657}
-
Tim van der Lippe authored
The upgrade to Clang pulled in a change that renamed `ProcessCompileDatabaseIfNeeded` (https://chromium-review.googlesource.com/c/chromium/src/+/3237169). In a similar fashion to https://chromium-review.googlesource.com/c/chromium/src/+/3253247 we should use an empty array as well. R=jkummerow@chromium.org Bug: none Change-Id: I056af8fc7969b7c5a31631a65c18743c48ff84be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256550 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77656}
-
Michael Lippautz authored
Bug: v8:12165 Change-Id: If1e30400363229048a47ea91d6ec86d2df35d8aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257545 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77655}
-
Victor Gomes authored
Data race access to chunk_map_. The main thread can read the map while the background thread (concurrent SP compiler) adds a new page to the map. Bug: v8:12054 Change-Id: Ie7c596f3d3aeb4dca9cc6f41ed16f39dcafc7871 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256547 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77654}
-
acho01 authored
Currently it is not possible to run samples on arm architecture I faced the issue on Macbook Pro M1 Running sample codes is crucial for getting started with the project R=tandrii@chromium.org Bug: None Change-Id: Ie3ed52e68d1f7193217110d43545971c714202c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251026Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77653}
-
Jakob Kummerow authored
When a Promise-Reject handler throws an unhandled exception, we should use that promise's context for reporting the exception to the runtime. This avoids a null-pointer deref. Fixed: chromium:1263994 Change-Id: I3792a1884af4a83991249d612caf15588ea77dad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3250912 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77652}
-
Maya Lekova authored
This CL adds a minor change to the arm/arm64 simulators to support up to 20 arguments in a C function call. This change is necessary for an upcoming CL which adds float support to the simulator and tests with more than 20 arguments, see https://chromium-review.googlesource.com/c/v8/v8/+/3060486 Bug: chromium:1052746 Change-Id: I60ae603c96554525d28f1cd248d7766f86c9cc3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256785 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77651}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Icefaa3f1090f9b41dc7837e3a95bbfd633703757 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251179Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77650}
-
Yang Guo authored
When materializing a scope object, we previously assumed that we will not have any name collisions. This is not correct e.g. when eval introduces an aliased local variable. This CL resolves this wrong assumption. The test case should not crash. It however fails as there is a bug in how debug-evaluate should resolve variables defined in eval. R=verwaest@chromium.org Fixed: chromium:1240962 Bug: chromium:1264852 Change-Id: I0e41e7905589735e25eff221376d09997ea99117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3250911 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77649}
-
Michael Achenbach authored
This reverts commit ca753bca. Reason for revert: Need another whitespace change. Original change's description: > Whitespace change to test alerts > > No-Try: true > Change-Id: I0f6211c6fc3990051ea6c50c815cc1fcc9f4643e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256787 > Auto-Submit: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77643} Change-Id: I81399910d7fa4d61e9459f85001e1563acba2a4c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256546 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77648}
-
Milad Fa authored
After https://crrev.com/c/3247035 compilation with gcc may fail with the following error: ``` error: comparison between 'enum v8::internal:: compiler::BitsetType::<unnamed>' and 'enum v8::internal:: TurbofanTypeBits::Flag' ``` Change-Id: I5edf28e335483be66ae46e4359e0a4dc83341adf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3255303Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77647}
-