1. 12 Jul, 2017 3 commits
    • Camillo Bruni's avatar
      Reland "[mjsunit] Improve mjsunit stracktrace readability" · 34874b3b
      Camillo Bruni authored
      This is a reland of f720d024
      Original change's description:
      > [mjsunit] Improve mjsunit stracktrace readability
      > 
      > Format the function name and file-position into proper columns to easily spot
      > where the test code ends and the mjsunit framework code starts.
      > 
      > BEFORE:
      > Stack: Error
      >     at new MjsUnitAssertionError (test/mjsunit/mjsunit.js:36:18)
      >     at failWithMessage (test/mjsunit/mjsunit.js:310:11)
      >     at fail (test/mjsunit/mjsunit.js:327:12)
      >     at assertEquals (test/mjsunit/mjsunit.js:398:7)
      >     at closure (test/mjsunit/regress/regress-4121.js:20:7)
      >     at literals_sharing_test (test/mjsunit/regress/regress-4121.js:27:3)
      >     at test (test/mjsunit/regress/regress-4121.js:37:5)
      >     at eval (eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6), <anonymous>:1:1)
      >     at test/mjsunit/regress/regress-4121.js:49:6
      >     at Array.forEach.call (test/mjsunit/regress/regress-4121.js:50:7)
      >     throw new MjsUnitAssertionError(message);
      > 
      > AFTER:
      > Stack: MjsUnitAssertionError
      >     at assertEquals          test/mjsunit/mjsunit.js 398:7
      >     at closure               test/mjsunit/regress/regress-4121.js 20:7
      >     at literals_sharing_test test/mjsunit/regress/regress-4121.js 27:3
      >     at test                  test/mjsunit/regress/regress-4121.js 37:5
      >     at eval                  eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6)
      >     at                       test/mjsunit/regress/regress-4121.js 49:6
      >     at Array.forEach.call    test/mjsunit/regress/regress-4121.js 50:7
      >     throw new MjsUnitAssertionError(message);
      > 
      > 
      > Change-Id: Iad3460a648e26effb43c00426ab043743ee6a138
      > Reviewed-on: https://chromium-review.googlesource.com/563627
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46589}
      
      Change-Id: I44bf07f7be4114369315605542cafd17345b4397
      Reviewed-on: https://chromium-review.googlesource.com/567063Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46602}
      34874b3b
    • Georg Neis's avatar
      Revert "[mjsunit] Improve mjsunit stracktrace readability" · c86ad81b
      Georg Neis authored
      This reverts commit f720d024.
      
      Reason for revert: Bot failure at
      https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20custom%20snapshot%20-%20debug/builds/15690
      
      Original change's description:
      > [mjsunit] Improve mjsunit stracktrace readability
      > 
      > Format the function name and file-position into proper columns to easily spot
      > where the test code ends and the mjsunit framework code starts.
      > 
      > BEFORE:
      > Stack: Error
      >     at new MjsUnitAssertionError (test/mjsunit/mjsunit.js:36:18)
      >     at failWithMessage (test/mjsunit/mjsunit.js:310:11)
      >     at fail (test/mjsunit/mjsunit.js:327:12)
      >     at assertEquals (test/mjsunit/mjsunit.js:398:7)
      >     at closure (test/mjsunit/regress/regress-4121.js:20:7)
      >     at literals_sharing_test (test/mjsunit/regress/regress-4121.js:27:3)
      >     at test (test/mjsunit/regress/regress-4121.js:37:5)
      >     at eval (eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6), <anonymous>:1:1)
      >     at test/mjsunit/regress/regress-4121.js:49:6
      >     at Array.forEach.call (test/mjsunit/regress/regress-4121.js:50:7)
      >     throw new MjsUnitAssertionError(message);
      > 
      > AFTER:
      > Stack: MjsUnitAssertionError
      >     at assertEquals          test/mjsunit/mjsunit.js 398:7
      >     at closure               test/mjsunit/regress/regress-4121.js 20:7
      >     at literals_sharing_test test/mjsunit/regress/regress-4121.js 27:3
      >     at test                  test/mjsunit/regress/regress-4121.js 37:5
      >     at eval                  eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6)
      >     at                       test/mjsunit/regress/regress-4121.js 49:6
      >     at Array.forEach.call    test/mjsunit/regress/regress-4121.js 50:7
      >     throw new MjsUnitAssertionError(message);
      > 
      > 
      > Change-Id: Iad3460a648e26effb43c00426ab043743ee6a138
      > Reviewed-on: https://chromium-review.googlesource.com/563627
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Igor Sheludko <ishell@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46589}
      
      TBR=machenbach@chromium.org,cbruni@chromium.org,ishell@chromium.org
      
      Change-Id: I631cec7f318637ce2f60500e2bf0ab7fe1f6d09e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/567062Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Commit-Queue: Georg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46592}
      c86ad81b
    • Camillo Bruni's avatar
      [mjsunit] Improve mjsunit stracktrace readability · f720d024
      Camillo Bruni authored
      Format the function name and file-position into proper columns to easily spot
      where the test code ends and the mjsunit framework code starts.
      
      BEFORE:
      Stack: Error
          at new MjsUnitAssertionError (test/mjsunit/mjsunit.js:36:18)
          at failWithMessage (test/mjsunit/mjsunit.js:310:11)
          at fail (test/mjsunit/mjsunit.js:327:12)
          at assertEquals (test/mjsunit/mjsunit.js:398:7)
          at closure (test/mjsunit/regress/regress-4121.js:20:7)
          at literals_sharing_test (test/mjsunit/regress/regress-4121.js:27:3)
          at test (test/mjsunit/regress/regress-4121.js:37:5)
          at eval (eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6), <anonymous>:1:1)
          at test/mjsunit/regress/regress-4121.js:49:6
          at Array.forEach.call (test/mjsunit/regress/regress-4121.js:50:7)
          throw new MjsUnitAssertionError(message);
      
      AFTER:
      Stack: MjsUnitAssertionError
          at assertEquals          test/mjsunit/mjsunit.js 398:7
          at closure               test/mjsunit/regress/regress-4121.js 20:7
          at literals_sharing_test test/mjsunit/regress/regress-4121.js 27:3
          at test                  test/mjsunit/regress/regress-4121.js 37:5
          at eval                  eval at <anonymous> (test/mjsunit/regress/regress-4121.js:49:6)
          at                       test/mjsunit/regress/regress-4121.js 49:6
          at Array.forEach.call    test/mjsunit/regress/regress-4121.js 50:7
          throw new MjsUnitAssertionError(message);
      
      
      Change-Id: Iad3460a648e26effb43c00426ab043743ee6a138
      Reviewed-on: https://chromium-review.googlesource.com/563627Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46589}
      f720d024