- 30 Jul, 2021 5 commits
-
-
Lu Yahan authored
-- 3059689: [baseline] Fallback to handle references on heap compilation | https://chromium-review.googlesource.com/c/v8/v8/+/3059689 Change-Id: Ie055e181e5081d7acb2195ae41abaecdd0f68989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062030 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#76014}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: Id06775f9f3c7f1a505a736fcc4b992feb0d09308 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056454 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#76013}
-
Georg Neis authored
Traces calls to Heap::IsAllocationPending that return true. This is useful when debugging concurrent Turbofan. Bug: v8:7790 Change-Id: If10e6f40c3bf03c768ad8b74403007fe86f860fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060488Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76012}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/ab74ae5..1067dfc Remove dead code from PredictNumItersNeeded (#1206) (Braedy) https://chromium.googlesource.com/external/github.com/google/benchmark/+/1067dfc TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I4c52fee681f648ea2f1fbfc253e276a824de7011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#76011}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/82f37a4..8aa210e Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/4ec4cd2..2d924d7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/30a89ee..d0097bc Rolling v8/tools/luci-go: git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422..git_revision:59603935354589d60cd8374e75889932bf84c33f Rolling v8/tools/luci-go: git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422..git_revision:59603935354589d60cd8374e75889932bf84c33f Rolling v8/tools/luci-go: git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422..git_revision:59603935354589d60cd8374e75889932bf84c33f TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1f2a40e39fdfc524bb0bd0ad4d007b564944286a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062202Reviewed-by:
-
- 29 Jul, 2021 35 commits
-
-
Milad Fa authored
mtvsrdd uses 2 gprs as input. Change-Id: I4446a51bda1196ce262e3a90ed7c840da89c9d16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3061478Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76009}
-
Milad Fa authored
Cl also optimizes the usage on Power9 by using mtvsrdd. Change-Id: Ibd6b227111adc0c262c621be6ce4068d3de2e659 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060493Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76008}
-
legendecas authored
This proposal reached Stage 3 at the July 2021 TC39. https://github.com/tc39/proposal-array-find-from-last Bug: v8:11990 Change-Id: I1364b46b7ed4bc56e4b3024d14bde799f9878b5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3037160 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#76007}
-
Junliang Yan authored
Change-Id: I8d33239180b04afd322c99988dcf6aea0c928797 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060495Reviewed-by:
-
Junliang Yan authored
Change-Id: I4a11a5409922550119a3d8cafd254c4f8dd798e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060494Reviewed-by:
-
Milad Fa authored
Port 642a4673 Original Commit Message: If a GC happens between Code object allocation and Code finalization, we might have invalid embedded object references. We fallback and patch the refernces back to handles, then unbox the handles and relocate. R=victorgomes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I680cc33fa9d06d7a00cc52c142599bb5536a9b88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060487Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76004}
-
Mythri A authored
Introduce a flush_baseline_code flag to control if baseline code is flushed or not. Currently flush_baseline_code implies flush_bytecode as well. So if flush_baseline_code is enabled both bytecode and baseline code are flushed. If the flag is disabled we only flush bytecode and not baseline code. In a follow-up CL we will add support to control baseline and bytecode flushing independently i.e. we can flush only bytecode / only baseline code / both. Bug: v8:11947 Change-Id: I5a90ed38469de64ed1d736d1eaaeabc2985f0783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059684 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76003}
-
legendecas authored
Each time a constructor is being called without new operator, a TypeError is thrown. The TypeError should be the realm's one according to 10.2.1.5.b. Refs: https://tc39.es/ecma262/#sec-ecmascript-function-objects-call-thisargument-argumentslist Refs: https://github.com/tc39/ecma262/pull/2216 Bug: v8:11530 Change-Id: Iff10a78e96fb547fe2062c86b9f93a30d2a8be20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056830Reviewed-by:
-
Marja Hölttä authored
This CL assumes https://github.com/tc39/proposal-resizablearraybuffer/issues/68 is indeed a spec bug. Bug: v8:11111 Change-Id: I8d24f0d07f7ab40ba01b8c422868ad189d6f7e5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060478 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76001}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I52eb7e458fc614e3f5e936fb1761680a5cdeadb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056983Reviewed-by:
-
Junliang Yan authored
Change-Id: I0420b3cd9c940dbf684c0aa1478172921423c724 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060483Reviewed-by:
-
Clemens Backes authored
When calling the {Isolate::StackOverflow} method, we should not have overflown the stack limit by too much. Otherwise there might not be enough space on the stack for handling the stack overflow exception. This DCHECK would have failed before landing https://crrev.com/c/3059074 and https://crrev.com/c/3059075. If it fails, we might need to add more special stack checks also in other places. Such failures should not be considered security issues per se, but we should try to fix them to avoid potential issues. R=jkummerow@chromium.org CC=ahaas@chromium.org Bug: v8:12017 Change-Id: I25e42a20d3fcc981c266ae998f52b3f090237297 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059076Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit bce81d6b. Reason for revert: Newly introduced test is flaking, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20ASAN/41030/overview or https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/43171/overview Original change's description: > [wasm] Support partial serialization of modules > > At the moment a WebAssembly module can be serialized successfully when > all functions were compiled with TurboFan. However, for some functions > it may not be necessary to be compiled with TurboFan, e.g. for functions > where Liftoff code is as good as TurboFan code. > > With this CL we allow WebAssembly modules to get serialized even when > not all functions are compiled with TurboFan. Missing functions are > marked as missing in the serlialization. Upon deserialization, missing > functions either get compiled by Liftoff, or initialized with a > lazy-compilation stub, depending on the V8 configuration. > > Bug: v8:11862 > Change-Id: Ic833a17639bf841c5def6fe3c35173fe0376c246 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960209 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75987} Bug: v8:11862 Change-Id: I5445c097ec47f407e5f951d4cf6d2168113f80e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060484 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75997}
-
Victor Gomes authored
If a GC happens between Code object allocation and Code finalization, we might have invalid embedded object references. We fallback and patch the refernces back to handles, then unbox the handles and relocate. Bug: v8:11872 Change-Id: I3a7b050c20179c1708eef343ec8266441ab5dca1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059689 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Clemens Backes authored
This adds a code comment before the OOL code for the special stack check for a large frame. Otherwise it is hard to see where it begins in the code, and it might be unexpected to see that block of code at the end of a Liftoff function. Drive-by: Replace another "out of line: " comment by "OOL: ", which is typically understood equally well. R=ahaas@chromium.org Bug: v8:12017 Change-Id: Ie8b243cedebe979ca46e0515a9fdd0695ab58304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059081Reviewed-by:
-
Thibaud Michaud authored
The JS API constructor was renamed to "WebAssembly.Tag" to match the spec: https://github.com/WebAssembly/exception-handling/issues/159 Rename "exception" to "tag" throughout the codebase for consistency with the JS API, and to match the spec terminology (e.g. "tag section"). R=clemensb@chromium.org,nicohartmann@chromium.org Bug: v8:11992 Change-Id: I63f9f3101abfeefd49117461bd59c594ca5dab70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3053583Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75994}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ib3ae55349024ebeab9ceaf9472a6de2b4d86ce55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056975Reviewed-by:
-
Jakob Gruber authored
Clearing cached PropertyAccessInfos is used for stress-testing. Note all this will soon be removed. Bug: v8:7790,chromium:1234288 Change-Id: I4576563375b65830296cad295342823700d13b3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059696 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75992}
-
Clemens Backes authored
Add an explicit check for the available stack space before allocating a large frame. Even though this typically does not cause problems on ia32, we should do it to be consistent with other platforms and with TurboFan code. This follows the same structure as on x64: https://crrev.com/c/3059074 A follow-up CL will add a DCHECK to verify that we never overflow the stack space by more than 4KB (https://crrev.com/c/3059076). R=ahaas@chromium.org Bug: v8:12017 Change-Id: Ifffe56f29feae14545e6f70e30a1c94c5eabad6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059075Reviewed-by:
-
Clemens Backes authored
Add an explicit check for the available stack space before allocating a large frame. Even though this typically does not cause problems on x64, we should do it to be consistent with other platforms and with TurboFan code. After also fixing ia32 (https://crrev.com/c/3059075), we can add a DCHECK to verify that we never overflow the stack space by more than 4KB (https://crrev.com/c/3059076). R=ahaas@chromium.org Bug: v8:12017 Change-Id: I4f407dc6a83d4a71636066777706f23d05002111 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059074Reviewed-by:
-
Clemens Backes authored
The comment is a left-over of the state before https://crrev.com/c/3055302. It should have been removed as part of that CL. R=ahaas@chromium.org Bug: v8:12017 Change-Id: Ic5234b230b3eda30e9a4a346e8c3b83c813a5dbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059078Reviewed-by:
-
Marja Hölttä authored
This will change the behavior of %TypedArray%.prototype.fill. Bug: v8:11111 Change-Id: I66e7d3decf07663a6497c3c86374b3c77ab6a682 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056977Reviewed-by:
-
Andreas Haas authored
At the moment a WebAssembly module can be serialized successfully when all functions were compiled with TurboFan. However, for some functions it may not be necessary to be compiled with TurboFan, e.g. for functions where Liftoff code is as good as TurboFan code. With this CL we allow WebAssembly modules to get serialized even when not all functions are compiled with TurboFan. Missing functions are marked as missing in the serlialization. Upon deserialization, missing functions either get compiled by Liftoff, or initialized with a lazy-compilation stub, depending on the V8 configuration. Bug: v8:11862 Change-Id: Ic833a17639bf841c5def6fe3c35173fe0376c246 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960209 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75987}
-
Omer Katz authored
Cppgc reports used bytes statistics to CppHeap. CppHeap should forward the stats to v8. However, if we are not allowed to trigger a GC, CppHeap will cache the stats until the reporting. On GC finalization, CppHeap resets v8's counters to the current marked bytes counter. If the last reported stats before GC finalization are cached, CppHeap doesn't clear the cache on GC finalization. On the next stats reporting, CppHeap will report the cached values. If the cache is a decrease that is larger than the current marked bytes, a DCHECK in LocalEmbedderHeapTracer::DecreaseAllocatedSize will fail. Bug: chromium:1056170 Change-Id: I47933abc3e5f5c4a91454e0ec03adde5cf61d8fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056970 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Make sure we use fast prechecks in the header files - MicrotaskQueue::CallEnqueueMicrotask returns a Smi instead of a more costly undefined value (the return value is enforced by the calling convention, but unused) - Merge FireMicrotasksCompletedCallback into OnComplete Change-Id: I3797b946bcffb6349e5693c41478bd2bad1f93fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024154 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Clemens Backes authored
This fixes the youcompleteme config script to look for ninja_output.py in tools/vim instead of tools/ninja (it was moved there in https://crrev.com/c/2797536), and makes a minor adjustment for python3 compatibility. R=machenbach@chromium.org Bug: v8:11879 Change-Id: Ia825903fb6019865244c5529bf2d23935a10ad5e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059077Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75984}
-
Camillo Bruni authored
If v8_enable_runtime_call_stats == false, we don't need TracingFlags::is_runtime_stats_enabled and can save a bit of code and needless overhead. Bug: v8:11299 Change-Id: Ia5ec51c29b2408b77b65984c5bba0ae16e0de243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024155Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75983}
-
Leszek Swirski authored
This is a reland of 14941067 which is a reland of 0f79565b which is a reland of 85e6c4b6 The _other_ gc-stress issue should be now be fixed with https://crrev.com/c/3059072. Relanding without changes. TBR=verwaest@chromium.org Original change's description: > Reland^2 "[sparkplug] Enable sparkplug by default on desktop" > > This is a reland of 0f79565b > which is a reland of 85e6c4b6 > GC-stress issue was still flushing, now fixed for real with > https://crrev.com/c/3054117. > > Relanding without changes. > > TBR=verwaest@chromium.org > > Original change's description: > > Reland "[sparkplug] Enable sparkplug by default on desktop" > > > > This is a reland of 85e6c4b6 > > GC-stress issue was flushing, fixed with https://crrev.com/c/3048172. > > Relanding without changes. > > > > TBR=verwaest@chromium.org > > > > Original change's description: > > > [sparkplug] Enable sparkplug by default on desktop > > > > > > Bug: v8:11420 > > > Change-Id: I07ac7f30b5ffffe40170ac15d5df0d3bf8a53523 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041418 > > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#75868} > > > > Bug: v8:11420 > > Change-Id: I44ac0e4a5df07db79fa50db3134cdae3af41c88c > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3053588 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75916} > > Bug: v8:11420 > Change-Id: I24c7aea81ca58c339fc3bcc904663bdefb93106b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3054118 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#75926} Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng,v8_linux_arm64_gc_stress_dbg_ng,v8_mac64_gc_stress_dbg_ng Bug: v8:11420 Change-Id: I94f9927b689d876135750f6151de14f295035c72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056986 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Anton Bikineev authored
Due to missing locks, there is a race between AllocatePagesAt (or ReserveForSharedMemoryMapping) and other functions that modify std::sets in RegionAllocator (e.g. AllocatePages or ReleasePages). The CL adds locks to AllocatePagesAt and ReserveForSharedMemoryMapping. Bug: chromium:1232067 Change-Id: I0ec503ab1ab432952ea067eb916299ea88566879 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056985 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Andrew Comminos authored
If context filtration fails, ensure that we still include an empty sample. This ensures that we can properly terminate stacks. Bug: chromium:956688 Change-Id: I3edeb3434960c420e24827c209055f7c378361bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058053Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#75980}
-
Yoshisato Yanagisawa authored
- goma cache silo is a builder to build the same target with cache silo. This is needed for fair build performance comparison between reclient and Goma. - reclient compare is a builder to verify artifacts generated in remote and that generated locally matches. Bug: chromium:1233780 Change-Id: I5854d20880e972a07fa09cfc5d4a6f9385844fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058059Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#75979}
-
Leszek Swirski authored
InterpreterOnStackReplacement_ToBaseline spills the accumulator register without a frame, but can then call kInstallBaselineCode. If that function then allocates, then the GC will see an invalid stack. Fix this by making sure that the accumulator register is spilled inside the internal frame of the kInstallBaselineCode, and either don't spill it at all outside that frame, or at least make sure that we pop/re-push the spilled value so that it moves inside the frame. Bug: v8:11420 Change-Id: Iad2aa718b0477ff960544d881fecae9efcbeef54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059072 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 71e27849. Reason for revert: As of https://crrev.com/c/3059685 it's fast. Original change's description: > Mark json-parser-recursive as slow > > Bug: v8:12029 > Change-Id: I0d25f8c844c9826e10ca2ccc6beb385439e97dde > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058451 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75968} Bug: v8:12029 Change-Id: I9536adbe4d8434e44d3e113104694baa3b3cea47 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059687 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75977}
-
Leszek Swirski authored
The test makes sure that JSON parsing doesn't stack overflow if given a deeply nested JSON object. This deep nesting makes the test slow, so we can test ~the same thing by lowering both the nesting and the stack size. Bug: v8:12029 Change-Id: I689ffc1b9db167a1cf1de93beeb09c89e03264a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059685 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Bug: chromium:1234045 Change-Id: Id72ac120d161d1419a1c07d68dbe6314bf865e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059084 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
