- 09 Aug, 2018 36 commits
-
-
John Barboza authored
Change-Id: I853f7899dbba9112ba1ca2ce78e2838b5a09c975 Reviewed-on: https://chromium-review.googlesource.com/1168087 Commit-Queue: John Barboza <jbarboza@ca.ibm.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55028}
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: I6391c3d5e86d2b04735e241a1e0549a170ab4852 Reviewed-on: https://chromium-review.googlesource.com/1164640Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55027}
-
Junliang Yan authored
Port 352e408b Original Commit Message: Add codegen support for up to 4GiB memories in Liftoff code. This CL also adds three new mjsunit tests that stress large WASM memories (1, 2, and 4 GiB) and checks that accesses near these boundaries properly generate traps. Note there is still some trickiness around the setting of: 1.) the flag --wasm-max-mem-pages 2.) wasm-limits.h kSpecMaxWasmMemoryPages = 65536 3.) wasm-limits.h kV8MaxWasmMemoryPages = 32767 In particular, the allocation of memories is still limited to 3.) and the runtime flag can only lower this limit. The above means that the tests for 2GiB and 4GiB memories will silently OOM by design until 3.) is changed (though they currently pass with manual testing). I argue it is better to include these tests up front, since they will immediately trigger if their memory allocation succeeds. Therefore the plan is to lift the restriction on 3.) after removing all other other internal V8 limitations including array buffers and views. R=titzer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:7881 LOG=N Change-Id: Ice70a9ac5a9a26b08cc77acb7deec98305574d01 Reviewed-on: https://chromium-review.googlesource.com/1167914 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Simon Zünd authored
This CL changes the order of the parameters of HasProperty to be more consistent with other CSA macros. Drive-by-change: Use HasProperty stub directly in Torque. R=jgruber@chromium.org Bug: v8:8015 Change-Id: I73d1096afbb86d52e2af67c1969549f1158448a7 Reviewed-on: https://chromium-review.googlesource.com/1166831 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55025}
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=santa Change-Id: I1f14da5476fdf6b52f62c5259ff36cdfe24105e3 Reviewed-on: https://chromium-review.googlesource.com/1169802 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=sigurds@chromium.org TEST=mjsunit/wasm/asm-wasm BUG=v8:8038 NOTREECHECKS=true Change-Id: Id12226116aae1b12c8cc948b28097c1dc126f17c Reviewed-on: https://chromium-review.googlesource.com/1169046 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55023}
-
jgruber authored
The HasProperty builtin differed in its expected argument order from the HasProperty runtime function. Like all other related spec primitives (e.g.: GetProperty, SetProperty, DeleteProperty), it should take {object} as the first argument and {key} as the second. This CL changes the builtin and all related spots to use the correct order. There was also a tricky bug in interpreter intrinsic rewriting, which assumes (but does not verify) that the argument order between runtime function and builtin is identical. Besides cctests, HasProperty intrinsic rewriting seems to be dead code. Bug: v8:8036 Change-Id: Ia669fd6f5c73a30df4e4607064603be759ced392 Reviewed-on: https://chromium-review.googlesource.com/1167297 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#55022}
-
Ulan Degenbaev authored
When the memory pressure level is critical and there are managed objects that call AdjustAmountOfExternalMemory in their finalizer, we trigger GC for each dying managed object. See the test for an example. This fixes the bug by clearing the memory pressure level before GC. Bug: v8:8014 Change-Id: Id5144430a52fb8545aa23f33229a11b1714cbf10 Reviewed-on: https://chromium-review.googlesource.com/1169011Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55021}
-
Marja Hölttä authored
It's now unused. BUG=v8:7308 Change-Id: I301b83fde1d941d5d535922a1174d017186b82ce Reviewed-on: https://chromium-review.googlesource.com/1169017Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55020}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I940ed715949307abb831d47c197b7e75ed5b0fca Reviewed-on: https://chromium-review.googlesource.com/1169047 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This CL introduces a set of configuration options implemented as a struct of booleans that together comprise the set of enabled or detected features. The configuration options replace command-line flags that were checked deep in the implementation. As such, it is necessary to plumb them through multiple levels of abstraction. R=ahaas@chromium.org CC=mstarzinger@chromium.org BUG=chromium:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1b82f5826e4fd263f68e8cafcd923bac5818a637 Reviewed-on: https://chromium-review.googlesource.com/1163670Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55018}
-
Creddy authored
This is a reland of 690bda84 Original change's description: > [Interpreter] Do not use IC slots for property load/stores in an IIFE and top-level code > > An IIFE or top-level code is executed only once hence, there is no need to collect > type feedback. We can save some memory by not using IC slots for property Loads/Stores > within a IIFE/top-level code. This CL emits Runtime Get/Set property calls instead of LdaNamedProperty > /StaNamedProperty for the property loads within a IIFE and top-level code. > > Change-Id: I3e0ce26d05d82bb3648cb9262c4e112a2c4556c9 > Reviewed-on: https://chromium-review.googlesource.com/1146579 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Cr-Commit-Position: refs/heads/master@{#54949} Change-Id: I7b07ce86f7236d82191caaceafd31b86e5863ff5 Reviewed-on: https://chromium-review.googlesource.com/1167802Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#55017}
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=test-jump-table-assembler/JumpTablePatchingStress BUG=v8:8018 Change-Id: I1bb4c52a912a7c7ec7fbaf19c79cb7c7dd00a13e Reviewed-on: https://chromium-review.googlesource.com/1167283 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55016}
-
Tobias Tebbi authored
This should allow to re-land https://crrev.com/c/1039190 Bug: chromium:871886 Change-Id: If815537410b3fa09902026dc26205421f5c36ae5 Reviewed-on: https://chromium-review.googlesource.com/1169019 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55015}
-
Tobias Tebbi authored
Bug: v8:8029 Change-Id: I5d5575a74af49236ff55a39c6a6805472bd63609 Reviewed-on: https://chromium-review.googlesource.com/1166910 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Currently it was only used for modules, so repurposed it to be a weak pointer to JSModuleNamespace. BUG=v8:7308 Change-Id: I4ef522fafebd37624c309081d7432501c2c69b7a Reviewed-on: https://chromium-review.googlesource.com/1163704Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55013}
-
Ivica Bogosavljevic authored
TEST=cctest/test-run-wasm-simd/RunWasm_S8x16Concat_turbofan Change-Id: Ifcc14b57d65d15e5ae8477a05746027356bac547 Reviewed-on: https://chromium-review.googlesource.com/1166909Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Andreas Haas authored
With the callback we can check if the origin trial is turned on for a given context. I will not land the other CL which added a flag to the isolate. The information if the origin trial is on is context-specific and not isolate-specific, and it's hard on the embedder side to track all creations of a context. With the API proposed in this CL we will ask the embedder every time we start compilation whether the origin trial is on or off. R=yangguo@chromium.org Bug:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8822f40ab12582a5b0bd6640790a269107fc085a Reviewed-on: https://chromium-review.googlesource.com/1163621 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:871886 Change-Id: I91c6099ebaa064575db1ee3d7354e02cd42bbfd2 Reviewed-on: https://chromium-review.googlesource.com/1166906 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Georg Neis authored
Also make printing of an incomplete AST more robust. Change-Id: I56636890deb6e38882a3f8206aff7cde3e4bab60 Reviewed-on: https://chromium-review.googlesource.com/1168498Reviewed-by:
-
Kanghua Yu authored
Benefit from constant folding, this CL reduce snapshot by 704 bytes for {Call,Construct}WithArrayLike builtins. R=tebbi@chromium.org Change-Id: I34f055c9b46039698150f560644459aa492cde9e Reviewed-on: https://chromium-review.googlesource.com/1168739 Commit-Queue: Kanghua Yu <kanghua.yu@intel.com> Reviewed-by: -
Clemens Hammacher authored
This allows to have only one version of {AreAliased} which has a clean implementation. R=mstarzinger@chromium.org Bug: v8:8015 Change-Id: I25c64a8c2077383129548773319799fac768521e Reviewed-on: https://chromium-review.googlesource.com/1167290 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55007}
-
Rodrigo Bruno authored
The HeapController is now refactored in a way that new controllers only need to specify the constants that define how a space grows and shrinks. Bug: chromium:845409 Change-Id: I804eed440a791d6fbd232b7540a1cbe66b16a5f1 Reviewed-on: https://chromium-review.googlesource.com/1165347 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds a SetProperty method to the KeyedStoreGenericGenerator that mirrors what "KeyedStoreGeneric" does (used for KeyedStoreIC_MegaMorphic). This new SetProperty method is then used in the SetProperty stub. Change-Id: I72a684238ef6c3b8c4db8ba957d5b79238f7e495 Reviewed-on: https://chromium-review.googlesource.com/1164945 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
jgruber authored
Elements is already set by CSA::AllocateJSArray. Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I89b87f9f33eca4a92216f248606fb746f0de5412 Reviewed-on: https://chromium-review.googlesource.com/1168487 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the sorting algorithm used in Array.p.sort from QuickSort to TimSort (implemented in Torque). Detailed performance results can be found here: https://goo.gl/4E733J To save on code space, fast-paths are implemented as sets of function pointers instead of specializing generics. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7382, v8:7624 Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de Reviewed-on: https://chromium-review.googlesource.com/1151199 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:6600 Change-Id: I2adb5a74cfdc6ec7e229f1ca1bd31d8209156617 Reviewed-on: https://chromium-review.googlesource.com/1167519Reviewed-by:
-
Simon Zünd authored
This CL fixes the copy-within JSTest benchmark so it works on Android. R=machenbach@chromium.org Change-Id: I63662f9ab00d0199614681a53118bc4079e697ff Reviewed-on: https://chromium-review.googlesource.com/1168488Reviewed-by:
-
Simon Zünd authored
This CL adds a baseline Torque implementation without fast-paths for Array.p.copyWithin. The JS version in array.js is removed. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Change-Id: Ie53047883a65dd9310ea8f8d0edb440f431044ea Reviewed-on: https://chromium-review.googlesource.com/1165223Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:775123 Change-Id: I8883be60cc4860fad572ba644bbc722972551eb3 Reviewed-on: https://chromium-review.googlesource.com/1168483Reviewed-by:
-
Michael Hablich authored
This reverts commit ff4fa92e. Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/1167969 ... see https://chromium-swarm.appspot.com/task?id=3f344f7ada4e0110&refresh=10&show_raw=1 for stacktrace. Original change's description: > [builtins] Enable Torque Array.prototype.splice > > Before, splice was implemented with a C++ fast path and a > comprehensive JavaScript version. > > This impl. is entirely in Torque with a fastpath for SMI, > DOUBLE and OBJECT arrays, and a comprehensive slow path. > The same level of "sparse" array support as given by the > array.js implementation is included. > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ibfa3407ed75b9ad15ac54cce446b3952e38f90a9 > Reviewed-on: https://chromium-review.googlesource.com/1039190 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54974} TBR=danno@chromium.org,yangguo@chromium.org,mvstanton@chromium.org,tebbi@chromium.org,szuend@google.com Change-Id: I900f667b30a0cf673ead9621618a9988cf85ffdf No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1168902 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:866862 Change-Id: I52737a644c36f78b1803a443b89600bb7a114082 Reviewed-on: https://chromium-review.googlesource.com/1168485Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8e67c4a..1f2ff68 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ada05b3..8fa35d1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/735f71d..dd5051f Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/c8d8248..1da4e38 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/ce468a1..d526632 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/42f0661..7302dfb TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id550e6db520a917cf7eed91e5b65ba0cb39ea043 Reviewed-on: https://chromium-review.googlesource.com/1168653Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54996}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838266 Change-Id: I7a8065038b4f62d10a1c0bc26df91566bdfec6bb Reviewed-on: https://chromium-review.googlesource.com/1154220 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54995}
-
Frank Tang authored
Change-Id: I1fba76623d128748dfe001a2603ea5c8cebcc4eb Reviewed-on: https://chromium-review.googlesource.com/1161708Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: Id4881bd0cd01564cb969da7aad855a7ce6685bb8 Reviewed-on: https://chromium-review.googlesource.com/1168482 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 08 Aug, 2018 4 commits
-
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I367e7a7e93de267cf9b0718f193f5de3abfbf692 Reviewed-on: https://chromium-review.googlesource.com/1152556 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54992}
-
Frank Tang authored
Spec: http://tc39.github.io/proposal-intl-list-format/ Design Doc: go/add-intl.listformat-to-v8 Test: intl/list-format/* R=gsathya@chromium.org, mvstanton@chromium.org Bug: v8:7871 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I820c205ca842c228ffe37f7e1648667f30f80bd8 Reviewed-on: https://chromium-review.googlesource.com/1126683 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#54991}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:863607 Change-Id: I999770d1dafbafe8bbe60b575a940f6feb90fae0 Reviewed-on: https://chromium-review.googlesource.com/1165551Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: chromium:872230 Change-Id: I15534f533e43cd4bdeedcdac204776178886c48d Reviewed-on: https://chromium-review.googlesource.com/1166916Reviewed-by:
-
