- 06 May, 2020 2 commits
-
-
Jakob Gruber authored
The isolate snapshot must not contain context-dependent objects, thus root visitation must not reach context-dependent objects. This CL sanitizes the isolate around serialization by clearing & later restoring two lists: 1. feedback vectors for profiling tools, 2. detached contexts. Drive-by: Set an array buffer allocator for SerializeDeserializeAndVerify. Drive-by: Allow serialization of *another* native context when serializing a native context. Bug: v8:10416,v8:10493 Change-Id: I1c49bda364eccd6d44f9499a9926f4bcd31f665d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179008Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67584}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8aef078..3c7540e Rolling v8/third_party/aemu-linux-x64: i0Kh0s13OUsO28Cn7E_Vm5Rv0jN7IXSm_qrvu2cBDmMC..J3cO22hWB2vC_byojuODbkHgkNGvxvrCAEPaKGOx3GwC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cd56abf..c5ffb21 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0f47d33..4de5413 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ibe41d58bb62a7c53bf223f40892dfedac1da38bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183356Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67583}
-
- 05 May, 2020 33 commits
-
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: I8026a25d9b1a62a7c5d7b20b99f6474374333445 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171551 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67582}
-
Anton Bikineev authored
This ports sweeper logic from Blink into a separate entity - Sweeper. Concurrent sweeping is in a followup. Bug: chromium:1056170 Change-Id: I41196225f0d882cb0ab5190d23e297ee2498df6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2167858 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67581}
-
Seth Brenith authored
Marja pointed out that the following code causes a Torque crash: Convert<Smi>(MessageTemplate::kFoo) This change is a small fix to not crash in that case. Bug: v8:7793, v8:10475 Change-Id: I7856366856a4cd7facdb19686a2d4c92b0d04516 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182175Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#67580}
-
Dan Elphick authored
Removes spurious self-include in src/heap/memory-chunk.h Bug: v8:10473 Change-Id: I0bdf3b6b62f3b3a241225a99d681ddc1f1bd6bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181329 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ng Zhi An authored
It was assuming that the input is always a register, but it isn't. Bug: chromium:1078399 Change-Id: If14abb8ea34f9febfc04a67a8da260a7e66af7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182176Reviewed-by:
-
Deepti Gandluri authored
Revert "[compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on." This reverts commit 0c9a0072. Reason for revert: Breaks tests on the blink bots, will block roll. https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux/4465 Original change's description: > [compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on. > > In the current state, when unconditional compilation is on, strings are evaluated and other objects are passed through unchanged. After this, non-strings are passed to the modifying callback which could unwrap and eval them. eval(string) is not affected. > > If a non-modifying callback is set, it still takes the precedence, and the non-string object is returned as it would be currently (line 1933). > > Change-Id: I835b976b3420635baba245c08f8563a9e5b3b246 > Bug: chromium:1024786 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917147 > Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67570} TBR=vogelheim@chromium.org,mvstanton@chromium.org,ssanfilippo@chromium.org,verwaest@chromium.org Change-Id: I75637347e92e805361f954be3515f84ca55d756b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1024786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182178Reviewed-by:
-
Georg Neis authored
Bug: chromium:1076708 Change-Id: I7f065791310606e11fe89936a36f0fe7cb0d38e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182639 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Bill Budge authored
- Port WasmTableGet, WasmTableSet, and WasmRefFunc to Torque. - Breaks WasmBuiltinsAssembler into .cc and .h files. Change-Id: I0f62715ce10beedabf7b4f9502c9476de9efdd5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2175090 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67575}
-
Ng Zhi An authored
Bug: chromium:1077198 Change-Id: I74f7afbd2c0d7753ef620e5d5ddee60ee8a16718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2176892Reviewed-by:
-
Clemens Backes authored
This function is always called right after creating the DefaultPlatform, hence merge it into the constructor. R=mlippautz@chromium.org Change-Id: I4afb14c83740224056157665db6b854c659da0c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182635Reviewed-by:
-
Liviu Rau authored
Slow tests are now collected in a heap with a fixed size. When the maximum size is reached we evict the fastest test after adding a new test to the heap. Bug: v8:10168 Change-Id: If3298df85d6e924451f55fe9350e293169cc849d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2106205 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#67572}
-
Philip Pfaffe authored
Wasm modules generated by emscripten today have two ways to point to debug symbol files, the source mapping url and external debug info custom sections. To support both, this CL extends CDP to appropriately report the symbol type and location. Bug: chromium:1064248 Change-Id: I9076034f6d73901d8a9c5cfd7c2988fb30bb14c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116208Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#67571}
-
Stefano Sanfilippo authored
In the current state, when unconditional compilation is on, strings are evaluated and other objects are passed through unchanged. After this, non-strings are passed to the modifying callback which could unwrap and eval them. eval(string) is not affected. If a non-modifying callback is set, it still takes the precedence, and the non-string object is returned as it would be currently (line 1933). Change-Id: I835b976b3420635baba245c08f8563a9e5b3b246 Bug: chromium:1024786 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917147 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#67570}
-
Marja Hölttä authored
Bug: v8:9808 Change-Id: I24df18562c5b1277a8151d35eb07b836e70f1149 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182457 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67569}
-
Philip Pfaffe authored
Allow the DevTools frontend to evaluate variables in a wasm frame context by reusing the existing Debugger expression evaluation API. Where previously the API expected JavaScript expressions, which would in general just fail, now the expression is expected to be base64 encoded Wasm that creates a JSON string in linear memory. Bug: chromium:1020120 chromium:1068571 Change-Id: I4b31fdb9d3b21b4e08c4995ec2f07880923959e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087396Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The flag is used by V8 to propagate information on whether this GC was somehow forced. This allows the embedder using EmbedderHeapTracer to easily figure out whether a GC was forced based on a local flag without depending on GC prologue/epilogue callbacks. Bug: chromium:1074061 Change-Id: Ic04c93ae58da854e54c6da1ca4aac03b5ab49897 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182473Reviewed-by:
-
Samuel Groß authored
Bug: v8:10391 Change-Id: I55d4d33820c83711d3ea3c6a2f3a20a36707fe36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151354Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#67566}
-
Hannes Payer authored
Change-Id: Ia316db16fb338e3f26b0666de88d5e53f375f8be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181263 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:1076708 Change-Id: I88a5eae0e562e32f1915deff3c4150ec4be14c6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181266 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67564}
-
Milad Farazmand authored
Without the added header some GCC compilers might produce this error: error: 'ceil' is not a member of 'std' Change-Id: I4fc784725c904adc58919a766671e37c9aca7ecb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181774 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Work towards adding heap-allocated object support for wasm, according to the gc proposal. Changes: - Implement subtyping for reference types (ref s) and (optref s), where 's' is a struct type. This CL does *not* implement subtyping between struct and function types. Also, it does not handle i31refs and eqrefs. - Implement struct.set. - Change struct.get to accept an optref as argument, as required by the standard. - Allow locals to store objects of ref and optref types. - Add a test for struct.set and optref locals. Modify the test for struct.get accordingly. Reference: https://github.com/WebAssembly/gc R=jkummerow@chromium.org R=clemensb@chromium.org Bug: v8:7748 Change-Id: I708626fa5f90a6e24e667d66eed1c7697f458a23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172089Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit a596efcc. Reason for revert: Was incorrect. Holes can appear in dead code. Original change's description: > [turbofan] Refine a DCHECK > > Hole checks are done using a lower level comparison. > > Change-Id: I61c5b787f12564ad3553d395a36938a00f5dd554 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172418 > Auto-Submit: Georg Neis <neis@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67466} TBR=neis@chromium.org,nicohartmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I47aff68cf8e224882a3eeac0d9edfe5a6228f0f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181324 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
On intel platforms, floats do not always have a stable bit pattern. To preserve the bit pattern of float immediates, we should keep them in an int using get_bits() instead of casting them to a float with get_scalar(). R=ahaas@chromium.org CC=zhin@chromium.org Change-Id: I481219f755c40cbba760be5744734c1075e8ab66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172694 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Clemens Backes authored
This removes the interpreter entry stubs, which are used to redirect specific wasm functions to the interpreter. It is only needed when mixing JS code with interpreted Wasm code, otherwise the test functions just call the interpreter directly. Thus a lot of tests that contain such interaction between JS and Wasm need to be restricted to execute in Liftoff and TurboFan only. After this CL, the WASM_INTERPRETER_ENTRY frame type and the corresponding WasmInterpreterEntryFrame are dead, and will be removed in a follow-up CL. R=thibaudm@chromium.org Bug: v8:10389 Change-Id: I8e50d350dbc2afcc1cddaeb98baf23711117af2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172962 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#67559}
-
Samuel Groß authored
Bug: v8:10391 Change-Id: I29393ebcb58b1000040d7f7ba205895a8ba363f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2148782Reviewed-by:
-
Michael Lippautz authored
This adds PostConstructionCallbackTrait which can be used to get a callback that is executed right after an object instance is created. This can be useful for hooks that require to be able to call into virtual methods. Bug: chromium:1074061 Change-Id: Idd5ef677fed291bcba81b9a47f2932c9bb5832b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179385 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Andreas Haas authored
The existing implementation needed uses of the outputs of an AtomicExchange to allocate registers for the result value. However, these uses are not guaranteed to exist. With this CL temp registers get allocated if the uses don't exist. R=gdeepti@chromium.org Bug: chromium:1077130 Change-Id: I058ee53b87c6e995c9f490f3aebbfdba69934f3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179503Reviewed-by:
-
Shu-yu Guo authored
%GetUndetectable() is used for testing document.all's wacky "emulates undefined" behavior both in mjsunit tests and in test262. mjsunit doesn't rely its [[Call]] behavior, while test262 relies on its [[Call]] returning null [1]. So, make it return null. [1] https://github.com/tc39/test262/blob/master/INTERPRETING.md search for IsHTMLDDA Bug: v8:7184 Change-Id: I93d15715303deb0a932545d919bc281f5f4d5829 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181475 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#67555}
-
Shu-yu Guo authored
R=marja@chromium.org Bug: v8:10372 Change-Id: Iaba823712140418b5a5ae73d77c50b4ea20df991 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181164 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
There is already a %GetUndetectable runtime test function, so use that. Bug: v8:7184 Change-Id: I04af03d95c4245ab9c7061cb00d5890972b82f46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181195 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:9801 Change-Id: Id1c6aa94e291b9ea09515a60f248e0b3a0cc99c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181163 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Dan Elphick authored
Also makes memory-chunk.h accessible from outside heap which allows removal of some heap-inl.h includes. Bug: v8:10473, v8:10496 Change-Id: Iec4fc5ce8ad201f6ee5fd924cc3cd935324429fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172088 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/81c45bb..8aef078 Rolling v8/third_party/aemu-linux-x64: KkC1dMnOt3dQMJqp-GzpAoyULRktX6-7fxUPrsEeEJMC..i0Kh0s13OUsO28Cn7E_Vm5Rv0jN7IXSm_qrvu2cBDmMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/72830df..cd56abf Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/082a11a..0f47d33 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8e06d3e7a3810f1ad892502adef37dfc6adb2bbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182149Reviewed-by:
-
- 04 May, 2020 5 commits
-
-
Frank Tang authored
Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle to replace a hack which get the pattern of "jjmm" to find out the default hour cycle of a locale Bump the required API version from 65 to 67 Bug: v8:10225 Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875Reviewed-by:
-
Frank Tang authored
The revised spec in https://tc39.es/ecma402/#sec-Intl.Locale.prototype.maximize now set the minimal or maximal to the %Locale% without the same opeartion as in Intl.Locale(tag, [option]) Bug: v8:10489 Change-Id: I08c45879b158a84e8cba19922423666e2b98412b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174976Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10347 Change-Id: I5a64a9e90ec7e0f3f0baf032f2d6801a94c08a3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2168026Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
This reverts commit 3c400825. Reason for revert: Re-enable interpreter tests Original change's description: > [wasm-simd] Remove interpreter tier of SIMD tests > > As per the all-hands a couple of weeks ago, the interpreter will > be removed soon. Remove running tests on this tier, so we no longer > put effort into maintaining tests for this tier. > > Change-Id: I9fce0f3a7cd869d6ccecf1c1f820b794e89858e1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2175021 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67520} TBR=gdeepti@chromium.org,zhin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Iac0f21311769157c5ae303e8078c25d96fbc7c93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2180343Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#67546}
-
Dan Elphick authored
This removes the static ReadOnlyHeap::Instance method replacing it with PopulateReadOnlySpaceStatistics on the way to removing the global ReadOnlyHeap object. Bug: v8:10454 Change-Id: Ic78c898ff99c6a7dac023d2b5230fbbbf6f36f46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179805 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
