- 26 Oct, 2018 1 commit
-
-
Jakob Kummerow authored
This CL applies the equivalent of the Object -> ObjectPtr transformation to MaybeObject and HeapObjectReference. We need no renaming in this case because we can just migrate them both in one go. Bug: v8:3770 Change-Id: Ie1259c3e8c556eff00f8bcf534d7270ca9fe00e1 Reviewed-on: https://chromium-review.googlesource.com/c/1298386 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57010}
-
- 25 Oct, 2018 39 commits
-
-
Junliang Yan authored
Port e893eb14 Original Commit Message: This adds support for having reference type values (i.e. anyref) stored in an exception. It is the natural combination of the reference type proposal and the exception handling proposal. Note that this also introduces support for having write barriers in generated WasmCode, as this is the first time we are storing references within generated code. Such write barriers will be needed for other uses of reference types (e.g. mutable global) regardless. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:8341 LOG=N Change-Id: I6837a31791654ebe4171f6ecb563939beb3a66dd Reviewed-on: https://chromium-review.googlesource.com/c/1299899Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57009}
-
Michael Lippautz authored
Change-Id: I87d17d087f47eb60efbd2ddaf04d5d574c73164c Reviewed-on: https://chromium-review.googlesource.com/c/1299245Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57008}
-
Michael Achenbach authored
This reverts commit 9cde8808. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Linux%20V8%20FYI%20Release%20(NVIDIA)/3086 Original change's description: > [Compile] Ensure we don't access the native context during bytecode finalization. > > Resets the isolate's context to nullptr in debug builds during bytecode finalization > to ensure that we don't rely on the native context during context independent > unoptimized compilation. > > BUG=chromium:898076, v8:8041 > > Change-Id: Ifaa5006a7a3d31d7fbd535ebb63f8889c75526c4 > Reviewed-on: https://chromium-review.googlesource.com/c/1297961 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56979} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,leszeks@chromium.org Change-Id: I363bc9db3f4b89e46ecdaf41c101f7fc1145a325 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:898076, v8:8041 Reviewed-on: https://chromium-review.googlesource.com/c/1299247Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57007}
-
Michael Achenbach authored
This reverts commit e05913ff. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23203 Original change's description: > [heap] Add marking summary counter > > Change-Id: I41e5c4a99331ddc844cd1fe86f63406a28eebdbf > Reviewed-on: https://chromium-review.googlesource.com/c/1299243 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57005} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I0acfee50159527f496f752015b19e56eaf1c1600 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1299246Reviewed-by:
-
Michael Lippautz authored
Change-Id: I41e5c4a99331ddc844cd1fe86f63406a28eebdbf Reviewed-on: https://chromium-review.googlesource.com/c/1299243Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57005}
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I6b08006397a70c2a9c35807a39c6d7e1ebf185e0 Reviewed-on: https://chromium-review.googlesource.com/c/1299025 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57004}
-
Lei Zhang authored
In a DCHECK inside SetPayload(), MSVC gives a C4806 warning. Use the right types to avoid this. Also add pointer-with-payload.h to BUILD.gn. Change-Id: I10a415250e7d2f06dab7a10bff48eef5890bb723 Reviewed-on: https://chromium-review.googlesource.com/c/1297991 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57003}
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: Ia231f3eef158643c9ebe29f0854b37610f962acb Reviewed-on: https://chromium-review.googlesource.com/c/1299242 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
A node short-cutting optimization was not updating uses correctly. This fix makes sure that there are no other users of the node, thus making the use update unnecessary. This fix might have negative performance implications. Change-Id: Ie9bd23caf4434eb2137e111dc5e7c143fd97521c Reviewed-on: https://chromium-review.googlesource.com/c/1299019 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57001}
-
Stephan Herhut authored
This also disables the test on tsan bots and on bots that have dchecks always enabled, which includes try bots. Bug: v8:8332, v8:8831 Change-Id: Ib52cd32985d50e89ddfdc525f08f60ddfd981f1e Reviewed-on: https://chromium-review.googlesource.com/c/1297319Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I0722a30dc201b04f212d49dc96b8e4353a0201ad Reviewed-on: https://chromium-review.googlesource.com/c/1299024Reviewed-by:
-
Clemens Hammacher authored
The "max_len" argument for fuzzer targets is deprecated. We need to enforce the limit internally. R=ahaas@chromium.org Bug: chromium:894939 Change-Id: I2206bc63d5e39f1aa189e11042a6a0bbcca31b0d Reviewed-on: https://chromium-review.googlesource.com/c/1299020Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56998}
-
Bill Budge authored
- Moves call to DeserializeNativeModule into SaveContext to avoid a crash in IsWasmCodegenAllowed. Bug: chromium:719172 Change-Id: Idd367824a325fc684f29e335b0c07e515f9fdad3 Reviewed-on: https://chromium-review.googlesource.com/c/1298375 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This uses the PIMPL idiom to hide the implementation of {CompilationState} while still allowing to call methods on {CompilationState} using the externally visible type. It also allows to pass the {CompilationState} in a unique_ptr without a custom deleter. R=ahaas@chromium.org, mstarzinger@chromium.org Bug: v8:8238 Change-Id: I5e842723270bc6bb36b605253e3e88103caec61a Reviewed-on: https://chromium-review.googlesource.com/c/1297956 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
This adds support for having reference type values (i.e. anyref) stored in an exception. It is the natural combination of the reference type proposal and the exception handling proposal. Note that this also introduces support for having write barriers in generated WasmCode, as this is the first time we are storing references within generated code. Such write barriers will be needed for other uses of reference types (e.g. mutable global) regardless. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-anyref BUG=v8:8341 Change-Id: I1211d4a850954622cb873eede0b4024fecc3dd8b Reviewed-on: https://chromium-review.googlesource.com/c/1296484 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: Ia1662720a9a6f9b688dd097718597b44425bb134 Reviewed-on: https://chromium-review.googlesource.com/c/1299017 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Hai Dang authored
This reuses the fast path from IterableToList for Array.from. The fast paths are taken when .from is called with the receiver Array and the only argument is the iterable (no mapping function or thisArg). Bug: v8:7980 Change-Id: I975b0c5e3f838262d7b71ad4dec5111fb031d746 Reviewed-on: https://chromium-review.googlesource.com/c/1297322 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56993}
-
Clemens Hammacher authored
The {CompilationState} currently stores the {WasmEngine}, while the {NativeModule} only stores the {WasmCodeManager}. From a high-level view, this does not make much sense. The {NativeModule} belongs to exactly one {WasmEngine}, so that link should be stored there. We can then get to the {WasmCodeManager} from the {WasmEngine}. This change requires a refactoring of the {WasmCodeManagerTest} which created {WasmCodeManager}s independent of the {Isolate} and the {WasmEngine}. This is not supported any more. Note that in production, each {WasmEngine} owns exactly one {WasmCodeManager} and one {WasmMemoryTracker}, so testing that a {WasmMemoryTracker} can be shared by several {WasmCodeManager}s didn't make sense in the first place. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I582e698be35f97dbd38bf6e12eb7f8ee4fc1f0f2 Reviewed-on: https://chromium-review.googlesource.com/c/1297960 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
This gives us better test coverage. Also enable --strict-heap-broker by default. I think this flag is no longer necessary and can be removed soon. Bug: v8:7790 Change-Id: I55d43dea45ff99bb753189b0d019f945b61752ac Reviewed-on: https://chromium-review.googlesource.com/c/1298898 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56991}
-
Jakob Gruber authored
This removes the last V8_EMBEDDED_BUILTIN ifdefs from the ia32 macro assembler. It also enables root-relative accesses in a few more spots where they are cheap. Bug: v8:6666 Change-Id: I10c8e69d8a76fccd3d0753dad020cced4d92a4a2 Reviewed-on: https://chromium-review.googlesource.com/c/1299018 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56990}
-
Hai Dang authored
This CL allows ExtractFixedArray to know if the JSArray has only Smi elements. In that case ExtractFixedArray will always skip write barriers when copying the Smi-only backing store. In the case that the copying is not possibly conflicting with the concurrent marker, CopyElements will efficiently use memcpy for further performance. This improves the performance of ExtractFastJSArray and CloneFastJSArray. As a result, performance of copying Smi arrays by slice() and spreading is improved, except for spreading Smi holey arrays. Bug: v8:7980 Change-Id: Ie39f8abf3b5039cc12a8ca7ece81352375e0e9da Reviewed-on: https://chromium-review.googlesource.com/c/1286340Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Hai Dang <dhai@google.com> Cr-Commit-Position: refs/heads/master@{#56989}
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I45df1db051c69b05e0b84e432a072fd6bbdcf6d4 Reviewed-on: https://chromium-review.googlesource.com/c/1299083 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: I956bdd92688d4dddedca4a6ca844344072bad3f7 Reviewed-on: https://chromium-review.googlesource.com/c/1299085 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: v8:8363, v8:7926 Change-Id: Ib4e39c9b23cf0733c189480ba8fbe1df27c85395 Reviewed-on: https://chromium-review.googlesource.com/c/1299084Reviewed-by:
-
Toon Verwaest authored
Since tokens turn illegal automatically upon failure, we can delay checking in places where we'll return upon illegal token anyway. We still need checks before uses of a possible invalid expression (nullptr in parser), so keep those checks for now; possibly pushing a previously higher check to right before the dereference. Bug: v8:8363 ,v8:7926 Change-Id: Ia402fc83c15f4c3258a335614b9213f8211a3c53 Reviewed-on: https://chromium-review.googlesource.com/c/1299081Reviewed-by:
-
Jakob Gruber authored
This is a reland of a31a6230 Original change's description: > [ia32] Remove poisoning logic on ia32 > > Poisoning has been disabled by default on ia32 a while ago. This CL > removes its logic from ia32 code generation, which will let us move > towards fuller (and unconditional) root register support. > > Bug: chromium:860429, v8:8254 > Change-Id: I8f672cf48a6ffc7bf21e7794c1b7463d7f8b9594 > Reviewed-on: https://chromium-review.googlesource.com/c/1296131 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56978} Tbr: mstarzinger@chromium.org,jarin@chromium.org Bug: chromium:860429, v8:8254 Change-Id: Ia65ac57fdc6b9a0f59cc64455d6a000005e9be3b Reviewed-on: https://chromium-review.googlesource.com/c/1299080Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56984}
-
Clemens Hammacher authored
This CL extracts some functionality out of the {PrepareAndStartCompile} step, in order to reuse that from the {AsyncStreamingProcessor}. We currently schedule a {PrepareAndStartCompile} task to get the same effect, and rely on the internal implementation to do the right thing. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I43135fe488a5f72c09307ac955381c69b7987ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1297321Reviewed-by: -
Jakob Gruber authored
PrepareElementsForSort must return a number less than or equal the array length. Bug: chromium:897512, v8:7382 Change-Id: If5f9c4d052e623ab9f3300b8534603abbee859fa Reviewed-on: https://chromium-review.googlesource.com/c/1297958 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#56982}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I842615412368b37a1be4a5dfff7ba37f781f7906 Reviewed-on: https://chromium-review.googlesource.com/c/1297965Reviewed-by:
-
Michael Achenbach authored
This reverts commit a31a6230. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21332 Original change's description: > [ia32] Remove poisoning logic on ia32 > > Poisoning has been disabled by default on ia32 a while ago. This CL > removes its logic from ia32 code generation, which will let us move > towards fuller (and unconditional) root register support. > > Bug: chromium:860429, v8:8254 > Change-Id: I8f672cf48a6ffc7bf21e7794c1b7463d7f8b9594 > Reviewed-on: https://chromium-review.googlesource.com/c/1296131 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56978} TBR=mstarzinger@chromium.org,jarin@chromium.org,jgruber@chromium.org Change-Id: I305e9e1719fb4b3f8ef267c232723db9b52966e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:860429, v8:8254 Reviewed-on: https://chromium-review.googlesource.com/c/1299015Reviewed-by:
-
Ross McIlroy authored
Resets the isolate's context to nullptr in debug builds during bytecode finalization to ensure that we don't rely on the native context during context independent unoptimized compilation. BUG=chromium:898076, v8:8041 Change-Id: Ifaa5006a7a3d31d7fbd535ebb63f8889c75526c4 Reviewed-on: https://chromium-review.googlesource.com/c/1297961 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#56979}
-
Jakob Gruber authored
Poisoning has been disabled by default on ia32 a while ago. This CL removes its logic from ia32 code generation, which will let us move towards fuller (and unconditional) root register support. Bug: chromium:860429, v8:8254 Change-Id: I8f672cf48a6ffc7bf21e7794c1b7463d7f8b9594 Reviewed-on: https://chromium-review.googlesource.com/c/1296131 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The flag was only there to tell whether the {AsyncCompileJob} needs to be kept alive. We already have this information in all the other fields of the {AsyncCompileJob}, thus remove it. R=ahaas@chromium.org Bug: v8:8238 Change-Id: I8d1d76ba8d622d1816c240e7a824ecf31c3b1ce5 Reviewed-on: https://chromium-review.googlesource.com/c/1297957Reviewed-by: -
Peter Marshall authored
This is a reland of c92a1dda Original change's description: > [cpu-profiler] Fix a bug which caused a pure virtual function call > > We need to remove each Sampler from the SamplerManager before we call > the Sampler destructor. This is because the signal handler can interrupt > the destructor, and call DoSampler(), which calls sampler->SampleStack() > on the sampler being destructed, causing general unhappiness and > "Pure virtual function called!" crashes. > > Bug: v8:8346, v8:5193 > Change-Id: Iaa595a196eab33fb1af31584e9a68fd1ce0a18f6 > Reviewed-on: https://chromium-review.googlesource.com/c/1293949 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56882} TBR=yangguo@chromium.org Bug: v8:8346, v8:5193 Change-Id: I9878f65c868ff1aed6f3a587cba688c4241bad8c Reviewed-on: https://chromium-review.googlesource.com/c/1298893Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56976}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:865541 Change-Id: I98f21c278099bd2c90b4a1ff9b7dddb74d263e34 Reviewed-on: https://chromium-review.googlesource.com/c/1144923 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Toon Verwaest authored
It's unnecessary to buffer in the zone, and using a deque is more expensive than an std::vector as a stack since we reuse areas very frequently. The top-of-stack that the State keeps track of is now simply tracked in the state, with a scope_depth_ counter to figure out if the fni_ is "open" (has an active state). Change-Id: I29ad3db7520340b8fe035feed400178bd50785bc Reviewed-on: https://chromium-review.googlesource.com/c/1298894Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8182 Change-Id: I4dadd9cab071ecd4314c370be5f444e36acb708e Reviewed-on: https://chromium-review.googlesource.com/c/1297317Reviewed-by:
-
Florian Sattler authored
Replace the explicit ok tracing by setting the scanner to fail, allowing us to return automatically. RETURN_IF_PARSE_ERROR is now used instead of CHECK_OK to verify if the parser failed. In a follow-up CL we'll merge RETURN_IF_PARSE_ERROR after Expect* into an EXPECT* macro. We'll keep (for now) RETURN_IF_PARSE_ERROR that guard uses of possible NullExpression (e.g., impl()->IsIdentifier(...)). All other RETURN_IF* will be removed. Uses after failure can likely later be fixed too by introducing a FailureExpression. Bug: v8:8363 ,v8:7926 Change-Id: I9896449eb9be476c453da4417a0bfd17c169ff38 Reviewed-on: https://chromium-review.googlesource.com/c/1294649 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6455acf..5a371bc Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/7e3c46a..b0e7838 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b026043..ed6fe0f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/98f1e59..2b71832 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/bac0433..29de0c2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a245b95..3041f30 Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/445d7c4..86c09e8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ieb48aa2ff019267e3be8d3f70e60829d545d34c3 Reviewed-on: https://chromium-review.googlesource.com/c/1298391Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56971}
-
