- 31 Aug, 2017 7 commits
-
-
Yang Guo authored
R=jgruber@chromium.org Bug: v8:6624 Change-Id: I4929a404999cf4d2c12471d5ee13533234fbcf7e Reviewed-on: https://chromium-review.googlesource.com/645126Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47730}
-
Michael Lippautz authored
heap-inl.h exposes the whole world, which is fine from other inline files but not from regular headers. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I09ec67c6558682cb0d5181031bc39341a3f4c5bf Reviewed-on: https://chromium-review.googlesource.com/643294Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47729}
-
Benedikt Meurer authored
When calling Object(value) where the value is known to be a JSReceiver, we can just replace it with value, as the Object constructor call is a no-op in that case. Otherwise when value is known to be not null or undefined then we can replace the Object constructor call with an invocation of ToObject. This covers the common pattern found in bundles generated by Webpack, where the Object constructor is used to call imported functions, i.e. Object(module.foo)(1, 2, 3) There's a lot of detail in https://github.com/webpack/webpack/issues/5600 on this matter and why this pattern was chosen. Bug: v8:6772 Change-Id: I2b4f0b4542b68b97b337ce571d6d79946c73d8bb Reviewed-on: https://chromium-review.googlesource.com/643868Reviewed-by:
-
Marja Hölttä authored
PreParser and Parser didn't agree whether a generator in a sloppy block is a sloppy block function or not, and thus the data generated by PreParser was inconsistent with what the Parser wanted to restore. BUG=v8:5516, chromium:760116 Change-Id: I0fd3c267691b8afd63a1336774769caf551c143e Reviewed-on: https://chromium-review.googlesource.com/642886Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#47727}
-
Sathya Gunasekaran authored
Bug: v8:5046 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I586dad351c950c119ec4d16693ce2a82395a8272 Reviewed-on: https://chromium-review.googlesource.com/640011 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Andrey Lushnikov authored
This patch: - teaches Runtime.callFunctionOn to accept executionContextId instead of objectId. - adds the optional objectGroup parameter to the Runtime.callFunctionOn. R=kozy TBR=pfeldman BUG=chromium:760367 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I024654860f23a9e79fb57865ba5bd472692ea526 Reviewed-on: https://chromium-review.googlesource.com/641921 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47725}
-
Sathya Gunasekaran authored
This patch introduces a new container type ScriptOrModule which provides the name and the host defined options of the script/module. This patch also introduces a new PrimitivesArray that can hold Primitive values, which the embedder can use to store metadata. The HostDefinedOptions is passed to V8 through the ScriptOrigin, and passed back to the embedder through HostImportModuleDynamically for module loading. Bug: v8:5785, v8:6658, v8:6683 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I56c26fc9a680b273ac0a6691e5ad75f15b8dc80a Reviewed-on: https://chromium-review.googlesource.com/622158Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#47724}
-
- 30 Aug, 2017 29 commits
-
-
Jaroslav Sevcik authored
Bug: chromium:760434 Change-Id: I95bcf33f334349de0a81f574ba64128b8e1b2ebd Reviewed-on: https://chromium-review.googlesource.com/643192 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Adam Klein authored
CaseClause never made sense as an Expression; this CL allows us to remove several UNREACHABLEs and slim down the representation of CaseClause by removing its source position (which was only used in prettyprinting). The only real fallout of this change is that SourceRangeMap now stores its keys as ZoneObject*, rather than AstNode*, but since there's already compile time typechecking for inserting items into the map this shouldn't cause any ill effects. While modifying CaseClause, also removed the dead body_target() accessor (and related member variable). Thus this CL overall reduces the memory needed for each CaseClause by two words. Bug: v8:6092 Change-Id: I0021c0590a69e29305c41ec6105c8824ae0cc25b Reviewed-on: https://chromium-review.googlesource.com/639316Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47722}
-
Michael Lippautz authored
TEST=cctest/test-heap/EnsureAllocationSiteDependentCodesProcessed Bug: Change-Id: I803d6b33258175da32fa79ba9b839e67d5ba11bf Reviewed-on: https://chromium-review.googlesource.com/643210Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47721}
-
Leszek Swirski authored
Jumps (and returns) in Ignition update the interrupt budget, and call into the runtime if the budget drops below zero. Since forward jumps only ever increase the budget, we don't need to generate this check or the call for them at all. Change-Id: I8c4ae15edab39a3a5725a98f38efba3a16243d91 Reviewed-on: https://chromium-review.googlesource.com/643209Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:6761 Change-Id: I65f70cb192fc9cd9a06a0ba8a02532ff24ad1387 Reviewed-on: https://chromium-review.googlesource.com/643206 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47719}
-
John Barboza authored
I found that v8 will crash when --print-code is turned on while Regexp is interpreted. It crashes when trying to print Relocation info during Disassembly. It should probably avoid printing out disassembly when the Code object is a bytecode regexp. Bug: Change-Id: I35b531cb03996a303248652871452266c78fee38 Reviewed-on: https://chromium-review.googlesource.com/642127Reviewed-by:
-
Clemens Hammacher authored
It has exactly the inverse meaning of CHECK_ERROR. Since CHECK_ERROR is used in the majority of the cases, and is more readable in most cases, this CL replaces all uses of VALIDATE by CHECK_ERROR. It also includes a few minor refactorings of the touched code. R=titzer@chromium.org Bug: v8:6600 Change-Id: I3d6b3b8bfd131e14f0d852b07622382b11b488f0 Reviewed-on: https://chromium-review.googlesource.com/643268Reviewed-by:
-
Ben L. Titzer authored
This is a reland of 15fe64c0 Original change's description: > [wasm] Handle non-asm-js case in WasmCompiledModule::GetAsmJsSourcePosition. > > This hides more implementation details and simplifies callers. > > R=ahaas@chromium.org > > Bug: > Change-Id: I4809611c55b810a3b0674713e12f3f17401e6c9c > Reviewed-on: https://chromium-review.googlesource.com/620713 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47434} Change-Id: Ica097f43e5f9122eb44b537822f9021d5eab2703 Reviewed-on: https://chromium-review.googlesource.com/643207Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47716}
-
Ben L. Titzer authored
Script::SetEvalOrigin() could do a stackwalk depending on whether one of its arguments is a sentinel value. This is somewhat surprising behavior, and since this function has just one caller, it makes more sense to do this in that location. R=mstarzinger@chromium.org Bug: Change-Id: Iddd38b42d9a3a8f4898aafb20fe165dfee51d516 Reviewed-on: https://chromium-review.googlesource.com/643386Reviewed-by:
-
jgruber authored
intl_date_time_format_function is only set in i18n builds. Use opaque_reference_function to test for Builtins::kIllegal instead. TBR=yangguo@chromium.org NOTREECHECKS=true NOTRY=true Bug: v8:6624 Change-Id: I0631862e6e022d222b52dceb58a8fe65f7d6a4e8 Reviewed-on: https://chromium-review.googlesource.com/643506Reviewed-by:
-
Leszek Swirski authored
Use the DEFINE_FIELD_OFFSET_CONSTANTS macro to define the fields in the BytecodeArray layout description. Change-Id: I89ff2d7cd967aa1a503cbedd5d95dcd80f4d038c Reviewed-on: https://chromium-review.googlesource.com/643130Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#47713}
-
jgruber authored
Lazy deserialization needs to determine the underlying builtin by looking at the SharedFunctionInfo. This packs the builtin_id into the SFI::function_data field, and adds convenience functions to Code as a drive-by addition. Bug: v8:6624 Change-Id: I59093815aa6937342302153ebc95dd60edb0064e Reviewed-on: https://chromium-review.googlesource.com/641490 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
And reuse the CHECK_ERROR and VALIDATE macros. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ibeabdf0815418b6c70e2441ed9267261eb8883b6 Reviewed-on: https://chromium-review.googlesource.com/643131Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:738865, chromium:750084 Change-Id: Ife30da4be118cd6f3212e84752978ebb39500f15 Reviewed-on: https://chromium-review.googlesource.com/641414 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47710}
-
Ben L. Titzer authored
R=rossberg@chromium.org Bug: v8:6651 Change-Id: Iaa9217cacded9bdd3f0a35775275e79c231c272a Reviewed-on: https://chromium-review.googlesource.com/642969Reviewed-by:
Andreas Rossberg <rossberg@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47709}
-
jgruber authored
To deserialize builtins individually, we need to preserve their starting offsets within the serialized data. Bug: v8:6624 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I48a48330aeb63de2c8cfcbea6fb94e1b2917495c Reviewed-on: https://chromium-review.googlesource.com/637774Reviewed-by:
-
Michael Lippautz authored
Aligns behavior with other allocate calls in factory that allow choosing the generation depending on the use case. Bug: v8:6771 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I63b95de7e664a51af8ca24a75f2122dfe1792c42 Reviewed-on: https://chromium-review.googlesource.com/642799Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47707}
-
Peter Marshall authored
Bug: v8:6333 Change-Id: I5a38c1bcc6cd3b030ea2dd57fb2198009e8920e6 Reviewed-on: https://chromium-review.googlesource.com/638290 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
jgruber authored
This is a reland of 49e3bfd5 Original change's description: > [snapshot] Move builtins to dedicated snapshot area > > As a first step towards lazy builtin deserialization, this CL moves > builtins to their own dedicated area in the snapshot blob, physically > located after startup data and before context-specific data. > > The startup- and partial serializers now serialize all seen builtins as > references, i.e. they only encode the relevant builtin id (taking care > to preserve special behavior around the interpreter trampoline and > CompileLazy). Builtins are later fully serialized by the > BuiltinSerializer. The separate blobs are finally glued together by > CreateSnapshotBlob. > > Deserialization takes the same steps: when we see builtin reference > bytecodes before builtins have been deserialized, we push to a list of > deferred builtin references. After builtin deserialization, this list is > iterated and all builtin references are fixed up. > > Bug: v8:6624 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: Idee42fa9c92bdbe8d5b8c4b8bf3ca9dd39634004 > Reviewed-on: https://chromium-review.googlesource.com/610225 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47596} Bug: v8:6624 Change-Id: I8bfac56c482d992987c270bf0fea7acd9e4ca0c7 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/638271Reviewed-by:
-
Maya Lekova authored
Bug: chromium:760268 Change-Id: Id9b24ddee61926a5d1324d7da12efccf2c1eb9c2 Reviewed-on: https://chromium-review.googlesource.com/642798Reviewed-by:
-
Mostyn Bramley-Moore authored
Daniel Bratell reports: > v8 had a couple of files that were very slow to compile before jumbo > and if those now end up in the same translation unit, then I can see > how that translation unit can take an extreme time to get through > the compiler. > > From one of my test builds (times in seconds): > 49.7 v8_base/objects.o > 44.0 v8_base/code-stub-assembler.o > 32.9 v8_base/api.o > 30.5 v8_base/elements.o > 25.9 v8_builtins_generators/builtins-regexp-gen.o > 22.8 v8_base/parser.o > 21.2 v8_base/heap.o > > All of these are in the slowest 0.1% ninja jobs so they are extreme > in some way. I think I would just exclude them all (or at least the > 30s+ ones) completely from jumbo. BUG=chromium:746958 Change-Id: I01741109def4f9ac7c946319374076eb7b9d03b6 Reviewed-on: https://chromium-review.googlesource.com/637971 Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#47703}
-
Enrico Bacis authored
This CL introduces two tests to verify that the correct memory is accessed when a wasm module invokes an wasm function imported from a second module that accesses its (i.e., second module's) memory. The first test verifies that the second module's memory is accessed in case the first module does not have memory. In the second test, both the modules have memory. R=ahaas@chromium.org,clemensh@chromium.org,gdeepti@chromium.org Change-Id: I75c3a5335583a91af0e7e4179c482142165b1c01 Reviewed-on: https://chromium-review.googlesource.com/637837 Commit-Queue: Enrico Bacis <enricobacis@google.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Peter Marshall authored
Bug: v8:6333 Change-Id: I53d321292b0a2c7b7f72ee90bd119484f163bdc1 Reviewed-on: https://chromium-review.googlesource.com/637913 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Sergei D authored
To enable executing code in a context of a particular time or date (e.g. when codepath depends on whether it's say evening or New Year) there is a need for a way to provide it bypassing actual system time. Bug: chromium:751993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iee35d97b74345f63fff814a65a6f134d7c970341 Reviewed-on: https://chromium-review.googlesource.com/598666 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47700}
-
Tobias Tebbi authored
Bug: Change-Id: Ib9e0d0844ad5e7bc6cd038f736546cad77669321 Reviewed-on: https://chromium-review.googlesource.com/641530Reviewed-by:
-
Benedikt Meurer authored
Cleanup for 562663d5. Bug: v8:6702 Change-Id: I7fbacbe6e4b52dc56d810cab3123b497329be3ca Tbr: jarin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/641874Reviewed-by:
-
Benedikt Meurer authored
Introduce a proper empty_descriptor_array, which has the proper layout (length is 2 and the two fields are set properly). Also add a special EnumCache class and a matching empty_enum_cache. The contract now is that we only need to check the EnumLength on the map to know whether we are allowed to use the enum cache. This greatly simplifies the handling of the enum cache (and also the descriptor arrays), especially for the future work on optimizing keyed access via the enum cache indices. Bug: v8:6702 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I5ef517a3041163cd65ef003f691139ea52233e83 Reviewed-on: https://chromium-review.googlesource.com/641030 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:760434 Change-Id: I50ed6779f79ed1b17053a0a0f2013cae53091a3a Reviewed-on: https://chromium-review.googlesource.com/641873Reviewed-by:
-
Adam Klein authored
Also rename options key from "no_network" to "network" to avoid too many levels of double-negatives. Change-Id: I6d29edce8abde64199b27ef0f3453ab370a9937b Reviewed-on: https://chromium-review.googlesource.com/642516Reviewed-by:
-
- 29 Aug, 2017 4 commits
-
-
Jaideep Bajwa authored
Port 51a15140 Original Commit Message: This change adapts the Call bytecode handlers such that they don't require a stack frame. It does this by modifying the call bytecode handler to tail-call the Call or InterpreterPushArgsAndCall builtins. As a result, the callee function will return to the InterpreterEntryTrampoline when it returns (since this is the return address on the interpreter frame), which is adapted to dispatch to the next bytecode handler. The return bytecode handler is modified to tail-call a new InterpreterExitTramoline instead of returning to the InterpreterEntryTrampoline. Overall this significanlty reduces the amount of stack space required for interpreter frames, increasing the maximum depth of recursive calls from around 6000 to around 12,500 on x64. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:753705 LOG=N Change-Id: Ieac490d82098c13741080061eda762d54baf8c04 Reviewed-on: https://chromium-review.googlesource.com/639315Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47694}
-
Franziska Hinkelmann authored
No need to reassign those JSTypedArrays. Bug: v8:6704 Change-Id: Ide1f8bb119285b57ea85b8e710358c917244f801 Reviewed-on: https://chromium-review.googlesource.com/641474 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Adam Klein authored
There was only one case where this wasn't the case, having to do with variable declarations, and for that case the information need not actually be stored on the block, but should rather be propagated to the VariableProxy. Bug: v8:6092 Change-Id: I0d0025ec73d3dd4f9402606105d3e883a9417283 Reviewed-on: https://chromium-review.googlesource.com/639911 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Adam Klein authored
The vast majority of callers pass null |labels| and kNoSourcePosition, so make those the default arguments. Bug: v8:6092 Change-Id: Ifac3f0d49f56b680ec75b1a7afde5e5e788d9cfd Reviewed-on: https://chromium-review.googlesource.com/639761 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
-
