- 06 Jun, 2019 26 commits
-
-
Yang Guo authored
Bug: chromium:965916 Change-Id: I2cb28a8c569c88631bc835b55a04e8629f56cb6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630684Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62034}
-
Dan Elphick authored
This reverts commit 566233ae. Reason for revert: Breaks the build Original change's description: > Extend IsExtensible proxy trap fast path for Reflect.isExtensible > > The fast path for IsExtensible proxy trap is already implemented, we just need to use this for ReflectIsExtensible. > Now, ReflectIsExtensible is now a Torque builtin (previously CPP). Other cases will fall back to runtime. > > Bug: v8:6664 > Change-Id: Ib1c3f78d1f1a44c6628d351fed3bcdc91ca08cb5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645438 > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#62031} TBR=jgruber@chromium.org,mslekova@chromium.org,tmrts@chromium.org,duongn@microsoft.com Change-Id: I92f83d8c9cbdca1a33ddd0e875551deb62d7de89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6664 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648241Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#62033}
-
Milad Farazmand authored
Port 4237fc37 Port 71c66873 Original Commit Message: We want to allocate feedback vectors lazily in lite mode. To do that, we should create closures with the correct feedback cell. This cl allocates feedback cell arrays to hold these feedback cells in lite mode. This cl also modifies the compile lazy to builtin to expect these arrays in the feedback cell. Drive-by fix: InterpreterEntryTrampoline no longer has argument count in a register. So updated comments and removed unnecessary push/pop of this register. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2cca35cab2c0a1bc75619ff1565e453635f6b0e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646891Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#62032}
-
Z Nguyen-Huu authored
The fast path for IsExtensible proxy trap is already implemented, we just need to use this for ReflectIsExtensible. Now, ReflectIsExtensible is now a Torque builtin (previously CPP). Other cases will fall back to runtime. Bug: v8:6664 Change-Id: Ib1c3f78d1f1a44c6628d351fed3bcdc91ca08cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645438Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62031}
-
Ulan Degenbaev authored
If the embedder specifies an initial heap size, then we can take it as a hint to skip full GCs below that threshold. Bug: v8:9306 Change-Id: I42a4c597bf75c6ba9845ed7a6bd9946012979005 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646515Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62030}
-
Toon Verwaest authored
Change-Id: I386261bc012d0d4556b0f9417b2880cc7f44bf2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647697 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#62029}
-
Georg Schmid authored
R=jarin@chromium.org, tebbi@chromium.org Change-Id: I3f23b48d4294722d056edb0ec30f834c0169b042 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645331 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62028}
-
Simon Zünd authored
This CL adds lint errors when 'let' bindings, arguments and labels are not used. Note that errors for 'const' bindings will be added later. In cases where arguments are actually needed to match the signature, the warning can be silenced by prefixing identifiers with "_". This might be needed for generic specializations or builtins called from TurboFan. Trying to use a variable or label that was marked with "_" results in a compilation error. Implicit arguments are not linted. They are implemented using exact string matching. Prefixing an implicit argument with "_" in a callee would break all callers as the names would no longer match. Drive-by: Fix all new lint errors in the existing Torque code. Bug: v8:7793 Change-Id: I68b3c59c76b956e9f88709e9388a40a19546ce52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645092 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62027}
-
Mythri A authored
Bug: v8:8394 Change-Id: I02551ff3d51e914f5a24f221186f23a8e3d2cc77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648096Reviewed-by:
-
Igor Sheludko authored
Tbr: yangguo@chromium.org Bug: v8:9183, v8:8948 Change-Id: I7d68344479c67027be3ef63dec2c927c103b3fa6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647165 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Igor Sheludko authored
The implementation is already quite trivial and in addition in case of ptr-compr this implementation becomes even simpler and C++ compiler gets the opportunity to hoist common computation of isolate root. Tbr: yangguo@chromium.org Bug: v8:7464, v8:7703 Change-Id: I6e59cd43253c9ade5a0e27025ea7fabecd5b7af7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647171 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62024}
-
Leszek Swirski authored
Change-Id: Ieed04203b400f33dcb05eebd42b74db322c0c833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1648097 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit ca10d2ba. Reason for revert: Breaks layout tests - https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064%20(dbg)/17693 Original change's description: > [turbofan] Brokerize reduction of API calls > > JSCallReducer::ReduceCallApiFunction is now heap access free. > > Bug: v8:7790 > Change-Id: I5718d73589d0bed14149ef0bc084b8a6ab1b9b5b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624792 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62014} TBR=mvstanton@chromium.org,neis@chromium.org,mslekova@chromium.org Change-Id: I56d3e8e28f778858decf29d756564ac8ea04c8c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647170Reviewed-by:
-
Georg Schmid authored
Bug: v8:9314 Change-Id: I746dcdffe29ca7de144ad9c7d6310e479bff2434 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647164Reviewed-by:
-
Georg Schmid authored
R=jarin@chromium.org, tebbi@chromium.org TBR: machenbach@chromium.org Change-Id: I82dd17b14eb086928f602395d80f0f2cf09770eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635449Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Schmid <gsps@google.com> Cr-Commit-Position: refs/heads/master@{#62020}
-
Georg Neis authored
Move the closure hints out of environment_hints_ so that they are handled similar to return value hints. That makes things a little cleaner overall. Also make it clear in terms of SLOW_DCHECKs why we don't need to merge closure hints and, in the case of a dead environment, return value hints. Also rename environment_hints_ to ephemeral_hints_. The old name was weird because these are not the only hints in the environment. Bug: v8:7790 Change-Id: I2cb5389632c4827b027799985b8320f39e1e2314 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643555 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62019}
-
Mythri A authored
This is a reland of 8c10501b. Reland after fixing test failures. Original change's description: > Enable lazy feedback allocation > > Bug: v8:8394 > Change-Id: I29ffd38725bdcaa9dd11221045dba681eb0d567b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643430 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61991} Bug: v8:8394 Change-Id: Icc9e276ab22ca6455b775f3c27e0d43c3f08b887 TBR: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647161Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#62018}
-
Ulan Degenbaev authored
The new API function is called ConfigureDefaultsFromHeapSize and accepts two parameters: the initial and the maximum heap size. Based on the given limits the function computes the default size for the young and the old generation. The patch also cleans up the existing functions to make them consistent in terms of units and heap structure. Bug: v8:9306 Change-Id: If2200a9cdb45b0b818a373207efe4e6426f7b688 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631593 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:9213 Change-Id: Iee04bfe25e37cfe639964f8ab31e6702d3750bfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645319 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62016}
-
Maciej Goszczycki authored
This is a reland of 81abe8f7 It also disables ro-heap sharing in nosnap builds Original change's description: > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > Shared read-only heap is currently incompatible with pointer compression. > Enable sharing only if pointer compression is disabled. > > Bug: v8:7464 > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Cr-Commit-Position: refs/heads/master@{#61963} Bug: v8:7464 Change-Id: I6b620152d380864db2a725c25f3c916d695d4f81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1639298 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62015}
-
Maya Lekova authored
JSCallReducer::ReduceCallApiFunction is now heap access free. Bug: v8:7790 Change-Id: I5718d73589d0bed14149ef0bc084b8a6ab1b9b5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624792 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Ideally, in the common case the backtracking stack should be stack-allocated (and thus cheap). We should only switch to dynamic allocation if needed. SmallVector implements exactly this strategy, so switch to that as a backing store. This improves Octane/RegExp scores (--regexp-interpret-all) by 50%. Bug: v8:7777,v8:9330 Change-Id: I0d1b07bd8fd94483128e021390d054f483076f8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645318 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62013}
-
Jakob Gruber authored
This section potentially contains allocations and thus gc, all object references should be handlified. Bug: v8:9333 Change-Id: I5814e66e8b9b75a8bd952afecae7a3a27b42a642 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1647695 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62012}
-
Mythri A authored
We need to hold onto the bytecode array so it doesn't get flushed. Bug: v8:8394 Change-Id: Ia583a0a662740e369fcbc1c94041895e463be26e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645329 Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds the last fields needed to stringify all stack frames from StackFrameInfo objects instead of accessing the FrameArray directly. Drive-by-change: The factory method that creates StackFrameInfo is refactored to: 1. collect all values for the fields 2. allocate a StackFrameInfo 3. set all the values on the allocated info object. This fixes undefined evaluation order bugs that GCMole failed to spot, as well as make one factory method unnecessary. Note: More precise types on the fields that are currently "Object" will happen in a follow up CL. Bug: v8:8742 Change-Id: Ia8c55fc128434f27aadeba78e8483d90296abe3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1641242Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/388c061..03613cf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3344e16..d71ff5d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d2f31cc..8a37389 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/f5edb4f..31200de Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/779c4f0..9b1b0ed TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I3f1e0a20e06f8dba783dd6cc5e300a785de91056 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1646511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62009}
-
- 05 Jun, 2019 14 commits
-
-
Ulan Degenbaev authored
This reverts commit ce23fd64. Original change's description: > [heap] Clean up Heap::ConfigureHeap > > This re-arranges the implementation of the function to make it more > consistent. The only functional change is replacement of RoundUp with > RoundDown, which makes more sense for the limits. > > Bug: v8:9306 > Change-Id: Id1d4bc6cc414e3618c3878de8cb87a9ed59711f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643432 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61997} TBR=mlippautz@chromium.org,jgruber@chromium.org Change-Id: I2352c1305ea3e617b32951e4b1aa871271800478 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645330 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This is a reland of a0486202. It turns out that this gives ~2x speedup on highly parallel WebAssembly compilation, so let's try again landing this in isolation. Original change's description: > [zone] Use 32kb instead of 1MB as high zone page size > > It seems that allocating smaller pages is actually quite a bit faster than > larger pages, probably because they can be cached by malloc. Let's see what the > bots say. > > In a follow-up I'll check whether the segment-pool is actually beneficial or > whether we should just remove it. > > This also drops SegmentSize::kLarge as a way to make compilation deterministic. > Turns out that by now we need >8mb anyway, and the previous 1mb wasn't enough. > At the same time the compiler was fixed to not rely on virtual addresses of > zone objects anymore, and there's a bot checking whether the snapshot is > determistic. > > Change-Id: I38cbb0d209d68b3671fd38763b42714811f4223e > Reviewed-on: https://chromium-review.googlesource.com/c/1346370 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57683} Change-Id: I243ba741f0968879b4cfe9f366d81ddc53a9bf27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645326Reviewed-by:
-
Z Nguyen-Huu authored
ObjectIsExtensible is now a Torque builtin (previously CPP) and the Proxy path is implemented completely in Torque while everything else calls into runtime (and is thus a bit slower than previously). Improvement in micro-benchmark Before: IsExtensibleWithoutTrap-Proxies(Score): 2228 IsExtensibleWithTrap-Proxies(Score): 917 After: IsExtensibleWithoutTrap-Proxies(Score): 3683 IsExtensibleWithTrap-Proxies(Score): 3310 Bug: v8:6664 Change-Id: I1fbe1c51cb724a23d7a59fc8231bb3d1461a6add Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637444 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Suraj Sharma authored
This is a reland of 42fee61a The in-object fields of JSModuleNamespace has been excluded from torque. It is restored back to its existing mechanism on the C++ side and rest of the class is ported to torque. Original change's description: > [torque] Convert few class layout to torque. > > 1. Converted Module, JSModuleNameSpace, JSCollator, JSV8BreakIterator, > TemplateList, > JSStrictArgumentsObject to torque. > > Bug: v8:8952 > Change-Id: I01e88ac36acd7ba18791bec609e5ae737672c731 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619146 > Commit-Queue: Suraj Sharma <surshar@microsoft.com> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61671} Bug: v8:8952 Change-Id: Ibd41000ad96ae57bd4f452f0c0c1b890e2c6fb5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632833Reviewed-by:
-
Tobias Tebbi authored
TBR: yangguo@chromium.org Bug: v8:7793 Change-Id: Ie680d72a1da23038d3136f82532496eabbd9c363 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632227 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: Iaeb42a7ae049dcacd90596cb541c1b1a2464953a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645320 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I1660897803d826d6f2852186d5be7ce5650a32be Bug: v8:8054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643431 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Simon Zünd authored
R=tebbi@chromium.org Bug: v8:7793 Change-Id: Ibba7651f8bd6a8e06b7810a8190d210b4cd54be0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645324 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Jakob Gruber authored
During regexp execution we usually do not expect any interrupts to exist. This optimization doubles Octane/RegExp scores with --regexp-interpret-all. Drive-by: Do the same for irregexp stack checks (only applicable when called through the runtime). Drive-by: Slightly more specific AllowHeapAllocation scopes. Bug: v8:7777, v8:9328, v8:9330 Change-Id: I502d54d49a1267dee4b8a086dc6c2dca318a2d97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645313 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit f2823886. Reason for revert: Causes TSAN timeouts in RestoreHeapLimit, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26812 Original change's description: > [heap] Clean up Heap::ConfigureHeap > > This re-arranges the implementation of the function to make it more > consistent. The only functional change is replacement of RoundUp with > RoundDown, which makes more sense for the limits. > > Bug: v8:9306 > Change-Id: Id1d4bc6cc414e3618c3878de8cb87a9ed59711f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643432 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61997} TBR=ulan@chromium.org,mlippautz@chromium.org,jgruber@chromium.org Change-Id: I635d60fdfb332cf62ab55eb32242937ebee2f6ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645323Reviewed-by:
-
Igor Sheludko authored
... as it uniquely idenifies object inside an Isolate. This also allows comparisons between full tagged values ([Maybe]Object) and potentially compressed tagged values ([Strong]TaggedValue). As a side effect with this change we should generate a bit less code. Bug: v8:7703 Change-Id: I822df24e03653fa73314e0a6f81f0fa7b5c61eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643433Reviewed-by:
-
Ulan Degenbaev authored
This re-arranges the implementation of the function to make it more consistent. The only functional change is replacement of RoundUp with RoundDown, which makes more sense for the limits. Bug: v8:9306 Change-Id: Id1d4bc6cc414e3618c3878de8cb87a9ed59711f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643432Reviewed-by:
-
Simon Zünd authored
This CL changes the way stack trace serialization appends numbers. Instead of converting plain int to Handle<String>, they are converted to char*. The reason is that appending a Handle<String> causes the IncrementalStringBuilder to shrink the current part and create two ConsString instances to concatenate the accumulator, the current part and the passed in Handle<String>. This CL improves stack trace serialization micro benchmarks by ~12%. Bug: v8:8742 Change-Id: I174667379084381245827cb979f91db3c59ce75e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643169 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Georg Schmid authored
R=tebbi@chromium.org Bug: chromium:964833 chromium:970120 Change-Id: I0fc179aa1e8fc5c13279342501f8639fce9ee7d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645315Reviewed-by:
-
