- 04 Dec, 2017 5 commits
-
-
Jaroslav Sevcik authored
The existing object materialization in the deoptimizer has the following problems: - Objects do not necessarily verify during materialization (because during the depth first walk we might have inconsistent objects). - Stack can overflow (because we just materialize using recursive calls). - We generalize object fields. This CL re-implements the materialization algorithm to solve this problem. The new implementation creates the objects in two steps: 1. We allocate space for all the objects. In general, we allocate ByteArrays of the right size. For leaf objects that cannot participate in cycles, we build and initialize the materialized objects completely. For JS objects, we insert markers into the byte array at the positions where unboxed doubles are expected. 2. We initialize all the objects with the proper field values and change the map from the ByteArray map to the correct map. This requires some sync with the concurrent marker (Heap::NotifyObjectLayoutChange). When initializing the JS object fields, we make sure that we respect the unboxed double marker. Bug: chromium:770106, v8:3836 Change-Id: I1ec466a9d19db9538df4ba915516d4c3ca825632 Reviewed-on: https://chromium-review.googlesource.com/777559 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49821}
-
Clemens Hammacher authored
According to the style guide, we pass unique_ptr by value, or by reference in rare cases, but never by rvalue reference. R=ahaas@chromium.org Bug: v8:7109 Change-Id: I6cfdb8b61fada532ce334e2da419598085a2b408 Reviewed-on: https://chromium-review.googlesource.com/803716Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49820}
-
Andreas Haas authored
R=bradnelson@chromium.org Change-Id: I100f33a7c0da2f86aea78cf645b7a784a920596b Reviewed-on: https://chromium-review.googlesource.com/805241 Commit-Queue: Andreas Haas <ahaas@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#49819}
-
Andreas Haas authored
Bug: v8:7109 Change-Id: Id71f85a38e6c4f37176e1a70bf5c1e584ee08c56 Reviewed-on: https://chromium-review.googlesource.com/803345Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49818}
-
Andreas Haas authored
Since we have this d8 directory now, we can also use it. R=machenbach@chromium.org Bug: v8:7109 Change-Id: I595ceb30e1c9350ad00d5cfaf998e40294602103 Reviewed-on: https://chromium-review.googlesource.com/803214Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49817}
-
- 03 Dec, 2017 2 commits
-
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:748036, chromium:748038, chromium:748124 Change-Id: Iec59098bf0687a89dd967d12d03e6d4e08293780 Reviewed-on: https://chromium-review.googlesource.com/805236 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49816}
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org No-Try: true Bug: chromium:748036, chromium:748038, chromium:748124 Change-Id: I0102446623110a67655c4d119968c64afd879280 Reviewed-on: https://chromium-review.googlesource.com/805235 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 02 Dec, 2017 7 commits
-
-
Sergiy Byelozyorov authored
This reverts commit 0996c9f5. Reason for revert: new config is invalid Original change's description: > Migrate two more builders to LUCI > > R=machenbach@chromium.org > > No-Try: true > No-Presubmit: true > Bug: chromium:748000, chromium:748124 > Change-Id: Ief457560503f56b72e7d7c0135b499a01de0b8c1 > Reviewed-on: https://chromium-review.googlesource.com/803296 > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49813} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I251581ba9302972e51efa677c2993eb7dc2c7b3a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:748000, chromium:748124 Reviewed-on: https://chromium-review.googlesource.com/805314Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org No-Try: true No-Presubmit: true Bug: chromium:748000, chromium:748124 Change-Id: Ief457560503f56b72e7d7c0135b499a01de0b8c1 Reviewed-on: https://chromium-review.googlesource.com/803296 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Georg Neis authored
R=adamk@chromium.org Bug: Change-Id: Ic5668ba70065c7315c354b9921b3c493080da2a7 Reviewed-on: https://chromium-review.googlesource.com/803254Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49812}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a7ac13d..19d97ed Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/280aff0..c796cbc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5ff5f02b6186adcd17d06e9873df4f4d7a72b8a4 Reviewed-on: https://chromium-review.googlesource.com/804863Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49811}
-
Mathias Bynens authored
This patch normalizes the casing of hexadecimal digits in escape sequences of the form `\xNN` and integer literals of the form `0xNNNN`. Previously, the V8 code base used an inconsistent mixture of uppercase and lowercase. Google’s C++ style guide uses uppercase in its examples: https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters Moreover, uppercase letters more clearly stand out from the lowercase `x` (or `u`) characters at the start, as well as lowercase letters elsewhere in strings. BUG=v8:7109 TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6 Reviewed-on: https://chromium-review.googlesource.com/804294 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49810}
-
Mircea Trofin authored
The deleted lines are unnecessary, but somehow still managed to make their way in. Bug: Change-Id: If86b7e773af3149e18de59caecbf03d4558a313c Reviewed-on: https://chromium-review.googlesource.com/804822Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49809}
-
Alexey Kozyatinskiy authored
All these warnings were fixed long time ago. TBR=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I066136ce685f95d07b7cbbb4efa8255f5aeaf1a8 Reviewed-on: https://chromium-review.googlesource.com/804816Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49808}
-
- 01 Dec, 2017 26 commits
-
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: I2ae9c2a2d2b6a02826a50cd150cb8008841f55e4 Reviewed-on: https://chromium-review.googlesource.com/804212 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#49807}
-
Eric Holk authored
Bug: v8:7109 Change-Id: Ia29472641c9906433749d55269e15a32c8984355 Reviewed-on: https://chromium-review.googlesource.com/804213Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49806}
-
Michael Achenbach authored
This reverts commit 3b065110. Reason for revert: Broke fuzzers: https://build.chromium.org/p/client.v8.clusterfuzz/builders/V8%20Deopt%20Fuzzer/builds/384 Original change's description: > Reland "[test] Creating command before execution phase." > > This is a reland of 98cc9e86 > Original change's description: > > [test] Creating command before execution phase. > > > > Immutable command class with shell, flags and > > environment. > > > > Command creation moved from worker to the main > > process. Because of that there is no need to send > > test cases beyond process boundaries and load test > > suites in worker processes. > > > > Bug: v8:6917 > > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > > Reviewed-on: https://chromium-review.googlesource.com/791710 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#49746} > > Bug: v8:6917 > Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a > Reviewed-on: https://chromium-review.googlesource.com/800370 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michał Majewski <majeski@google.com> > Cr-Commit-Position: refs/heads/master@{#49756} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6917 Change-Id: I4938642c4396366be1e13daf6998c4b8538b688b Reviewed-on: https://chromium-review.googlesource.com/804254Reviewed-by:
-
Erik Luo authored
Aligns console.count() behavior with spec, which says the default label should be "default" when the label provided is not defined. Bug: chromium:700624 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie58af210d300ef3151082b23187dd18e356f5de8 Reviewed-on: https://chromium-review.googlesource.com/780620 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Erik Luo authored
Similar to Firefox and Safari, calling console.time() repeatedly with the same label will now produce a console warning indicating that the label already exists. Similarly for console.timeEnd() as well. Bug: chromium:727514 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id644ee107b09e7f4686fff44c5f32d31c88371ad Reviewed-on: https://chromium-review.googlesource.com/794345 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL adds support for f32 locals and parameters, and implements the basic f32 binary operations. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ia2d792dd1a6f7e97eab52a4ac49543b128fe3041 Reviewed-on: https://chromium-review.googlesource.com/796854Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49802}
-
Camillo Bruni authored
Bug: v8:7109 Change-Id: I16759ac5c9e09a9df4117d84ae6de26cc2410faf Reviewed-on: https://chromium-review.googlesource.com/803483Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49801}
-
Mircea Trofin authored
Flush the icache after JIT-ing using the WasmCodeManager. Also, re-enable tests that were previously failing on Linux ARM. Bug: v8:7138 Change-Id: I8e18b80dba58df173a2360f8ac365ee5daaf3239 Reviewed-on: https://chromium-review.googlesource.com/802961 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Hexadecimal escape sequences of the form `\xNN` are more readable in the context of byte values, and are preferred per Google’s C++ style guide. https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters BUG=v8:7109 Change-Id: I6821ccb804388d99e5601e92fc392afdf496691e Reviewed-on: https://chromium-review.googlesource.com/803057Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#49799}
-
Mathias Bynens authored
BUG=v8:7109 Change-Id: I976eeb012e5de944468f01b0676902fc82cd9604 Reviewed-on: https://chromium-review.googlesource.com/802828Reviewed-by:
-
Clemens Hammacher authored
Some uses use uint64_t instead of int64_t to avoid compiler warnings about illegal narrowing of values with the MSB set. R=tebbi@chromium.org,mlippautz@chromium.org Bug: v8:7109 Change-Id: I6e861f48828bd931c451ef336672a260c13ae042 Reviewed-on: https://chromium-review.googlesource.com/803275 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#49797}
-
Ben L. Titzer authored
This is a reland of 163c1c82 Original change's description: > [wasm] Gracefully handle malformed custom sections in WebAssembly.Module.customSections(). > > R=clemensh@chromium.org > BUG=chromium:789952 > > Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 > Reviewed-on: https://chromium-review.googlesource.com/800941 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49767} Bug: chromium:789952 Change-Id: Ie17629b3fcbf2d5f78c83be2aa2a6b904a61f3ab Reviewed-on: https://chromium-review.googlesource.com/803575 Commit-Queue: Ben L. Titzer <titzer@google.com> Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=chromium:789764 Change-Id: I6a466660159721683c4979af32019d740094151b Reviewed-on: https://chromium-review.googlesource.com/803217Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#49795}
-
Peter Marshall authored
Bug: v8:7109 Change-Id: I367b3de52f03958d97b5da49987310d4af1b55f5 Reviewed-on: https://chromium-review.googlesource.com/803344Reviewed-by:
-
Mythri authored
Adds new API function to request code cache. Earlier code cache was produced along with compile requests. This new API allows us to request code cache after executing. Also adds support in the code serializer to serialize after executing the script. Bug: chromium:783124,chromium:789694 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Id4e6a967e176e3e979dc4ccb9a37a353c70c3890 Reviewed-on: https://chromium-review.googlesource.com/797036Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#49793}
-
Marja Hölttä authored
BUG=v8:5402,v8:7109 Change-Id: Ifee03125d8894181acffc7ed9c6bda44e3939d2d Reviewed-on: https://chromium-review.googlesource.com/803336 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: I3730443db3b6f67dd57e07f8d2f03a3b34a6b0a7 Reviewed-on: https://chromium-review.googlesource.com/796215 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49791}
-
Clemens Hammacher authored
V8_INT64_C will be cleaned up in a follow-up CL. R=tebbi@chromium.org,mlippautz@chromium.org Bug: v8:7109 Change-Id: I6af97e7266039eb443896b404b77b8e2b5de5adb Reviewed-on: https://chromium-review.googlesource.com/803294Reviewed-by:
-
Marja Hölttä authored
These should've been moved earlier but were left behind. BUG=v8:5402,v8:7109 Change-Id: I9736da35f1ef89628c987c33eed40a07aa266bea Reviewed-on: https://chromium-review.googlesource.com/803375 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49789}
-
Sathya Gunasekaran authored
Reported by @ziyunfei here: https://twitter.com/ziyunfei/status/936524009528811520 Bug: v8:5367 Change-Id: I2b1bb43dff86f35dec824e275740fce4f0c97b2e Reviewed-on: https://chromium-review.googlesource.com/802877Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49788}
-
Marja Hölttä authored
BUG=v8:5402,v8:7109 Change-Id: Ief9bea58e4dcade4cf4dfbb1d52166b7a5ef3ac0 Reviewed-on: https://chromium-review.googlesource.com/803255 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ali Ijaz Sheikh authored
This is a reland of 86da38fd Original change's description: > [heap] minor cleanup in allocation observer code > > Change-Id: If0bec38d41a415e9fbfff57ac891de0461bac13b > Reviewed-on: https://chromium-review.googlesource.com/668836 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> > Cr-Commit-Position: refs/heads/master@{#48046} Change-Id: If5fd9f7d123a62672d5a4450ddeac5a6e29158b8 Reviewed-on: https://chromium-review.googlesource.com/675423 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
-
Martyn Capewell authored
The Arm atomic operations used an input register as a temporary, corrupting it for future uses. Fix this by adding another temporary, the impact of which is partly reduced by removing the "unique" requirement on the address base register. Bug: Change-Id: I99a7bc3c14100d64cb7478e2053cf83ab6dcea50 Reviewed-on: https://chromium-review.googlesource.com/795953 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
R=ulan@chromium.org Bug: v8:7141 Change-Id: I21b82f5c3f6a2cd5f6e525d267d6c6819b1370fb Reviewed-on: https://chromium-review.googlesource.com/796370 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:788113 Change-Id: I205c57869caa24957d63a139f6ba0c6e8cf45749 Reviewed-on: https://chromium-review.googlesource.com/800151 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensh@chromium.org Bug: v8:7109 Change-Id: I8836663f4c66fd0f8c50f2cb66ab4cb8e2712f6c Reviewed-on: https://chromium-review.googlesource.com/803274Reviewed-by:
-
