- 09 Nov, 2018 29 commits
-
-
Daniel Clifford authored
It sould take an exception argument to ensure the proper re-throw semantics. Change-Id: I36caba1a80c0d3f59c18dce5a58a0c1f0100657d Reviewed-on: https://chromium-review.googlesource.com/c/1328803 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57401}
-
Toon Verwaest authored
Change-Id: I6da7a3cbf681a5ae691fe0aee2e69536a84f0df0 Reviewed-on: https://chromium-review.googlesource.com/c/1329174 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57400}
-
Mythri authored
After adding an explicit API to create code caches the compile options related to producing code caches are no longer supported. Parser caches are also no longer supported. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6eb5d7cf6b03437834eb1a1d326374f09fbce5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1238493 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57399}
-
Mythri authored
Bug: chromium:896326 Change-Id: I9257573963f611711edbc48a46a3bacbe12a567d Reviewed-on: https://chromium-review.googlesource.com/c/1305934Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#57398}
-
Clemens Hammacher authored
This extracts the lambda tasks to an own compilation unit and header file. Additionally, it addresses the TODO to avoid templates and just store the function to execute in an std::function. Third, it provides the same functionality for pure (non-cancellable non-idle) tasks. Last, it removes the "Lambda" part from the methods, because we can actually instantiate it with anything that is invocable (function pointer, lambda, functor, ...). R=ahaas@chromium.org Bug: v8:8238 Change-Id: I2f613f5b15ee208f215bbf74bd6d1d41889fd637 Reviewed-on: https://chromium-review.googlesource.com/c/1328923 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57397}
-
Michael Achenbach authored
Also add the ability to skip tests only when --optimize-for-size is passed. TBR=sergiyb@chromium.org Bug: v8:7819 Change-Id: I1dcc26ea8664d014b6c50f0d636c13bf21e26ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1328945Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57396}
-
Georg Neis authored
Primary change is the removal of a CheckValue that is unnecessary because we only care about the map and there's already a CheckMaps. Secondary change is a minor refactoring for clarity. Change-Id: I96abd1bc2b38919fd08daa1c688298f8807a0fe7 Reviewed-on: https://chromium-review.googlesource.com/c/1326026Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 61d42c94. Switched to acquire/release memory order. Original change's description: > Use std::atomic in Cancelable > > Avoid deprecated base::AtomicValue, use std::atomic instead. > Plus minor drive-by cleanups. > > R=mstarzinger@chromium.org > > Bug: v8:8238 > Change-Id: I47a1f00e26a843b60380c50399eedc49d859830a > Reviewed-on: https://chromium-review.googlesource.com/c/1326463 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57386} Bug: v8:8238 Change-Id: I992a49d29af68cfa45bfae1bfb8dba5b47f94b25 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1329164 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Peter Marshall authored
There is a better maintained script in node-code-utils which properly bumps the version numbers for each of the LTS branches, which is more useful. Node collaborators also use this script, so it will make backports more uniform. Change-Id: If5449b8a801c4bd14f39d59b7af52cc959989be7 Reviewed-on: https://chromium-review.googlesource.com/c/1328927Reviewed-by:
-
Camillo Bruni authored
The InnerPointerToCodeCache was masking out the Page address to get stable hashes. However, for pointers into the embedded code this still introduces a sources of randomness due to how the data is mapped in. This is fixed by using offsets relative to the start of the embedded data. Hopefully this will fix one category of flaky tests unde with v8_enable_verify_predictable enabled. Change-Id: I6bc3a1b6a03555341a9e4387e8bc058921298ef1 Reviewed-on: https://chromium-review.googlesource.com/c/1327045Reviewed-by:
-
Leszek Swirski authored
Change the keyword/identifier scan to a single loop that branchlessly collects information on whether this is a possible keyword, identifier terminator or slow path (i.e. escapes) by looking up the value in a flags table (as long as the character is ascii). Also rewrites that loop as an AdvanceUntil, and sprinkles in some V8_LIKELY magic which is 'likely' to improve things. Change-Id: If06b0fff23630e7593b515308e5ffeca2d65daa8 Reviewed-on: https://chromium-review.googlesource.com/c/1328943Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57391}
-
Michael Starzinger authored
R=herhut@chromium.org BUG=chromium:903197 Change-Id: Ibc9225afe4237f221ae169de3ce6b3abb45e2708 Reviewed-on: https://chromium-review.googlesource.com/c/1328925Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57390}
-
Michael Achenbach authored
NOTRY=true TBR=jshin@chromium.org Bug: v8:8414 Change-Id: I7059304b2e9f593f9685a4a0a82f3e303cc4bc1e Reviewed-on: https://chromium-review.googlesource.com/c/1329202Reviewed-by:
-
Toon Verwaest authored
The current implementation isn't very helpful anyway if we ever really want this. Change-Id: Iad4132734980937aee462a1613d47887383585a0 Reviewed-on: https://chromium-review.googlesource.com/c/1328928Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57388}
-
Clemens Hammacher authored
This reverts commit 61d42c94. Reason for revert: TSan failures: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/23459 Original change's description: > Use std::atomic in Cancelable > > Avoid deprecated base::AtomicValue, use std::atomic instead. > Plus minor drive-by cleanups. > > R=mstarzinger@chromium.org > > Bug: v8:8238 > Change-Id: I47a1f00e26a843b60380c50399eedc49d859830a > Reviewed-on: https://chromium-review.googlesource.com/c/1326463 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57386} TBR=ulan@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I96f269800eb9c26812050629f7f2c75096f3c858 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8238 Reviewed-on: https://chromium-review.googlesource.com/c/1329201Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57387}
-
Clemens Hammacher authored
Avoid deprecated base::AtomicValue, use std::atomic instead. Plus minor drive-by cleanups. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I47a1f00e26a843b60380c50399eedc49d859830a Reviewed-on: https://chromium-review.googlesource.com/c/1326463 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This better separates non-arrow/assignment from the alternative, and destructuring assignment from other types of assignment to avoid unnecessary and duplicate branches. Change-Id: I51c59f86c705646c02f182c9719700c558297e4a Reviewed-on: https://chromium-review.googlesource.com/c/1328921 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57385}
-
Toon Verwaest authored
Change-Id: I81e14fd1b9b46181c44e2176dd0917966742d9d4 Reviewed-on: https://chromium-review.googlesource.com/c/1322910Reviewed-by:
-
Marja Hölttä authored
The regressing change was: https://chromium-review.googlesource.com/c/v8/v8/+/1090922/17/src/heap/factory.cc This difference (empty list vs uninitialized) is important for other parts of the code, mainly JSObject::UnregisterPrototypeUser whose return value depends on this difference. Other parts of the CL already talk about + prepare for using Smi::kZero as a placeholder for "uninitialized" list. No regression test added since without this bug, the regressesion test doesn't crash but hangs. BUG=chromium:903245 Change-Id: Id3efe955fbd7e08cc4048d23c5b519c504f0201c Reviewed-on: https://chromium-review.googlesource.com/c/1328924Reviewed-by:
-
Benedikt Meurer authored
Previously we'd check `x` for -0 by testing `(1.0 / x) == -Infinity`, but this will yield the wrong results when `x` is a subnormal, i.e. really close to 0. In CSA we already perform bit checks to test for -0, so teach TurboFan to do the same for comparisons to -0 (via `Object.is`). We introduce a new NumberIsMinusZero simplified operator to handle the case where SimplifiedLowering already knows that the input is a number. Bug: chromium:903043, v8:6882 Change-Id: I0cb7c568029b461a92fc183104d5f359b4bfe7f4 Reviewed-on: https://chromium-review.googlesource.com/c/1328802 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57382}
-
Ulan Degenbaev authored
Currently the new space linear allocation area boundaries are fetched with sequentially consistent atomic loads. This can be replaced with an acquire load. Change-Id: Ib08e0bc0ae0ce79fee3723d29dc9a99a5d771880 Reviewed-on: https://chromium-review.googlesource.com/c/1326467Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57381}
-
Yang Guo authored
This allows Node.js to enable detailed source positions for optimized code early on, without having to pass a flag string. R=petermarshall@chromium.org Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75 Reviewed-on: https://chromium-review.googlesource.com/c/1319757 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57380}
-
Jakob Gruber authored
This is only used by ProfileEntryHookStub. For builtins, this also needs to go through an indirection. Bug: v8:6666 Change-Id: I088fa472e2d365ccfb2d027bfbdad182ffae487e Reviewed-on: https://chromium-review.googlesource.com/c/1326025Reviewed-by:
-
Clemens Hammacher authored
1) Use own test fixture {CancelableTaskManagerTest}. 2) Avoid base::AtomicWord. 3) Use unique_ptr. 4) Fix order of expected and actual values in EXPECT_EQ. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: I3d29785864bbf3de58c5d9d5384b9e0065255e99 Reviewed-on: https://chromium-review.googlesource.com/c/1325967 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:903562 Change-Id: I150dd598249ed3f55eaebab1d776669f70a93c1b Reviewed-on: https://chromium-review.googlesource.com/c/1327194Reviewed-by:
-
Michael Achenbach authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cae006c..3f61809 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1a1b38d..5d50916 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/75fa855..93cd73d Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/834113a..45f655f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7798243..31f2d26 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org The ICU roll also fixes a test that now passes. The status file has been changed. But: v8:8414 Change-Id: I82577bf6133176f2245b5562b71097fe3b222658 Reviewed-on: https://chromium-review.googlesource.com/c/1328003 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57376}
-
Jaroslav Sevcik authored
Change-Id: Ia1f47083689abb7d37c91098465a107a71f4dbea Reviewed-on: https://chromium-review.googlesource.com/c/1225757 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Tom Tan authored
Same as Windows x64, Windows ARM64 doesn't prefix assembly label with _. Bug: chromium:893460 Change-Id: I1b19a4e7ea16da3fe8bd1873509fffe3d067613a Reviewed-on: https://chromium-review.googlesource.com/c/1298376 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:893593 Change-Id: I5efafa57c8206982c4e5e4fa7442a3a05fb3c474 Reviewed-on: https://chromium-review.googlesource.com/c/1328641Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57373}
-
- 08 Nov, 2018 11 commits
-
-
Frank Tang authored
Split the case of 'ar-SA' into test/intl/regress-8432.js Bug: v8:8432, v8:8413 Change-Id: I6a0e3040b132be6620649c7b7aa5fdd2e0f07053 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng_triggered Reviewed-on: https://chromium-review.googlesource.com/c/1324574Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57372}
-
Sergiy Byelozyorov authored
This is useful to see exact command used to communicate with buildbucket and debug any triggering issues. R=machenbach@chromium.org Change-Id: I1630485ed128f757364d9c1f62b7f1d663db2ece Reviewed-on: https://chromium-review.googlesource.com/c/1325371Reviewed-by:
-
Yutaka Hirano authored
We are migrating streams implementation from JavaScript (v8Extra) to C++. One of missing features is an ability to set promise.[[PromiseIsHandled]] to true, used for example in https://streams.spec.whatwg.org/#rs-pipe-through. This CL introduces the feature. Bug: chromium:894357, chromium:888154, chromium:902633 Change-Id: If6487b29a74a212761e6d2ef04ef3ca0e6957dce Reviewed-on: https://chromium-review.googlesource.com/c/1322296Reviewed-by:
-
Jakob Kummerow authored
Behavior in Release mode was correct; Debug mode triggered a DCHECK failure that indicated an inefficiency: when a requested truncation would be a no-op, we should return the original BigInt, rather than creating a copy. In the special case of -2^(n-1), i.e. the smallest negative n-bit integer, getting truncated to n bits, with n being a multiple of kDigitBits, this shortcut was not taken. Bug: v8:8426 Change-Id: I8e4595d9ac0dbef81aae06688f9a9636bd2d9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1325029Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57369}
-
Caitlin Potter authored
Change the macros added in bf84766a to only do the hard work if FLAG_unbox_double_fields is unset (otherwise, they will attempt to dereference raw float64s, which is bad!) Also adds a write barrier in CopyPropertyArrayValues for each store if it's possible that a MutableHeapNumber is cloned. BUG=chromium:901301, chromium:902965, chromium:903070, v8:7611 R=cbruni@chromium.org, jkummerow@chromium.org, ishell@chromium.org Change-Id: I224d3c4e7b0a887684bff68985b4d97021ba4cfb Reviewed-on: https://chromium-review.googlesource.com/c/1323911 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7871 Change-Id: I287f4a365b5e1443652131e97bcd149f9e6fd623 Reviewed-on: https://chromium-review.googlesource.com/c/1324491Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8238 Change-Id: I03454ced41da35be9d389d843026ed5c0f7131fe Reviewed-on: https://chromium-review.googlesource.com/c/1326465 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Igor Sheludko authored
The rounding error occured in VirtualMemory class when the provided page allocator had bigger allocation page size than the commit page size and the VirtualMemory was requested to reserve an area of a size aligned only to commit page size. Bug: v8:8096 Change-Id: Ifb9b7fe5797881408d1bb9e95073991a42b62e80 Reviewed-on: https://chromium-review.googlesource.com/c/1327041Reviewed-by:
-
Toon Verwaest authored
- Mark arrow functions the uncommon assignment case - arrow formal parameter productions are ignored by default already - avoid duplicate is_destructuring_assignment branch - immediately pass expected productions into Accumulate Change-Id: Ifaeece53a1d6b99999ea298518702e82bc20db73 Reviewed-on: https://chromium-review.googlesource.com/c/1326941 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
It's too easy to implicitly cast it to bool, as we did in several tests. Also, move TryAbortResult out of CancelableTaskManager to avoid too much typing when referencing one of the enum values. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: Ia3fa8597428876217bc86f9b8b31c21ae4846fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1326027 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This allows the main ExpressionCoverGrammar parsing to be a little tighter. Change-Id: I45e3d1a9a647a98ffe1ad9969cb1ffbe47f67f1c Reviewed-on: https://chromium-review.googlesource.com/c/1326468 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
