- 15 Jul, 2015 14 commits
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1237953002 Cr-Commit-Position: refs/heads/master@{#29678}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1228113003 Cr-Commit-Position: refs/heads/master@{#29677}
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1225713003 Cr-Commit-Position: refs/heads/master@{#29676}
-
bmeurer authored
Bunch of cleanups to allow us to get rid of handles-inl.h at some point (in the not so far future); but more importantly to sanitize uses of handles and prepare for handle canonicalization support. R=yangguo@chromium.org Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222} Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 Cr-Commit-Position: refs/heads/master@{#29666} Review URL: https://codereview.chromium.org/1128533002 Cr-Commit-Position: refs/heads/master@{#29675}
-
rossberg authored
R=adamk@chromium.org, littledan@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1240463002 Cr-Commit-Position: refs/heads/master@{#29674}
-
machenbach authored
Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c Reland after https://codereview.chromium.org/1241643002/ TBR=jochen@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1237793003 Cr-Commit-Position: refs/heads/master@{#29673}
-
yangguo authored
By not having to patch the return sequence (we patch the debug break slot right before it), we don't overwrite it and therefore don't have to keep the original copy of the code around. R=ulan@chromium.org BUG=v8:4269 LOG=N Review URL: https://codereview.chromium.org/1234833003 Cr-Commit-Position: refs/heads/master@{#29672}
-
mvstanton authored
A sloppy mode eval call that establishes strict mode will leak that strictness into the sloppy surrounding scope on recompile. This changes the structure of the type feedback vector for the function and crashes follow. The fix is straightforward. BUG=491536, 503565 LOG=N Review URL: https://codereview.chromium.org/1231343003 Cr-Commit-Position: refs/heads/master@{#29671}
-
ishell authored
Reland "Enable loads and stores to global vars through property cell shortcuts installed into parent script context." Review URL: https://codereview.chromium.org/1237043006 Cr-Commit-Position: refs/heads/master@{#29670}
-
machenbach authored
Revert of [handles] Sanitize Handle and friends. (patchset #5 id:180001 of https://codereview.chromium.org/1128533002/) Reason for revert: [Sheriff] Still breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/2066 Original issue's description: > [handles] Sanitize Handle and friends. > > Bunch of cleanups to allow us to get rid of handles-inl.h at some > point (in the not so far future); but more importantly to sanitize uses > of handles and prepare for handle canonicalization support. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 > Cr-Commit-Position: refs/heads/master@{#28222} > > Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 > Cr-Commit-Position: refs/heads/master@{#29666} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1235253007 Cr-Commit-Position: refs/heads/master@{#29669}
-
ishell authored
Review URL: https://codereview.chromium.org/1231893007 Cr-Commit-Position: refs/heads/master@{#29668}
-
adamk authored
This makes Object.getOwnPropertyNames() return the integer keys in the proper order, following the spec: http://www.ecma-international.org/ecma-262/6.0/#sec-ordinary-object-internal-methods-and-internal-slots-ownpropertykeys BUG=v8:4118 LOG=n Review URL: https://codereview.chromium.org/1228803006 Cr-Commit-Position: refs/heads/master@{#29667}
-
bmeurer authored
Bunch of cleanups to allow us to get rid of handles-inl.h at some point (in the not so far future); but more importantly to sanitize uses of handles and prepare for handle canonicalization support. R=yangguo@chromium.org Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222} Review URL: https://codereview.chromium.org/1128533002 Cr-Commit-Position: refs/heads/master@{#29666}
-
littledan authored
This patch removes the MathMax call from String.prototype.includes in order to improve performance. With some quick and dirty benchmarking, (test case courtesy of the node folks) a sizable performance gain is visible: d8> function testIndexOf() { var stringArray = [ 'hello', 'world', '123', 'abc' ]; return stringArray.some(function(val, idx, arr) { return val.indexOf('world') !== -1 })} d8> function testIncludes() { var stringArray = [ 'hello', 'world', '123', 'abc' ]; return stringArray.some(function(val, idx, arr) { return val.includes('world') })} d8> function testTime(fn) { var before = Date.now(); fn(); return Date.now() - before; } d8> testTime(function() { for (var i = 0; i < 10000000; i++) { testIncludes() } }) 2244 d8> testTime(function() { for (var i = 0; i < 10000000; i++) { testIndexOf() } }) 2212 Compare that to before the test, when the performance difference was much larger: d8> testTime(function() { for (var i = 0; i < 10000000; i++) { testIndexOf() } }) 2223 d8> testTime(function() { for (var i = 0; i < 10000000; i++) { testIncludes() } }) 2650 In my runs, performance of both functions drifts up and down, but running them in quick succession back and forth shows a roughly consistent delta of about this magnitude. String.prototype.includes is still slightly (maybe 5%) slower than String.prototype.indexOf, but the effect is significantly reduced. R=adamk BUG=v8:3807 LOG=Y Review URL: https://codereview.chromium.org/1231673008 Cr-Commit-Position: refs/heads/master@{#29665}
-
- 14 Jul, 2015 26 commits
-
-
binji authored
See http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4695/steps/Check%20%28flakes%29/logs/d8-worker-sharedarray.. BUG=v8:4306 R=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true LOG=n Review URL: https://codereview.chromium.org/1241713003 Cr-Commit-Position: refs/heads/master@{#29664}
-
binji authored
Reland of d8 workers: make sure Shell::Quit is only called once (patchset #1 id:1 of https://codereview.chromium.org/1235083004/) Reason for revert: Looks like the failure is unrelated to my change (still fails after the revert). See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/856/steps/webkit_unit_tests/logs/stdio Original issue's description: > Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5 id:80001 of https://codereview.chromium.org/1230403003/) > > Reason for revert: > Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio > > Original issue's description: > > d8 workers: make sure Shell::Quit is only called once > > > > When running with isolates, Quit can be called simultaneously by two threads. > > If this happens, then both threads try to clean up the Workers, which could > > crash. > > > > BUG=v8:4279 > > R=jarin@chromium.org > > R=machenbach@chromium.org > > LOG=n > > > > Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c > > Cr-Commit-Position: refs/heads/master@{#29654} > > TBR=jarin@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4279 > > Committed: https://crrev.com/6b2c6eb75678747afca59b4a78ace597e218145d > Cr-Commit-Position: refs/heads/master@{#29656} TBR=jarin@chromium.org,machenbach@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4279 Review URL: https://codereview.chromium.org/1224203004 Cr-Commit-Position: refs/heads/master@{#29663}
-
littledan authored
Duplicate parameters are banned both overall in strict mode and also in arrow functions. Our error message for both cases blamed strict mode, which is confusing. This patch fixes the message to point to arrow functions as a possible source as well. R=wingo, adamk LOG=N Review URL: https://codereview.chromium.org/1236863008 Cr-Commit-Position: refs/heads/master@{#29662}
-
littledan authored
For destructuring bind, the parser needs to complain about things which are inappropriate to have on the left-hand side. Previously, regexp literals and template literals were let through the parser inappropriately. This patch turns those into errors. This patch also fixes off-by-one errors in reporting the location of this type of error for strings and numbers. Before the patch, the error would look like: d8> var {x: 3} = {x: 4} (d8):1: SyntaxError: Unexpected number var {x: 3} = {x: 4} ^ SyntaxError: Unexpected number And with the patch, the error is d8> var {x: 3} = {x: 4} (d8):1: SyntaxError: Unexpected number var {x: 3} = {x: 4} ^ SyntaxError: Unexpected number R=rossberg Review URL: https://codereview.chromium.org/1236803003 Cr-Commit-Position: refs/heads/master@{#29661}
-
bbudge authored
Adds SameValue and SameValueZero functions for float and double. These will be used for HeapNumber and SIMD values. LOG=N BUG=v8:4124 Review URL: https://codereview.chromium.org/1234073003 Cr-Commit-Position: refs/heads/master@{#29660}
-
mbrandy authored
Labels which are not associated with branches (e.g. labels which record the location of the embedded constant pool or jump tables) should not be tracked for the purpose of trampoline generation. This also improves management of the high water mark in the buffer which triggers trampoline generation such that it is reset whenever the number of tracked branches drops to zero. These changes should help minimize unnecessary trampoline and (subsequent) slow branch generation. R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1237213002 Cr-Commit-Position: refs/heads/master@{#29659}
-
binji authored
Note: the previous try was reverted for occasional flaky tests. This continued after the revert, and should be fixed by https://codereview.chromium.org/1226143003. Previously, the serialization code would call Externalize for every transferred ArrayBuffer or SharedArrayBuffer, but that function can only be called once. If the buffer is already externalized, we should call GetContents instead. Also fix use-after-free bug when transferring ArrayBuffers. The transferred ArrayBuffer must be internalized in the new isolate, or be managed by the Shell. The current code gives it to the isolate externalized and frees it immediately afterward when the SerializationData object is destroyed. BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1223813008 Cr-Commit-Position: refs/heads/master@{#29658}
-
adamk authored
Return both --harmony-spreadcalls and --harmony-spread-arrays to staging, in preparation for disabling those features on the M45 branch. There are no known bugs in spread calls, but without rest and spread arrays it seems appropriate to leave all of them out rather than only supporting a singular use of the '...' operator. BUG=v8:4298 LOG=y Review URL: https://codereview.chromium.org/1230773005 Cr-Commit-Position: refs/heads/master@{#29657}
-
binji authored
Revert of d8 workers: make sure Shell::Quit is only called once (patchset #5 id:80001 of https://codereview.chromium.org/1230403003/) Reason for revert: Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio Original issue's description: > d8 workers: make sure Shell::Quit is only called once > > When running with isolates, Quit can be called simultaneously by two threads. > If this happens, then both threads try to clean up the Workers, which could > crash. > > BUG=v8:4279 > R=jarin@chromium.org > R=machenbach@chromium.org > LOG=n > > Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c > Cr-Commit-Position: refs/heads/master@{#29654} TBR=jarin@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4279 Review URL: https://codereview.chromium.org/1235083004 Cr-Commit-Position: refs/heads/master@{#29656}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1228373004 Cr-Commit-Position: refs/heads/master@{#29655}
-
binji authored
When running with isolates, Quit can be called simultaneously by two threads. If this happens, then both threads try to clean up the Workers, which could crash. BUG=v8:4279 R=jarin@chromium.org R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1230403003 Cr-Commit-Position: refs/heads/master@{#29654}
-
binji authored
The length property can be monkey-patched, so use the native function instead. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1227913006 Cr-Commit-Position: refs/heads/master@{#29653}
-
balazs.kilvady authored
BUG= Review URL: https://codereview.chromium.org/1237753004 Cr-Commit-Position: refs/heads/master@{#29652}
-
ishell authored
Follow-up for "Enable loads and stores to global vars through property cell shortcuts installed into parent script context." Review URL: https://codereview.chromium.org/1236523004 Cr-Commit-Position: refs/heads/master@{#29651}
-
verwaest authored
Remove duplicate flattening. Defining accessors doesn't call out, so don't assert that the context doesn't change. BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1233073003 Cr-Commit-Position: refs/heads/master@{#29650}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1228803005 Cr-Commit-Position: refs/heads/master@{#29649}
-
verwaest authored
BUG=chromium:509961 LOG=n Review URL: https://codereview.chromium.org/1241613003 Cr-Commit-Position: refs/heads/master@{#29648}
-
mstarzinger authored
This adapts JSCallConstruct nodes to represent both, ordinary 'new' constructor calls as well as 'super' constructor calls. Note that we still bailout for super calls for now. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1234023003 Cr-Commit-Position: refs/heads/master@{#29647}
-
conradw authored
BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1235983002 Cr-Commit-Position: refs/heads/master@{#29646}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1238533003 Cr-Commit-Position: refs/heads/master@{#29645}
-
chunyang.dai authored
port 01f40e6a (r29618). original commit message: BUG= Review URL: https://codereview.chromium.org/1233033004 Cr-Commit-Position: refs/heads/master@{#29644}
-
chunyang.dai authored
port 6ddcd327 (r29617) original commit message: Cleanup Generate_JSConstructStubHelper a bit. BUG= Review URL: https://codereview.chromium.org/1237013002 Cr-Commit-Position: refs/heads/master@{#29643}
-
chunyang.dai authored
port 0a19e449 (r29568) original commit message: If we do it too early, we might get a constant pool between the reloc info and the actual slot. Review URL: https://codereview.chromium.org/1228923003 Cr-Commit-Position: refs/heads/master@{#29642}
-
chunyang.dai authored
port a0129a25 (r29591). original commit message: BUG= Review URL: https://codereview.chromium.org/1232383003 Cr-Commit-Position: refs/heads/master@{#29641}
-
verwaest authored
Remove map-copying for global objects. This was an old (broken) requirement that has been fixed for a while. BUG= Review URL: https://codereview.chromium.org/1235113002 Cr-Commit-Position: refs/heads/master@{#29640}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1222223002 Cr-Commit-Position: refs/heads/master@{#29639}
-