- 08 Apr, 2021 10 commits
-
-
Sara Tang authored
This CL implements the equivalent of ETW in macos (called Signposts) Bug: v8:11043 Change-Id: Ifa72cfd17fca81b18e3e8b1003fd6ab72de3c986 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807157 Commit-Queue: Sara Tang <sartang@microsoft.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#73856}
-
Victor Gomes authored
https://github.com/tc39/proposal-error-cause Bug: chromium:1192162 Change-Id: If6e2d1f105bb520104bb832ccbc7f660bb8115a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784681 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73855}
-
Michael Lippautz authored
The only valid way to define a GCed type T is by inheriting from GarbageCollected<T>. Since this is prone to typos (see tests), add a simple check that covers most interesting use cases. The static assert covers A -> B -> GarbageCollected<C> The static assert does not cover A -> B -> C -> GarbageCollected<B> (In order to do so, we would need __direct_bases() support which is not yet available for C++.) Bug: pdfium:1670, chromium:1056170 Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73854}
-
Thibaud Michaud authored
This is a reland of f645d0b8 The issue was that converting an i64 to an i32 didn't clear the upper bits on arm64. This was not necessary before because we did the zero extension as part of the load operand, but this is required now that we use the full register. Original change's description: > [liftoff][arm64] Use 64 bit offset reg in mem op > > Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, > which is fine if we check bounds first, but not if we rely on the > trap handler to catch the OOB. > > R=clemensb@chromium.org > > Bug: v8:11587 > Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73829} Bug: v8:11587 Change-Id: Ibc182475745c6f697a0ba6d75c260b74ddf8fe52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810846Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73853}
-
Maya Lekova authored
This CL adds handling of unexpected argument types to the functions provided by d8.test.fast_c_api. Bug: chromium:1196598 Change-Id: I7c62280f168817b73e89fdb7457ee9054b51a318 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808948Reviewed-by:
-
Jakob Gruber authored
This is part of moving towards MapUpdater as the bottleneck for map updates. Drive-by: Move helpers. Drive-by: Use a plain std::queue instead of a ZoneQueue in UpdateFieldType. Bug: v8:7790 Change-Id: Iff80a6e9bf3390a010305f7998d6f6dad2bce09f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807602 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73851}
-
Igor Sheludko authored
This CL fixes a segfault when Wasm tried to generate a builtin call from background compilation job when the Isolate was already teared down by the main thread. Drive-by: Use CallBuiltin in RegExpMacroAssemblerARM64. Bug: v8:11527, chromium:1195552 Change-Id: I8048ffcb212bda4d19d07b5ec6b487d6fb16b30d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811739 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73850}
-
Jakob Gruber authored
Lookarounds rewind the position after matching, and thus don't play well with eats_at_least (EAL). This CL disables EAL propagation from lookarounds. In the future we could be a bit smarter by skipping over lookarounds instead of resetting to 0. Bug: v8:11290 Change-Id: I935400a7f9cda96d9c5a80e412ba7d04de70a84f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808944Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73849}
-
Jakob Gruber authored
The eats_at_least (EAL) value is applied in forward-directions only. Two reasons for that which are relevant to this CL: - EAL's of neighboring nodes are combined additively, irrespective of their read_backward value. - EatsAtLeastPropagator::VisitText uses the successor's eats_at_least_from_not_start value, which doesn't work properly for read_backwards successors (which may end at the start). A symptom of this bug was that we applied an incorrect EAL of 255 starting at the initial 'x' of /x(?<=^x{4})/); for subject strings shorter than 255 chars, this would result in an incorrect failure result. Bug: v8:11616 Change-Id: I4b2b1b78f0cea8f59e4beb1037ee46035d83c927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807596Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/52bfb9d..77edba1 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/a136a3b..d0f3388 Rolling v8/third_party/aemu-linux-x64: RQd3qSR12Rp6wgHjC31u-jwbITCfk3M-ZJyL6s1ju4sC..SeLS6a0f6IL-PCOUKbMTN5LYgjjJbDSnb3DGf5q9pwsC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3f562c0..98a52e2 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d879aac..81d6568 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/6900bf4..084aee0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c9e9ef51ca70bdab1bf6cd0b5d1c178177fb137 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811464Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73847}
-
- 07 Apr, 2021 30 commits
-
-
Z Nguyen-Huu authored
Change-Id: I8ea9403fa2ae8d45300c291a6d9a55b9293e7c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2805731 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Junliang Yan authored
Change-Id: Id5dd7a33b4d64cb73ccc4f5c1457f8a28905d814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810885Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73845}
-
Camillo Bruni authored
Change-Id: Ibe7d571ee057eb9229d74922f94b9791be953b08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2786845 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: Ia4eebe80bdac6a89b2c4c4b072d7e61240755973 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810416Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:1195977 Change-Id: I16843bce2e9f776abca0f2b943b898ab5e597e42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810787Reviewed-by:
-
Deepti Gandluri authored
Bug: v8:11613 Change-Id: Ib1ad2dc7bb7235b5f8ef5068a5d3175556d1a65b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2806547Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#73841}
-
Ng Zhi An authored
If SSE4.2 is enabled, all the previous extensions should also be enabled. In particular, you cannot have --enable-sse4_1 and --no-enable-sse3. Bug: chromium:1195579 Change-Id: Id3e10db24cee2aee14449a77c9e7cff82e97edff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808621Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This CL completes Jobs cleanup for deprecated and pure virtual functions in v8 platform. Bug: chromium:1196703 Change-Id: I823ab06b56077181e92eee5a6468096a355634fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810155Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#73839}
-
Etienne Pierre-doray authored
Now that all users are migrated to Jobs API. Bug: chromium:1196703 Change-Id: Ic48cce441c1793b1b33f0fc3d6a60847f2eefb2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810156 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
-
Milad Fa authored
From PPC ABI: >The condition code register fields CR0, CR1, CR5, CR6, and CR7 are volatile. The condition code register fields CR2, CR3, and CR4 are nonvolatile. We can safely clear Cr field 6 without the need to save its content first. Clearing the entire CR register will cause crashes if it's not restored properly. Change-Id: I854f5631294f56f542b1a6f4e23dd7dbcf000d7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810802Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73837}
-
Benedikt Meurer authored
The inspector has some magic to add a special __proto__ property to object value mirrors as long as the object itself has a [[Prototype]]. However it doesn't check whether the object already has a regular property named __proto__ and thus confuses the front-end by sending two properties with the same name. Fixed: chromium:1193250 Change-Id: I75a1cd78ba94aeda4afedcc0f1e69b8dadb6673f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810784 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#73836}
-
Michael Achenbach authored
This reverts commit f645d0b8. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release/3544 Original change's description: > [liftoff][arm64] Use 64 bit offset reg in mem op > > Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, > which is fine if we check bounds first, but not if we rely on the > trap handler to catch the OOB. > > R=clemensb@chromium.org > > Bug: v8:11587 > Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73829} Bug: v8:11587 Change-Id: If7396981d43833f32ebc525c20abdbe78020e717 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810785 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73835}
-
Dominik Inführ authored
IMHO kStackRoots is more descriptive than kTop. Change-Id: I9eeffa6974ae0188021cb1628c2b21e691ab9490 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810782Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Add a flag similar to the tiering mask to choose between regular baseline code or debug code in Liftoff. R=clemensb@chromium.org Bug: chromium:1183774 Change-Id: I0e87154e2e1cd57679ce0c57bb1e075a97691248 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807603Reviewed-by:
-
Clemens Backes authored
If bounds checks are completely disabled (for performance testing) we would still emit protected instructions which generate landing pads for trap handlers in code generation. This CL fixes that by implicitly disabling trap handling if stack checks are disabled. R=ahaas@chromium.org Bug: v8:10949 Change-Id: I1172087fb14ab56e9117c6eee388f71099568a13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808946Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Maya Lekova authored
This CL fixes the behaviour of the d8.test.fast_c_api constructor when the global object has been modified by not allowing calls to it without the `new` keyword. Bug: chromium:1196597 Change-Id: I49b4a412d501f5c9adaa72b63beec1483ab4c449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808943 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Change-Id: Ic00ce0856d6ce3f9c6872fa7f35c469f7177c9c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807605 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#73830}
-
Thibaud Michaud authored
Accessing the Wasm memory with a 64 bit offset was truncated to 32 bit, which is fine if we check bounds first, but not if we rely on the trap handler to catch the OOB. R=clemensb@chromium.org Bug: v8:11587 Change-Id: I82a3a2906e55d9d640c30e770a5c93532e3a442c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808942Reviewed-by:
-
Junliang Yan authored
Change-Id: I440b3bdabddce862a45127df4c72846c1f5c7fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808555Reviewed-by:
-
Leszek Swirski authored
Example usage: tools/find-builtin LoadIC | xargs code -g Change-Id: I12c15d3d4a80edbcddfa9cc8b9a515b839c96fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808949 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Dan Elphick authored
ARM is often defined as a macro so this changes it to kArm and fixes other cases in the same file. Bug: v8:11384 Change-Id: Iab0149be03b3b0139e3335b91a25cb4bbb2f56e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808939 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Until now we've only exposed trace output for the parse- and assembly stages of regexp codegen. Debug tracing of the graph was missing. The new --trace-regexp-graph flag fills that hole. Available regexp codegen tracing flags are now: --trace-regexp-parser --trace-regexp-graph --trace-regexp-assembler The output of --trace-regexp-graph can be formatted with `dot`, for example: $ d8 --trace-regexp-graph [...] | dot -Tjpg -o regexp-graph.jpg Change-Id: Ice593c34f7818c94e42d98e98a31533178bb538b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808945 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73825}
-
Manos Koukoutos authored
Since wrappers do not get optimized, https://chromium-review.googlesource.com/c/v8/v8/+/2739976 introduced some performance regression by not caching nodes in the WasmGraphBuilder. Therefore, we reintroduce caching of the instance node. We do it in Start() to ensure the effect chain is correct. Additional changes: - Change signature of Start() to void. - Initialize effect and control in Start(). - Rename BuildLoadInstance() -> GetInstance(). Bug: chromium:1189100 Change-Id: I9147f738e67b4f4b822c845e7d33d9fd4ceb65fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2804679 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Change-Id: Ifca0084272ec1f5ec781452c2a54d25cb4e80c95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807718Reviewed-by:
-
Maya Lekova authored
This CL disables exposing the d8.test.fast_c_api constructor when we're doing correctness fuzzing to prevent TypeError when the object is not defined (which happens when --turbo-fast-api-calls is not passed). Bug: chromium:1196569 Change-Id: I39069c736d11326419b7562189931afc69a485b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808940Reviewed-by:
-
Sara Tang authored
Guard system-instrumentation with V8_OS_WIN instead of V8_TARGET_OS_WIN. Re-enable ENABLE_SYSTEM_INSTRUMENTATION Bug: v8:11043, chromium:1196278 Change-Id: I3c3ab07de909ad5b58dd9a99740ff5f59ab8165f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2809530Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
-
Patrick Thier authored
Add check, that passed argument is a HeapObject. Bug: chromium:1196503 Change-Id: I23d951b5581781ad3c6867d81c765d13c329d3a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808936 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Maya Lekova authored
This CL skips the fast-api-calls mjsunit test, as it relies on particular optimization/deoptimization patterns. Bug: v8:11620 Change-Id: I4c2fd3b1db8aff73935dd6525fd0ad3edc307dd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2808935 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73819}
-
Frank Tang authored
Somehow we have no-NO-NY locale data in ICU and cause problem. Bug: v8:11595 Change-Id: I68ba4c4c219bb3fbc88976f901a86219c44ea265 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782602Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#73818}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/7af6071..cab90cb Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f95480f..52bfb9d Rolling v8/buildtools/linux64: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92 Rolling v8/third_party/aemu-linux-x64: RDM8t3fsvkJHrC_GtCTB1D0dnK1Xv1ZqnZI2DXJ6_4wC..RQd3qSR12Rp6wgHjC31u-jwbITCfk3M-ZJyL6s1ju4sC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/13c4bd1..41a5e5e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/da76875..3f562c0 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/db62979..a387faa TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I887fb192791aac410a5311afc6e707d60347c203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2809940Reviewed-by:
-
