- 14 Apr, 2016 30 commits
-
-
machenbach authored
BUG=chromium:603131 LOG=y Review URL: https://codereview.chromium.org/1886983002 Cr-Commit-Position: refs/heads/master@{#35487}
-
yangguo authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/1889803002 Cr-Commit-Position: refs/heads/master@{#35486}
-
mlippautz authored
- Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed This reverts commit 6df04b29. BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Review URL: https://codereview.chromium.org/1891683002 Cr-Commit-Position: refs/heads/master@{#35485}
-
ishell authored
BUG=v8:4915 LOG=N Review URL: https://codereview.chromium.org/1891633003 Cr-Commit-Position: refs/heads/master@{#35484}
-
ahaas authored
R=mstarzinger@chromium.org BUG=v8:4914 LOG=n Review URL: https://codereview.chromium.org/1886173003 Cr-Commit-Position: refs/heads/master@{#35483}
-
mstarzinger authored
This removes the flag in question. It just duplicates the corresponding compilation hint in the underlying SharedFunctionInfo object. Now that the backends should have a SharedFunctionInfo available most of the time it is safe to use the cannonical predicate. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1883583002 Cr-Commit-Position: refs/heads/master@{#35482}
-
yangguo authored
There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=mstarzinger@chromium.org Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d Cr-Commit-Position: refs/heads/master@{#35257} Review URL: https://codereview.chromium.org/1854713002 Cr-Commit-Position: refs/heads/master@{#35481}
-
rmcilroy authored
Modifies Ignition to store code entry addresses in the dispatch table rather than code objects. This allows the interpreter to avoid calculating the code entry address from the code object on every dispatch and provides a ~5-7% performance improvement on Octane with Ignition. This change adds ArchOpcode::kArchTailCallAddress to TurboFan to enable tail call dispatch using these code addresses. It also adds a Dispatch linkage creator (distinct from the stub linkage type used previously) to allow targetting a code address target (which will diverge further from the stub linkage type when we remove the context machine register in Ignition). BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1882073002 Cr-Commit-Position: refs/heads/master@{#35480}
-
epertoso authored
Replaces the HCallRuntime instruction in HGraphBuilder::BuildBinaryOperation with a call to the corresponding TurboFan stub. Review URL: https://codereview.chromium.org/1884103002 Cr-Commit-Position: refs/heads/master@{#35479}
-
zhengxing.li authored
port e6b6e554 (r35163) original commit message: In the earlier implementation of GenerateDoubleToObject the context is loaded from the parent's frame. rsi is clobbered because it is used to store kHoleNan constnat. It is not always safe to peek at the parents frame. Bytecode handlers have TypedFrame and the type of frame is stored at FP + 1. GenerateDoubleToObject expects context to be store at that place. In the current implementation rsi is pushed onto the stack and is popped when exiting this function. BUG= Review URL: https://codereview.chromium.org/1884873007 Cr-Commit-Position: refs/heads/master@{#35478}
-
mstarzinger authored
This makes sure that when cached optimized code is found while doing lazy compilation via Compiler::Compile installs any existing literals array as well. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1879973005 Cr-Commit-Position: refs/heads/master@{#35477}
-
zhengxing.li authored
port f954934d (r35140) original commit message: BUG= Review URL: https://codereview.chromium.org/1886243002 Cr-Commit-Position: refs/heads/master@{#35476}
-
mythria authored
Removes skips for two tests that no longer fail on windows system. Updates description of another failing test with more details. BUG=v8:4280,v8:4680 LOG=N Review URL: https://codereview.chromium.org/1878893004 Cr-Commit-Position: refs/heads/master@{#35475}
-
mlippautz authored
To keep track of memory characteristics of a JS program use GetHeapSpaceStatistics from a combination of - a GC epilogue callback registered using AddGCEpilogueCallback - an interrupt registered using RequestInterrupt Rationale: The feature is currently broken as those callbacks are (also) executed from background threads, breaking our implicit contract for only performing callbacks on the foreground thread. Furhtermore, it's not clear for the embedder whether these allocations originate in JS, or are required for a GC. Note: - The already deprecated non-isolate versions are removed with this CL. R=jochen@chromium.org BUG=v8:4813 LOG=Y Review URL: https://codereview.chromium.org/1886573006 Cr-Commit-Position: refs/heads/master@{#35474}
-
zhengxing.li authored
port 53d51c52 (r35139) original commit message: Removed Frame::needs_frame and the function-wide logic using it in favor of FrameAccessState::has_frame, which can be set on a more granular level, and driving it block by block. BUG= Review URL: https://codereview.chromium.org/1886963002 Cr-Commit-Position: refs/heads/master@{#35473}
-
mstarzinger authored
This removes one of the duplicated pipeline implementation from the compiler. By now we can reuse the existing CompileForDebugging for all compilations being kicked off for debugging. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1885063002 Cr-Commit-Position: refs/heads/master@{#35472}
-
mstarzinger authored
The compiler hints in question are already correctly initialized by the NewSharedFunctionInfoForLiteral function. Reinitializing them again here is no longer needed by now. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1887673002 Cr-Commit-Position: refs/heads/master@{#35471}
-
machenbach authored
Port https://codereview.chromium.org/1886493002 BUG=chromium:603011, chromium:603131 LOG=n TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1880423003 Cr-Commit-Position: refs/heads/master@{#35470}
-
bmeurer authored
At some point we thought about using this instead of JSToNumber, but now there doesn't seem to be any reason for this anymore. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1890763002 Cr-Commit-Position: refs/heads/master@{#35469}
-
verwaest authored
This should bring back the performance of speedometer-backbone at least very close to the performance before @@species. BUG=chromium:596825 LOG=n Review URL: https://codereview.chromium.org/1879053003 Cr-Commit-Position: refs/heads/master@{#35468}
-
bradnelson authored
Collecting: Time histograms for: instantiate, decode module, decode function, compile, compile function. Memory histograms for: decode peak, instantiate peak, compile function peak, min mem pages, max mem pages, function bytes, module bytes. Range histograms of: functions per module. BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167 TEST=None R=ahaas@chromium.org,bmeurer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1866873002 Cr-Commit-Position: refs/heads/master@{#35467}
-
ahaas authored
We use the cvttsd2si (float64-to-int32) instruction to avoid that negative numbers get sign extended in the destination register. @rodolph: Is sign extension also a thing on arm64? I noticed that also on arm64 a float64-to-int64 instruction is used. Review URL: https://codereview.chromium.org/1877133004 Cr-Commit-Position: refs/heads/master@{#35466}
-
machenbach authored
BUG=v8:4751 LOG=n NOTRY=true TBR=adamk@chromium.org, rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1891693002 Cr-Commit-Position: refs/heads/master@{#35465}
-
zhengxing.li authored
The CL #35139 (https://codereview.chromium.org/1775323002) added V8_TARGET_ARCH_IA32 macro in src/globals.h. X87 is almost same as IA32, So It needs the V8_TARGET_ARCH_X87 macro in src/globals.h too. BUG= Review URL: https://codereview.chromium.org/1886233002 Cr-Commit-Position: refs/heads/master@{#35464}
-
v8-autoroll authored
Rolling v8/build/gyp to 6ea68631cdabab9b7c5257657567a785a261692e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1886223002 Cr-Commit-Position: refs/heads/master@{#35463}
-
mbrandy authored
Port 5e9ddf6c Original commit message: * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 R=binji@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG=v8:4614 LOG=N Review URL: https://codereview.chromium.org/1887823002 Cr-Commit-Position: refs/heads/master@{#35462}
-
mbrandy authored
Port 9336f4cc Original commit message: This is useful for escape analysis, and helps upcoming changes to type feedback gathering. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1883743004 Cr-Commit-Position: refs/heads/master@{#35461}
-
joransiu authored
* Use proper int64_t printf format qualifier to fix 64-bit sim compile on Mac. * Minor cleanup to ExecuteInstruction() to remove an unncessary 'processed' variable. R=jyan@ca.ibm.com,mbrandy@us.ibm.com,michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1889643002 Cr-Commit-Position: refs/heads/master@{#35460}
-
adamk authored
R=littledan@chromium.org Review URL: https://codereview.chromium.org/1836183002 Cr-Commit-Position: refs/heads/master@{#35459}
-
aseemgarg authored
BUG=v8:4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,bradnelson@chromium.org,ahaas@chromium.org LOG=N Review URL: https://codereview.chromium.org/1887833002 Cr-Commit-Position: refs/heads/master@{#35458}
-
- 13 Apr, 2016 10 commits
-
-
jyan authored
size_t defined as unsigned long on 31-bit s390. R=jochen@chromium.org, jfb@chromium.org TBR=ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/1889623002 Cr-Commit-Position: refs/heads/master@{#35457}
-
robtsuk authored
Fixes for misnamed toolchain from https://github.com/appcelerator/v8_titanium. Added a way to specify the NDK path since the Mac versions of the NDK aren't checked into the tools repo. Disabled a few dependencies which do not build on the Mac but which aren't needed for building usable V8 static libraries. Made the including of libdl and librt omitted for Mac hosted builds. BUG= Review URL: https://codereview.chromium.org/1879793002 Cr-Commit-Position: refs/heads/master@{#35456}
-
aseemgarg authored
This change implements switch as a balanced if/else tree or break table or hybrid. A lot of asm.js modules are expected to extensively use switch alongside function tables that can benefit from a better implementation. BUG=v8:4203 TEST=mjsunit/asm-wasm R=titzer@chromium.org,bradnelson@chromium.org,ahaas@chromium.org LOG=N Review URL: https://codereview.chromium.org/1838973002 Cr-Commit-Position: refs/heads/master@{#35455}
-
mlippautz authored
Revert of [heap] Better integrate handling of aborted compaction pages (patchset #7 id:130001 of https://codereview.chromium.org/1881423003/ ) Reason for revert: Breaks: https://uberchromegw.corp.google.com/i/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/20 RecordMigratedSlotVisitor is not safe to use on code pages. Original issue's description: > [heap] Better integrate handling of aborted compaction pages > > - Get rid of fixing up pointers on the main thread > - Get rid of sweeping on the main thread > > Instead: > - Record (and process afterwards) slots in parallel > - Add the pages to the concurrent sweeper as pointers have already been fixed > > BUG=chromium:581412 > LOG=N > TEST=cctest/test-compaction/* > > Committed: https://crrev.com/2e4f57774d4993f9f98332d3b2469280ee10beca > Cr-Commit-Position: refs/heads/master@{#35451} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Review URL: https://codereview.chromium.org/1890553002 Cr-Commit-Position: refs/heads/master@{#35454}
-
binji authored
Reland of (https://codereview.chromium.org/1617503003) * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG=v8:4614 LOG=y TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,machenbach@chromium.org Review URL: https://codereview.chromium.org/1617503003 Cr-Commit-Position: refs/heads/master@{#35427} Review URL: https://codereview.chromium.org/1881383003 Cr-Commit-Position: refs/heads/master@{#35453}
-
machenbach authored
BUG=chromium:603011,chromium:603131 LOG=n Review URL: https://codereview.chromium.org/1880383003 Cr-Commit-Position: refs/heads/master@{#35452}
-
mlippautz authored
- Get rid of fixing up pointers on the main thread - Get rid of sweeping on the main thread Instead: - Record (and process afterwards) slots in parallel - Add the pages to the concurrent sweeper as pointers have already been fixed BUG=chromium:581412 LOG=N TEST=cctest/test-compaction/* Review URL: https://codereview.chromium.org/1881423003 Cr-Commit-Position: refs/heads/master@{#35451}
-
Ilija.Pavlovic authored
Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. Port 52148c41 TEST= BUG= Review URL: https://codereview.chromium.org/1886723003 Cr-Commit-Position: refs/heads/master@{#35450}
-
ofrobots authored
Left trimming assumes that nobody other than the JSArray has a reference to the backing store. Sampling heap profiler may profile the backing store and keep a reference too it. This reference was never updated on a left-trim, causing a crash. R=alph@chromium.org, hpayer@chromium.org, mattloring@google.com BUG= Review URL: https://codereview.chromium.org/1885723002 Cr-Commit-Position: refs/heads/master@{#35449}
-
mlippautz authored
- Get rid of temp lists and use a lock-protected deque instead BUG= Review URL: https://codereview.chromium.org/1886723002 Cr-Commit-Position: refs/heads/master@{#35448}
-