- 01 Aug, 2018 11 commits
-
-
Clemens Hammacher authored
All compile tasks are already canceled when the {CompilationState} dies. This happens when the {NativeModule} dies, and all {NativeModule}s die before the {WasmEngine} dies. Thus, the WasmEngine does not need to cancel any compile jobs, because there are none anyway. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I7e006392a1f9126333733c81c4c19985f626a470 Reviewed-on: https://chromium-review.googlesource.com/1158411Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54840}
-
Clemens Hammacher authored
We currently don't execute the tests on android, because the error message is redirected to the android log. What we can still to though is ensuring that the call aborts the process, but just ignore the error message. R=mstarzinger@chromium.org Bug: chromium:863799 Change-Id: I54b503849358133ffe647be83eae7a964c2ac49e Reviewed-on: https://chromium-review.googlesource.com/1148444 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This changes the WebAssembly serializer to take a full snapshot of the code table before measuring and serializing the module. It allows other threads (or other Isolates) to mutate the native module while the main thread is serializing the module. R=clemensh@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I64bc27600452880f37f4fbb2f40c77c79975358f Reviewed-on: https://chromium-review.googlesource.com/1156596 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54838}
-
Clemens Hammacher authored
This moves the {ReadUnalignedValue} and {WriteUnalignedValue} methods from utils.h to v8memory.h. R=titzer@chromium.org Bug: v8:7754, v8:7490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8becfc3ac169427968c11e24b035a90856f51e8e Reviewed-on: https://chromium-review.googlesource.com/1158405Reviewed-by:Ben Titzer <titzer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54837}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I9389bc60eab8283d9b70a49a9a71c6d092146de0 Reviewed-on: https://chromium-review.googlesource.com/1158071Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Change-Id: I9b54049852696680fb7fde26813638aae727b5d3 Reviewed-on: https://chromium-review.googlesource.com/1158231Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54835}
-
Andreas Haas authored
This is the second V8 CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. R=mstarzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 Reviewed-on: https://chromium-review.googlesource.com/1143187 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
The original implementation of 'testAsync' in mjsunit.js required to put the call to '%AbortJS' into an 'eval' statement. The reason is that this call requires the flag --allow-natives-syntax to be set, but the flag is not set in all mjsunit tests. With the use of 'eval' compilation errors can be avoided. The problem with this approach was that the fuzzer started to produce test cases which include the line 'eval("%AbortJS(message)");', and this line crashes intentionally. Different to the line '%Abort(message)', however, the 'eval' statement cannot be filtered so easily in the fuzzer. Therefore I pulled the implementation of 'testAsync' into a separate file to avoid the 'eval'. Additional changes: I use '===' now instead of 'deepEquals' in AsyncAssertion.equals because 'deepEquals' is not available outside mjsunit.js. Using '===' seems more appropriate anyways because for all tests but one it is sufficient, and it is more precise than deepEquals. R=gsathya@chromium.org Bug: chromium:774841 Change-Id: I47270aa63ff5a1d6aa76a771f9276eaaf579c5ac Reviewed-on: https://chromium-review.googlesource.com/1156598Reviewed-by:Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54833}
-
Sathya Gunasekaran authored
Similar to existings helpers like SetProperty, WriteToReadOnlyProperty, etc, this create an helper for CreateDataProperty that abstracts away the LookupIterator. Bug: v8:5751 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5ca02a2bad982adf233f3ea9de799e5706cd248a Reviewed-on: https://chromium-review.googlesource.com/1156400Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54832}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3e09e23..e9eade2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/65f883b..5c2d9e7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b0e855a..6f812e1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/24c4916..af36d66 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I80e0c172cd95e10c9d445ebe8ae563c9c799c047 Reviewed-on: https://chromium-review.googlesource.com/1157881Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54831}
-
Caitlin Potter authored
An object with a deprecated Map which has already been cached in CloneObjectIC feedback is still a valid Map for fast cloning --- but to be consistent with other ICs, deprecated maps are ignored, and are expected to be transitioned away from. If the source object has a deprecated map, the instance is migrated. BUG=v8:7611, chromium:867958, chromium:868586, chromium:869342, chromium:869347, chromium:869293 R=jkummerow@chromium.org, mvstanton@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1154143 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#54799} Change-Id: I6e2f7b28c41bb9bd6255441da0f209a97bce5e8f Reviewed-on: https://chromium-review.googlesource.com/1157142 Cr-Commit-Position: refs/heads/master@{#54830}
-
- 31 Jul, 2018 29 commits
-
-
Jungshik Shin authored
ICU maps a few grandfathered tags to made-up values even when there is no preferred value entry in the IANA language tag registry. [1] 1. Check for grandfathered tags without preferred value upfront and return them as they're. 2. Lowercase the input before structural validity check to simplify check for grandfathered tag without preferred value as well as regexps used in the structural validity check. intl/general/grandfathered_tags_without_preferred_value is added and intl/general/language_tags_with_preferred_values is changed to check for case-insensitive matching of grandfathered tags. [1] https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry Bug: v8:7669 Test: test262/intl402/Intl/getCanonicalLocales/preferred-grandfathered Test: intl/general/grandfathered_tags_without_preferred_value Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie0520de8712928300fd71fe152909789483ec256 Reviewed-on: https://chromium-review.googlesource.com/1156529 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 19953355 Original Commit Message: The {CommentOperator}, used for implementing the --code-comments flag, is not UBSan-safe. This CL fixes this and adds a test which uses code comments. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia7976ec9a726fdeb7d8bfbb99c8a16d473aa0da4 Reviewed-on: https://chromium-review.googlesource.com/1157230Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54828}
-
Tobias Tebbi authored
Change-Id: I4710d317cf9f5686551a3df6e98619bab79387fa Reviewed-on: https://chromium-review.googlesource.com/1156698 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#54827}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I99c0a72c40133532acfa09cd809b695052b91ea1 Reviewed-on: https://chromium-review.googlesource.com/1156547 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54826}
-
Georg Neis authored
The test uses an incomplete native context, so the broker fails during serialization. Bug: v8:7790 Change-Id: I33e9e37df4e4acce62829123a8d16087d4fdc76d Reviewed-on: https://chromium-review.googlesource.com/1156693Reviewed-by:
-
Georg Neis authored
For the sake of incremental development it makes sense to still allow serialization to happen even when the broker is in mode 'kSerialized'. To locally obtain the stricter behavior, I'm adding the temporary flag --strict-heap-broker. Bug: v8:7790 Change-Id: Ie92f4f13d76bac9ce1f98bdd245829984d436d77 Reviewed-on: https://chromium-review.googlesource.com/1156603 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
The heap broker expects that handles get canonicalized. R=jarin@chromium.org Bug: v8:7790 Change-Id: If6162316bb2a256e783a8175ac7d4172d040b28b Reviewed-on: https://chromium-review.googlesource.com/1155123 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
MakeAssemblerBufferExecutable now flushes the i-cache, so we do not need to do that again. Change-Id: I46f5619167114cdb84064ef363106bee64282d1f Reviewed-on: https://chromium-review.googlesource.com/1152813Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54821}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I5cb76b4e989fbe6d4d08bafb60dbbb26c3d58e2d Reviewed-on: https://chromium-review.googlesource.com/1156515Reviewed-by:
-
Sathya Gunasekaran authored
... So that this can be re-used in the intl code. Also, add a helper method that loads the iterator if it's not provided. Bug: v8:5751 Change-Id: Ifc1142a486b2cdf1c33a813c5446b206ad9f81ef Reviewed-on: https://chromium-review.googlesource.com/1156390 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
As discussed offline, this header is not really useful without its inline definitions. So instead of trying to split it (unnaturally), declare defeat and make it an inline header file. Also remove two unnecessary uses of it, move the JSON stringifier class into its .cc file (because it needs IncrementalStringBuilder inline) and forward declare in prettyprinter.h. R=petermarshall@chromium.org, mstarzinger@chromium.org BUG=v8:7965 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ba032ca718a195e156ec3e59f8e858a25423450 Reviewed-on: https://chromium-review.googlesource.com/1156401Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54818}
-
Georg Neis authored
Use sizeof of the C type instead. Also fix a few #undef's that got reported after my changes. R=jarin@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I30a43b3d93e6df04fb9fb33050b52988edd7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1155108Reviewed-by:
-
Michael Starzinger authored
This changes recording of compilation stats (i.e. code and reloc info size) for each code object individually after it is finished, instead of for the entire module. It avoids needed to iterate the code table which would race with background tasks performing tier-up. R=clemensh@chromium.org Change-Id: Ic196fccb38b069a07e79fed4633d01dfc2639cd7 Reviewed-on: https://chromium-review.googlesource.com/1156396 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7424 Change-Id: I49f0f31e19d9242ac6eb26406a0aecd4d60ad869 Reviewed-on: https://chromium-review.googlesource.com/1148396 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Peter Marshall authored
There are still some cases where entry->instruction_start() is 0, meaning that computing pc_offset makes no sense. We don't care about those cases really; the dcheck in CodeMap::FindEntry will find the interesting cases. Bug: v8:7983, v8:8002 Change-Id: I7369f32da15e858f1c7af88f88cede60751b7eea Reviewed-on: https://chromium-review.googlesource.com/1156398 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54814}
-
jgruber authored
This changes Call(ExternalReference) to use the correct Mov() overload, which contains logic to load external references indirectly (i.e. in an isolate-independent way). Bug: v8:6666, v8:7985 Change-Id: Ib6f3931308c7d13fd4ef0563b7e1e83db3a760eb Reviewed-on: https://chromium-review.googlesource.com/1152730 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54813}
-
Dan Elphick authored
This new method only compares Strings and so doesn't need a Context. It also can't throw so it returns bool. Can be used in place of the deprecated Equals method and many Equals call currently taking a Context. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4cfe7747aa140e5a55d9513681ee4704414e1545 Reviewed-on: https://chromium-review.googlesource.com/1151321 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54812}
-
Ben L. Titzer authored
BUG=chromium:863205 R=clemensh@chromium.org Change-Id: I15f3a09e15210a80b155def5761d9aead95d19b7 Reviewed-on: https://chromium-review.googlesource.com/1156386Reviewed-by:
-
Andreas Haas authored
The lifetime of the WasmInterpreter is managed by the GC. However, we did not tell the GC the amount of memory consumed by the interpreter. Therefore it was possible to fill up memory with instances of the interpreter without triggering a GC to free memory. With this CL we pass the size of the stack as an estimate for the size of the interpreter. At least in the fuzzer the stack is the dominating factor for memory consumption. R=clemensh@chromium.org Bug: chromium:863198 Change-Id: Ic5cb0bd364500bcff793a1fd53d2d0113196dfe2 Reviewed-on: https://chromium-review.googlesource.com/1156385Reviewed-by:
-
Peter Marshall authored
For optimized code there are two modes. This is controlled by NeedsSourcePositionsForProfiling(). The problem we currently have is that this mode must be enabled before the code is optimized, otherwise the source position information will be low quality, even once the CPU profiler is turned on. Also add an implication from --future to this new flag, to gather perf & memory data from the bots. Bug: v8:7983 Change-Id: I993fc03df83028529eea365b6d336d9f4c0dcd2b Reviewed-on: https://chromium-review.googlesource.com/1156309Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54809}
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: Idad7bcfe2734df7395c62ec56fb737e180035c76 Reviewed-on: https://chromium-review.googlesource.com/1152918 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54808}
-
Michael Achenbach authored
This reverts commit 23cb219f. Reason for revert: https://crbug.com/v8/7996 Original change's description: > [build] Add MB config for deprecation warning bot > > TBR=yangguo@chromium.org > NOTRY=true > > Bug: v8:7963 > Change-Id: I1a91047b2a3c7d128f3b01a0970ce53a63c196d6 > Reviewed-on: https://chromium-review.googlesource.com/1145187 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54585} TBR=machenbach@chromium.org,yangguo@chromium.org NOTRY=true Bug: v8:7996 Change-Id: Ib6a0c972cd9bdf864295f70ebeda50f9f23ca314 Reviewed-on: https://chromium-review.googlesource.com/1156404 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54807}
-
Michael Starzinger authored
This avoids serializing and deserializing the sharable part of a module when it is transferred via {TransferrableModule}, which is possible when all Isolates run off the same engine via the --wasm-shared-engine flag. This adds a new --wasm-shared-code flag to enable this feature. R=ahaas@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I099d581d7ccc4d058a4646f545a011745fd84eb4 Reviewed-on: https://chromium-review.googlesource.com/1142144 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Sigurd Schneider authored
ReadFile returned a Vector with ownership transfer, i.e. the client needed to call Dispose to free the memory. This CL changes the interface to return a std::string instead, which manages ownership. As it turns out, there is only one user of ReadString that sometimes calls an API function which expects to take ownership of its Vector argument. Bug: v8:7932 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie624a7a65cf5814fddce7a57bc557e4b9876bc53 Reviewed-on: https://chromium-review.googlesource.com/1155115 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Also define some infrastructure for serialization. Bug: v8:7790 Change-Id: Icaa3d5b877dca41dfd5554683d05667fda115e80 Reviewed-on: https://chromium-review.googlesource.com/1150531 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
They were marked V8_DEPRECATE_SOON for the 6.9 branch, so we deprecate them for the 7.0 branch. R=yangguo@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idc42affd4d1b103e9946e3b77a93720694eb2dfd Reviewed-on: https://chromium-review.googlesource.com/1150024Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6922 Change-Id: I6341cf5d16276f894c5986c194ff3fff3b71b46a Reviewed-on: https://chromium-review.googlesource.com/1154973Reviewed-by:
-
Michael Achenbach authored
This reverts commit d854d351. Reason for revert: Speculative revert for webkit unit tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25209 Original change's description: > [builtins] Clear RelocInfo for off-heap trampolines > > For technical reasons, we used to serialize off-heap trampolines with a > RelocInfo containing a single OFF_HEAP_TARGET entry. This RelocInfo was > never needed at runtime. It also ended up being somewhat misleading > because printing an embedded code object would show the OFF_HEAP_TARGET > entry (belonging to the trampoline) at the first 'real' instruction. > > With this CL, we explicitly serialize an empty byte array as the reloc > info for each off-heap trampoline, i.e. the snapshot will never contain > such off-heap target reloc infos. > > Bug: v8:6666, v8:7969 > Change-Id: If6fa85a438d093ed5dcea07ce0de1db49a224d28 > Reviewed-on: https://chromium-review.googlesource.com/1146643 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54786} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: If5eabd162141149361df90095b89a173fe2cb81e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666, v8:7969 Reviewed-on: https://chromium-review.googlesource.com/1155594Reviewed-by:
-
