- 08 Jul, 2020 17 commits
-
-
Milad Farazmand authored
Change-Id: Ic60a47a931c8c359dce27ea5c774592bed1d4762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287230 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68743}
-
Victor Gomes authored
The second argument of FromParameterIndex should be the parameter count, including the receiver. Previously it worked by chance, because the code was trying to access the receiver but did not include it in the parameter count, accessing the first argument. This does not work anymore when the arguments are reversed (V8_REVERSE_JSARGS). Change-Id: I8ca9054a99d074c130f9a9b444e7b8a379840991 Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282531Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#68742}
-
Clemens Backes authored
--trace-wasm-decoder should not imply --single-threaded, as --single-threaded implies --no-liftoff. Hence we cannot trace the decoder in Liftoff mode. R=thibaudm@chromium.org Change-Id: I3e4f0ea119288ef88c4b00dd2f2a11244b77c204 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287492Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68741}
-
Clemens Backes authored
Instead of having one decoder method per opcode, make all load and store opcodes use the same method, and load the necessary information from a static array. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I27daf52b9cb0af6a288a5642913c132e20f0eabd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287489Reviewed-by:
-
Frank Tang authored
Bug: v8:10684 Change-Id: Id686d9f4d0b08d00ecf63217493e71f608d61b5d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286812Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68739}
-
Zeynep Cankara authored
This CL attempts to hide panels from the user view until data upload event to help users read instructions more easily. Screenshots: https://imgur.com/a/qFgIKI8 Bug: v8:10665 Change-Id: Ida666aa850b80cff3f428e1789cc92592ec79a6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278474Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68738}
-
Manos Koukoutos authored
Bug: chromium:1103161 Change-Id: I8b6155ec4f1033eb7024d798a08cd6f55f5f609d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287502Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68737}
-
Ulan Degenbaev authored
Bug: v8:10315 Change-Id: I6be83e742a3ef488e09ac44a379e028592a5ff64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287493 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68736}
-
Georg Neis authored
Due to an optimization in how resumable functions are compiled, we can actually see another Oddball type as StrictEquality inputs. I'm giving up on getting the DCHECK right and removing it entirely. Bug: chromium:1102683 Change-Id: Ia210777c66641e898e96900713710a51ebed311d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2287494 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68735}
-
Igor Sheludko authored
... into src/zone/scoped-list.h src/zone/zone-hashmap.h src/zone/zone-list.h src/zone/zone-fwd.h zone-fwd.h header contains zone-related forward type declarations. Bug: v8:10506 Change-Id: Ic61b6717b3034afa24bdd49fbc0ce758a0e93c75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284987 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68734}
-
Peter Ralbovsky authored
Goal is to include coverage of builtin functions into coverage bitmap send to Fuzzilli fuzzer. In order to do this, after each REPRL loop, coverage data of bitmaps are retrieved from JS heap and stored into coverage bitmap. Additionally, there is an option, to print out statistics about how many of edges from builtin functions were turned on by the program inputted into REPRL loop. This commit introduces two flags: --no-fuzzilli-enable-builtins-coverage - when enable-builtins-coverage turned of, builtins coverage will not be exported to fuzzilli --fuzzilli-coverage-statistics - when turned on, d8 prints statistics into covlog.txt file after each loop Change-Id: I8f9cf8dc693b952467b108c6d6bc00134125bc5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2263154 Commit-Queue: Peter Ralbovsky <ralbovsky@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#68733}
-
Clemens Backes authored
Instead of having one method with a big switch, and specializing that method for each single opcode, we now have one proper method per opcode. This makes the code way more readable, and also reduces the compile time of liftoff-compiler.cc significantly. Unfortunately, we cannot use template specializations for this, since GCC does not support specializing the methods within an unspecialized templated class. Hence, we need to have another dispatch per opcode when generating the opcode handler table. I left a comment explaining why we do it this way. The upside of this is that we get nicer method names. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I8c7026177490893711c999217eeb1e4f2fbb5e36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282533 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Change-Id: I1a7afc332dc2f1c4d4087650f116484437f7a09a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285851 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#68731}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f89ea875..281eb10 Bug: v8:7834 Change-Id: I9a8bcd56b09092999430f568edb0f841b417c955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2285850Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68730}
-
Zeynep Cankara authored
This CL attempts to change System Analyzer to fit to the dark theme by Material Design. Link dark theme: https://material.io/design/color/dark-theme.html Screen Shots: https://imgur.com/a/xWJo1Xb Change-Id: Ib921febfaaee7aa362495031a174875f442af3a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282596Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68729}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/89943b9..4222272 Rolling v8/third_party/aemu-linux-x64: LQ_bftKUbwaforl6s7QhdVirfTBttP4-yogIN0A6CcoC..Cht8VcqmH1adKCbBa1TuNhvNv-lMJJ0W5LvFyKpchi8C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9ef36d0..7cbda52 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/81923d6..e62496b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b49c12a..faaecad TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1e21a8f8d9687f18206e393348c453878fbf474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2286649Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68728}
-
Gus Caplan authored
Bug: v8:9891 Change-Id: I559ee50a09a2c8530c3d75a650b383b7d987f6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282713 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
- 07 Jul, 2020 23 commits
-
-
Jakob Gruber authored
Native context independent code generation should, at the moment, not use any collected feedback. We implement this by returning InsufficientFeedback from the heap broker's ReadFeedbackForX methods if currently compiling nci code. Thus all feedback.IsInsufficient() calls inside the compiler will return true (disabling feedback-based optimizations). FeedbackSource::IsValid() (used in generic lowering) can still return true. Bug: v8:8888 Change-Id: I198b6457276073e7376c777b206c50726f1b3645 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284494 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68726}
-
Jakob Kummerow authored
We used to expose raw WasmGC objects via the JS interface and made use of that in our cctests. Since those objects would cause crashes when used in JavaScript, this patch prevents such interactions, and migrates the tests to use the C-Wasm interface instead. Bug: v8:7748 Change-Id: I76a10663cda43c940c8c22c57c14922be9b05134 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284497 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Drive-by fix for x64 to remove unused temporary register. Bug: v8:8460 Change-Id: Ib4e83bad4e14670ccd93dd10e16c5483eb0897b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2283233 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
The unregister_token slot is iterated as a custom weak pointer slot, which means the heap verifier treats it as a strong slot. Currently, popped WeakCells (that is, WeakCells for which the owning FinalizationRegistry's finalizer has already been invoked) neither clears out the unregister_token slot nor marks it, which trips the heap verifier. Bug: chromium:1102161 Change-Id: I0a803f12379fc9df6935bc8331b3d5ecb199571a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284202 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#68723}
-
Mythri A authored
In turboprop, we reuse the code on a soft deopt. It will be good to differentiate between a deopt that reuses the optimized code on the next run and the deopt that discards the code. The deopt that reuses the code is called a "bailout" because it is just bails out for one execution to the unoptimized code. Change-Id: I9a300201e9b327415e94c2817065d6a561f8ece5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277807 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Dan Elphick authored
Adds const modifiers to several methods and their parameters in AllocationStats, BasicMemoryChunk and ReadOnlySpace. Also moves BasicMemoryChunk::OffsetToAddress to ReadOnlyPage. Bug: v8:10454 Change-Id: Ibda8f9212d95dff71ed1d8f1f985eb1c7e6087aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284986 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This is needed for write-barrier and persistent-handle code that does not otherwise get an instance of LocalHeap Bug: v8:10315 Change-Id: I480e31f32141510f2f9e678af3449d5841e3156e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284492 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
bcoe authored
Rather than only removing the continuation range for the last return statement prior to a synthetic return statement, remove the continuation tracking for whatever statement occurs prior to the synthetic return. Bug: v8:10628 Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68719}
-
Ulan Degenbaev authored
By default the v8::MeasureMemory API forces GC after some timeout. There are use cases that require low overhead measurements without forcing GC at all. Change-Id: I7d57c552d78d86800c4f37acb680c70c6422477f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2257856Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I6793133d7b05c3b8dbece80a51a7a6e5e250e8b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284482 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Michael Lippautz authored
- Adds JSVisitor that is used for unified heap marking. - Adds JSMember as supported reference type that also encapsulates a write barrier in future. JSMember is a replacement for TracedReference which can be deprecated with EmbedderHeapTracer once the library is used to handle unified heap collections. The dispatch for v8::JSMember on cppgc::Visitor is provided through a specialization of TraceTrait. Bug: chromium:1056170 Change-Id: I60d976ae66db3e5fa2e690a21627bdcb8c6871af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2284488Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68716}
-
Jakob Kummerow authored
When rtt.sub is called repeatedly with the same arguments, it should return the same result. This CL introduces a cache for previously created sub-RTTs to achieve that. Bug: v8:7748 Change-Id: Ie6c74eedf0df6f94cd973fdb0b6b6fc0130a9c41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275967 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This lets us type the last VARIABLE. PrepareValueForWriteToTypedArray still returns Node* for the non-templated version since it can return Word32T or Float64T or Float32T or BigInt. Bug: v8:6949 Change-Id: I90dee90d2e7eff08b1f69a57af371dec399b94c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282595 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#68714}
-
Aaron O'Mullan authored
Bug: chromium:1059746 Change-Id: I309c15a33a7185c9397b7893a9eefcb90981dc64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280085 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#68713}
-
Jakob Gruber authored
Similar to the feedback vector, we cannot embed the native context as a constant in NCI code (it is trivially native-context-dependent). In NCI mode, load it from the current context. In default turbofan, we keep the HeapConstant. Bug: v8:8888 Change-Id: Iff95c673b25245c701c7755416abf2038b5fdf08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282532 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
HasProperty and InstanceOf now both have a feedback vector input, and collect feedback in generic lowering. CreateClosure loads the feedback cell (in nci mode) instead of embedding a heap constant. Bug: v8:8888 Change-Id: Id479cda344684aeb5054f687b087c4fedeac05d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282530Reviewed-by:
-
Jakob Gruber authored
Turbofan now has support for generating generic code in two variants, with and without feedback collection. Currently, feedback is collected only for some load and store operators (historical reasons). This CL enables feedback collection for (almost) all operators by default. The exception in the default TF configuration are call and construct variants (see also https://crrev.com/c/2276042). In NCI mode, all operators collect feedback. Regression have looked acceptable in our benchmarks so far. This is an experiment to see impact on real world. If successful, the non-collecting variants can be removed. Bug: v8:8888 Change-Id: I0dddc7113ce94071552d5c4d992471db5ac5f989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239571 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This CL types almost all remaining VARIABLEs. Only one remains (in PrepareValueForWriteToTypedArray) since it depends on a variable MachineRepresentation. Will be done in a follow-up. Bug: v8:6949 Change-Id: Icdec3d8fdc1459c0b35fc3d1f7e8816981bbccba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282594Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I70ecda5e43e188835166b34a42620a477a5e7997 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282600 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:9708, v8:6949 Change-Id: I00c74df771ce719c318045f57b075ac2cb5df5fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282593Reviewed-by:
-
Zeynep Cankara authored
This CL attempts to add a index.html landing page for listing all the tools V8 has with brief descriptions within V8's tools directory. Screen Shots: https://imgur.com/a/NwWTI0d Bug: v8:10664 Change-Id: I945e78381797966d6ebcd754126d26973ca9f649 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275962Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#68706}
-
Mythri A authored
When marking the function for a deopt due a dependency change, we only print the information about the code object. This isn't very useful when looking at the output of --trace-deopt. This cl also adds SharedFunctionInfo which makes it easier to see which function got deoptimized. Also adds these events to the log file so they can be used in profview to print more accurate deoptimization information. Change-Id: I1b7a88b5cc2a1ad1ebb0863cf8a4f7d2e151b76a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2281001 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Philip Pfaffe authored
This CL implements two additional evaluator module proxy operations for accessing globals and values on the wasm operand stack. Drive-By: Also fix how the breakpoint position is computed in the evalutor tests. Bug: chromium:1020120 Change-Id: I161768da9e12586b2c710f5b26922b9600527814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282526 Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Reviewed-by:
-
