- 19 Jun, 2018 39 commits
-
-
Michael Starzinger authored
This removes special casing in the handling of {RelocInfo::CODE_TARGET} for cases where such references appeared in {WasmCode}. Such references can only appear in real {Code} objects and also only target real {Code} objects by now. R=clemensh@chromium.org Change-Id: I87c55c60cd6344bb67fa8c8d04b66fb523d07ba7 Reviewed-on: https://chromium-review.googlesource.com/1104680 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53848}
-
Clemens Hammacher authored
Direct jumps only work for offset up to 64 MB on arm. For longer jumps, use indirect branches (load target from constant pool into the pc register). R=mstarzinger@chromium.org CC=pierre.langlois@arm.com Bug: v8:7758 Change-Id: I1cf66b7d1bfb62cfcd6b1619c02816909a1f651e Reviewed-on: https://chromium-review.googlesource.com/1105996 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53847}
-
Michael Starzinger authored
This makes sure we use WebAssembly runtime stubs when performing value coercions in wrapper code that is compiled into {WasmCode}. It hence removes the last {RelocInfo::CODE_TARGET} references in {WasmCode}. R=clemensh@chromium.org BUG=v8:7424 Change-Id: Ic96e541abe98f90796a6506b09ff99557743b6f7 Reviewed-on: https://chromium-review.googlesource.com/1104462 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Georg Neis authored
This encapuslates some of the heap accesses done by JSNativeContextSpecialization::ReduceJSLoadGlobal and JSNativeContextSpecialization::ReduceJSStoreGlobal. Bug: v8:7790 Change-Id: Ib6c63903809927d6094af22519285cb9d0bbff7a Reviewed-on: https://chromium-review.googlesource.com/1106141Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53845}
-
Clemens Hammacher authored
After the removal of the --skip-compiling-wasm-funcs flag, this helper does not help that much any more, and contains unneeded logic. This CL just inlines the computation in the caller. R=titzer@chromium.org Bug: v8:7754 Change-Id: I99cf006ffe9c33d79bea2ce186354c38bc63f6af Reviewed-on: https://chromium-review.googlesource.com/1105767Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53844}
-
Tobias Tebbi authored
Bug: chromium:849098 Change-Id: Iec81d08cf6edb6040445650cadf802a34b65b8e1 Reviewed-on: https://chromium-review.googlesource.com/1092749 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Dan Elphick authored
Like Heap::InFromSpace, it doesn't use any members, so should be made static. Also clean up call sites to not call via a heap pointer. Change-Id: If55484ddac51351d789c73093f1f7ebf1c568bea Reviewed-on: https://chromium-review.googlesource.com/1088618Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53842}
-
Toon Verwaest authored
Change-Id: I5fd42cd70aaba15cfef32eea54232f8292aaa874 Reviewed-on: https://chromium-review.googlesource.com/1105775Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53841}
-
Peter Marshall authored
Bug: chromium:854066 Change-Id: Icabd9bf5e00868822b9debfb9bbb5d3932726465 Reviewed-on: https://chromium-review.googlesource.com/1105774 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Théotime Grohens authored
This CL adds the incorrect return type of the conditional expression in 'if constexpr' conditionals to the error message displayed if the return type is different from 'constexpr bool'. Change-Id: I58be4c140fa6fc475dc907a9ec872005fcb7d839 Reviewed-on: https://chromium-review.googlesource.com/1105768Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53839}
-
Simon Zünd authored
Bug: v8:7382 Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d Reviewed-on: https://chromium-review.googlesource.com/1100881 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Théotime Grohens authored
This CL moves the ToBoolean function from data-view.tq to base.tq. It used to be in data-view.tq because we couldn't call macros from one file to the other but this has been fixed now, and it makes more sense to have it there. Change-Id: Id201979eacbeb4307ff7d515db48377490d5bed7 Reviewed-on: https://chromium-review.googlesource.com/1104683Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53837}
-
Sigurd Schneider authored
This CL enables embedded builtins to get benchmark feedback. We need this feedback to identify and address remaining performance problems. Bug: v8:6666 Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233 Reviewed-on: https://chromium-review.googlesource.com/1105834Reviewed-by:
-
Sigurd Schneider authored
If a call to a builtin is generated at run-time (vs at snapshot time) we don't need to tag the call/jump with relocation info, as the builtin address will not change. The only way to generate a builtin call at snapshot time is via MacroAssembler::JumpToInstructionStream where we keep OFF_HEAP_TARGET. The reloc info for builtin calls and jumps is set to NONE. Bug: v8:6666 Change-Id: I9e8ad9f23481a2177e69352a56010084336402e7 Reviewed-on: https://chromium-review.googlesource.com/1105758 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=jarin@chromium.org Change-Id: I369684ee6ccff83329bcc4f463b922e0263ae0b0 Reviewed-on: https://chromium-review.googlesource.com/1105823Reviewed-by:
-
Clemens Hammacher authored
We need to create one {WasmCompiledModule} before creating the {WasmModuleObject}. This CL refactors the code such that the {WasmModuleObject} itself creates the {WasmCompiledModule}. This moves us closer to removing the {WasmCompiledModule}. R=titzer@chromium.org Change-Id: I9f85e47f643c39840036f4f1f92df736732c8f74 Reviewed-on: https://chromium-review.googlesource.com/1105762Reviewed-by: -
Michael Achenbach authored
The blacklist is needed to make compilation work. TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:853202 Change-Id: Ie867b3605a42ddbcf02514965652ff89121be14d Reviewed-on: https://chromium-review.googlesource.com/1105830Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53832}
-
Clemens Hammacher authored
This also restores some uniformity in these headers. R=mstarzinger@chromium.org Change-Id: Ic3a941bce287596f564ba9f87f3a8ca2c46c2ee2 Reviewed-on: https://chromium-review.googlesource.com/1105763Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2c1e4aa9. Reason for revert: https://ci.chromium.org/buildbot/client.v8.ports/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/11591 Original change's description: > [test] Initialize slow-dcheck runtime flag with compile time value > > This makes sure slow dchecks are part of the snapshot when the compile > time flag is set. It'll also obviate the need to set the runtime flag > in general, making configurations simpler. > > It's still possible to opt out at runtime for the non-snapshot dchecks > using the negated runtime flag. > > Bug: v8:7853 > Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d > Reviewed-on: https://chromium-review.googlesource.com/1105050 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53819} TBR=machenbach@chromium.org,cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: If209aa824749f358a892218dda99c30b1a63b99d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7853 Reviewed-on: https://chromium-review.googlesource.com/1105857Reviewed-by:
-
Clemens Hammacher authored
This is a reland of 733b7c82. The arm64 bug was fixed in https://crrev.com/c/1105051. Original change's description: > [wasm] Introduce jump table > > This introduces the concept of a jump table for WebAssembly, which is > used for every direct and indirect call to any WebAssembly function. > For lazy compilation, it will initially contain code to call the > WasmCompileLazy builtin, where it passes the function index to be > called. > For non-lazy-compilation, it will contain a jump to the actual code. > The jump table allows to easily redirect functions for lazy > compilation, tier-up, debugging and (in the future) code aging. After > this CL, we will not need to patch existing code any more for any of > these operations. > > R=mstarzinger@chromium.org, titzer@chromium.org > > Bug: v8:7758 > Change-Id: I45f9983c2b06ae81bf5ce9847f4542fb48844a4f > Reviewed-on: https://chromium-review.googlesource.com/1097075 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53805} TBR=titzer@chromium.org,mstarzinger@chromium.org Bug: v8:7758 Change-Id: I68555230c6db97e70f0b8fef784188f55ee04794 Reviewed-on: https://chromium-review.googlesource.com/1105158 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Leszek Swirski authored
To avoid repeating code for the few places where we can call GetIsolate and GetHeap safely. Bug: v8:7786 Change-Id: I6c6de81488bfa79dca50cfd2b6356f432401b68e Reviewed-on: https://chromium-review.googlesource.com/1104684 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53828}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Bug: chromium:853202 Change-Id: Ibdb74e840820a7524db7767f94afb84768773da5 Reviewed-on: https://chromium-review.googlesource.com/1105824Reviewed-by:
-
Dan Elphick authored
This removes several GetIsolate calls from Map:: methods and instead passes the Isolate in. This is a very noisy change but mostly it is just adding Isolate to method declarations and forwarding it on. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I159505e50a9462d01066f14da0fcc29762bd5531 Reviewed-on: https://chromium-review.googlesource.com/1075267Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53826}
-
Simon Zünd authored
This CL changes all ArraySort benchmarks to execute the setup function for each iteration (one run call), instead of only once for all iterations. Even though we now also measure the time needed to copy and prepare the array, this is needed, otherwise we would mainly measure sorting already sorted arrays. R=cbruni@chromium.org, jgruber@chromium.org Change-Id: I2e0e301b52b0288b8c825c3c8401c348c4a0dee7 Reviewed-on: https://chromium-review.googlesource.com/1105045Reviewed-by:
-
Sigurd Schneider authored
TurboFan returned null handles if compilation did not succeed. This CL changes that to a MaybeHandle to make it explicit that client code needs to handle the error. Bug: v8:7856 Change-Id: I6087e6263faa1150b9788213dd22c398b4a2fc2d Reviewed-on: https://chromium-review.googlesource.com/1104688 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53824}
-
Toon Verwaest authored
Change-Id: I566ab09800f4a2873aca86423c858b63c58d6d98 Reviewed-on: https://chromium-review.googlesource.com/1105049 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Leszek Swirski authored
We want to remove GetIsolate calls, but this particular one is safe and necessary to avoid either storing the isolate in the parser/scopes, or passing it through as a parameter throughout the parser. Bug: v8:7786 Change-Id: I07765f5c20b2c9925bb0b980bc9fe850c91d7811 Reviewed-on: https://chromium-review.googlesource.com/1104685Reviewed-by:
-
Simon Zünd authored
R=jgruber@chromium.org Change-Id: Ibb35c1ae090cd8e79e48c977735af1188414f531 Reviewed-on: https://chromium-review.googlesource.com/1105054Reviewed-by:
-
Dan Elphick authored
Replace all but one Handle<T*>(T*) calls with ones that explicitly pass in an Isolate. Requires plumbing Isolate* through several Parser functions which previously avoided it because of worries about accessing the heap off the main thread. In all off-main-thread cases, isolate will be nullptr and every such function asserts with: DCHECK_EQ(parsing_on_main_thread_, isolate != nullptr); Also deletes unused function ParseInfo::ReopenHandlesInNewHandleScope. Bug: v8:7786 Change-Id: I3dd9c49dcde49fdbcb684ba73f47a30d00fc495e Reviewed-on: https://chromium-review.googlesource.com/1087272 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53820}
-
Michael Achenbach authored
This makes sure slow dchecks are part of the snapshot when the compile time flag is set. It'll also obviate the need to set the runtime flag in general, making configurations simpler. It's still possible to opt out at runtime for the non-snapshot dchecks using the negated runtime flag. Bug: v8:7853 Change-Id: Iadfc46ed691d32e9d39717e2ea0383e784660d1d Reviewed-on: https://chromium-review.googlesource.com/1105050Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: v8:7859 Change-Id: Ie3d21f21b12bc2d36eb1b0ea798e2d6030342492 Reviewed-on: https://chromium-review.googlesource.com/1105760 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
{WasmCompileLazyFrameConstants::kFixedFrameSizeFromFp} did not incorporate padding. This CL fixes that. R=mstarzinger@chromium.org No-Try: true Bug: chromium:853468 Change-Id: I042e68623bdfd81c96180a39c29ecd70271ba1be Reviewed-on: https://chromium-review.googlesource.com/1105051 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
Bump limit for isolate creation in cctest; the test started crashing recently on nosnap.debug builds, hence we bump the limit. Bug: v8:7856 Change-Id: I7c2396c7f112a2ed7fc189f0fa72658e0ed75050 Reviewed-on: https://chromium-review.googlesource.com/1104691Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 380dba0a. Reason for revert: Fails gc-stress: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/1471 Original change's description: > [runtime][gc] Drop AllocationSite::weak_next field for sub-literals > > Use AllocationSite without Weaknext field for all the allocations in nested > literal except for Root. The nested field is sufficient to link all the > allocations in a nested literal. Only the Root is added to heap weak_alloc_list > for GC to traverse > > Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 > Reviewed-on: https://chromium-review.googlesource.com/1101323 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53813} TBR=ulan@chromium.org,cbruni@chromium.org,chandanreddy@google.com Change-Id: Icc87027f14f917da3033db256c2535e08e2a4a34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1105159Reviewed-by:
-
Théotime Grohens authored
This CL adds a 'constexpr String' type to Torque, which gets compiled to 'const char*'. It makes it easier to pass strings around in Torque files, especially when trying to Print() them. Bug: v8:7793 Change-Id: I2d4feac7012f5401f2b467475f8df086e46ac18a Reviewed-on: https://chromium-review.googlesource.com/1104466 Commit-Queue: Théotime Grohens <theotime@google.com> Reviewed-by:
-
Creddy authored
Use AllocationSite without Weaknext field for all the allocations in nested literal except for Root. The nested field is sufficient to link all the allocations in a nested literal. Only the Root is added to heap weak_alloc_list for GC to traverse Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 Reviewed-on: https://chromium-review.googlesource.com/1101323 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
-
Simon Zünd authored
This CL enables out-of-bounds checks for debug builds when loading or storing FixedArray elements. Since "--enable-slow-asserts" is not passed through to mksnapshot, the OOB checks were basically never executed. Bug: v8:7853 Change-Id: I81bdd9ac04868f9ffc362c3f4fd8fa3ddd122ee1 Reviewed-on: https://chromium-review.googlesource.com/1103568 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53812}
-
Simon Zünd authored
This CL fixes a bug that allowed OOB read/stores on fastpaths when a comparison function caused the underlying FixedArray to change while keeping the elements kinds and size property on the original JSArray the same. R=jgruber@chromium.org Bug: chromium:852592 Change-Id: I09af357d10e7f41e75241e4c87430fc9aa806f8c Reviewed-on: https://chromium-review.googlesource.com/1104158 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Anna Henningsen authored
Refs: https://ci.chromium.org/buildbot/client.v8/V8%20Linux64%20TSAN/21047 Bug: v8:7836 Change-Id: Ic825065de419bbab97972d9b7a2beb6527b0a48a Reviewed-on: https://chromium-review.googlesource.com/1103560 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53810}
-
- 18 Jun, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
Inspector test expectations may be changed without changes inside src/inspector directory. R=dgozman@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3196209a4b974d4cf32c76c51116d77e589a9dbb Reviewed-on: https://chromium-review.googlesource.com/1104303Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53809}
-
